Age | Commit message (Collapse) | Author | Files | Lines |
|
Fix handling of Not Found status for multicloud plugin
query of a workload.
Change-Id: Ie33b8728bf71fbcf0eaaa6496520351404928a36
Issue-ID: SO-1821
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
|
|
in place of literals Issue-ID: SO-1490"
|
|
of unused local variables. Replace type specifications with diamond operator as per guide lines. Issue-ID: SO-1490"
|
|
specifications Issue-ID: SO-1490"
|
|
specifications Issue-ID: SO-1490"
|
|
Reorder modifiers to complt with Java code specifications
Issue-ID: SO-1490
Change-Id: Idcd8c8dcd2a664310007d3e965700363672cbea3
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
|
|
Reorder modifiers to complt with Java code specifications
Issue-ID: SO-1490
Change-Id: Ic8adde29c0bc8b3d039e3f0f1c8837f53dd10aee
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
|
|
Removal of unused local variables. Replace type specifications with diamond operator as per guide lines.
Issue-ID: SO-1490
Change-Id: I728287427c0f6f9e8289fb0dfa8e906856c774ff
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
|
|
Constants are declared and used in place of literals
Issue-ID: SO-1490
Change-Id: I8891e3aad24b29b4c951d995df0192437304d06e
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
|
|
String literal should be on the left side of string comparision as per guidelines.
Issue-ID: SO-1490
Change-Id: I294cbbb2fe7dae9c68b7b20e9b3a0d1d75824ba0
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
|
|
Fix to three Sonar vulnerabilites.
Changed mutable collections of constants (exposed by utility class) to
immutable.
Change-Id: I3b301eac20b52df72a6d1318483b7b931e750313
Issue-ID: SO-1794
Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com>
|
|
Supports multicloud API query by workload name or id.
Gets workload details e.g. stack outputs, etc.
To be used to fill in inputs for vfmodule
that has a volume group or base module.
Change-Id: If45783e82c2a209d3385be1b689a02a05baf9922
Issue-ID: SO-1445
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
|
|
Added in maven plugins to enforce coding style rules
Added in eclipse java formatting xml
Change-Id: I3727bbf4ce8dc66abfd8ad21b6cfd0890c5d3ff0
Issue-ID: SO-1765
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Add Query param to pull back nested stack information
Change-Id: Idf83291107e2ef7e86bb2de914469b0401eda0ac
Issue-ID: SO-1760
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Fixed blockers according to Sonar analysis.
Change-Id: Ib068b586cd72c1634780220ac5498e1962dee434
Issue-ID: SO-1734
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
|
|
The multicloud API can take the tenantId as an item in the
header. Add the tenantId to the request headers of the
multicloud plugin.
Change-Id: I7ff11cd52eea429e0c694092b006887f13de2fda
Issue-ID: SO-1446
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
|
|
|
|
Fixed blockers according to Sonar analysis.
Added tests for fixed issues.
Change-Id: I8e259147082d722961048454fae9484cc0d8b0a8
Issue-ID: SO-1734
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
|
|
After successful vfmodule create, invoke the
multicloud api to trigger update in aai.
Change-Id: I3f6ceee7a8ea5f907fefcbe1a57ba35b9a666cb1
Issue-ID: SO-1444
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
|
|
added logic to write sub interface information
from openstack to a&ai when audit fails to find it
Change-Id: I24266812dc60eb69bfd90e3e5b34113e9fd8f4f4
Issue-ID: SO-1737
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Use the cloudOwner and cloudRegion to construct the
multicloud endpoint for the multicloud VNF plugin adapter.
Use configuration to obtain the MSB IP and port number.
Stop using the cloud sites catalog DB since there is only
a single endpoint required talking to multicloud.
Change-Id: I0e9b45a51b6e36f4782226f851e7d01de7f1b133
Issue-ID: SO-1447
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
|
|
Change-Id: I7a61470291e05286cce0aa4e35c2f4068c4319fb
Issue-ID: SO-1490
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
|
|
Eliminated calls to printStackTrace() on Throwable as they go to stdout
and are not handled by logger.
Occurences has been replaced by calls to logger or modifications to
nearby logger calls (Throwable passed as last parameter).
Occurences in unit test classes left without modification.
Change-Id: I6a771d60a3ea69ceecc29bb21358e565aa5ce101
Issue-ID: LOG-631
Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com>
|
|
Update the Multicloud plugin adapter to use the
the enhanced multicloud infra_workload API.
Mainly involves adding the user_directives and
the vf-module model IDs to the call.
Change-Id: I7ab78a8a304dbd61a5743ec67bb839037861ef9d
Issue-ID: SO-1446
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
|
|
|
|
Adjust audit to use device_id to find nova server
Change-Id: If060b68ba480b0750e66a7fe26a6fa72382dcdd5
Issue-ID: SO-1677
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
The BPMN layer has the CloudRegion which includes the CloudOwner
attribute, but this is not passed to the VNF adapter layer.
Calls to the Multicloud infrastructure workload need the
CloudOwner as well.
This patch adds CloudOwner to the VNF adapter API. While
the intended usage is primarily for the multicloud adapter,
it touches a log of other files - though those do not
make use of it at this point.
Change-Id: I88028096fbd84fc3fe5d53786c70b3c8806bb711
Issue-ID: SO-1447
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
|
|
Bye bye MsoLogger class.
Extracted constants to separated classes.
Fixed imports.
Change-Id: I7c8e0527e7dbd097d3ea93b9dab279354652da47
Issue-ID: LOG-631
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
|
|
only cast to Element if value is of that type
added XmlAccessorType annotations to classes
map of string, object now correctly maps with jaxb
Null comma delimited lists can convert to null as well
Handle null values all types in input parameters map.
Change-Id: Ic46ed31c05b8f8551d39b2267ae731829abfc1f0
Issue-ID: SO-1617
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
only convert object type json when input is a String
Change-Id: I465dfe905f5d85de583b6232640dc4dc13a09c7a
Issue-ID: SO-1610
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Adjust test data to add tenant mapping
Remove unused unit test already renamed
Update logic, to pass hostname not pservername
remove unused file that has been refactored
Add project to ignore, remove class
Address issues in comments on pull request
Remove logging that is not needed, used
UPdate BPMN to use Boolean Value, change timings
Adjust BPMN to not hit deadlock scenario
put error message in execution before checking rollback
- removed extra code for vnf resource processing found in onap
environment.
Fix improper use of inclusive gateway causing deadlock
Fix flakey unit tests from ONAP
Remove qualifier on bean, as it breaks callbacks
Adjust pom version of external camunda client
Fix polling timers to be more reasonable
Updated Junit test for delete vf module in onap.
Changed auditInventoryNeeded variable to a boolean to prevent
bpmn from erroring out in the event this variable is not found
on the execution.
Update logic to support writing of self link
Change-Id: I2f784a0a58a09f303775282c9be6019031668570
Issue-ID: SO-1597
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
map object representations of json back to json strings
marshal all objects to json strings before sending
all input params converted to Map<String, Object>
Updated userParams map from HashMap<String, String> to Map<String,
Object> as HashMap<String, String> userParams was causing VNF spin up
to fail. Input json in Userparams was not accepted as a valid json
format. Updated other files that were affected by this change.
Change-Id: I0c00fc00c4c11b54ace4df7be8d5bfc80d41d130
Issue-ID: SO-1582
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Removed MsoLogger from adapters ('mso-adapter-utils')
Replaced MsoLogger with plain slf4j
Refactored login output
Fixed imports
Change-Id: I5805427f3d6870a35f523934ceee73f17d4e130d
Issue-ID: LOG-631
Signed-off-by: k.kazak <k.kazak@samsung.com>
|
|
MsoMulticloudUtils: multicloudClient may be null
throw MsoException if it is null (instead of NullPointer)
removed unnecessary StackInfo object creation
using format specifiers for a logger instead of String concatenation
removed else block to make the code easier to read
Added tests for the method
Change-Id: I80d2e0ba2ef2d20c488cdfcf103d9cfa5784ab65
Issue-ID: SO-1516
Signed-off-by: k.kazak <k.kazak@samsung.com>
|
|
MsoHeatUtils: remove unnecessary heatClient check for null
1. sonar assumes that heatClient is nullable and NullPointer may be thrown in line 309
2. heatClient is never null: method creates a new object or throws Exception
MsoHeatUtilsTest: added tests for getHeatClient and createStack methods
BaseTest: made CloudIdentity and CloudSite getters protected for other tests to use them
StubOpenStack: added stubs for getStack and unsuccessful authorization
removed unused imports
Change-Id: Ie62c89f55d1894df48d9cc4d14760d36e96c4cb2
Issue-ID: SO-1516
Signed-off-by: k.kazak <k.kazak@samsung.com>
|
|
Remove un-needed cacheing layer for OS Clients
Change-Id: I7fbb6e23a3c34f65286202ec4dad1fb051991cf0
Issue-ID: SO-1500
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Address Review comments on pull request
Update Unit test to have proper variable for testing
update logic inside bpmn to reflect proper variable
Update unit test to check property for audit
Add flag to turn on and off audit behavior
Add license headers, remove un-used files
Update Building Block Tests and Activity Names
Fix additional unit tests in so-bpmn-tasks layer
Fix broken Junit Test, and correct Bug in if statement
Add annotation to ignore class under test profile
Additional bug fixes and unit tests for classes
Add Additional JUNITS, add more sample data
Add Openstack Audit functionality to Adapter
Change-Id: I0492063271e991eefc608b56336a5cdf1d5a7778
Issue-ID: SO-1456
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Issue-ID: SO-1435
Change-Id: If065ef5c91e769452fd6701fa6c28a23b4bdf2b2
Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
|
|
add headers to files which were missing them
Issue-ID: SO-1390
Change-Id: I6c754f72c5d1ef6485d6343aae4b994120901d08
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
-Replace constructor calls with existing factory
-Add create methods to factory for each required Media Type
Change-Id: Ibd03c10230c87a0413c0ec529e0ea9ac800444f9
Issue-ID: SO-1344
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
|
|
One more fixup for logging calls which would have an exception.
Change-Id: Id29324309400be5e4fdcf25cf8dd29929d10e6c1
Issue-ID: SO-1336
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
|
|
Fix log calls which would have an exception.
Throw and mso exception when call to multicloud
fails to create a stack.
Change-Id: Ib103c6f4420e444734bbb715699eb57ffc110925
Issue-ID: SO-1336
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
|
|
moved all ecomp.mso properties to org.onap.so
Change-Id: I55bd57d1c1d1dca065575c03d3c0b8f83aa4594d
Issue-ID: SO-1278
Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
|
|
Allow the multicloud adapter to work if no
oof or sdnc directives are passed in - use an empty
json node - e.g. {}.
Change-Id: Ia701051de8a3da314957e4a4085963af6aff16b6
Issue-ID: SO-1247
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
|
|
Fix broken UT from removing alarm logger
fixed compilation and merge issues
Remove all usage of AlarmLogger
Change-Id: Ic87abd51423274570bfca0ed976d9642a91a843d
Issue-ID: SO-1229
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
update JEL with explicit getVariable call
set project object into scope object
add camunda properties as defaults in application.yaml
added exception handling to keystone v3 case
added in password method to identity object
initial commit of keystone v3 auth support
updated json property values with "_name"
added new columns to cloud identity
Change-Id: Ie08e9893c34d7199197efdb21fe4dd5413b25f44
Issue-ID: SO-1225
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Issue-ID: SO-1209
Change-Id: Icb018e4a178ab13f6d142bdcb1000411c0d0dedf
Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
(cherry picked from commit 6e3aad261b40427288b18f21b86f109172dbd9c4)
|
|
Issue-ID: SO-1209
Change-Id: Icb018e4a178ab13f6d142bdcb1000411c0d0dedf
Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
|
|
Use the static final string variable for the parameter
key values instead of literal string of the variable name.
Also, vf_module_id and vnf_id (generic vnf id for multicloud)
are already part of the required input list, so they are
not needed to be added to the list of inputs.
Change-Id: I2b0bbf385e4114f0432673a3d7e8c9d652226f0a
Issue-ID: SO-1210
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
|
|
corrected typo in CloudConfiguration class
removed files which should not have been merged
updated gr api test cases with dynamic cloud owner
updated groovy files to allow for dynamic cloud owner values
moved VFModularity folder to mso-infrastructure bpmn
updated GR API layer to include cloud owner
added enum for default cloud owner
- fixing junit test cases for using catalogDb client r2
- fixing junit test cases for using catalogDb client
- Internal review comments incorporated for merging mocking into
BaseTest
- Internal review comments incorporated for removing direct repo calls
- CLONE - Key Management Hardcoded encryption key | fixing junits
- CLONE - Key Management Hardcoded encryption key
Updated builder to use String.format
Added exception specifically for issues interacting with
requestdbadapter
Updated exception message and added junit test case
removed useless error handling test case from workflow
changed method name and added junit coverage to errors
added max retry and success status after completed bb
Added case to handle when homing is not called during assign vnf.
Fixing fortify issues | Implementing review comments
- Key Management Hardcoded encryption key - fixing prop files
- Key Management Hardcoded encryption key
include network ID for completion handler
Added exception handling for saving to requestdb
- Adding a check on the predicate availability on the repository before
firing the query with default conditions. This ensures that the api
returns data only when there is an input against which it was able to
form some conditions
Modify UT to show that the API does not behave
- adding negative test case for checkInstanceNameDuplicate
added assertion that global count var was reset to 0
updated rollback to reset current sequence count var
workflowaction calls rollback is complete before error
workflowaction will set failure on successful rollback
added check for isrollback to know which complete to call
removed file which should not have been added
add fabric check before running vf module a la carte
Enhance UCPEMigrateService junits and add them to Jenkins build..
Added back removed test case for ManualTasks
Added test case for response error
Added rainy day test cases for ManualTasks
revert the other change and fix the rollback logic instead
fixed current sequence and updated rollback code
added network cloud heat template parameters to mapper
Generate a unique subRequestId for each request to APP-C.
reverted conditional logic for determining fabric
Fix Bean scanning so it picks up the resttemplate
removed unnecessary RestTemplate Bean configurations
removed file which should not have been added
workflowaction calls rollback is complete before error
workflowaction will set failure on successful rollback
added check for isrollback to know which complete to call
add fabric check before running vf module a la carte
added assertion that global count var was reset to 0
updated rollback to reset current sequence count var
include network ID for completion handler
Revert Application.yaml change accidentally checked in
Added exception handling for saving to requestdb
Added case to handle when homing is not called during assign vnf.
removed useless error handling test case from workflow
changed method name and added junit coverage to errors
...
add cloud owner variable to camunda in mapping
Revert "Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Added
juint test to verify variables are set in the execution. Set default
cloudOwner in main module CreateVfModuleVolumeInfraV2"
updated cloud configuration pojo to inlcude defaults
Revert "Test to verify ServiceInstance object mapping"
Test to verify ServiceInstance object mapping
Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Added juint test
to verify variables are set in the execution. Set default cloudOwner in
main module CreateVfModuleVolumeInfraV2
Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Set default
cloudOwner 'att-aic' if null per old requirements.
removed references to att-aic from BBInputSetup
Changes done in encryption decryption logic | used
DelegateExecutionFake in Tests
Changes done in encryption decryption logic | used
DelegateExecutionFake in Tests
Changes done in encryption decryption logic
Changes done in encryption decryption logic | removed Default Auth
Constant as per the comments
Changes done in encryption decryption logic | Fixed UT
Changes done in encryption decryption logic | Added XmlComparator
assertion for verifying XML
Changes done in encryption decryption logic | Reverted as per the
review comment
Changes done in encryption decryption logic | Fixed UTs
Changes done in encryption decryption logic | Fixed UTs
Changes done in encryption decryption logic | modified related
encrypted properties in test yaml files
Changes done in encryption decryption logic for fortify issue
resolution | Fixed UTs
Changes done in encryption decryption logic | modified related
encrypted properties in yaml files
Changes done in encryption decryption logic for fortify issue
resolution.
Fixed Property fetching issue in required file
Added TasksBeansTest using openpojo
Removed renamed test file from tasksbeans
Updated imports on TasksBeansTest
Added openpojo test to replace the individual tests
Removed tests that provided no coverage
script clean up -Update reference data to support distinct recreate and
replace requests with their own sequences
Update reference data to support distinct recreate and replace requests
with their own sequences- Fix seq number
Update reference data to support distinct recreate and replace requests
with their own sequences
added null check to mdc and interceptors to sdnc cxf
validations can now match against multiple BBs
reverted changes to BBInputSetup class
added support for pre and post validation for BBs
initial commit of generic building block validator
converted test to no longer be a springboot test
Remove cosmetic changes from BPMN files to be consistent.
Remove minor changes that are not related to functionality.
Rework to implement the functionality as part of Validator
Combine the verification methods into one based on the flow's name;
change the logging.
Add verification of status of other VF Modules in the VNF for the
delete/deactivate/unassign.
added network-technology validation for CreateNetworkBB
Sonar Issue Fix | Changes done in encryption decryption logic |
Refactoring
Changes done in encryption decryption logic| Used AES/GCM/NoPadding
algorithm | fixed sonar issues
added network-type and network-technology to mapper
Continue the fight to make JUNITS work properly
Update ASDC ATT to be springboot 2.0 compliant
Continue to fix Unit tests for springboot 2.0 port
removed autowired from workflowactionbbtaskstest
fixed workflowactiontest and reduced size by 500 lines
Update last of UT for mockito upgrade to 2.0
Fix more JUNITS due to mockito 2.0 upgrade
Unit Test fixes to use proper mockito not spring
Update Base Test to import proper packages for compile
Additional Springboot 2.0 changes, for tests
Additional springboot 2.0 fixes and upgrades
Update Migration to be Flyway 5 Compliant
Fix MSOBPMN Infrastructure common tests
Fix Groovy Unit Tests in CommonBPMN Project
Update MSO common BPMN to Springboot 2.0
Upgrade ASDC controller to SpringBoot 2.0
Port Openstack adapters to springboot 2.0
Fix VFC Adapter to be springboot 2 compatible
Port CatalogDB adapter code to springboot 2
Port SDNC Adapter to Springboot 2.0
...
added update scripts to macro data instead of v12 sql
added secondarypolicy to rainy day handling table
confirm subnet map is not null in adapter response
shallow copy subnet before AAI udpate
update AAIObjectType to use uriTemplate
extract subnet data from adapter response
update correct AAIObjectType for subnet query
update subnet(s) in AAI on network create completion
confirm subnet map is not null in adapter response
shallow copy subnet before AAI udpate
update AAIObjectType to use uriTemplate
extract subnet data from adapter response
update correct AAIObjectType for subnet query
update subnet(s) in AAI on network create completion
fixed test http entity unit test to remove testing appid and
transaction id
added unit test for querySubsystemHealth method. also added
resttemplate mock to implement healthcheck endpoint
fixed unit test to use mock instead of actually goes out to health
check endpoint
added code to extend globalhealthcheck to include pinging other
components and consolidate the responses
converted test to no longer be a springboot test
Remove cosmetic changes from BPMN files to be consistent.
Remove minor changes that are not related to functionality.
added update scripts to macro data instead of v12 sql
Rework to implement the functionality as part of Validator
added secondarypolicy to rainy day handling table
added network-type and network-technology to mapper
Combine the verification methods into one based on the flow's name;
change the logging.
Add verification of status of other VF Modules in the VNF for the
delete/deactivate/unassign.
updated how request db is set to failure in workflowA
corrected code to match existing unit tests
corrected tests after springboot 2 upgrade
Added Required UTs in UpdateConfigurationStateTest and also fixed some
UTs.
added in missing parenthesis on method call
added back execution variable for allotted uri
addressed comments on pull request
refactor AAI Rest calls from groovy files - Changes as per review
comments
checkin to refactor AAI rest | Fixing AAIResourceClient.update call
refactor AAI Rest calls from groovy files - UpdateConfiguration
refactor AAI Rest calls from groovy file - DeleteConfiguration
refactor AAI Rest calls from groovy file - UpdateConfiguration
refactor AAI Rest calls from groovy file - CreateConfiguration &
ConfigurationUtils
refactor AAI Rest calls from groovy files - Fix getARByID issue
checkin to refactor AAI rest | Adding Junits
checkin to refactor AAI rest | Adding few more classes
checkin to refactor AAI rest of DoCreateVfModuleVolumeV2
checkin to refactor AAI rest | Update junit
checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 | Adding junits
checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 | Adding junits
checkin to refactor AAI rest of DoCreateVfModuleVolumeV2.groovy
...
updated in and out mapping to be generalBuildingBlock
change source out mapping to generalBuildingBlock
Change-Id: I122f1ebe3e15b77da0a55af201d89d47e326bf83
Issue-ID: SO-1098
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|