summaryrefslogtreecommitdiffstats
path: root/adapters/mso-adapter-utils/src/main
AgeCommit message (Collapse)AuthorFilesLines
2018-12-05moved all ecomp.mso properties to org.onap.soKalkere Ramesh, Sharan (sk720x)3-6/+20
moved all ecomp.mso properties to org.onap.so Change-Id: I55bd57d1c1d1dca065575c03d3c0b8f83aa4594d Issue-ID: SO-1278 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-11-27Remove all usage of AlarmLoggerBenjamin, Max (mb388a)6-37/+33
Fix broken UT from removing alarm logger fixed compilation and merge issues Remove all usage of AlarmLogger Change-Id: Ic87abd51423274570bfca0ed976d9642a91a843d Issue-ID: SO-1229 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-11-21Add Keystone V3 SupportBenjamin, Max (mb388a)8-67/+357
update JEL with explicit getVariable call set project object into scope object add camunda properties as defaults in application.yaml added exception handling to keystone v3 case added in password method to identity object initial commit of keystone v3 auth support updated json property values with "_name" added new columns to cloud identity Change-Id: Ie08e9893c34d7199197efdb21fe4dd5413b25f44 Issue-ID: SO-1225 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-11-17Up TimerSmokowski, Steve (ss835w)1-1/+1
Issue-ID: SO-1209 Change-Id: Icb018e4a178ab13f6d142bdcb1000411c0d0dedf Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com> (cherry picked from commit 6e3aad261b40427288b18f21b86f109172dbd9c4)
2018-11-05Springboot 2.0 upgradeBenjamin, Max (mb388a)1-3/+3
corrected typo in CloudConfiguration class removed files which should not have been merged updated gr api test cases with dynamic cloud owner updated groovy files to allow for dynamic cloud owner values moved VFModularity folder to mso-infrastructure bpmn updated GR API layer to include cloud owner added enum for default cloud owner - fixing junit test cases for using catalogDb client r2 - fixing junit test cases for using catalogDb client - Internal review comments incorporated for merging mocking into BaseTest - Internal review comments incorporated for removing direct repo calls - CLONE - Key Management Hardcoded encryption key | fixing junits - CLONE - Key Management Hardcoded encryption key Updated builder to use String.format Added exception specifically for issues interacting with requestdbadapter Updated exception message and added junit test case removed useless error handling test case from workflow changed method name and added junit coverage to errors added max retry and success status after completed bb Added case to handle when homing is not called during assign vnf. Fixing fortify issues | Implementing review comments - Key Management Hardcoded encryption key - fixing prop files - Key Management Hardcoded encryption key include network ID for completion handler Added exception handling for saving to requestdb - Adding a check on the predicate availability on the repository before firing the query with default conditions. This ensures that the api returns data only when there is an input against which it was able to form some conditions Modify UT to show that the API does not behave - adding negative test case for checkInstanceNameDuplicate added assertion that global count var was reset to 0 updated rollback to reset current sequence count var workflowaction calls rollback is complete before error workflowaction will set failure on successful rollback added check for isrollback to know which complete to call removed file which should not have been added add fabric check before running vf module a la carte Enhance UCPEMigrateService junits and add them to Jenkins build.. Added back removed test case for ManualTasks Added test case for response error Added rainy day test cases for ManualTasks revert the other change and fix the rollback logic instead fixed current sequence and updated rollback code added network cloud heat template parameters to mapper Generate a unique subRequestId for each request to APP-C. reverted conditional logic for determining fabric Fix Bean scanning so it picks up the resttemplate removed unnecessary RestTemplate Bean configurations removed file which should not have been added workflowaction calls rollback is complete before error workflowaction will set failure on successful rollback added check for isrollback to know which complete to call add fabric check before running vf module a la carte added assertion that global count var was reset to 0 updated rollback to reset current sequence count var include network ID for completion handler Revert Application.yaml change accidentally checked in Added exception handling for saving to requestdb Added case to handle when homing is not called during assign vnf. removed useless error handling test case from workflow changed method name and added junit coverage to errors ... add cloud owner variable to camunda in mapping Revert "Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Added juint test to verify variables are set in the execution. Set default cloudOwner in main module CreateVfModuleVolumeInfraV2" updated cloud configuration pojo to inlcude defaults Revert "Test to verify ServiceInstance object mapping" Test to verify ServiceInstance object mapping Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Added juint test to verify variables are set in the execution. Set default cloudOwner in main module CreateVfModuleVolumeInfraV2 Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Set default cloudOwner 'att-aic' if null per old requirements. removed references to att-aic from BBInputSetup Changes done in encryption decryption logic | used DelegateExecutionFake in Tests Changes done in encryption decryption logic | used DelegateExecutionFake in Tests Changes done in encryption decryption logic Changes done in encryption decryption logic | removed Default Auth Constant as per the comments Changes done in encryption decryption logic | Fixed UT Changes done in encryption decryption logic | Added XmlComparator assertion for verifying XML Changes done in encryption decryption logic | Reverted as per the review comment Changes done in encryption decryption logic | Fixed UTs Changes done in encryption decryption logic | Fixed UTs Changes done in encryption decryption logic | modified related encrypted properties in test yaml files Changes done in encryption decryption logic for fortify issue resolution | Fixed UTs Changes done in encryption decryption logic | modified related encrypted properties in yaml files Changes done in encryption decryption logic for fortify issue resolution. Fixed Property fetching issue in required file Added TasksBeansTest using openpojo Removed renamed test file from tasksbeans Updated imports on TasksBeansTest Added openpojo test to replace the individual tests Removed tests that provided no coverage script clean up -Update reference data to support distinct recreate and replace requests with their own sequences Update reference data to support distinct recreate and replace requests with their own sequences- Fix seq number Update reference data to support distinct recreate and replace requests with their own sequences added null check to mdc and interceptors to sdnc cxf validations can now match against multiple BBs reverted changes to BBInputSetup class added support for pre and post validation for BBs initial commit of generic building block validator converted test to no longer be a springboot test Remove cosmetic changes from BPMN files to be consistent. Remove minor changes that are not related to functionality. Rework to implement the functionality as part of Validator Combine the verification methods into one based on the flow's name; change the logging. Add verification of status of other VF Modules in the VNF for the delete/deactivate/unassign. added network-technology validation for CreateNetworkBB Sonar Issue Fix | Changes done in encryption decryption logic | Refactoring Changes done in encryption decryption logic| Used AES/GCM/NoPadding algorithm | fixed sonar issues added network-type and network-technology to mapper Continue the fight to make JUNITS work properly Update ASDC ATT to be springboot 2.0 compliant Continue to fix Unit tests for springboot 2.0 port removed autowired from workflowactionbbtaskstest fixed workflowactiontest and reduced size by 500 lines Update last of UT for mockito upgrade to 2.0 Fix more JUNITS due to mockito 2.0 upgrade Unit Test fixes to use proper mockito not spring Update Base Test to import proper packages for compile Additional Springboot 2.0 changes, for tests Additional springboot 2.0 fixes and upgrades Update Migration to be Flyway 5 Compliant Fix MSOBPMN Infrastructure common tests Fix Groovy Unit Tests in CommonBPMN Project Update MSO common BPMN to Springboot 2.0 Upgrade ASDC controller to SpringBoot 2.0 Port Openstack adapters to springboot 2.0 Fix VFC Adapter to be springboot 2 compatible Port CatalogDB adapter code to springboot 2 Port SDNC Adapter to Springboot 2.0 ... added update scripts to macro data instead of v12 sql added secondarypolicy to rainy day handling table confirm subnet map is not null in adapter response shallow copy subnet before AAI udpate update AAIObjectType to use uriTemplate extract subnet data from adapter response update correct AAIObjectType for subnet query update subnet(s) in AAI on network create completion confirm subnet map is not null in adapter response shallow copy subnet before AAI udpate update AAIObjectType to use uriTemplate extract subnet data from adapter response update correct AAIObjectType for subnet query update subnet(s) in AAI on network create completion fixed test http entity unit test to remove testing appid and transaction id added unit test for querySubsystemHealth method. also added resttemplate mock to implement healthcheck endpoint fixed unit test to use mock instead of actually goes out to health check endpoint added code to extend globalhealthcheck to include pinging other components and consolidate the responses converted test to no longer be a springboot test Remove cosmetic changes from BPMN files to be consistent. Remove minor changes that are not related to functionality. added update scripts to macro data instead of v12 sql Rework to implement the functionality as part of Validator added secondarypolicy to rainy day handling table added network-type and network-technology to mapper Combine the verification methods into one based on the flow's name; change the logging. Add verification of status of other VF Modules in the VNF for the delete/deactivate/unassign. updated how request db is set to failure in workflowA corrected code to match existing unit tests corrected tests after springboot 2 upgrade Added Required UTs in UpdateConfigurationStateTest and also fixed some UTs. added in missing parenthesis on method call added back execution variable for allotted uri addressed comments on pull request refactor AAI Rest calls from groovy files - Changes as per review comments checkin to refactor AAI rest | Fixing AAIResourceClient.update call refactor AAI Rest calls from groovy files - UpdateConfiguration refactor AAI Rest calls from groovy file - DeleteConfiguration refactor AAI Rest calls from groovy file - UpdateConfiguration refactor AAI Rest calls from groovy file - CreateConfiguration & ConfigurationUtils refactor AAI Rest calls from groovy files - Fix getARByID issue checkin to refactor AAI rest | Adding Junits checkin to refactor AAI rest | Adding few more classes checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 checkin to refactor AAI rest | Update junit checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 | Adding junits checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 | Adding junits checkin to refactor AAI rest of DoCreateVfModuleVolumeV2.groovy ... updated in and out mapping to be generalBuildingBlock change source out mapping to generalBuildingBlock Change-Id: I122f1ebe3e15b77da0a55af201d89d47e326bf83 Issue-ID: SO-1098 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-10-25Resolve vf_module_id setting bugMarcus G K Williams1-7/+18
Do not remove vf_module_id and vnf_id from parameters in HeatUtils. Issue-ID: SO-1165 Change-Id: I6f00350a6f7dc419a8be9b90b28188228949cb43 Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-10-17Return canonical stack id on multicloud createEric Multanen1-1/+1
When creating vfmodule via multicloud adapter, return the canonical name of the stack <stackname>/<stack id> Code was returning <stack id>/<stack id> Change-Id: Iaa2a105ab779acc9638fe515c7bc4e5c23d7233e Issue-ID: SO-1142 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-10-16Fix swapped parameters for multicloud DELETEEric Multanen1-1/+1
cloudSiteId and tenantId were swapped in call to deleteStack(). Change-Id: I56bc326cb680dabb9d397cb7f0f918e406cb8bba Issue-ID: SO-1139 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-10-12Fix up request body of multicloud adapter bodyEric Multanen2-31/+19
Make some of the attributes json instead of json in a string. Fixed up payload of request. Change-Id: I7737fd19d44c8075bd7fef19068a72f8c0ec7e6d Issue-ID: SO-1124 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-10-01Fix up handling of multicloud return statusEric Multanen2-34/+258
Add calls to query vfmodule status to return when doing create and delete. Return status based on the query result and not the rest response. Put in the completion polling support on create. Change-Id: Ife50509e54e001b92f4a65ec6be2905aef99f9b5 Issue-ID: SO-1082 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-09-27Fix calls to multicloud adapterEric Multanen9-186/+706
Fix up the json body of the POST call to multicloud. Improve checkout of responses from multicloud calls. Change-Id: I1fb47460b54e9e5b478815d3b531d5bdbe1fe3dc Issue-ID: SO-1082 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-09-22Merge "DeploymentInfo tests and construction improvement"Seshu Kumar M3-172/+226
2018-09-20Add multicloud to VnfPluginAdapterEric Multanen4-171/+795
Adds new mode 'multicloud' to VnfPluginAdapter along with MsoMulticloudUtils and supporting code. Change-Id: I1cfdc9ba09c58315fb0bfc025854cf0122a32759 Issue-ID: SO-752 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-09-17DeploymentInfo tests and construction improvementMichal Kabaj3-172/+226
- Improved construction by adding DeploymentInfoBuilder - DeploymentInfo immutable - added detailed unit tests Change-Id: I3dabb91d5190ef932e77f0c76e18fde8ca73c64d Issue-ID: SO-1055 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-08-31Update LoggingSmokowski, Steve (ss835w)1-38/+0
Add CXF interceptor for SOAP based logging Clean up extra logging statements Add UT to ensure MDC properly populated Change package name on Jax-RS Filter to be more accurate Issue-ID: SO-947 Change-Id: I3a2afc58de3bf370675658ce3d19cf899b90def7 Change-Id: I3a2afc58de3bf370675658ce3d19cf899b90def7 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-08-23Changed RequestFactory for Catalog DB clientBenjamin, Max (mb388a)6-25/+13
- Missed some files, the repository isn't required now that we dont fetch the identity service directly - Fixing review comments and removing the unused import - Fixing the build :) Now that cloudSite has a 1-1 relationship with cloudidentity, there shouldn't be a need to query the identity on its own unless the site is missing Refactored some code to use site to fetch identity as a composition - Changing the catalogDb client to use HttpComponentsClientHttpRequestFactory instead of SimpleClientHttpRequestFactory, the later would lead to a IOException (FileNotFoundException specifically) whenever a 40X type of a response code is returned from the spring rest endpoint. Adding some tests for the catalogDbClient which earlier got missed in handover. Also fixing another issue with cloudSite repository which was not fetching data correctly. Fixed a repository which was added initially but later the same went missing (Not sure how) Change-Id: I72506865c4c5f7fd07a6031c146a4aba1a96c2c8 Issue-ID: SO-892 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-13Cloud config database table supportBenjamin, Max (mb388a)14-734/+44
added cloud config database entities added cloud config repository converted existing cloud config class converted all code interacting with previous cloud config object created migration to automatically load cloud config properties from application.yaml Issue-ID: SO-854 Change-Id: Icf408e5d0fcabd1b7e97298963c555fae6964930 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-07-31Containerization feature of SOBenjamin, Max (mb388a)58-4102/+2192
Change-Id: I95381232eeefcd247a66a5cec370a8ce1c288e18 Issue-ID: SO-670 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-07-25Replace with the diamond operatorSS004935051-1/+1
AriaVduPlugin.java Sonar Link: https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.so%3Aso&open=AWK-9MGVwGn37JfbmLXt&resolved=false&severities=MAJOR Location:src/main/java/org/openecomp/mso/aria/AriaVduPlugin.java Line No: L126 Change-Id: I186e7dfef1ddf406036f902d1f04b4677652b91f Issue-ID: SO-739 Signed-off-by: SS00493505 <ss00493505@techmahindra.com>
2018-07-13add junit for VfModuleCustomizationToVduMapperLukasz Muszkieta1-2/+18
Change-Id: Ia63f7ababdb7f51a89da4713ae29c1297e7bd746 Issue-ID: SO-718 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-05-16Add guard time to keystone expiryBrian Freeman1-1/+2
Issue-ID: SO-622 Change-Id: If8260ee70d3c632325939affcbd80258b2602c99 Signed-off-by: Brian Freeman <bf1936@att.com>
2018-05-04Fix CloudConfig junitsRob Daugherty7-38/+50
...for some definition of the word "fix". There is still a lot that's less than ideal about how CloudConfig is handled, and with how the unit tests are written. Change-Id: Ic8c66c64d336f22c141687cf41a4828810bf1aec Issue-ID: SO-584 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-05-01SDNC Adapter not loading propertiesRob Daugherty1-5/+3
Somebody changed some variables from static to non-static, and this broke the CloudConfig loading logic. I changed them back. Change-Id: Id7dca76a4f0af0209ebd6cef8f3e0209c3f7a022 Issue-ID: SO-584 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-04-26SDNC Adapter not loading propertiesRob Daugherty2-0/+127
We are missing 2 source files in SO which were part of MSO 1802: CloudConfigInitializer.java CloudConfigIdentityMapper.java The missing initializer means that cloud-config.json is never loaded. Change-Id: Id1186edda01d345de072b5288382dbdc56679294 Issue-ID: SO-584 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-04-13updated to use latest vdu plugin codedfilppi3-2/+534
Change-Id: I46cd41d32e0902a141a87d0c1e01aea278ec17ea Issue-ID: SO-561 Signed-off-by: DeWayne Filppi <dewayne@cloudify.co>
2018-03-27Initial commit of VDU plugin implementationKalkere Ramesh, Sharan (sk720x)11-13/+1154
This was documented in the API we committed to at M3. Change-Id: Id0c886d956dc46dba71157cfa35d88844028e7fd Issue-ID: SO-511 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-03-27Update Heat enviroment HPA parametersShashank Kumar Shankar1-194/+218
[WORK IN PROGRESS] This patch adds support for updating HPA parameters in Heat templates. Change-Id: Id37e2d1ec752085bdd6808f03be5e85ac040d0c3 Issue-ID: SO-408 Signed-off-by: Shashank Kumar Shankar <shashank.kumar.shankar@intel.com>
2018-03-14AT&T 1712 and 1802 release codeRob Daugherty42-1348/+2213
This is code from AT&T's 1712 and 1802 releases. Change-Id: Ie1e85851e94bc66c4d9514a0226c221939531a04 Issue-ID: SO-425 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-12junit adding and refactor for CloudConfigLukasz Muszkieta2-47/+19
Change-Id: I3b98e6f8633347970be70e7b93680ec8ed4daacc Issue-ID: SO-430 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-03-09Merge "Sonar:Critical"Seshu Kumar M1-1/+1
2018-03-08Remove redundant declaration of extending objectMunir Ahmad1-5/+5
Change-Id: Iee7e4fc93dd82cab27986335560a41000851c33d Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-06Remove redundant catch clauseMunir Ahmad2-4/+0
Change-Id: Ib26f47171384125847a1b31bc1a958b50d0bba70 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-06Merge "Replace StringBuilder with String & inline return"Seshu Kumar M5-51/+31
2018-03-06Replace explicit type with dimond typeMunir Ahmad4-8/+8
Change-Id: I1dedb9ef1ca7b734e3cfc0a3a594d733dbd298d4 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-06Replace StringBuilder with String & inline returnMunir Ahmad5-51/+31
Resolved merge conflicts Change-Id: I1a8c8b6fd801c1eb7719ea3d17f029972e2ba84f Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-06Merge "Simplify if statements where it makes sense"Seshu Kumar M3-13/+3
2018-02-27Merge "Make use of getOrDefault"DeWayne Filppi1-3/+1
2018-02-26Make use of getOrDefaultMunir Ahmad1-3/+1
Change-Id: Ic73b58835a7964cb2fd88415f55b03ff79ad33ff Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-27Make use of append instead of string concatenationMunir Ahmad3-14/+14
Change-Id: I94ad658026f165ba8b5a74352095188a27ee50e5 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-26Simplify if statements where it makes senseMunir Ahmad3-13/+3
Change-Id: Id04ede6b8aa8fa3ca8c02b8c32ad5f4745ef47f4 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-25Swap while loops with foreach where applicableMunir Ahmad1-55/+53
Change-Id: Id3b54e8192f0e60657aa4c50af56c1ef98fbff5e Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-23add junit for cloud wrappersLukasz Muszkieta2-20/+0
Change-Id: I699b10ee2cb6e8b57ca56e8a9baae8aa41000540 Issue-ID: SO-430 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-02-21Boolean constructor callMunir Ahmad1-1/+1
Change-Id: Ic5a16598b1f1ac4f53ab651064b872316abafde0 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-21Swap String concatenation with StringBuilderMunir Ahmad1-3/+3
Change-Id: I5c43d3267e5f75623bcc837e27c57a6ad6aa8877 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-21Merge "add junit for AuthenticationMethodFactory"Seshu Kumar M2-25/+11
2018-02-21Sonar:CriticalAS004650591-0/+2
Fixing MsoCommonUtils.java MsoCommonUtils.java: L130 L145 Sonar Link: https://sonar.onap.org/issues/search#resolved=false|severities=MAJOR|rules=squid%3AS2293|assignees=__me__ Location:src/main/java/org/openecomp/mso/openstack/utils/MsoCommonUtils.java Change-Id: I120d35a9c06f56dd82b50f248062fc38e60c0819 Issue-ID: SO-401 Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
2018-02-16Sonar:CriticalSumapriya Sarvepalli1-1/+1
Make the enclosing method static or remove this set CloudConfigFactory.java:L152 L158 Sonar Link: https://sonar.onap.org/project/issues?fileUuids=AV3Bnscm5bp_wwmIVB8j&id=org.openecomp.so%3Aso&resolved=false&severities=CRITICAL Location: src/main/java/org/openecomp/mso/cloud/CloudConfigFactory.java Change-Id: Ie4bbda9ab312f920971b77f58ec3ced6ea9f9db2 Issue-ID: SO-427 Signed-off-by: Sumapriya Sarvepalli <SS00493505@TechMahindra.com>
2018-02-09Merge "add junit for MsoHeatEnvironmentEntry"Seshu Kumar M1-177/+48
2018-02-08add junit for AuthenticationMethodFactoryLukasz Muszkieta2-25/+11
Change-Id: I115792b73c62c50362a39fe45936fe294fe575dc Issue-ID: SO-414 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-02-08Merge "refactoring - add Optional"Seshu Kumar M7-188/+60