summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-02-16Sonar:CriticalSumapriya Sarvepalli1-1/+1
Make the enclosing method static or remove this set CloudConfigFactory.java:L152 L158 Sonar Link: https://sonar.onap.org/project/issues?fileUuids=AV3Bnscm5bp_wwmIVB8j&id=org.openecomp.so%3Aso&resolved=false&severities=CRITICAL Location: src/main/java/org/openecomp/mso/cloud/CloudConfigFactory.java Change-Id: Ie4bbda9ab312f920971b77f58ec3ced6ea9f9db2 Issue-ID: SO-427 Signed-off-by: Sumapriya Sarvepalli <SS00493505@TechMahindra.com>
2018-02-11Merge "Fix some Sonar Blocker issues in apihandler/common"Seshu Kumar M9-59/+38
2018-02-09Merge "add junit for MsoHeatEnvironmentEntry"Seshu Kumar M3-188/+133
2018-02-09Imporve test coverage for RequestDatabasesubhash kumar singh2-0/+295
Import test coverate for requestDatabase. Change-Id: Idc25f9758ca4c4e03460642e9e2460f0b126726e Issue-ID: SO-360 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-02-08Fix some Sonar Blocker issues in apihandler/commonShashank Kumar Shankar9-59/+38
Some sonar code fixes are done in this patch. https://sonar.onap.org/issues/search#issues=AV3BntKO5bp_wwmIVCLv https://sonar.onap.org/issues/search#issues=AV5mhwQk32hFUzlqebFJ https://sonar.onap.org/issues/search#issues=AV3BntKc5bp_wwmIVCMJ https://sonar.onap.org/issues/search#issues=AV3BntKi5bp_wwmIVCMK https://sonar.onap.org/issues/search#issues=AV3BntKu5bp_wwmIVCMQ https://sonar.onap.org/issues/search#issues=AV3BntK35bp_wwmIVCMX https://sonar.onap.org/issues/search#issues=AV5mhwRN32hFUzlqebFQ https://sonar.onap.org/issues/search#issues=AV3BntLG5bp_wwmIVCMc https://sonar.onap.org/issues/search#issues=AV3BntLR5bp_wwmIVCMh Change-Id: I3ba77adec1951fb7153ed640eb1ea0a4a3ed3e6b Issue-ID: SO-165 Signed-off-by: Shashank Kumar Shankar <shashank.kumar.shankar@intel.com>
2018-02-08Merge "Sonar:Critical"Seshu Kumar M2-13/+9
2018-02-08Merge "refactoring - add Optional"Seshu Kumar M12-239/+111
2018-02-08Sonar:CriticalManamohan Satapathy2-13/+9
Define and throw a dedicated exception instead of using a generic one:L39 L41 L43 Sonar Link: https://sonar.onap.org/component_issues/index?id=org.openecomp.so%3Aso#resolved=false|severities=CRITICAL|fileUuids=AV5mhvcK32hFUzlqebDQ Location:src/main/java/org/openecomp/mso/client/aai/AAIRestClient.java Change-Id: I606ff51c58ef22975222fc7fda04aab4680ac2de Issue-ID: SO-399 Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
2018-02-07add junit for MsoHeatEnvironmentEntryLukasz Muszkieta3-188/+133
Change-Id: Ibc2b9562de8fbfdb60ee09add404bd3923431501 Issue-ID: SO-360 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-02-07Merge "Sonar blocker issue - closeableHttpClient"Seshu Kumar M1-100/+18
2018-02-08Sonar blocker issue - closeableHttpClientliboNet1-100/+18
user the try-with-resource method to fix issue https://sonar.onap.org/issues/search#issues=AV-B6Uh2-08if2a6r-Va and https://sonar.onap.org/issues/search#issues=AV-B6Uh2-08if2a6r-Vb Change-Id: I70a6424307e88c28a7290ed23d13888ef55c3aa3 Issue-ID: SO-165 Signed-off-by: Zhu Libo <libo.zhu@intel.com>
2018-02-07Merge "Get Msb Ip from env parameter"Seshu Kumar M1-8/+15
2018-02-07Get Msb Ip from env parameterc001491071-8/+15
Get Msb Ip from env parameter instead of config file. Change-Id: I86e1664ffb4f817d70631f870c49a773bf04cc04 Issue-ID: SO-410 Signed-off-by: c00149107 <chenchuanyu@huawei.com>
2018-02-06Merge "Sonar:Critical"Seshu Kumar M1-3/+3
2018-02-06Merge "Added unittests for RollbackData"Seshu Kumar M2-67/+145
2018-02-06Merge "Refactor of DecomposeJsonUtils class."Seshu Kumar M5-189/+139
2018-02-06Sonar:CriticalSumapriya Sarvepalli1-3/+3
Define and throw a dedicated exception instead of using a generic one ApplicationControllerClient.java:L79 L121 L132 Sonar Link: https://sonar.onap.org/account/issues#resolved=false|rules=squid%3AS00112 Location:src/main/java/org/openecomp/mso/client/appc/ApplicationControllerClient.java Change-Id: Iba0d52ad2310fed17bb1012611e4ca0bf0ae2180 Issue-ID: SO-400 Signed-off-by: Sumapriya Sarvepalli <SS00493505@TechMahindra.com>
2018-02-06Merge "Sonar:Major"Seshu Kumar M1-1/+1
2018-01-31Added unittests for RollbackDatabiniek2-67/+145
Change-Id: I3c6f3b204e3cea6acce643f023f73561765226ee Issue-ID: SO-374 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2018-01-31add junit for StackInfoLukasz Muszkieta7-210/+144
Change-Id: I80e60b590d761c30fd2c71e259c2b4f5cf53b508 Issue-ID: SO-360 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-01-31Merge "Sonar:Major"Seshu Kumar M1-0/+1
2018-01-31Merge "Sonar:Major"Seshu Kumar M1-0/+1
2018-01-31Merge "Sonar:Major"Seshu Kumar M1-0/+1
2018-01-31Merge "Same Service names under two different Customers"Seshu Kumar M4-6/+100
2018-01-31Sonar:MajorSumapriya Sarvepalli1-1/+1
The diamond operator (<>) should be used OrchestrationRequests.java:L163 Sonar Link: https://sonar.onap.org/issues/search#resolved=false|severities=MAJOR|rules=squid%3AS2293|assignees=__me__ Location:OrchestrationRequests.java:L163 Change-Id: I2b3241d46d72b9ad52f2009dc7746cf4a3f456ea Issue-ID: SO-397 Signed-off-by: Sumapriya Sarvepalli <SS00493505@TechMahindra.com>
2018-01-30Sonar:MajorManamohan Satapathy1-0/+1
Add the @Override annotation above this method signature:L145 Issue-ID: SO-395 Sonar Link: https://sonar.onap.org/component_issues/index?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|rules=squid%3AS1161 Location:src/main/java/org/openecomp/mso/bpmn/core/domain/JsonWrapper.java Change-Id: Ifb0d6ee37ec3b935326d7aed7cc50e8b79aa0df5 Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
2018-01-30Merge "Sonar:Major"Seshu Kumar M1-1/+1
2018-01-30Merge "Default Recipe Mapping for Service"Seshu Kumar M1-5/+13
2018-01-30Sonar:MajorManamohan Satapathy1-0/+1
Add the @Override annotation above this method signature.java:L92 Issue-ID: SO-394 Sonar Link: https://sonar.onap.org/component_issues/index?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|rules=squid%3AS1161 Location:src/main/java/org/openecomp/mso/bpmn/core/RollbackData.java Change-Id: Ib3d56f82b1a21df201fe2f9558f2b33004033c7e Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
2018-01-30Sonar:MajorAzhar Sardar Sayyed1-0/+1
Add the @Override annotation LoggingAndURNMappingPlugin.java:L326 Sonar Link:https://sonar.onap.org/component_issues/index?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|rules=squid%3AS1161 Location:LoggingAndURNMappingPlugin.java:L326 Change-Id: I047385bdf582a8c07998243ce25f9f669ce20765 Issue-ID: SO-396 Signed-off-by: Azhar Sardar Sayyed <AS00465059@TechMahindra.com>
2018-01-29Merge "add JUnit for NetworkInfo"Seshu Kumar M6-90/+191
2018-01-29Merge "Unittest refactoring."Seshu Kumar M5-245/+209
2018-01-29Refactor of DecomposeJsonUtils class.biniek5-189/+139
Change-Id: I72b779eb17ffb901266de605eb2eda49f13bd03e Issue-ID: SO-374 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2018-01-29refactoring - add OptionalLukasz Muszkieta12-239/+111
change possible null return value to Optional Change-Id: I70bf78a51b901a74932b00d1d8735bef5eeacef7 Issue-ID: SO-360 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-01-29Sonar:MajorSumapriya Sarvepalli1-1/+1
The diamond operator (<>) should be used NsParameters.java:L38 Issue-ID: SO-392 Sonar Link: https://sonar.onap.org/issues/search#resolved=false|severities=MAJOR|rules=squid%3AS2293|assignees=__me__ Location:src/main/java/org/openecomp/mso/adapters/vfc/model/NsParameters.java Change-Id: I12ec3ceb4b7da8c5cccc0e01205addce6c2c0d1e Signed-off-by: Sumapriya Sarvepalli <SS00493505@TechMahindra.com>
2018-01-29Merge changes Ie0f9c31f,I1fbe5516,I4beee70d,Ib9c5dad0,I80eb6d4fSeshu Kumar M2-125/+792
* changes: Improve UT for catalog db Improve UT for catalog db Improve UT for catalog db Improve UT for catalog db Improve UT for catalog db
2018-01-25Improve UT for catalog dbsubhash kumar singh2-74/+488
Improve UT for catalog db. Change-Id: Ie0f9c31f9ec39e4cc693b8b1076702fb1fe11a25 Issue-ID: SO-360 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-01-24Same Service names under two different CustomersChittaranjan Sardar4-6/+100
SO is not allowing to create services with same name with in different customers. Change-Id: I2ce83f3d6c8d999f88154a1ac50330a8b6d50118 Issue-ID: SO-382 Signed-off-by: Chittaranjan Sardar <chittaranjan.sardar@amdocs.com>
2018-01-24Merge changes Ifc9dda6b,Ic7b8d75dSeshu Kumar M2-4/+10
* changes: Deal with network VL for voLTE Add mso.vfc.properties
2018-01-24Merge "Add Category info For Service and Resource"Seshu Kumar M7-10/+102
2018-01-23Default Recipe Mapping for ServiceAbhishek Shekhar1-5/+13
Change-Id: Ib01f46eae63963496a809e255dc71c977e79c759 Issue-ID: SO-384 Signed-off-by: Abhishek Shekhar <abhishek.shekhar1@amdocs.com>
2018-01-22Deal with network VL for voLTEc001491071-3/+9
Deal with network VL for voLTE, no heat needed. Change-Id: Ifc9dda6b90ea6b05841d46cff8e40a93c7ed98e2 Issue-ID: SO-380 Signed-off-by: c00149107 <chenchuanyu@huawei.com>
2018-01-22Add mso.vfc.propertiesc001491071-1/+1
Add mso.vfc.properties config file Change-Id: Ic7b8d75d9e10d8ce284a98e76459d47edcbb697f Issue-ID: SO-383 Signed-off-by: c00149107 <chenchuanyu@huawei.com>
2018-01-22Add Category info For Service and Resourcec001491077-10/+102
Add Category info For Service and Resource,It is used for generic workflow Change-Id: I952d39388eac8b379a8ecc365e1292fdc0cf597e Issue-ID: SO-379 Signed-off-by: c00149107 <chenchuanyu@huawei.com>
2018-01-19add JUnit for NetworkInfoLukasz Muszkieta6-90/+191
Change-Id: I08210bc29f4f6c2f90723b57e30d48c60a81e3bb Issue-ID: SO-360 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-01-19Improve UT for catalog dbsubhash kumar singh2-15/+64
Improve UT for catalog db. Change-Id: I1fbe5516b29763fdaf2a2734f1aa7432a1261eae Issue-ID: SO-360 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-01-19Improve UT for catalog dbsubhash kumar singh2-10/+60
Improve UT for catalog db. Change-Id: I4beee70d0e78fca0d792480477d1010d5faa086d Issue-ID: SO-360 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-01-19Improve UT for catalog dbsubhash kumar singh2-12/+117
Improve UT for catalog db Change-Id: Ib9c5dad03c0107778c554c54d1586e0ddd79c297 Issue-ID: SO-360 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-01-19Improve UT for catalog dbsubhash kumar singh2-15/+64
Improve UT for catalog db. Change-Id: I80eb6d4f58ea9de2d73a92a917dad8f9c98dc88a Issue-ID: SO-360 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-01-19Merge "Sonar blocker issue - NullPointerExeption"Seshu Kumar M1-15/+1