Age | Commit message (Collapse) | Author | Files | Lines |
|
Major Sonar fixes in different classes:
-Removed unnecessary code.
-Removed unused variables.
-Removed unnecessary imports.
-Simplified diamond operators.
-Improved String comparisons in equals.
Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I279c63f8e7161d6e33d5d6a28b938c0c64e90f1f
|
|
|
|
|
|
Sonar vulnerability fixes in ServicePluginFactory:
-Added logger.
Issue-ID: SO-2139
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Id1752ea35db970b20d02e730dac9900c411958ca
|
|
Added servicename to MDC so that it gets logged and added enter and
exit markers.
Issue-ID: SO-2122
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I63ff5e5de21d851c989ffa5db2051755751d9ead
|
|
|
|
Add basic auth for so-monitoring app
Issue submitted in pentest report
Change-Id: I8e826da9b9f66e893826fd9b40b3b26623b2ab8d
Issue-ID: OJSI-169
Signed-off-by: k.kazak <k.kazak@samsung.com>
|
|
|
|
|
|
warning about unused variable"
|
|
* changes:
Added null check for function param pFqdns to prevent crash at for loop.
Added check for null ptr before dereferencing at gBBInput.getCustomer().getServiceSubscription() - to prevent static analyzer warning
|
|
|
|
|
|
Set networkName value to the name from L3network object.
Add JUnit argument captures for naming creates
Fix formatting errors in the JUnit file.
Issue-ID: SO-2123
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Ie4d2bd86f1a47bd5742aa7786dc9cba47fa11392
|
|
Removing the application-local.yaml files because they're no longer
maintained or working.
Issue-ID: SO-2121
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I191c8775de931671a4657be8940e6aec64023359
|
|
Fix error when updating existing record in request_processing_data
table.
Use correct field name in the toString method in RequestProcessingData
bean class.
RequestDbClient.updateRequestProcessingData should include entity id in
the URI on the PUT request.
Add new Config class ExposeEntityIdResourceConfiguration to make
Spring data Rest return id in the response for RequestProcessingData.
Make spring-boot-starter-data-rest not optional dependency in
mso-requests-db-repositories
Added unit test for RequestDbClient.updateRequestProcessingData()
method.
Issue-ID: SO-2120
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I733be06185e5c19a0b7112918ce0a0f2abf861d7
|
|
|
|
Remove duplicate name check in createAAITasks. This hould be done prior
to status check in WorkflowAction or BBInputSetup.
Issue-ID: SO-2119
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Change-Id: I0d6d34476b1ab2b351314c9a23926f2fff0e4f89
|
|
analyzer warning about workflowResponse never being set to anything but null."
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Issue-ID: SO-2116
Change-Id: I1e5bdfcf3164545c89fb370014d49ef3ae6a9cf1
Signed-off-by: MichaelMorris <michael.morris@est.tech>
|
|
Added SO update the R__WorkflowDesignerData.sql script to insert name of BPMN process
instead of description in the NAME field of workflow table for VnfInPlaceUpdate and
VnfConfigUpdate
Issue-ID: SO-2112
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: I288a1159e95c3798c37ff41a599662e5df8317ba
|
|
Add requestContext to unassignVfModule tasks and tests
Issue-ID: SO-2115
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Change-Id: Ifddfe32fab9406afb69ad9192351500cfbed3610
|
|
New script to expand column request_status on table
archived_infra_requests as well.
Issue-ID: SO-2114
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Change-Id: Ife1168e658bbb9e7fa69541de42173947564cac8
|
|
Need to check if audit is enabled first in the delete record task
Updates to audit delete redeisgn and data to table
Various updates to logging, audit object, added tag to query, updated
tag value.
Updated write method to make sure an entry for this heat stack doesnt
already exist to avoid duplicate entrys
Updated unit test to account for get query
Added so that id is not hidden from query results
Updated the was delete is done plus minor updates.
Updated delete method to use resttemplate instead of bowman client
Combined the write and get stack data task into the external tasks.
Removed the task to delete the stack data from db
Updates to junit request id so its not a random id for test
Updated service tasks in att BB to call external task
Update to be a real uuid format due to failing unit test
Updated fields to protected and updated unit test
Issue-ID: SO-2111
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Change-Id: I8f479a046cf837403f60c330ed6ad8bc08a9c82f
|
|
getParameterListFromEnvt()
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I8fabba8d99e311f01a5fd5dad166e0bb643044e3
|
|
Change-Id: I6331d08441b9bf1f621f56ec1b7d911851010e62
Issue-ID: SO-1948
Signed-off-by: waqas.ikram <waqas.ikram@est.tech>
|
|
static analyzer warning about unused variable
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I0d46bcc817d08a6fbad3501c56336dc532bb5907
|
|
prevent crash at for loop.
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I5e72e1c6d74c5f197479062348090ab2b87fafae
|
|
static analyzer warning about workflowResponse never being
set to anything but null.
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Ib150e3836fda9b7d9785a574f904b2c61bfa39f4
|
|
gBBInput.getCustomer().getServiceSubscription() -
to prevent static analyzer warning
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I5e1cb6248412ae9e3036011bd96d708f36170d70
|
|
Fixes in WorkflowAction according to the Sonar analysis:
-Fixed String comparison.
-Removed unnecessary method parameters.
-Updated junit test.
Issue-ID: SO-2107
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I7522269e237f736521a627bcd1c8f77b0c776a70
|
|
Major Sonar fixes in different classes:
-Removed unused variables.
-Simplified diamond operators.
-Removed unnecessary imports.
-Removed unnecessary code.
Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ib54fbe048700a4e31042481f0a9b13838552aee7
|
|
Sonar vulnerability fixes in ServicePluginFactory.
-Moved hardcoded IP addresses to the property file.
-Added junit test.
Issue-ID: SO-2106
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Id33e17f7845c106212bbf4d4a8ca78641cea1396
|
|
|
|
|
|
Removed unused imports from the file
Issue-ID: SO-2103
Change-Id: Id126f5203789d866b340d86b55bbc616991afc99
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
|
|
|
|
|
|
Major Sonar fixes in different classes:
-Removed unnecessary code.
-Removed unused variables.
-Removed unnecessary imports.
-Simplified diamond operators.
Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I098e3dcd93b804e58220bb41ea15325e820e3a59
|
|
Sonar fixes in OrchestrationRequests according to the Sonar analysis.
-Removed unnecessary code.
-Removed unused variables.
Issue-ID: SO-2101
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I564f35519c5063028e1cf540eb81ab81cf923fd5
|
|
Code fixes in ManualTasks according to the Sonar analysis.
-Removed unnecessary code.
-Removed unused imports.
-Removed unused variables.
Issue-ID: SO-2100
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I79848456cc88b7f2cb812f7054bb6cec12b584c0
|
|
Major code fixes in E2EServiceInstances according to the Sonar analysis.
-Removed unnecessary code.
-Removed unnecessary method parameters.
-Removed unused variables.
Issue-ID: SO-2099
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I0e217174455a6748c663b3d5cc92fdc22b67ce2d
|
|
Fixed multiple sonar issues in this file
Issue-ID: SO-2098
Change-Id: I7da9ffae8ee11d8475445b5263bc7cfb78834a9c
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|