aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-02-21Make use of addAll instead of loopMunir Ahmad3-15/+5
Change-Id: Ia3afb3ecfec21e81982c4838bf019cc8e3ef55c1 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-21Swap String concatenation with StringBuilderMunir Ahmad5-31/+31
Change-Id: I5c43d3267e5f75623bcc837e27c57a6ad6aa8877 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-21Remove redundant toStringMunir Ahmad6-16/+16
Change-Id: If039248f233e3aa53733aa1a888b571836ca9406 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-21Replace Collection.sort with List.sortMunir Ahmad1-8/+8
Change-Id: Ie7f81c79ac334e5783c4b7f6e1f45e454e215cda Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-21Merge "Added unittests for ApplicationControllerSupport"Seshu Kumar M1-0/+83
2018-02-21Merge "add junit for AuthenticationMethodFactory"Seshu Kumar M4-79/+121
2018-02-21Merge "Sonar:Critical"Seshu Kumar M1-0/+2
2018-02-21Merge "Adding Junit "Seshu Kumar M1-0/+54
2018-02-21Merge "Optimize number of MsoLogger instances"Seshu Kumar M1-10/+36
2018-02-21Added unittests for ApplicationControllerSupportbiniek1-0/+83
Change-Id: Id128e23a545de353e13a18b85ac23dbdd685f2bf Issue-ID: SO-374 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2018-02-21Sonar:CriticalAS004650591-0/+2
Fixing MsoCommonUtils.java MsoCommonUtils.java: L130 L145 Sonar Link: https://sonar.onap.org/issues/search#resolved=false|severities=MAJOR|rules=squid%3AS2293|assignees=__me__ Location:src/main/java/org/openecomp/mso/openstack/utils/MsoCommonUtils.java Change-Id: I120d35a9c06f56dd82b50f248062fc38e60c0819 Issue-ID: SO-401 Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
2018-02-21Merge "Added unittests"Seshu Kumar M3-31/+150
2018-02-20Added ability to PUT binary CSARdfilppi3-368/+421
Change-Id: Ib1dcad8b557cd543ecbf37c5e5947250ee0eb01e Issue-ID: SO-429 Signed-off-by: DeWayne Filppi <dewayne@cloudify.co>
2018-02-20Adding Junit AS004650591-0/+54
Junit for SDNCAdapterRequest.java Change-Id: I570ce3381b967e184601535558413826a5c0baf2 Issue-ID: SO-431 Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
2018-02-16Add Vdu plugin supportdfilppi4-0/+505
Change-Id: Icd47c120fff9c7ccc782c8c946b698c3f4a72ac0 Issue-ID: SO-428 Signed-off-by: DeWayne Filppi <dewayne@cloudify.co>
2018-02-15Optimize number of MsoLogger instancesUsaraswat1-10/+36
Each call to getMsoLogger creates a new instance of MsoLogger which is a potential memory leak Change-Id: Ib0dda3abbf45d8633b4c8a2d49aa9d5c87e12931 Issue-ID: LOG-174 Signed-off-by: Usaraswat <saraswat.urwashi@amdocs.com>
2018-02-15Added unittestsbiniek3-31/+150
Added unittests for ResponseExecptionMapperImpl and refactored one test for CompleteMsoProcessTest Issue-ID: SO-374 Signed-off-by: biniek <lukasz.biniek@nokia.com> Change-Id: I359daf14d2a913829721fff3f2d340c6e893aa13 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2018-02-14Fixed build.dfilppi21-1/+59
Change-Id: I48e69958b08767c14085fef5e9befb4b7f9a5875 Issue-ID: SO-426 Signed-off-by: DeWayne Filppi <dewayne@cloudify.co>
2018-02-11Merge "Fix some Sonar Blocker issues in apihandler/common"Seshu Kumar M9-59/+38
2018-02-09Merge "add junit for MsoHeatEnvironmentEntry"Seshu Kumar M3-188/+133
2018-02-09Imporve test coverage for RequestDatabasesubhash kumar singh2-0/+295
Import test coverate for requestDatabase. Change-Id: Idc25f9758ca4c4e03460642e9e2460f0b126726e Issue-ID: SO-360 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-02-08Fix some Sonar Blocker issues in apihandler/commonShashank Kumar Shankar9-59/+38
Some sonar code fixes are done in this patch. https://sonar.onap.org/issues/search#issues=AV3BntKO5bp_wwmIVCLv https://sonar.onap.org/issues/search#issues=AV5mhwQk32hFUzlqebFJ https://sonar.onap.org/issues/search#issues=AV3BntKc5bp_wwmIVCMJ https://sonar.onap.org/issues/search#issues=AV3BntKi5bp_wwmIVCMK https://sonar.onap.org/issues/search#issues=AV3BntKu5bp_wwmIVCMQ https://sonar.onap.org/issues/search#issues=AV3BntK35bp_wwmIVCMX https://sonar.onap.org/issues/search#issues=AV5mhwRN32hFUzlqebFQ https://sonar.onap.org/issues/search#issues=AV3BntLG5bp_wwmIVCMc https://sonar.onap.org/issues/search#issues=AV3BntLR5bp_wwmIVCMh Change-Id: I3ba77adec1951fb7153ed640eb1ea0a4a3ed3e6b Issue-ID: SO-165 Signed-off-by: Shashank Kumar Shankar <shashank.kumar.shankar@intel.com>
2018-02-08Merge "Sonar:Critical"Seshu Kumar M2-13/+9
2018-02-08add junit for AuthenticationMethodFactoryLukasz Muszkieta4-79/+121
Change-Id: I115792b73c62c50362a39fe45936fe294fe575dc Issue-ID: SO-414 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-02-08Merge "refactoring - add Optional"Seshu Kumar M12-239/+111
2018-02-08Sonar:CriticalManamohan Satapathy2-13/+9
Define and throw a dedicated exception instead of using a generic one:L39 L41 L43 Sonar Link: https://sonar.onap.org/component_issues/index?id=org.openecomp.so%3Aso#resolved=false|severities=CRITICAL|fileUuids=AV5mhvcK32hFUzlqebDQ Location:src/main/java/org/openecomp/mso/client/aai/AAIRestClient.java Change-Id: I606ff51c58ef22975222fc7fda04aab4680ac2de Issue-ID: SO-399 Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
2018-02-07add junit for MsoHeatEnvironmentEntryLukasz Muszkieta3-188/+133
Change-Id: Ibc2b9562de8fbfdb60ee09add404bd3923431501 Issue-ID: SO-360 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-02-07Merge "Sonar blocker issue - closeableHttpClient"Seshu Kumar M1-100/+18
2018-02-08Sonar blocker issue - closeableHttpClientliboNet1-100/+18
user the try-with-resource method to fix issue https://sonar.onap.org/issues/search#issues=AV-B6Uh2-08if2a6r-Va and https://sonar.onap.org/issues/search#issues=AV-B6Uh2-08if2a6r-Vb Change-Id: I70a6424307e88c28a7290ed23d13888ef55c3aa3 Issue-ID: SO-165 Signed-off-by: Zhu Libo <libo.zhu@intel.com>
2018-02-07Merge "Get Msb Ip from env parameter"Seshu Kumar M1-8/+15
2018-02-07Get Msb Ip from env parameterc001491071-8/+15
Get Msb Ip from env parameter instead of config file. Change-Id: I86e1664ffb4f817d70631f870c49a773bf04cc04 Issue-ID: SO-410 Signed-off-by: c00149107 <chenchuanyu@huawei.com>
2018-02-06Merge "Sonar:Critical"Seshu Kumar M1-3/+3
2018-02-06Merge "Added unittests for RollbackData"Seshu Kumar M2-67/+145
2018-02-06Merge "Refactor of DecomposeJsonUtils class."Seshu Kumar M5-189/+139
2018-02-06Sonar:CriticalSumapriya Sarvepalli1-3/+3
Define and throw a dedicated exception instead of using a generic one ApplicationControllerClient.java:L79 L121 L132 Sonar Link: https://sonar.onap.org/account/issues#resolved=false|rules=squid%3AS00112 Location:src/main/java/org/openecomp/mso/client/appc/ApplicationControllerClient.java Change-Id: Iba0d52ad2310fed17bb1012611e4ca0bf0ae2180 Issue-ID: SO-400 Signed-off-by: Sumapriya Sarvepalli <SS00493505@TechMahindra.com>
2018-02-06Merge "Sonar:Major"Seshu Kumar M1-1/+1
2018-01-31Added unittests for RollbackDatabiniek2-67/+145
Change-Id: I3c6f3b204e3cea6acce643f023f73561765226ee Issue-ID: SO-374 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2018-01-31add junit for StackInfoLukasz Muszkieta7-210/+144
Change-Id: I80e60b590d761c30fd2c71e259c2b4f5cf53b508 Issue-ID: SO-360 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-01-31Merge "Sonar:Major"Seshu Kumar M1-0/+1
2018-01-31Merge "Sonar:Major"Seshu Kumar M1-0/+1
2018-01-31Merge "Sonar:Major"Seshu Kumar M1-0/+1
2018-01-31Merge "Same Service names under two different Customers"Seshu Kumar M4-6/+100
2018-01-31Sonar:MajorSumapriya Sarvepalli1-1/+1
The diamond operator (<>) should be used OrchestrationRequests.java:L163 Sonar Link: https://sonar.onap.org/issues/search#resolved=false|severities=MAJOR|rules=squid%3AS2293|assignees=__me__ Location:OrchestrationRequests.java:L163 Change-Id: I2b3241d46d72b9ad52f2009dc7746cf4a3f456ea Issue-ID: SO-397 Signed-off-by: Sumapriya Sarvepalli <SS00493505@TechMahindra.com>
2018-01-30Sonar:MajorManamohan Satapathy1-0/+1
Add the @Override annotation above this method signature:L145 Issue-ID: SO-395 Sonar Link: https://sonar.onap.org/component_issues/index?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|rules=squid%3AS1161 Location:src/main/java/org/openecomp/mso/bpmn/core/domain/JsonWrapper.java Change-Id: Ifb0d6ee37ec3b935326d7aed7cc50e8b79aa0df5 Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
2018-01-30Merge "Sonar:Major"Seshu Kumar M1-1/+1
2018-01-30Merge "Default Recipe Mapping for Service"Seshu Kumar M1-5/+13
2018-01-30Sonar:MajorManamohan Satapathy1-0/+1
Add the @Override annotation above this method signature.java:L92 Issue-ID: SO-394 Sonar Link: https://sonar.onap.org/component_issues/index?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|rules=squid%3AS1161 Location:src/main/java/org/openecomp/mso/bpmn/core/RollbackData.java Change-Id: Ib3d56f82b1a21df201fe2f9558f2b33004033c7e Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
2018-01-30Sonar:MajorAzhar Sardar Sayyed1-0/+1
Add the @Override annotation LoggingAndURNMappingPlugin.java:L326 Sonar Link:https://sonar.onap.org/component_issues/index?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|rules=squid%3AS1161 Location:LoggingAndURNMappingPlugin.java:L326 Change-Id: I047385bdf582a8c07998243ce25f9f669ce20765 Issue-ID: SO-396 Signed-off-by: Azhar Sardar Sayyed <AS00465059@TechMahindra.com>
2018-01-29Merge "add JUnit for NetworkInfo"Seshu Kumar M6-90/+191
2018-01-29Merge "Unittest refactoring."Seshu Kumar M5-245/+209