summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-06-05General Sonar fixes and improvementsr.bogacki6-39/+13
General fixes and improvements according to the Sonar analysis. -Fixed imports. -Removed unnecessary variables. -Protect utility static classes with private constructor. -Removed unnecessary exceptions. Issue-ID: SO-1992 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Ib0011d730f86e0e1a25d4cf1080a61b2fbb335ae
2019-06-04Improvements in ToscaResourceInstallerr.bogacki1-22/+19
Improvements in ToscaResourceInstaller according to the Sonar analyses. -Removed unnecessary imports. -Removed unnecessary exceptions. -Improvements for an array size checking. -Refactored diamond operators for a simplicity. Issue-ID: SO-1984 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I498933adadbb2d6f5dc956b0056c728f141e3869
2019-06-04Improvements in VfResourceStructurer.bogacki1-4/+6
Improvements in VfResourceStructure according to the Sonar analyses. -Removed unnecessary imports. -Removed unnecessary exceptions. -Improvements for possible NPE issues. Issue-ID: SO-1983 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I014c5de19eca853cf1263b541e2c34b6e6db9b1d
2019-06-03Merge "Fix ConfigAssignVnfBB and ConfigDeployVnfBB"Marcus Williams3-19/+28
2019-06-03Merge "update INFO.yaml"Marcus Williams1-7/+13
2019-06-03update INFO.yamlseshukm1-7/+13
Issue-ID: SO-1944 Change-Id: I221fc3cce7f72373ad35a6ce07c887e928038348 Signed-off-by: seshukm <seshu.kumar.m@huawei.com> (cherry picked from commit c32829b9f2e67a46fb56b590c253fd3bdc9cce97)
2019-06-03Fix ConfigAssignVnfBB and ConfigDeployVnfBBAlexis de Talhouët3-19/+28
Change-Id: If5a175ee26e279cf71e38c996a75fa627e5e2c00 Issue-ID: SO-1981 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2019-06-03Cleaned up duplicated literalsrob.bog126-625/+781
Cleaned up Sonar code smells related to the duplicated literals in loggers. Issue-ID: SO-1932 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e
2019-06-02Merge "New GroupLevel DeleteE2EServiceInstance flow"Seshu Kumar M4-188/+342
2019-05-31Merge "property to determine if delete audit is needed"Steve Smokowski2-1/+11
2019-05-31Merge "apih resume request handling more generic"Steve Smokowski9-162/+777
2019-05-31Merge "issue encoding openstack errors"Steve Smokowski2-2/+23
2019-05-31Merge "Fix issue where request was not being updated"Steve Smokowski6-4/+145
2019-05-31enhanced vnf adapter errog log.Sangalang, Felix3-6/+15
enhanced vnf adapter error log for heatEnvironment when null. removed the junit tests because of no assertions coverage. enhanced vnf adapter errog log. Change-Id: I80d3070ce203c4c8339f0a0e7df6f3731d0a16c2 Issue-ID: SO-1967 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31Fix issue where request was not being updatedSmokowski, Steven6-4/+145
Fix issue where request was not being updated Change-Id: Ib4b3809797449224ac417facfaa4bf48d91a1ecb Issue-ID: SO-1966 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31issue encoding openstack errorsSmokowski, Steven2-2/+23
Fix setting of port to fix unit test issues Fix formatting error on the file causing build issue Properly revert change that was made previously Fix issue where base java library not encoding properly Change-Id: I2bfa46825d9a99998195dbd7bd422f88fa76ef09 Issue-ID: SO-1965 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31property to determine if delete audit is neededKalkere Ramesh, Sharan2-1/+11
update the onap delete vf module BB bpmn as well validate formatting of audit tasks code changes added a property to determine if delete audit is needed Change-Id: Id29eed6295ed6623636a4812708e53c5ae440b83 Issue-ID: SO-1964 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31apih resume request handling more genericPlummer, Brittany9-162/+777
getInstanceName throws exception if requestScope doesn't match modelType Updated to combine separate return statements Replaced if statements for modelType and added tests Replace if statements for modelType in ResumeOrchestrationRequest and added tests Added coverage for setId in ModelType Updated to use ModelType setters/getters model type can now get and set generically Added modelInfo to RequestBody for resume request Added getModelType call and unit tests Moved getModelType from ServiceInstances Moved getModelType and added unit tests Added tests for getIsBaseVfModule Added more tests for isBaseVfModule Began adding tests for getIsBaseVfModule Updated currentActiveRequest creation and isBaseVfModule Updated recipe lookup and setting of aLaCarte to be more general Updated concurrency control to include other resources Change-Id: I12ad011d0a021c3ee066e16b4c8a4526d040cbe3 Issue-ID: SO-1963 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31Merge "converted lock time from hard coded value"Steve Smokowski4-5/+13
2019-05-31Merge "Corrected enum formatting by plugin"Steve Smokowski23-109/+435
2019-05-31Merge "JUnit tests for RestfulUtil"Steve Smokowski2-2/+159
2019-05-31Merge "Added NPE check for audit"Steve Smokowski2-54/+56
2019-05-31Merge "apih to populate original request id"Steve Smokowski10-11/+132
2019-05-31Corrected enum formatting by pluginBenjamin, Max (mb388a)23-109/+435
enums are now single item per line Change-Id: I6330ea4a9093071457dd47b95b6ed3bb7f8312e7 Issue-ID: SO-1970 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31converted lock time from hard coded valueKalkere Ramesh, Sharan4-5/+13
update lock time property to have a default of 60000 converted lock time from hard coded to property driven Change-Id: I4a42b85c4241c8865f8dc133be96d7bc92b8574d Issue-ID: SO-1962 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31Handle multiple host routes correctly for networksMcblain, Thomas3-6/+72
unit test for the method that creates subnets Remove project name from junit test data Handle multiple host routes correctly for networks Change-Id: I537b9bbb68c11901c06ed2366591cedeb3b29acd Issue-ID: SO-1961 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31apih to populate original request idPlummer, Brittany10-11/+132
Updated schema.sql to fix failing tests Added constants for request parameters Added originalRequestId to be saved on resume request Added originalRequestId to orchestrationRequests response Change-Id: If2b86d233ee3db9bbe0e1185d92874bca2b3a07a Issue-ID: SO-1960 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31Added NPE check for auditBoslet, Cory2-54/+56
Added NPE check so that flow continues when no audit results present Change-Id: I614dbaff7eaaca86a503da2734d7c5f7a197bb1b Issue-ID: SO-1959 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31Merge "Renamed NF fields in catalog db pojo"Steve Smokowski2-23/+23
2019-05-31Merge "Remove update of request status"Steve Smokowski2-4/+1
2019-05-31fix keypair conflict issue in openstack adapterSmokowski, Steven24-951/+1150
Fix wiremock stubs to return proper data and url Fix copyright header issue on unit test file Fix keypair issue, clean up unit tests and logging Fix issues found in unit testing, update data Fix broken Unit tests that used invalid data Continue Refactor to support keypair failure scenario Update logic for when to auto delete a stuck keypair Change-Id: Ice5256cf0381a3b46d1c442907c0f321a1c0d006 Issue-ID: SO-1897 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31New GroupLevel DeleteE2EServiceInstance flowsarada prasad sahoo4-188/+342
Modified the subprocess 'DoDeleteE2EServiceInstance' to support Group level instances. Change-Id: I8dfd154bc6eb9c9f7c7dc932bdce215a3b9fd800 Issue-ID: SO-1393 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
2019-05-31Merge "Improvements in AAIClientHelper"Lukasz Muszkieta1-5/+3
2019-05-31Improvements in AAIClientHelperr.bogacki1-5/+3
Improvements in AAIClientHelper according to the Sonar analysis. Removed unnecessary exception throwing. Fixed imports. Updated java docs. Issue-ID: SO-1958 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I60835304466bb656f09ba16b487907fa529e5eab
2019-05-31Merge "Improvements in RequestClient"Lukasz Muszkieta2-13/+62
2019-05-30Improvements in RequestClientFactoryr.bogacki1-5/+6
Improvements in RequestClientFactory according to the Sonar analysis. Fixed imports. Removed unnecessary exceptions handling. Replaced depreciated DefaultHttpClient with a new one. Issue-ID: SO-1947 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Id497bfb620775aac67ad4c5f6d57e0fccce4fd34
2019-05-30Improvements in RequestClientr.bogacki2-13/+62
Improvements in RequestClient according to the Sonar analysis. Removed unnecessary exceptions handling. Added junit tests. Fixed imports. Issue-ID: SO-1945 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Iee22e7dbeb39ca28c437f9a8a804b81945cb9bc5
2019-05-30Merge "Improvements in CamundaClient"Steve Smokowski1-49/+21
2019-05-30Merge "Fix DeleteE2EServiceInstance flow"Seshu Kumar M5-295/+242
2019-05-29Improvements in CamundaClientrob.bog1-49/+21
Removed code duplicates. Fixed declarations of thrown exceptions. Fixed imports. Issue-ID: SO-1936 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Ic178341b0049307da033408719ff263a00059ba7
2019-05-29JUnit tests for RestfulUtilr.bogacki2-2/+159
Increased junit tests coverage according to Sonar analyses. Added missing tests for RestfulUtil. Issue-ID: SO-1692 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I8744960c0ad3a36ca4c36e23867168bfda5cbd1d
2019-05-29Merge "Fix request body for SDNC req"Seshu Kumar M2-1/+1
2019-05-28Fix request body for SDNC reqsubhash kumar singh2-1/+1
Fix request body for SDNC req. Issue-ID: SO-1393 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com> Change-Id: Ia8112b81fa29f886e282445b3c0dc068d487cadd
2019-05-27Fix sonar for MapEntryk.kazak5-11/+53
MapEntry bug: make entry private and provide accessors MapEntry codesmell: move comment 'Required by JAXB' into empty constructor MapElements codesmell: move explanatory comment inside empty constructor MapElements codesmell: log error stacktrace MapAdapter codesmell: use entry set instead of key set for iteration JAXBMarshallingTest: add test cases to cover 100% of MapElements & other cases Change-Id: If51f1f86b5ad44b3462424e4fd73cb0eff352124 Issue-ID: SO-1811 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-05-23Calls to/from VNFM failMichaelMorris8-12/+73
Issue-ID: SO-1909 Change-Id: I2f8a19dfd456316e5436be4e85d8a384d7d5ed6f Signed-off-by: MichaelMorris <michael.morris@est.tech>
2019-05-23Fix Build -Use latest SNAPSHOT appc client-libsMarcus G K Williams1-2/+2
Issue-ID: SO-1921 Change-Id: Id20f8f7d77469e8123317447aa974a3e77103761 Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2019-05-23Remove update of request statusSmokowski, Steven2-4/+1
fix unit test now that method does not update status Remove update of request status, should not be done Change-Id: I17958ef76ccfa059893da0c2bcea1baa124d6922 Issue-ID: SO-1915 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-23Renamed NF fields in catalog db pojoMerkel, Jeff2-23/+23
- Renamed Nf properties to just Function, Role, Type. Change-Id: I0cec751e783c1fb7abdcf9f9565eadf89e0ac32c Issue-ID: SO-1914 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-22SDNC request body fixsubhash kumar singh3-38/+70
Request body fix for sdnc requests. Change-Id: Id3e454be18c62ab8c2e5ee572de55bf3ef7c18a3 Issue-ID: SO-1393 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2019-05-22Fix instance resource listsubhash kumar singh1-13/+24
Fix instance resource list if group is not list type. Change-Id: I99d37d5407c925dbb3355de73105de755b30bc04 Issue-ID: SO-1393 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>