summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-08-27Fix issue in mso-api-handler-infraParshad Patel4-45/+50
Either log or rethrow this exception Define a constant instead of duplicating this literal Immediately throw this expression instead of assigning it to the temporary variable Remove the declaration of thrown exception 'org.json.JSONException' which is a runtime exception Issue-ID: SO-1841 Change-Id: I193f21ec2c4214863c8b51faf25fc3561d6be818 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-08-26Merge "Fix parsing issue for ccvpn"Byung-Woo Jun6-19/+335
2019-08-26Fix parsing issue for ccvpnsubhash kumar singh6-19/+335
Fix csar parsing issue for ccvpn. Change-Id: Ie99acbec8a52de7a08d1627c210c0e3fda986520 Issue-ID: SO-1393 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com> Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2019-08-26Added default value for when ErrorCode is null inBoslet, Cory5-143/+22
Added default value for when ErrorCode is null in mdc test to see if 404 log gets enhanced by change. Removed test id from class that was put to test via docker. Removed setting of partner name and tested with using try/catch Reverted change to request uri filter per comments Removed the request filter uri class that rerouted old uri orders Removed request filter from jersey config files Updated junit test that were pointing to the old uri to be failure test corrected formatting issues on ServiceInstancesTest Issue-ID: SO-2259 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Id8f9daef139a82ee9e934d4d37906ffb7a7aadff
2019-08-26Merge "Add the check Fabric Config in"Steve Smokowski2-2/+6
2019-08-26Merge "- Updated VNF and VfModules to use the getEntity"Steve Smokowski1-171/+161
2019-08-26Merge "path prefix now stripped off per system"Steve Smokowski2-1/+12
2019-08-26Merge "added in exception handling if auditResult is null"Steve Smokowski1-2/+8
2019-08-26Merge "added additional mock to MsoGroovyTest"Steve Smokowski1-66/+69
2019-08-26Merge "fixed dsl builder to correctly add output"Steve Smokowski2-1/+45
2019-08-26Javadoc and logging improvementManamohan8-12/+221
Added Javadocs and logging for these classes. Change-Id: I26dd974357cfb9ccaed3f9afd0510dc07e9bc33e Issue-ID: SO-2052 Signed-off-by: Manamohan <MS00534989@Techmahindra.com>
2019-08-23Add the check Fabric Config inBonkur, Venkat2-2/+6
Add the check Fabric Config in configuration-subtype after format file run and commit Issue-ID: SO-2256 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: If47f81a985e6321cd84ccfc8d35c51f3ee79e1c2
2019-08-23Merge "url correction and improve API doc Issue-ID: SO-2245"Seshu Kumar M4-1326/+1388
2019-08-23Merge "Fix issue in so-bpmn-tasks"Lukasz Muszkieta2-49/+61
2019-08-22url correction and improve API docRene_Robert4-1326/+1388
Issue-ID: SO-2245 Signed-off-by: Rene_Robert <rene.robert@orange.com> Change-Id: Ife95e64f0bed03e779f8ffef180f2a68ed0eb371
2019-08-22- Updated VNF and VfModules to use the getEntityMerkel, Jeff1-171/+161
- Updated VNF and VfModules to use the getEntity API. - Added the processFlexware step back in. Issue-ID: SO-2244 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I1274ccb9b2c2e600f3c24f8ac86dd1ff673c66da
2019-08-22Merge "Moved setNeutronNetworkId() call inside null check to prevent crash ↵Lukasz Muszkieta1-1/+1
at outputs.get() call"
2019-08-22Fix issue in so-bpmn-tasksParshad Patel2-49/+61
Either log or rethrow this exception Define a constant instead of duplicating this literal Move the string literal on the left side of this string comparison Issue-ID: SO-1841 Change-Id: I828e744be9e71b84d85850d56373e921c174d26b Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-08-22Merge "Moved null check for outputs so that get() method call won't result ↵Lukasz Muszkieta1-4/+4
in crash."
2019-08-22General sonar fixesArindam Mondal3-6/+5
+) Use format specifier to log exception ++) remove unused import Issue-ID: SO-2226 Change-Id: I0938d624b918eddf30e96da4f12d7a06cc0ddfe1 Signed-off-by: arindamm <arind.mondal@samsung.com>
2019-08-21Added null check for latestStack to prevent crashOleksandr Moliavko1-10/+14
at method calls; moved latestStack declaration according to comment by maintainer Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: Ic4bfeca94103f6c902808de39df752569580c066
2019-08-21Merge "Javadoc and logging improvement"Seshu Kumar M5-31/+97
2019-08-21Merge "Added null check for httpResponse to prevent crash at throwing exception"Seshu Kumar M1-2/+6
2019-08-21Added null check for rootNode to prevent crash atOleksandr Moliavko1-13/+18
for loop. Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I5ec16f3d73982c89e2bf5b14758274f1d4dd7740
2019-08-21Rewritten checks for status according to commentsOleksandr Moliavko1-5/+9
Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I6023a043e2cf532de330060973d23a402a742e36
2019-08-20path prefix now stripped off per systemBenjamin, Max2-1/+12
path prefix now stripped off per system Issue-ID: SO-2243 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ie74e7c68f927a49b612c433b4a664887058a1726
2019-08-20added in exception handling if auditResult is nullKalkere Ramesh, Sharan1-2/+8
added in exception handling if auditResult is null maven process format the file that is not formatted fix formsatting again because it failed last time Issue-ID: SO-2242 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I6a83c7fe120e02e808470dbc9e7e431e0b62f4f4
2019-08-20added additional mock to MsoGroovyTestBoslet, Cory1-66/+69
added additional mock to MsoGroovyTest Issue-ID: SO-2241 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I441d79f4951184b0ca79f2c568978fe3d2043025
2019-08-19Merge "Solve the vnfc_instance_group_customization_id insertion failure problem"Seshu Kumar M1-0/+1
2019-08-19Close input streams via try-with-resourcesk.kazak3-18/+13
DefaultDmaapPropertiesImpl: close FileInputStream after loading ServicePluginFactory: close HttpClient if processing fails close application.properties InputStream after loading remove redundant catch block if behavior is the same add logging of exception in finally block BpmnInstaller: close csarFile if processing fails Change-Id: Ic6f942c401277c5150c5cc1297aba27ccd40694c Coverity-scan: CID-203903, CID-211476, CID-211615, CID-219308 Issue-ID: SO-2211 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-08-19Added null check for heat to remove staticOleksandr Moliavko1-1/+5
analyzer warning Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I71eb14adcc1227af4470853e6e1acdb631a7efe8
2019-08-16fixed dsl builder to correctly add outputBenjamin, Max2-1/+45
fixed dsl builder to correctly add output look for lambda key rather than parent class null Issue-ID: SO-2233 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I251b9b8b4c391354b9759ee16a2462df43c188f9
2019-08-16Merge "add junit coverage for SvnfmService"Steve Smokowski1-0/+112
2019-08-16Merge "Add retrieval of vmIds and vServerIds for APPC"Steve Smokowski9-4/+719
2019-08-16Merge "Add SO Same deployment id on deployed custom workflows"Steve Smokowski1-1/+1
2019-08-16Merge "Initial commit of validation framework to APIH"Steve Smokowski53-344/+1148
2019-08-16Merge "asdc controller treat distributionid as requestid"Steve Smokowski2-0/+37
2019-08-16Merge "apih format statusdetail to return granular"Steve Smokowski2-1/+14
2019-08-16Added null check for httpResponse to prevent crashOleksandr Moliavko1-2/+6
at throwing exception Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: Iffbaaddea9c9bb1609ce2e0755f6f3ca49e0ad31
2019-08-16Removed unused CSAR class.Oleksandr Moliavko1-189/+0
Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I0efbb38cb34b0b36d2659ebf36f6cd2d109e5deb
2019-08-16Replaced string concatenations in a loop withOleksandr Moliavko1-4/+9
StringBuffer appends to remove static analyzer warning about inefficient string operations Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I89e0e5b599a8263882b0f91fb0f9191734a04ec1
2019-08-16Merge "Added check for empty processInstanceList"Lukasz Muszkieta2-13/+26
2019-08-16Sonar fix in MSOCommonBPMNParshad Patel2-18/+18
Either log or rethrow this exception Remove this useless assignment to local variable "serviceInstance" Remove the declaration of thrown exception which is a runtime exception Move the string literal on the left side of this string comparison Issue-ID: SO-1841 Change-Id: I24cdd3682eddd2e5ceb7e961477a61457ef91ab2 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-08-16Javadoc and logging improvementManamohan5-31/+97
Added Javadocs and logging for these classes. Change-Id: I365fc0677c0d5136e4579de3947d0478b26c22d3 Issue-ID: SO-2052 Signed-off-by: Manamohan <MS00534989@Techmahindra.com>
2019-08-16Solve the vnfc_instance_group_customization_id insertion failure problemzm3301-0/+1
Change-Id: Iac9eea25895d9f048b00218b67db5d7bfb3efb58 Issue-ID: SO-2164 Signed-off-by: zm330 <zhangminyj@chinamobile.com>
2019-08-15Initial commit of validation framework to APIHSmokowski, Steven53-344/+1148
Move ListenerRunner to common location Adjust request params name, update junit tests Update validations to work properly Properly escape period for the string split Issue-ID: SO-2232 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ia468cf7062cccf30e28afeb7a5cddc37ceb2e002
2019-08-15Added check for empty processInstanceListPlummer, Brittany2-13/+26
Added check for empty processInstanceList Issue-ID: SO-2225 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: If4569d94dbda794c9a347e6dc73102acf7664558
2019-08-15asdc controller treat distributionid as requestidBhatt, Prema2-0/+37
Setting RequestId in MDC using DistributionID value in ASDC-controller Setting RequestId in MDC using DistributionID value in ASDC-controller. Cleaned up code. Removing the log line as per the review comments. Issue-ID: SO-2231 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I07880a80d479ad01411e0c5ece12d77722b8cb6c
2019-08-15apih format statusdetail to return granularPlummer, Brittany2-1/+14
Should return unchanged requestState on statusDetail queryParam Formatted files with changes to fix build Added enum validation for setting requestStatus Updated test to send in "statusDetail" Issue-ID: SO-2230 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I8f5d79bc287581635a1543a00ddc69fb9eba2295
2019-08-15Add SO Same deployment id on deployed custom workflowsBonkur, Venkat (vb8416)1-1/+1
Added the change to call the DeploymentBuilder.deploy() method after going through all the custom workflows. Thus all the workflows deployed and they startup correctly. Issue-ID: SO-2210 Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com> Change-Id: Ieaa5d1447405f75744d7c05bd8f7603c16edf5ea