summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-08-22Fix issue in so-bpmn-tasksParshad Patel2-49/+61
Either log or rethrow this exception Define a constant instead of duplicating this literal Move the string literal on the left side of this string comparison Issue-ID: SO-1841 Change-Id: I828e744be9e71b84d85850d56373e921c174d26b Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-08-22General sonar fixesArindam Mondal3-6/+5
+) Use format specifier to log exception ++) remove unused import Issue-ID: SO-2226 Change-Id: I0938d624b918eddf30e96da4f12d7a06cc0ddfe1 Signed-off-by: arindamm <arind.mondal@samsung.com>
2019-08-21Added null check for latestStack to prevent crashOleksandr Moliavko1-10/+14
at method calls; moved latestStack declaration according to comment by maintainer Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: Ic4bfeca94103f6c902808de39df752569580c066
2019-08-21Merge "Javadoc and logging improvement"Seshu Kumar M5-31/+97
2019-08-21Merge "Added null check for httpResponse to prevent crash at throwing exception"Seshu Kumar M1-2/+6
2019-08-21Added null check for rootNode to prevent crash atOleksandr Moliavko1-13/+18
for loop. Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I5ec16f3d73982c89e2bf5b14758274f1d4dd7740
2019-08-21Rewritten checks for status according to commentsOleksandr Moliavko1-5/+9
Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I6023a043e2cf532de330060973d23a402a742e36
2019-08-19Merge "Solve the vnfc_instance_group_customization_id insertion failure problem"Seshu Kumar M1-0/+1
2019-08-19Close input streams via try-with-resourcesk.kazak3-18/+13
DefaultDmaapPropertiesImpl: close FileInputStream after loading ServicePluginFactory: close HttpClient if processing fails close application.properties InputStream after loading remove redundant catch block if behavior is the same add logging of exception in finally block BpmnInstaller: close csarFile if processing fails Change-Id: Ic6f942c401277c5150c5cc1297aba27ccd40694c Coverity-scan: CID-203903, CID-211476, CID-211615, CID-219308 Issue-ID: SO-2211 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-08-19Added null check for heat to remove staticOleksandr Moliavko1-1/+5
analyzer warning Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I71eb14adcc1227af4470853e6e1acdb631a7efe8
2019-08-16Merge "add junit coverage for SvnfmService"Steve Smokowski1-0/+112
2019-08-16Merge "Add retrieval of vmIds and vServerIds for APPC"Steve Smokowski9-4/+719
2019-08-16Merge "Add SO Same deployment id on deployed custom workflows"Steve Smokowski1-1/+1
2019-08-16Merge "Initial commit of validation framework to APIH"Steve Smokowski53-344/+1148
2019-08-16Merge "asdc controller treat distributionid as requestid"Steve Smokowski2-0/+37
2019-08-16Merge "apih format statusdetail to return granular"Steve Smokowski2-1/+14
2019-08-16Added null check for httpResponse to prevent crashOleksandr Moliavko1-2/+6
at throwing exception Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: Iffbaaddea9c9bb1609ce2e0755f6f3ca49e0ad31
2019-08-16Removed unused CSAR class.Oleksandr Moliavko1-189/+0
Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I0efbb38cb34b0b36d2659ebf36f6cd2d109e5deb
2019-08-16Replaced string concatenations in a loop withOleksandr Moliavko1-4/+9
StringBuffer appends to remove static analyzer warning about inefficient string operations Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I89e0e5b599a8263882b0f91fb0f9191734a04ec1
2019-08-16Merge "Added check for empty processInstanceList"Lukasz Muszkieta2-13/+26
2019-08-16Sonar fix in MSOCommonBPMNParshad Patel2-18/+18
Either log or rethrow this exception Remove this useless assignment to local variable "serviceInstance" Remove the declaration of thrown exception which is a runtime exception Move the string literal on the left side of this string comparison Issue-ID: SO-1841 Change-Id: I24cdd3682eddd2e5ceb7e961477a61457ef91ab2 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-08-16Javadoc and logging improvementManamohan5-31/+97
Added Javadocs and logging for these classes. Change-Id: I365fc0677c0d5136e4579de3947d0478b26c22d3 Issue-ID: SO-2052 Signed-off-by: Manamohan <MS00534989@Techmahindra.com>
2019-08-16Solve the vnfc_instance_group_customization_id insertion failure problemzm3301-0/+1
Change-Id: Iac9eea25895d9f048b00218b67db5d7bfb3efb58 Issue-ID: SO-2164 Signed-off-by: zm330 <zhangminyj@chinamobile.com>
2019-08-15Initial commit of validation framework to APIHSmokowski, Steven53-344/+1148
Move ListenerRunner to common location Adjust request params name, update junit tests Update validations to work properly Properly escape period for the string split Issue-ID: SO-2232 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ia468cf7062cccf30e28afeb7a5cddc37ceb2e002
2019-08-15Added check for empty processInstanceListPlummer, Brittany2-13/+26
Added check for empty processInstanceList Issue-ID: SO-2225 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: If4569d94dbda794c9a347e6dc73102acf7664558
2019-08-15asdc controller treat distributionid as requestidBhatt, Prema2-0/+37
Setting RequestId in MDC using DistributionID value in ASDC-controller Setting RequestId in MDC using DistributionID value in ASDC-controller. Cleaned up code. Removing the log line as per the review comments. Issue-ID: SO-2231 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I07880a80d479ad01411e0c5ece12d77722b8cb6c
2019-08-15apih format statusdetail to return granularPlummer, Brittany2-1/+14
Should return unchanged requestState on statusDetail queryParam Formatted files with changes to fix build Added enum validation for setting requestStatus Updated test to send in "statusDetail" Issue-ID: SO-2230 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I8f5d79bc287581635a1543a00ddc69fb9eba2295
2019-08-15Add SO Same deployment id on deployed custom workflowsBonkur, Venkat (vb8416)1-1/+1
Added the change to call the DeploymentBuilder.deploy() method after going through all the custom workflows. Thus all the workflows deployed and they startup correctly. Issue-ID: SO-2210 Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com> Change-Id: Ieaa5d1447405f75744d7c05bd8f7603c16edf5ea
2019-08-15Merge "- Updated vnfc instance groups to use the"Steve Smokowski2-77/+135
2019-08-14public keyword removed for DoCreateServiceInstanceRollback.groovyanjali.walsatwar1-5/+5
groovy file correction Issue-ID: SO-2212 Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com> Change-Id: If2b6f5d1416042dd8ce88ae9d467ae24b00a1c55
2019-08-14Merge "DoCreateVFCNetworkServiceInstance.groovy corrected"Lukasz Muszkieta1-6/+6
2019-08-13Add retrieval of vmIds and vServerIds for APPCElena Kuleshov9-4/+719
2nd take, resolving build issu - port retrieval of vmIds and vserverIds from groovy to java Issue-ID: SO-2189 Signed-off-by: Kuleshov, Elena <evn@att.com> Change-Id: Ic666a65336e40eb38ab91c0037b85236ec1eebb5
2019-08-13- Updated vnfc instance groups to use theMerkel, Jeff2-77/+135
- Updated vnfc instance groups to use the getEntity API. Issue-ID: SO-2224 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I278aebe5174dfb52ad3db86957c262dca5eac359
2019-08-13Merge "Removed unused CryptoHandler, ICryptoHandler and CryptoHandlerTest ↵Lukasz Muszkieta3-159/+0
classes"
2019-08-13Merge "Place diamond op in place of type spec"Lukasz Muszkieta4-8/+5
2019-08-13Merge "Removed unused method setHPAParameters()"Lukasz Muszkieta1-18/+0
2019-08-13Removed unused CryptoHandler, ICryptoHandler andOleksandr Moliavko3-159/+0
CryptoHandlerTest classes Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I944ae9b49326257b6ddfe94687c3241e91af4de9
2019-08-13Place diamond op in place of type specsindhu36725-10/+7
Place diamond op in place of type spec MSOCommonBPMN classes Issue-ID: SO-2187 Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com> Change-Id: I133a9328f5c91c61af24a57a610d36c6d6622f66
2019-08-13Removed unused method setHPAParameters()Oleksandr Moliavko1-18/+0
Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: Ic9de579495c1400bca233b679699ae857180520b
2019-08-13Merge "Removed duplicate use of networkType field in String.format() call to ↵Lukasz Muszkieta1-2/+2
prevent static analyzer warning"
2019-08-13Merge "Change variable name-comply with regex"Seshu Kumar M2-4/+4
2019-08-13Merge "Change variable name-comply with regex"Seshu Kumar M2-6/+6
2019-08-13Merge "update version for 1.5.1"subhash kumar singh1-1/+1
2019-08-13Merge "Enhance variable name-comply with regex"Lukasz Muszkieta1-1/+1
2019-08-13Removed duplicate use of networkType field inOleksandr Moliavko1-2/+2
String.format() call to prevent static analyzer warning Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I1e3ea352aac9a88172b683d267b2f3c804bb362b
2019-08-13Merge "Modify variable name-comply with regex"Seshu Kumar M1-2/+2
2019-08-13Merge "Replace with equalsIgnoreCase"Seshu Kumar M1-4/+4
2019-08-13Merge "Use diamond op in place of type spec"Seshu Kumar M9-18/+18
2019-08-13update version for 1.5.1seshukm1-1/+1
Issue-ID: SO-2223 Signed-off-by: seshukm <seshu.kumar.m@huawei.com> Change-Id: I972e6be75ce9ca38e3d08ac17a48af62f0aa2f05
2019-08-13Enhance variable name-comply with regexsindhu36721-1/+1
Enhance variable name-comply with regex bpmn ConfigCheckerDelegate class Issue-ID: SO-2187 Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com> Change-Id: I11c06607cdb160f59c77e7e5af004364d53bddf5