summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-07-18Merge "Added null check for yaml to prevent crash at getParameterListFromEnvt()"Steve Smokowski1-3/+6
2019-07-18Merge "Commented out updatedAttribute declaration to prevent static analyzer ↵Steve Smokowski1-1/+1
warning about unused variable"
2019-07-18Merge changes I5e72e1c6,I5e1cb624Steve Smokowski2-9/+17
* changes: Added null check for function param pFqdns to prevent crash at for loop. Added check for null ptr before dereferencing at gBBInput.getCustomer().getServiceSubscription() - to prevent static analyzer warning
2019-07-18Merge "Fix error updating request_processing_data"Steve Smokowski4-2/+57
2019-07-18Merge "Remove duplicate name check in createAAITasks."Steve Smokowski2-96/+0
2019-07-18Removing application-local.yaml filesRoy, Amresh8-696/+0
Removing the application-local.yaml files because they're no longer maintained or working. Issue-ID: SO-2121 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I191c8775de931671a4657be8940e6aec64023359
2019-07-18Fix error updating request_processing_dataGamboa, Gilbert4-2/+57
Fix error when updating existing record in request_processing_data table. Use correct field name in the toString method in RequestProcessingData bean class. RequestDbClient.updateRequestProcessingData should include entity id in the URI on the PUT request. Add new Config class ExposeEntityIdResourceConfiguration to make Spring data Rest return id in the response for RequestProcessingData. Make spring-boot-starter-data-rest not optional dependency in mso-requests-db-repositories Added unit test for RequestDbClient.updateRequestProcessingData() method. Issue-ID: SO-2120 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I733be06185e5c19a0b7112918ce0a0f2abf861d7
2019-07-18Merge "Implement TLS for calls from VNFM adapter to VNFM"Steve Smokowski13-11/+118
2019-07-18Remove duplicate name check in createAAITasks.Gamboa, Gilbert2-96/+0
Remove duplicate name check in createAAITasks. This hould be done prior to status check in WorkflowAction or BBInputSetup. Issue-ID: SO-2119 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com> Change-Id: I0d6d34476b1ab2b351314c9a23926f2fff0e4f89
2019-07-18Merge "Commented out initialization of workflowResponse to prevent static ↵Steve Smokowski1-1/+2
analyzer warning about workflowResponse never being set to anything but null."
2019-07-18Merge "Fixes in WorkflowAction"Steve Smokowski2-5/+8
2019-07-18Merge "Major Sonar fixes"Steve Smokowski6-16/+11
2019-07-18Merge "Vulnerability fixes in ServicePluginFactory"Steve Smokowski3-7/+38
2019-07-18Merge "Add requestContext to unassignVfModule tasks and"Steve Smokowski4-10/+14
2019-07-18Merge "Add SO BPMN name for NAME in tbl workflow"Steve Smokowski1-2/+2
2019-07-18Merge "We need to expand column request_status"Steve Smokowski1-0/+3
2019-07-18Implement TLS for calls from VNFM adapter to VNFMMichaelMorris13-11/+118
Issue-ID: SO-2116 Change-Id: I1e5bdfcf3164545c89fb370014d49ef3ae6a9cf1 Signed-off-by: MichaelMorris <michael.morris@est.tech>
2019-07-18Add SO BPMN name for NAME in tbl workflowBonkur, Venkat (vb8416)1-2/+2
Added SO update the R__WorkflowDesignerData.sql script to insert name of BPMN process instead of description in the NAME field of workflow table for VnfInPlaceUpdate and VnfConfigUpdate Issue-ID: SO-2112 Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com> Change-Id: I288a1159e95c3798c37ff41a599662e5df8317ba
2019-07-17Add requestContext to unassignVfModule tasks andMcblain, Thomas4-10/+14
Add requestContext to unassignVfModule tasks and tests Issue-ID: SO-2115 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com> Change-Id: Ifddfe32fab9406afb69ad9192351500cfbed3610
2019-07-17We need to expand column request_statusGamboa, Gilbert1-0/+3
New script to expand column request_status on table archived_infra_requests as well. Issue-ID: SO-2114 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com> Change-Id: Ife1168e658bbb9e7fa69541de42173947564cac8
2019-07-17add query stack data and populate table stepBoslet, Cory21-205/+879
Need to check if audit is enabled first in the delete record task Updates to audit delete redeisgn and data to table Various updates to logging, audit object, added tag to query, updated tag value. Updated write method to make sure an entry for this heat stack doesnt already exist to avoid duplicate entrys Updated unit test to account for get query Added so that id is not hidden from query results Updated the was delete is done plus minor updates. Updated delete method to use resttemplate instead of bowman client Combined the write and get stack data task into the external tasks. Removed the task to delete the stack data from db Updates to junit request id so its not a random id for test Updated service tasks in att BB to call external task Update to be a real uuid format due to failing unit test Updated fields to protected and updated unit test Issue-ID: SO-2111 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com> Change-Id: I8f479a046cf837403f60c330ed6ad8bc08a9c82f
2019-07-15Added null check for yaml to prevent crash atOleksandr Moliavko1-3/+6
getParameterListFromEnvt() Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I8fabba8d99e311f01a5fd5dad166e0bb643044e3
2019-07-12Fixing ASDCRestInterface for CSIT to simulate SDC reqwaqas.ikram5-62/+102
Change-Id: I6331d08441b9bf1f621f56ec1b7d911851010e62 Issue-ID: SO-1948 Signed-off-by: waqas.ikram <waqas.ikram@est.tech>
2019-07-12Commented out updatedAttribute declaration to preventOleksandr Moliavko1-1/+1
static analyzer warning about unused variable Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I0d46bcc817d08a6fbad3501c56336dc532bb5907
2019-07-12Added null check for function param pFqdns toOleksandr Moliavko1-8/+16
prevent crash at for loop. Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I5e72e1c6d74c5f197479062348090ab2b87fafae
2019-07-12Commented out initialization of workflowResponse to preventOleksandr Moliavko1-1/+2
static analyzer warning about workflowResponse never being set to anything but null. Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: Ib150e3836fda9b7d9785a574f904b2c61bfa39f4
2019-07-12Added check for null ptr before dereferencing atOleksandr Moliavko1-1/+1
gBBInput.getCustomer().getServiceSubscription() - to prevent static analyzer warning Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I5e1cb6248412ae9e3036011bd96d708f36170d70
2019-07-12Fixes in WorkflowActionr.bogacki2-5/+8
Fixes in WorkflowAction according to the Sonar analysis: -Fixed String comparison. -Removed unnecessary method parameters. -Updated junit test. Issue-ID: SO-2107 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I7522269e237f736521a627bcd1c8f77b0c776a70
2019-07-12Major Sonar fixesr.bogacki6-16/+11
Major Sonar fixes in different classes: -Removed unused variables. -Simplified diamond operators. -Removed unnecessary imports. -Removed unnecessary code. Issue-ID: SO-2102 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Ib54fbe048700a4e31042481f0a9b13838552aee7
2019-07-12Vulnerability fixes in ServicePluginFactoryr.bogacki3-7/+38
Sonar vulnerability fixes in ServicePluginFactory. -Moved hardcoded IP addresses to the property file. -Added junit test. Issue-ID: SO-2106 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Id33e17f7845c106212bbf4d4a8ca78641cea1396
2019-07-11Merge "Sonar Fix: SDNCAdapterApplication.java"Steve Smokowski1-2/+2
2019-07-10Merge "Major Sonar fixes in E2EServiceInstances"Lukasz Muszkieta1-27/+10
2019-07-10Sonar Fix: SDNCAdapterApplication.javaArundathi Patil1-2/+2
Removed unused imports from the file Issue-ID: SO-2103 Change-Id: Id126f5203789d866b340d86b55bbc616991afc99 Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2019-07-09Merge "Sonar fix in CreateInventoryTask.java"Marcus Williams1-4/+8
2019-07-09Merge "Sonar fixes in ManualTasks"Lukasz Muszkieta1-10/+3
2019-07-09Merge "Sonar fixes in OrchestrationRequests"Lukasz Muszkieta1-8/+4
2019-07-09Major Sonar fixesr.bogacki4-18/+21
Major Sonar fixes in different classes: -Removed unnecessary code. -Removed unused variables. -Removed unnecessary imports. -Simplified diamond operators. Issue-ID: SO-2102 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I098e3dcd93b804e58220bb41ea15325e820e3a59
2019-07-09Sonar fixes in OrchestrationRequestsr.bogacki1-8/+4
Sonar fixes in OrchestrationRequests according to the Sonar analysis. -Removed unnecessary code. -Removed unused variables. Issue-ID: SO-2101 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I564f35519c5063028e1cf540eb81ab81cf923fd5
2019-07-09Sonar fixes in ManualTasksr.bogacki1-10/+3
Code fixes in ManualTasks according to the Sonar analysis. -Removed unnecessary code. -Removed unused imports. -Removed unused variables. Issue-ID: SO-2100 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I79848456cc88b7f2cb812f7054bb6cec12b584c0
2019-07-09Major Sonar fixes in E2EServiceInstancesr.bogacki1-27/+10
Major code fixes in E2EServiceInstances according to the Sonar analysis. -Removed unnecessary code. -Removed unnecessary method parameters. -Removed unused variables. Issue-ID: SO-2099 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I0e217174455a6748c663b3d5cc92fdc22b67ce2d
2019-07-09Sonar fix in CreateInventoryTask.javaArundathi Patil1-4/+8
Fixed multiple sonar issues in this file Issue-ID: SO-2098 Change-Id: I7da9ffae8ee11d8475445b5263bc7cfb78834a9c Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2019-07-08Merge "remove unneeded code"Steve Smokowski1-12/+10
2019-07-08Merge "Added null check to prevent call of getVnfResources() method for null ↵Steve Smokowski1-2/+4
vf object"
2019-07-08Merge "Added null check for heatStack to prevent crash at getCanonicalName() ↵Steve Smokowski1-1/+1
call"
2019-07-08Merge "add junit coverage for VnfmHelper"Steve Smokowski2-1/+109
2019-07-08Merge "Fixed sonar issue in QueryGroups.java"Seshu Kumar M1-1/+2
2019-07-05Fixed sonar issue in QueryGroups.javaArundathi Patil1-1/+2
Fixed sonar issues across this file Issue-ID: SO-2096 Change-Id: Ib2b9fb5d12da2eb1f99562466c5a5d9039b0e50f Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2019-07-05mso will support new requeststate valuesGamboa, Gilbert6-103/+214
Support new request status - ROLLED_BACK, ROLLED_BACK_TO_ASSIGNED, ROLLED_BACK_TO_CREATED, and ABORTED. Support new request status - ROLLED_BACK, ROLLED_BACK_TO_ASSIGNED, ROLLED_BACK_TO_CREATED, and ABORTED. Added default FAILED request status in case rollback is not needed. Variable rollbackTargetState needs to be returned to WorkflowAction flow Variable rollbackTargetState needs to in to ExecuteBuildingBlock as well. Add new RequestDb migration file to expand infra_active_requests column request_status to 25 bytes to fit new request states. Change-Id: I0da2f8013001a28dcc20f64eb9455e4cfd3dd197 Issue-ID: SO-2093 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-07-05update bpmn to save extsystemerrorsourcePlummer, Brittany21-115/+657
Added ext error source to workflow exception Updated all lines that create this exception with source Added unit tests and updated existing ones Change-Id: Id9b3b1e6e24368224214a6370ea2d450ae667bfb Issue-ID: SO-2092 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-07-05add junit coverage for VnfmHelperLukasz Muszkieta2-1/+109
Change-Id: I0db84333f1c5ffa09ec78f504a101b75343157a3 Issue-ID: SO-1576 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>