summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-07-15Added null check for yaml to prevent crash atOleksandr Moliavko1-3/+6
getParameterListFromEnvt() Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I8fabba8d99e311f01a5fd5dad166e0bb643044e3
2019-07-12Commented out updatedAttribute declaration to preventOleksandr Moliavko1-1/+1
static analyzer warning about unused variable Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I0d46bcc817d08a6fbad3501c56336dc532bb5907
2019-07-12Added null check for function param pFqdns toOleksandr Moliavko1-8/+16
prevent crash at for loop. Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I5e72e1c6d74c5f197479062348090ab2b87fafae
2019-07-12Added check for null ptr before dereferencing atOleksandr Moliavko1-1/+1
gBBInput.getCustomer().getServiceSubscription() - to prevent static analyzer warning Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I5e1cb6248412ae9e3036011bd96d708f36170d70
2019-07-12Commented out initialization of workflowResponse to preventOleksandr Moliavko1-1/+2
static analyzer warning about workflowResponse never being set to anything but null. Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: Ib150e3836fda9b7d9785a574f904b2c61bfa39f4
2019-07-11Merge "Sonar Fix: SDNCAdapterApplication.java"Steve Smokowski1-2/+2
2019-07-10Merge "Major Sonar fixes in E2EServiceInstances"Lukasz Muszkieta1-27/+10
2019-07-10Sonar Fix: SDNCAdapterApplication.javaArundathi Patil1-2/+2
Removed unused imports from the file Issue-ID: SO-2103 Change-Id: Id126f5203789d866b340d86b55bbc616991afc99 Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2019-07-09Merge "Sonar fix in CreateInventoryTask.java"Marcus Williams1-4/+8
2019-07-09Merge "Sonar fixes in ManualTasks"Lukasz Muszkieta1-10/+3
2019-07-09Merge "Sonar fixes in OrchestrationRequests"Lukasz Muszkieta1-8/+4
2019-07-09Major Sonar fixesr.bogacki4-18/+21
Major Sonar fixes in different classes: -Removed unnecessary code. -Removed unused variables. -Removed unnecessary imports. -Simplified diamond operators. Issue-ID: SO-2102 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I098e3dcd93b804e58220bb41ea15325e820e3a59
2019-07-09Sonar fixes in OrchestrationRequestsr.bogacki1-8/+4
Sonar fixes in OrchestrationRequests according to the Sonar analysis. -Removed unnecessary code. -Removed unused variables. Issue-ID: SO-2101 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I564f35519c5063028e1cf540eb81ab81cf923fd5
2019-07-09Sonar fixes in ManualTasksr.bogacki1-10/+3
Code fixes in ManualTasks according to the Sonar analysis. -Removed unnecessary code. -Removed unused imports. -Removed unused variables. Issue-ID: SO-2100 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I79848456cc88b7f2cb812f7054bb6cec12b584c0
2019-07-09Major Sonar fixes in E2EServiceInstancesr.bogacki1-27/+10
Major code fixes in E2EServiceInstances according to the Sonar analysis. -Removed unnecessary code. -Removed unnecessary method parameters. -Removed unused variables. Issue-ID: SO-2099 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I0e217174455a6748c663b3d5cc92fdc22b67ce2d
2019-07-09Sonar fix in CreateInventoryTask.javaArundathi Patil1-4/+8
Fixed multiple sonar issues in this file Issue-ID: SO-2098 Change-Id: I7da9ffae8ee11d8475445b5263bc7cfb78834a9c Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2019-07-08Merge "remove unneeded code"Steve Smokowski1-12/+10
2019-07-08Merge "Added null check to prevent call of getVnfResources() method for null ↵Steve Smokowski1-2/+4
vf object"
2019-07-08Merge "Added null check for heatStack to prevent crash at getCanonicalName() ↵Steve Smokowski1-1/+1
call"
2019-07-08Merge "add junit coverage for VnfmHelper"Steve Smokowski2-1/+109
2019-07-08Merge "Fixed sonar issue in QueryGroups.java"Seshu Kumar M1-1/+2
2019-07-05Fixed sonar issue in QueryGroups.javaArundathi Patil1-1/+2
Fixed sonar issues across this file Issue-ID: SO-2096 Change-Id: Ib2b9fb5d12da2eb1f99562466c5a5d9039b0e50f Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2019-07-05mso will support new requeststate valuesGamboa, Gilbert6-103/+214
Support new request status - ROLLED_BACK, ROLLED_BACK_TO_ASSIGNED, ROLLED_BACK_TO_CREATED, and ABORTED. Support new request status - ROLLED_BACK, ROLLED_BACK_TO_ASSIGNED, ROLLED_BACK_TO_CREATED, and ABORTED. Added default FAILED request status in case rollback is not needed. Variable rollbackTargetState needs to be returned to WorkflowAction flow Variable rollbackTargetState needs to in to ExecuteBuildingBlock as well. Add new RequestDb migration file to expand infra_active_requests column request_status to 25 bytes to fit new request states. Change-Id: I0da2f8013001a28dcc20f64eb9455e4cfd3dd197 Issue-ID: SO-2093 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-07-05update bpmn to save extsystemerrorsourcePlummer, Brittany21-115/+657
Added ext error source to workflow exception Updated all lines that create this exception with source Added unit tests and updated existing ones Change-Id: Id9b3b1e6e24368224214a6370ea2d450ae667bfb Issue-ID: SO-2092 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-07-05add junit coverage for VnfmHelperLukasz Muszkieta2-1/+109
Change-Id: I0db84333f1c5ffa09ec78f504a101b75343157a3 Issue-ID: SO-1576 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-07-04fix global-jjb migration issuesarada prasad sahoo1-3/+3
fix global-jjb migration issue - VNFSDK, SO Issue-ID: SO-1992 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com> Change-Id: I2e11f0c151c54151e526efdebf92f49621dc0f7f
2019-07-04remove unneeded codeLukasz Muszkieta1-12/+10
Change-Id: Ib7c692b2a7fd8bc5f40d6a4acba504948cc7fc1b Issue-ID: SO-729 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-07-04fix global-jjb migration issuesarada prasad sahoo1-1/+1
fix global-jjb migration issue - VNFSDK, SO Issue-ID: SO-1992 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com> Change-Id: Idaee5994614a9264e0b0edc57be6e529a343b807
2019-07-02Added null check to prevent call of getVnfResources() methodOleksandr Moliavko1-2/+4
for null vf object Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I0c2ea5de5ed9ab55ad78f58f3a68241e7cb2d064
2019-07-02Added null check for heatStack to prevent crash atOleksandr Moliavko1-1/+1
getCanonicalName() call Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: Icf49b7db336002ad56769b221ec61101fac04fd5
2019-07-01Merge "do not overwrite status message with rollback"Steve Smokowski2-1/+40
2019-07-01do not overwrite status message with rollbackMnushkin, Dmitry2-1/+40
update rollback error for rollback and not original msg run code formatting on updated files add unit test for false value of isRollback flag Change-Id: I25d8fb9771766461b1192e3758237dfc199787f8 Issue-ID: SO-2081 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-07-01support new query param formatChan, Mercy30-105/+248
- added format query parameter (optional), implemented logic to populate requestStatus field based on whether or not format is present moved request status constants to its own class visible globally. - changed @requestParam to @QueryParam in GET endpoint (OrchestrationRequests class. updated unit tests to call method being tested directly rather than from another private function - moved setting requestStatus to a separate method, also updated unit tests to separate out each scenarion into its own method - added unit test for when format=detail, corrected existing unit tests to test result to be FAILED - updated Status.java to include extra request status values; moved Status class to common org.onap.so.constants package Change-Id: Ic593de5fdfdcbc3121f481c86d1e261406082260 Issue-ID: SO-2080 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-07-01Added check for null response to prevent crash atOleksandr Moliavko1-0/+5
response.getEntity() method call. Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: Id796f4426f33cf419bbe5ed07500452ac0c7c775
2019-06-27enhance workflowaction to handle resume funcMnushkin, Dmitry6-125/+362
init code for RESUME with junit passing overwrite URI on resume op from original request Change-Id: I1eee2bd66aa20804ba4a2834d269b5947565b9dc Issue-ID: SO-2055 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-27Merge "improved logging when no exception data is found"Steve Smokowski1-1/+5
2019-06-27Merge "Update failsafe dependency to 2.0.1"Steve Smokowski6-34/+48
2019-06-27Merge "handle multiple cvnfc configs"Steve Smokowski6-22/+36
2019-06-27Merge "add rollback ext system error source"Steve Smokowski9-17/+45
2019-06-27improved logging when no exception data is foundBenjamin, Max1-1/+5
improved logging when no exception data is found Change-Id: I4f6298652ad474119cd1ebc58a927d532ea3e6be Issue-ID: SO-2068 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-27Update failsafe dependency to 2.0.1Benjamin, Max6-34/+48
Updated calls to failsafe 2.0.1 API Change-Id: I2c86ca02d56a07262e330ee5f8f088d1a1f5b4a7 Issue-ID: SO-2057 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-27handle multiple cvnfc configsMerkel, Jeff6-22/+36
- Handle multiple cvnfc configs with the same model uuid. - Update CvnfcConfigurationCustomization to a List from a Set Change-Id: I8c026510d813ebb6294a9cedd39d4d4b8f4b9dcf Issue-ID: SO-2056 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-27add rollback ext system error sourcePlummer, Brittany9-17/+45
Added rollbackExtSystemErrorSource column and updated GET orchestrationRequests response Added missing columns from requestDb to schema.sql Change-Id: I2380f08b9bb1c86922e8faea70454df722c0873a Issue-ID: SO-2054 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-27Fix macro delete instance bug.Gamboa, Gilbert4-23/+27
Fix macro delete instance bug. vf-modules not being sorted correctly because isbaseboolean field is not being set. Change-Id: Id196e152977d922bee6c9bb797ad240bb70fbf47 Issue-ID: SO-2053 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-27Changed dependency back to 1.3.0Benjamin, Max (mb388a)1-1/+1
sdc-distribution-client changed back to 1.3.0 Change-Id: I53fd206c16bdb9c22976b6b671784841923b5295 Issue-ID: SO-2078 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-26Merge "Merge remote-tracking branch 'origin/dublin' into 'origin/master'"Steve Smokowski16-345/+334
2019-06-26Merge "Security updates for maven dependencies"Steve Smokowski5-4/+8
2019-06-26Merge "Updated path to match AID for resume requests"Steve Smokowski1-1/+1
2019-06-26Merge "Moved code inside IF checking for null ptr to prevent crash"Steve Smokowski1-3/+3
2019-06-26Merge "Sonar fixes in MsoVnfAdapterAsyncImpl"Steve Smokowski1-5/+3