summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-02-22fix potential nullpointer from sonark.kazak2-21/+144
MsoMulticloudUtils: multicloudClient may be null throw MsoException if it is null (instead of NullPointer) removed unnecessary StackInfo object creation using format specifiers for a logger instead of String concatenation removed else block to make the code easier to read Added tests for the method Change-Id: I80d2e0ba2ef2d20c488cdfcf103d9cfa5784ab65 Issue-ID: SO-1516 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-02-20Merge "Cleaned up Sonar issues in AuditStackServiceData"Steve Smokowski1-2/+3
2019-02-20Cleaned up Sonar issues in AuditStackServiceDatar.bogacki1-2/+3
Removed unnecessary imports. Removed unnecessary cast to "String". Change-Id: I8b14b0f53860edb656b38914941c44003a625037 Issue-ID: SO-1537 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-02-20Merge "Create Pre Building Block validator"Steve Smokowski4-2/+155
2019-02-20Merge "flowvaldiator will allow more flexible filtering"Steve Smokowski8-15/+15
2019-02-20Merge "Update to set correct cvnfc code"Steve Smokowski2-12/+39
2019-02-19Create Pre Building Block validatorBenjamin, Max (mb388a)4-2/+155
Use Flowvalidator shouldRunFor method to check if flow needs to be validated. Create Pre Building Block validator to check if cloud-region orchestration-disabled is true Change-Id: I2f1dca16c97505292d9b99f7e206713e4963261f Issue-ID: SO-1534 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-19flowvaldiator will allow more flexible filteringBenjamin, Max (mb388a)8-15/+15
fixed unit tests that reference forItems() forItems is now shouldRunFor allowing more flexibility Change-Id: I497f3a2899ae4df555e781c7c85a238e657fcba8 Issue-ID: SO-1533 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-19Update to set correct cvnfc codeBenjamin, Max (mb388a)2-12/+39
- Update testcase naming code to oamfw for testCvnfc. - Update to set correct cvnfc nfc_function and nfc_naming_code Change-Id: I13eca10d4d76a24753eca99e3f6ff96d0cc408f4 Issue-ID: SO-1532 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-19Added the conversion of decrypted valueBenjamin, Max (mb388a)2-3/+16
Added jUnit test for the conversion of decrypted value to Basic Base64Binary. Added the conversion of decrypted value as Basic Base64Binary. Change-Id: I361cbe3dac61df2728c9f58c314a21b3cc764a9f Issue-ID: SO-1531 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-19Merge "Validate inputs for pnf association"Lukasz Muszkieta4-33/+74
2019-02-19Merge "fix sonar potential nullpointer"Steve Smokowski2-17/+135
2019-02-19fix sonar potential nullpointerk.kazak2-17/+135
AppcRunTasks: fix potential null pointer if vnf = null AppcRunTasksTest: add tests for this case and the method itself Change-Id: I63b37670541ef5ff31b03b0336d990677b753fc5 Issue-ID: SO-1516 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-02-18set version when using constructorBenjamin, Max (mb388a)1-0/+1
set version when using constructor Change-Id: Iaa7c74c8189eb4c607f25fe3f1660c08e80b2586 Issue-ID: SO-1529 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-18Merge "fix sonar critical bug"Steve Smokowski4-23/+83
2019-02-18Merge "fix critical sonar bugs"Steve Smokowski4-4/+24
2019-02-18Validate inputs for pnf associationJoanna Jeremicz4-33/+74
Issue-ID: SO-1274 Change-Id: I3fdb66ef4bd259bef46c6f092d7d142b6cb5d9dc Signed-off-by: Joanna Jeremicz <joanna.jeremicz@nokia.com>
2019-02-15Use APIH credentials in 'mso.db.auth'Benjamin, Max (mb388a)1-3/+12
Updated to use methods: env.getRequiredProperty() and msoLogger.error(). Added the msoKey and the CryptoUtils.decrypt() code, and used "mso.camundaAuth". Used APIH credentials in 'mso.db.auth' as source instead of 'mso.camundaAuth' (need decrypt code by CryptoUtils). Change-Id: I66c9d96db8137c1d9a5b56aa33d14587cbaa7b9e Issue-ID: SO-1517 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-15fix sonar critical bugk.kazak4-23/+83
MsoHeatUtils: remove unnecessary heatClient check for null 1. sonar assumes that heatClient is nullable and NullPointer may be thrown in line 309 2. heatClient is never null: method creates a new object or throws Exception MsoHeatUtilsTest: added tests for getHeatClient and createStack methods BaseTest: made CloudIdentity and CloudSite getters protected for other tests to use them StubOpenStack: added stubs for getStack and unsuccessful authorization removed unused imports Change-Id: Ie62c89f55d1894df48d9cc4d14760d36e96c4cb2 Issue-ID: SO-1516 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-02-15Merge "query clients now set their expected object"Steve Smokowski3-4/+6
2019-02-15Merge "fix issue where we attempt audit with no servers"Steve Smokowski5-5/+53
2019-02-15Merge "updated camunda springboot version"Steve Smokowski7-58/+104
2019-02-15Merge "Process query of Network Policies from A&AI"Steve Smokowski7-16/+81
2019-02-15Merge "extract subinterface_network_quantity from policy"Steve Smokowski1-10/+39
2019-02-14query clients now set their expected objectBenjamin, Max (mb388a)3-4/+6
unit test is using the wrong number of keys for aai uri query clients now set their expected object for method Change-Id: I622c76cee0e9d47be35a78156267bf1c22cbf404 Issue-ID: SO-1514 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-14fix issue where we attempt audit with no serversBenjamin, Max (mb388a)5-5/+53
fix issue where we attempt audit with no servers Change-Id: I47f76121c616bf65a5f8be73910adcc0d7088bdb Issue-ID: SO-1513 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-14updated camunda springboot versionBenjamin, Max (mb388a)7-58/+104
Added required unimplemented methods to classes Change-Id: I1ab6333582f2f09c6c363786c8168fdf54936bf8 Issue-ID: SO-1512 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-14Process query of Network Policies from A&AIBenjamin, Max (mb388a)7-16/+81
Process query of Network Policies from A&AI as a NetworkPolicies object. Change-Id: I01b4c00e3732a5518ddc21d08740c0684de86d5e Issue-ID: SO-1511 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-14extract subinterface_network_quantity from policyBenjamin, Max (mb388a)1-10/+39
- Removed duplicate code that was causing a NumberFormatException - Changed name from crTarget to policyNetworkCollection - Added code to check we are setting the quantity on the correct NetworkCollection - Added code to extract the subinterface_network_quantity from the nodeTemplate policy Change-Id: Id12fa0241f16bfd4467209f08af5068d57b2d049 Issue-ID: SO-1510 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-14always increment gCurrentSequenceBenjamin, Max (mb388a)2-1/+5
always increment gCurrentSequence to properly interact with retry and rollback logic Change-Id: I7e99973682f93f891c8d35a4f3699ba17a05bc15 Issue-ID: SO-1509 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-14Merge "fix fields not set correctly in Fabric Policy dist"Marcus Williams2-45/+56
2019-02-14Merge "cloud config migration from openstack to catdb"Steve Smokowski8-196/+39
2019-02-14Merge "fix major sonar bug"Steve Smokowski2-10/+46
2019-02-14Merge "fixed CandidateType json serialization"Steve Smokowski6-65/+11
2019-02-14Merge "add new functionality to aai client"Steve Smokowski32-901/+771
2019-02-14Merge "workflow action should read config for max retries"Steve Smokowski2-2/+38
2019-02-14Merge "Update Working with SO Docker Documentation"Steve Smokowski1-95/+161
2019-02-14Merge "Remove un-needed cacheing layer for OS Clients"Steve Smokowski3-147/+2
2019-02-14Merge "Strip off TenantId from self link url"Steve Smokowski2-22/+33
2019-02-14fix critical sonar bugsk.kazak4-4/+24
Restore interrupted state when InterruptedException is thrown in SDNCRestClient Added test for this case Replaced formatting anchor with text empty object in GraphInventoryResultWrapper Escaped anchor is also considered as bug by sonar Case is already covered in AAIResultWrapperTest Marked comparison of the same object as false positive in EqualsAndHashCodeTester Added clearer comment to this comparison Change-Id: I24496c2323c33599db99a3d3b59fc4f6a008cf1f Issue-ID: SO-1492 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-02-13Strip off TenantId from self link urlBenjamin, Max (mb388a)2-22/+33
Strip off TenantId from self link url Change-Id: I58ac9fe693059eb8cb93d85fb88604cb9c0a0db2 Issue-ID: SO-1502 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-13fixed CandidateType json serializationBenjamin, Max (mb388a)6-65/+11
fixed CandidateType json serialization Change-Id: Icafa5884db5424167c7fac08ad6aae5781bdafa5 Issue-ID: SO-1503 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-13Merge "Associate PNF instance with Service"Lukasz Muszkieta9-65/+246
2019-02-13workflow action should read config for max retriesBenjamin, Max (mb388a)2-2/+38
workflow action should also read config for max retries Change-Id: Ib0617b59ca95df7c82fb2ab54895c9c83586f02f Issue-ID: SO-1504 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-13add new functionality to aai clientBenjamin, Max (mb388a)32-901/+771
Remove only the first occurrence of parentUri from uriTemplate. add createIfNotExists to transaction clients moved classes to generic GraphInventory location removed unused interfaces from graphinventory client refactored all graph inventory clients Change-Id: I2b946674ff92c44d33fff2f327e96655ed5c0195 Issue-ID: SO-1501 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-13Remove un-needed cacheing layer for OS ClientsBenjamin, Max (mb388a)3-147/+2
Remove un-needed cacheing layer for OS Clients Change-Id: I7fbb6e23a3c34f65286202ec4dad1fb051991cf0 Issue-ID: SO-1500 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-13fix fields not set correctly in Fabric Policy distBenjamin, Max (mb388a)2-45/+56
- Added a null check for vfModuleMemberName. - Added some extra logging to show the VF members and cvnfc template name - Updated to fix fields not set correctly in Fabric Policy distributions. Change-Id: Iaef2114a910ad10ff788b2178953883b0c5269da Issue-ID: SO-1499 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-13Update Working with SO Docker Documentationmohamed waly1-95/+161
patch description: Update Working with SO Docker documentation for casablanca release. Change-Id: If7a4601e83e0ca83f99a9f74e1f282abc3854bdd Issue-ID: SO-1505 Signed-off-by: mohamed waly <mohamed.waly@orange.com>
2019-02-13Merge "Fixed possible NPE in ResourceRequestBuilder"Steve Smokowski2-2/+32
2019-02-13Merge "use encrypted auth for dmaap"Steve Smokowski17-83/+117