diff options
Diffstat (limited to 'mso-api-handlers/mso-api-handler-common')
6 files changed, 13 insertions, 16 deletions
diff --git a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/camundabeans/BpmnRequest.java b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/camundabeans/BpmnRequest.java index f63e12910c..27a310fd2d 100644 --- a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/camundabeans/BpmnRequest.java +++ b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/camundabeans/BpmnRequest.java @@ -40,11 +40,7 @@ import org.openecomp.mso.apihandler.common.CommonConstants; CommonConstants.REQUEST_DETAILS_VARIABLE}) @JsonRootName(CommonConstants.CAMUNDA_ROOT_INPUT) public class BpmnRequest { - - public BpmnRequest() { - - } - + @JsonProperty(CommonConstants.CAMUNDA_HOST) private CamundaInput host; @@ -89,8 +85,11 @@ public class BpmnRequest { @JsonProperty(CommonConstants.REQUEST_DETAILS_VARIABLE) private CamundaInput requestDetails; - - + + public BpmnRequest() { + /* Empty constructor */ + + } @JsonProperty(CommonConstants.CAMUNDA_HOST) public CamundaInput getHost() { @@ -246,9 +245,7 @@ public class BpmnRequest { @Override public String toString() { - //return "CamundaRequest [requestId=" + + ", host=" - // + host + ", schema=" + schema + ", reqid=" + reqid + ", svcid=" - // + svcid + ", timeout=" + timeout + "]"; + return "BpmnRequest"; } diff --git a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/camundabeans/CamundaBpmnRequestInput.java b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/camundabeans/CamundaBpmnRequestInput.java index 7c882bea1b..f73829688c 100644 --- a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/camundabeans/CamundaBpmnRequestInput.java +++ b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/camundabeans/CamundaBpmnRequestInput.java @@ -21,7 +21,6 @@ package org.openecomp.mso.apihandler.camundabeans; import org.codehaus.jackson.annotate.JsonProperty; -import org.codehaus.jackson.map.annotate.JsonRootName; import org.openecomp.mso.apihandler.common.CommonConstants; @@ -38,6 +37,7 @@ public class CamundaBpmnRequestInput { public CamundaBpmnRequestInput() { + /* Empty constructor */ } @JsonProperty(CommonConstants.CAMUNDA_VALUE) diff --git a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/camundabeans/CamundaInput.java b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/camundabeans/CamundaInput.java index 8a90db675c..0c69a76b14 100644 --- a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/camundabeans/CamundaInput.java +++ b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/camundabeans/CamundaInput.java @@ -22,7 +22,6 @@ package org.openecomp.mso.apihandler.camundabeans; import org.codehaus.jackson.annotate.JsonProperty; -import org.codehaus.jackson.map.annotate.JsonRootName; import org.openecomp.mso.apihandler.common.CommonConstants; @@ -42,6 +41,7 @@ public class CamundaInput { public CamundaInput() { + /* Empty constructor */ } @JsonProperty(CommonConstants.CAMUNDA_VALUE) diff --git a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/BPELRestClient.java b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/BPELRestClient.java index a73eec578d..cd23991875 100644 --- a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/BPELRestClient.java +++ b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/BPELRestClient.java @@ -60,7 +60,7 @@ public class BPELRestClient extends RequestClient { CommonConstants.ENCRYPTION_KEY); if (userCredentials != null) { post.addHeader ("Authorization", - "Basic " + new String (DatatypeConverter.printBase64Binary (userCredentials.getBytes ()))); + "Basic " + DatatypeConverter.printBase64Binary (userCredentials.getBytes ())); } } } diff --git a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/RequestClientFactory.java b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/RequestClientFactory.java index a1f3805c7f..773c5b0a96 100644 --- a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/RequestClientFactory.java +++ b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/RequestClientFactory.java @@ -35,7 +35,7 @@ public class RequestClientFactory { if(props ==null){ throw new IllegalStateException("properties is null"); } - String url = null; + String url; if(orchestrationURI.contains(CommonConstants.BPEL_SEARCH_STR)){ url = props.getProperty(CommonConstants.BPEL_URL,null) + orchestrationURI; retClient= new BPELRestClient(); diff --git a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/XMLValidator.java b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/XMLValidator.java index 353246f576..b498259eed 100644 --- a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/XMLValidator.java +++ b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/XMLValidator.java @@ -65,7 +65,7 @@ public class XMLValidator { stringXsd = IOUtils.toString (xsdStream); factory = SchemaFactory.newInstance (XMLConstants.W3C_XML_SCHEMA_NS_URI); - factory.setResourceResolver ((new PathResourceResolver (XSDS_PATH))); + factory.setResourceResolver (new PathResourceResolver (XSDS_PATH)); factory.setFeature (XMLConstants.FEATURE_SECURE_PROCESSING, true); String quotedXsd = stringXsd.replaceAll (""", "\""); @@ -90,7 +90,7 @@ public class XMLValidator { } catch (IOException | SAXException e) { msoLogger.debug ("Exception: ", e); - return ("ErrorDetails: " + e.getMessage ()); + return "ErrorDetails: " + e.getMessage (); } catch (Exception e) { msoLogger.error (MessageEnum.APIH_CANNOT_READ_SCHEMA, "", "", MsoLogger.ErrorCode.SchemaError, "APIH cannot read schema file", e); |