14 files changed, 247 insertions, 216 deletions

diff --git a/adapters/mso-adapter-utils/src/main/java/org/openecomp/mso/openstack/beans/StackInfo.java b/adapters/mso-adapter-utils/src/main/java/org/openecomp/mso/openstack/beans/StackInfo.java
index 83e1484257..600985e310 100644
--- a/adapters/mso-adapter-utils/src/main/java/org/openecomp/mso/openstack/beans/StackInfo.java
+++ b/adapters/mso-adapter-utils/src/main/java/org/openecomp/mso/openstack/beans/StackInfo.java
@@ -7,9 +7,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -20,136 +20,89 @@
 
 package org.openecomp.mso.openstack.beans;
 
-
-import java.util.Map;
-import java.util.HashMap;
-
 import com.woorea.openstack.heat.model.Stack;
+import java.util.HashMap;
+import java.util.Map;
 
 /*
  * This Java bean class relays Heat stack status information to ActiveVOS processes.
- * 
+ *
  * This bean is returned by all Heat-specific adapter operations (create, query, delete)
  */
-
 public class StackInfo {
-	// Set defaults for everything
 	private String name = "";
 	private String canonicalName = "";
-	private HeatStatus status = HeatStatus.UNKNOWN;
-	private String statusMessage = "";
-	private Map<String,Object> outputs = new HashMap<String,Object>();
-	private Map<String,Object> parameters = new HashMap<String,Object>();
-	
-	static Map<String,HeatStatus> HeatStatusMap;
-	static {
-		HeatStatusMap = new HashMap<String,HeatStatus>();
-		HeatStatusMap.put("CREATE_IN_PROGRESS", HeatStatus.BUILDING);
-		HeatStatusMap.put("CREATE_COMPLETE", HeatStatus.CREATED);
-		HeatStatusMap.put("CREATE_FAILED", HeatStatus.FAILED);
-		HeatStatusMap.put("DELETE_IN_PROGRESS", HeatStatus.DELETING);
-		HeatStatusMap.put("DELETE_COMPLETE", HeatStatus.NOTFOUND);
-		HeatStatusMap.put("DELETE_FAILED", HeatStatus.FAILED);
-		HeatStatusMap.put("UPDATE_IN_PROGRESS", HeatStatus.UPDATING);
-		HeatStatusMap.put("UPDATE_FAILED", HeatStatus.FAILED);
-		HeatStatusMap.put("UPDATE_COMPLETE", HeatStatus.UPDATED);
-	}
+	private HeatStatus status;
+	private Map<String, Object> outputs = new HashMap<>();
+	private Map<String,Object> parameters = new HashMap<>();
+	static private Map<String, HeatStatus> heatStatusMap;
 
-	public StackInfo () {
+	static {
+		heatStatusMap = new HashMap<>();
+		heatStatusMap.put("CREATE_IN_PROGRESS", HeatStatus.BUILDING);
+		heatStatusMap.put("CREATE_COMPLETE", HeatStatus.CREATED);
+		heatStatusMap.put("CREATE_FAILED", HeatStatus.FAILED);
+		heatStatusMap.put("DELETE_IN_PROGRESS", HeatStatus.DELETING);
+		heatStatusMap.put("DELETE_COMPLETE", HeatStatus.NOTFOUND);
+		heatStatusMap.put("DELETE_FAILED", HeatStatus.FAILED);
+		heatStatusMap.put("UPDATE_IN_PROGRESS", HeatStatus.UPDATING);
+		heatStatusMap.put("UPDATE_FAILED", HeatStatus.FAILED);
+		heatStatusMap.put("UPDATE_COMPLETE", HeatStatus.UPDATED);
 	}
-	
-	public StackInfo (String name, HeatStatus status, String statusMessage, Map<String,Object> outputs) {
-		this.name = name;
-		this.canonicalName = name;	// Don't have an ID, so just use name
 
-		this.status = status;
-		if (statusMessage != null)  this.statusMessage = statusMessage;
-		if (outputs != null)  this.outputs = outputs;
-	}
-	
 	public StackInfo (String name, HeatStatus status) {
 		this.name = name;
 		this.canonicalName = name;	// Don't have an ID, so just use name
 		this.status = status;
 	}
-	
+
 	public StackInfo (Stack stack)
 	{
 		if (stack == null) {
 			this.status = HeatStatus.NOTFOUND;
 			return;
 		}
-	
 		this.name = stack.getStackName();
 		this.canonicalName = stack.getStackName() + "/" + stack.getId();
 
 		if (stack.getStackStatus() == null) {
 			this.status = HeatStatus.INIT;
-		} else if (HeatStatusMap.containsKey(stack.getStackStatus())) {
-			this.status = HeatStatusMap.get(stack.getStackStatus());
+		} else if (heatStatusMap.containsKey(stack.getStackStatus())) {
+			this.status = heatStatusMap.get(stack.getStackStatus());
 		} else {
 			this.status = HeatStatus.UNKNOWN;
 		}
-		
-		this.statusMessage = stack.getStackStatusReason();
-		
 		if (stack.getOutputs() != null) {
-			this.outputs = new HashMap<String,Object>();
-			for (Stack.Output output : stack.getOutputs()) {
-				this.outputs.put(output.getOutputKey(), output.getOutputValue());
-			}
+			this.outputs = new HashMap<>();
+			stack.getOutputs().forEach(output -> outputs.put(output.getOutputKey(), output.getOutputValue()));
 		}
-		
+
 		this.parameters = stack.getParameters();
 	}
-	
+
 	public String getName() {
 		return name;
 	}
-	
+
 	public void setName (String name) {
 		this.name = name;
 	}
-	
+
 	public String getCanonicalName() {
 		return canonicalName;
 	}
-	
-	public void setCanonicalName (String name) {
-		this.canonicalName = name;
-	}
-	
+
 	public HeatStatus getStatus() {
 		return status;
 	}
-	
-	public void setStatus (HeatStatus status) {
-		this.status = status;
-	}
-	
-	public String getStatusMessage() {
-		return statusMessage;
-	}
-	
-	public void setStatusMessage (String statusMessage) {
-		this.statusMessage = statusMessage;
-	}
-	
-	public Map<String,Object> getOutputs () {
+
+	public Map<String, Object> getOutputs() {
 		return outputs;
 	}
-	
-	public void setOutputs (Map<String,Object> outputs) {
-		this.outputs = outputs;
-	}
-	
+
 	public Map<String,Object> getParameters () {
 		return parameters;
 	}
-	
-	public void setParameters (Map<String,Object> parameters) {
-		this.parameters = parameters;
-	}
-	
+
 }
 
diff --git a/adapters/mso-adapter-utils/src/main/java/org/openecomp/mso/openstack/utils/MsoHeatUtils.java b/adapters/mso-adapter-utils/src/main/java/org/openecomp/mso/openstack/utils/MsoHeatUtils.java
index 08ea84d85d..8f21cfb2a3 100644
--- a/adapters/mso-adapter-utils/src/main/java/org/openecomp/mso/openstack/utils/MsoHeatUtils.java
+++ b/adapters/mso-adapter-utils/src/main/java/org/openecomp/mso/openstack/utils/MsoHeatUtils.java
@@ -648,7 +648,7 @@ public class MsoHeatUtils extends MsoCommonUtils {
         } catch (MsoTenantNotFound e) {
             // Tenant doesn't exist, so stack doesn't either
             LOGGER.debug ("Tenant with id " + tenantId + "not found.", e);
-            return new StackInfo (stackName, HeatStatus.NOTFOUND, null, null);
+            return new StackInfo (stackName, HeatStatus.NOTFOUND);
         } catch (MsoException me) {
             // Got an Openstack error. Propagate it
             LOGGER.error (MessageEnum.RA_CONNECTION_EXCEPTION, "OpenStack", "Openstack Exception on Token request: " + me, "Openstack", "", MsoLogger.ErrorCode.AvailabilityError, "Connection Exception");
@@ -662,7 +662,7 @@ public class MsoHeatUtils extends MsoCommonUtils {
 
         if (heatStack == null) {
             // Stack does not exist. Return a StackInfo with status NOTFOUND
-            StackInfo stackInfo = new StackInfo (stackName, HeatStatus.NOTFOUND, null, null);
+            StackInfo stackInfo = new StackInfo (stackName, HeatStatus.NOTFOUND);
             return stackInfo;
         }
 
@@ -712,7 +712,7 @@ public class MsoHeatUtils extends MsoCommonUtils {
         } catch (MsoTenantNotFound e) {
             // Tenant doesn't exist, so stack doesn't either
             LOGGER.debug ("Tenant with id " + tenantId + "not found.", e);
-            return new StackInfo (stackName, HeatStatus.NOTFOUND, null, null);
+            return new StackInfo (stackName, HeatStatus.NOTFOUND);
         } catch (MsoException me) {
             // Got an Openstack error. Propagate it
             LOGGER.error (MessageEnum.RA_CONNECTION_EXCEPTION, "Openstack", "Openstack Exception on Token request: " + me, "Openstack", "", MsoLogger.ErrorCode.AvailabilityError, "Connection Exception");
@@ -724,7 +724,7 @@ public class MsoHeatUtils extends MsoCommonUtils {
         Stack heatStack = queryHeatStack (heatClient, stackName);
         if (heatStack == null || "DELETE_COMPLETE".equals (heatStack.getStackStatus ())) {
             // Not found. Return a StackInfo with status NOTFOUND
-            return new StackInfo (stackName, HeatStatus.NOTFOUND, null, null);
+            return new StackInfo (stackName, HeatStatus.NOTFOUND);
         }
 
         // Delete the stack.
@@ -747,7 +747,7 @@ public class MsoHeatUtils extends MsoCommonUtils {
         } catch (OpenStackResponseException e) {
             if (e.getStatus () == 404) {
                 // Not found. We are OK with this. Return a StackInfo with status NOTFOUND
-                return new StackInfo (stackName, HeatStatus.NOTFOUND, null, null);
+                return new StackInfo (stackName, HeatStatus.NOTFOUND);
             } else {
                 // Convert the OpenStackResponseException to an MsoOpenstackException
                 throw heatExceptionToMsoException (e, DELETE_STACK);
@@ -813,7 +813,7 @@ public class MsoHeatUtils extends MsoCommonUtils {
             }
 
             // The stack is gone when this point is reached
-            return new StackInfo (stackName, HeatStatus.NOTFOUND, null, null);
+            return new StackInfo (stackName, HeatStatus.NOTFOUND);
         }
 
         // Return the current status (if not polling, the delete may still be in progress)
diff --git a/adapters/mso-adapter-utils/src/test/java/org/openecomp/mso/adapter_utils/tests/AdapterBeansTest.java b/adapters/mso-adapter-utils/src/test/java/org/openecomp/mso/adapter_utils/tests/AdapterBeansTest.java
index 6bd78153b6..250211845f 100644
--- a/adapters/mso-adapter-utils/src/test/java/org/openecomp/mso/adapter_utils/tests/AdapterBeansTest.java
+++ b/adapters/mso-adapter-utils/src/test/java/org/openecomp/mso/adapter_utils/tests/AdapterBeansTest.java
@@ -22,18 +22,15 @@ package org.openecomp.mso.adapter_utils.tests;
 

 import static org.junit.Assert.assertTrue;

 

-import com.woorea.openstack.heat.model.Stack;

 import java.util.ArrayList;

 import java.util.HashMap;

 import java.util.List;

 import java.util.Map;

 import org.junit.Test;

 import org.openecomp.mso.entity.MsoRequest;

-import org.openecomp.mso.openstack.beans.HeatStatus;

 import org.openecomp.mso.openstack.beans.MsoTenant;

 import org.openecomp.mso.openstack.beans.NetworkRollback;

 import org.openecomp.mso.openstack.beans.Pool;

-import org.openecomp.mso.openstack.beans.StackInfo;

 import org.openecomp.mso.openstack.beans.Subnet;

 import org.openecomp.mso.openstack.beans.VnfRollback;

 

@@ -99,26 +96,6 @@ public class AdapterBeansTest {
 	}

 

 	@Test

-	public final void stackInfoTest() {

-		StackInfo stackInfo = new StackInfo();

-		new StackInfo(new Stack());

-		new StackInfo("name", HeatStatus.CREATED, "statusmessage", new HashMap<>());

-		new StackInfo("name", HeatStatus.CREATED);

-		stackInfo.setCanonicalName("Canonicalname");

-		stackInfo.getCanonicalName();

-		stackInfo.setName("name");

-		stackInfo.getName();

-		stackInfo.setOutputs(new HashMap<>());

-		stackInfo.getOutputs();

-		stackInfo.setParameters(new HashMap<>());

-		stackInfo.getParameters();

-		stackInfo.setStatus(HeatStatus.CREATED);

-		stackInfo.getStatus();

-		stackInfo.setStatusMessage("statusMessage");

-		stackInfo.getStatusMessage();

-	}

-

-	@Test

 	public final void subnetTest() {

 		Subnet subnet = new Subnet();

 		subnet.setAllocationPools(new ArrayList<>());

diff --git a/adapters/mso-adapter-utils/src/test/java/org/openecomp/mso/openstack/beans/StackInfoTest.java b/adapters/mso-adapter-utils/src/test/java/org/openecomp/mso/openstack/beans/StackInfoTest.java
new file mode 100644
index 0000000000..9c7911ef89
--- /dev/null
+++ b/adapters/mso-adapter-utils/src/test/java/org/openecomp/mso/openstack/beans/StackInfoTest.java
@@ -0,0 +1,98 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * ONAP - SO
+ * ================================================================================
+ * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.openecomp.mso.openstack.beans;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import com.woorea.openstack.heat.model.Stack;
+import java.io.IOException;
+import org.codehaus.jackson.JsonNode;
+import org.codehaus.jackson.map.ObjectMapper;
+import org.junit.Test;
+
+public class StackInfoTest {
+
+    private static final String STACK_NAME = "stackNameTest";
+    private static final String STACK_STATUS = "CREATE_COMPLETE";
+    private static final String STACK_OUTPUT_KEY = "outputKeyTest";
+    private static final String STACK_OUTPUT_VALUE = "outputValueTest";
+    private static final String STACK_PARAM_KEY = "paramKeyTest";
+    private static final String STACK_PARAM_VALUE = "paramValueTest";
+
+    @Test
+    public void setStatusNotFoundWhenStackIsNull() {
+        StackInfo stackInfo = new StackInfo(null);
+        assertThat(stackInfo.getStatus()).isEqualTo(HeatStatus.NOTFOUND);
+        assertThat(stackInfo.getOutputs()).isEmpty();
+        assertThat(stackInfo.getParameters()).isEmpty();
+    }
+
+    @Test
+    public void createObjectWhenStackStatusIsNull() {
+        StackInfo stackInfo = new StackInfo(createStackWithStatus(null));
+        assertThat(stackInfo.getName()).isEqualTo(STACK_NAME);
+        assertThat(stackInfo.getOutputs()).isEmpty();
+        assertThat(stackInfo.getStatus()).isEqualTo(HeatStatus.INIT);
+        assertThat(stackInfo.getParameters()).hasSize(1).containsEntry(STACK_PARAM_KEY, STACK_PARAM_VALUE);
+    }
+
+    @Test
+    public void createObjectWhenStackStatusIsFound() {
+        StackInfo stackInfo = new StackInfo(createStackWithStatus(STACK_STATUS));
+        assertThat(stackInfo.getName()).isEqualTo(STACK_NAME);
+        assertThat(stackInfo.getOutputs()).isEmpty();
+        assertThat(stackInfo.getStatus()).isEqualTo(HeatStatus.CREATED);
+        assertThat(stackInfo.getParameters()).hasSize(1).containsEntry(STACK_PARAM_KEY, STACK_PARAM_VALUE);
+    }
+
+    @Test
+    public void createObjectWhenStackStatusIsUnknown() {
+        StackInfo stackInfo = new StackInfo(createStackWithStatus("unknownStatus"));
+        assertThat(stackInfo.getName()).isEqualTo(STACK_NAME);
+        assertThat(stackInfo.getOutputs()).isEmpty();
+        assertThat(stackInfo.getStatus()).isEqualTo(HeatStatus.UNKNOWN);
+        assertThat(stackInfo.getParameters()).hasSize(1).containsEntry(STACK_PARAM_KEY, STACK_PARAM_VALUE);
+    }
+
+    @Test
+    public void createStackWhenOutputsListIsNotNull() throws IOException {
+        StackInfo stackInfo = new StackInfo(createStackWithOutputs());
+        assertThat(stackInfo.getOutputs()).isNotEmpty().hasSize(1);
+        assertThat(stackInfo.getOutputs()).hasSize(1).containsEntry(STACK_OUTPUT_KEY, STACK_OUTPUT_VALUE);
+    }
+
+    private Stack createStackWithStatus(String stackStatus) {
+        Stack stack = new Stack();
+        stack.setStackName(STACK_NAME);
+        stack.setStackStatus(stackStatus);
+        stack.getParameters().put(STACK_PARAM_KEY, STACK_PARAM_VALUE);
+        return stack;
+    }
+
+    private Stack createStackWithOutputs() throws IOException {
+        String json = "{\"outputs\":[{\"output_key\" : \"" + STACK_OUTPUT_KEY + "\", \"output_value\" : \""
+                + STACK_OUTPUT_VALUE + "\" }]}";
+        JsonNode node = new ObjectMapper().readTree(json);
+        Stack stack = new ObjectMapper().readValue(node, Stack.class);
+        return stack;
+    }
+
+}
diff --git a/adapters/mso-vnf-adapter/src/test/java/org/openecomp/mso/adapters/vnf/test/MsoVnfAdapterAsyncImplTest.java b/adapters/mso-vnf-adapter/src/test/java/org/openecomp/mso/adapters/vnf/test/MsoVnfAdapterAsyncImplTest.java
index b680170abe..a045b00699 100644
--- a/adapters/mso-vnf-adapter/src/test/java/org/openecomp/mso/adapters/vnf/test/MsoVnfAdapterAsyncImplTest.java
+++ b/adapters/mso-vnf-adapter/src/test/java/org/openecomp/mso/adapters/vnf/test/MsoVnfAdapterAsyncImplTest.java
@@ -22,18 +22,10 @@ package org.openecomp.mso.adapters.vnf.test;
 

 import java.util.HashMap;

 import java.util.Map;

-

 import org.junit.Test;

 import org.openecomp.mso.adapters.vnf.MsoVnfAdapterAsyncImpl;

 import org.openecomp.mso.entity.MsoRequest;

-import org.openecomp.mso.openstack.beans.HeatStatus;

-import org.openecomp.mso.openstack.beans.StackInfo;

 import org.openecomp.mso.openstack.beans.VnfRollback;

-import org.openecomp.mso.openstack.exceptions.MsoException;

-import org.openecomp.mso.openstack.utils.MsoHeatUtils;

-

-import mockit.Mock;

-import mockit.MockUp;

 

 public class MsoVnfAdapterAsyncImplTest {

 

@@ -45,15 +37,6 @@ public class MsoVnfAdapterAsyncImplTest {
 

 	@Test

 	public void createVNFTest() {

-		new MockUp<MsoHeatUtils>() {

-			@Mock

-			public StackInfo queryStack(String cloudSiteId, String tenantId, String stackName) throws MsoException {

-				StackInfo info = new StackInfo();

-				info.setStatus(HeatStatus.CREATED);

-				return info;

-			}

-		};

-

 		MsoVnfAdapterAsyncImpl instance = new MsoVnfAdapterAsyncImpl();

 		MsoRequest msoRequest = new MsoRequest();

 		msoRequest.setRequestId("12345");

diff --git a/adapters/mso-vnf-adapter/src/test/java/org/openecomp/mso/adapters/vnf/test/MsoVnfAdapterImplTest.java b/adapters/mso-vnf-adapter/src/test/java/org/openecomp/mso/adapters/vnf/test/MsoVnfAdapterImplTest.java
index 77879089e9..6f01954db3 100644
--- a/adapters/mso-vnf-adapter/src/test/java/org/openecomp/mso/adapters/vnf/test/MsoVnfAdapterImplTest.java
+++ b/adapters/mso-vnf-adapter/src/test/java/org/openecomp/mso/adapters/vnf/test/MsoVnfAdapterImplTest.java
@@ -22,24 +22,11 @@ package org.openecomp.mso.adapters.vnf.test;
 

 import java.util.HashMap;

 import java.util.Map;

-

 import javax.xml.ws.Holder;

-

 import org.junit.Test;

 import org.openecomp.mso.adapters.vnf.MsoVnfAdapterImpl;

-import org.openecomp.mso.db.catalog.CatalogDatabase;

-import org.openecomp.mso.db.catalog.beans.VfModule;

-import org.openecomp.mso.db.catalog.beans.VfModuleCustomization;

-import org.openecomp.mso.db.catalog.beans.VnfResource;

 import org.openecomp.mso.entity.MsoRequest;

-import org.openecomp.mso.openstack.beans.HeatStatus;

-import org.openecomp.mso.openstack.beans.StackInfo;

 import org.openecomp.mso.openstack.beans.VnfRollback;

-import org.openecomp.mso.openstack.exceptions.MsoException;

-import org.openecomp.mso.openstack.utils.MsoHeatUtils;

-

-import mockit.Mock;

-import mockit.MockUp;

 

 public class MsoVnfAdapterImplTest {

 

@@ -51,16 +38,6 @@ public class MsoVnfAdapterImplTest {
 

 	@Test

 	public void createVnfTest() {

-

-		new MockUp<MsoHeatUtils>() {

-			@Mock

-			public StackInfo queryStack(String cloudSiteId, String tenantId, String stackName) throws MsoException {

-				StackInfo info = new StackInfo();

-				info.setStatus(HeatStatus.CREATED);

-				return info;

-			}

-		};

-

 		MsoVnfAdapterImpl instance = new MsoVnfAdapterImpl();

 		MsoRequest msoRequest = new MsoRequest();

 		msoRequest.setRequestId("12345");

@@ -80,37 +57,6 @@ public class MsoVnfAdapterImplTest {
 

 	@Test

 	public void updateVnfTest() {

-

-		new MockUp<MsoHeatUtils>() {

-			@Mock

-			public StackInfo queryStack(String cloudSiteId, String tenantId, String stackName) throws MsoException {

-				StackInfo info = new StackInfo();

-				info.setStatus(HeatStatus.CREATED);

-				return info;

-			}

-		};

-

-		new MockUp<CatalogDatabase>() {

-			@Mock

-			public VfModuleCustomization getVfModuleCustomizationByModelCustomizationId(String modelCustomizationUuid) {

-				VfModuleCustomization vfcModule = new VfModuleCustomization();

-				VfModule vfm = new VfModule();

-				vfm.setVnfResourceModelUUId("88a6ca3ee0394ade9403f075db23167e");

-				vfcModule.setVfModule(vfm);

-				return vfcModule;

-			}

-		};

-

-		new MockUp<CatalogDatabase>() {

-			@Mock

-			public VnfResource getVnfResourceByModelUuid(String modelUuid) {

-				VnfResource vnfResource = new VnfResource();

-				vnfResource.setAicVersionMin("1");

-				vnfResource.setAicVersionMax("2");

-				return vnfResource;

-			}

-		};

-

 		MsoVnfAdapterImpl instance = new MsoVnfAdapterImpl();

 		MsoRequest msoRequest = new MsoRequest();

 		msoRequest.setRequestId("12345");

@@ -130,17 +76,6 @@ public class MsoVnfAdapterImplTest {
 

 	@Test

 	public void deleteVnfTest() {

-		new MockUp<MsoHeatUtils>() {

-			@Mock

-			public Map<String, Object> queryStackForOutputs(String cloudSiteId, String tenantId, String stackName)

-					throws MsoException {

-				

-				Map<String, Object> outputs = new HashMap<>();

-				outputs.put("Key1", "value1");

-				return outputs;

-			}

-		};

-

 		MsoVnfAdapterImpl instance = new MsoVnfAdapterImpl();

 		MsoRequest msoRequest = new MsoRequest();

 		msoRequest.setRequestId("12345");

diff --git a/adapters/mso-vnf-adapter/src/test/java/org/openecomp/mso/adapters/vnf/test/QueryTest.java b/adapters/mso-vnf-adapter/src/test/java/org/openecomp/mso/adapters/vnf/test/QueryTest.java
index 315db2eb83..f6e79e12a0 100644
--- a/adapters/mso-vnf-adapter/src/test/java/org/openecomp/mso/adapters/vnf/test/QueryTest.java
+++ b/adapters/mso-vnf-adapter/src/test/java/org/openecomp/mso/adapters/vnf/test/QueryTest.java
@@ -21,26 +21,23 @@
 package org.openecomp.mso.adapters.vnf.test;
 
 
-import java.util.Map;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
 
+import java.util.Map;
 import javax.xml.ws.Holder;
-
 import mockit.Mock;
 import mockit.MockUp;
 import org.junit.Test;
 import org.openecomp.mso.adapters.vnf.MsoVnfAdapter;
 import org.openecomp.mso.adapters.vnf.MsoVnfAdapterImpl;
+import org.openecomp.mso.adapters.vnf.exceptions.VnfException;
 import org.openecomp.mso.openstack.beans.HeatStatus;
 import org.openecomp.mso.openstack.beans.StackInfo;
 import org.openecomp.mso.openstack.beans.VnfStatus;
-import org.openecomp.mso.adapters.vnf.exceptions.VnfException;
-import org.openecomp.mso.openstack.exceptions.MsoCloudSiteNotFound;
 import org.openecomp.mso.openstack.exceptions.MsoException;
 import org.openecomp.mso.openstack.utils.MsoHeatUtils;
 
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertTrue;
-
 public class QueryTest {
 
     @Test
@@ -49,8 +46,7 @@ public class QueryTest {
             new MockUp<MsoHeatUtils>() {
                 @Mock
                 public StackInfo queryStack(String cloudSiteId, String tenantId, String stackName) throws MsoException {
-                    StackInfo info = new StackInfo();
-                    info.setStatus(HeatStatus.CREATED);
+                    StackInfo info = new StackInfo("stackName", HeatStatus.CREATED);
                     return info;
                 }
             };
@@ -77,8 +73,7 @@ public class QueryTest {
             new MockUp<MsoHeatUtils>() {
                 @Mock
                 public StackInfo queryStack(String cloudSiteId, String tenantId, String stackName) throws MsoException {
-                    StackInfo info = new StackInfo();
-                    info.setStatus(HeatStatus.NOTFOUND);
+                    StackInfo info = new StackInfo("stackName", HeatStatus.NOTFOUND);
                     return info;
                 }
             };
@@ -102,13 +97,6 @@ public class QueryTest {
     @Test(expected = VnfException.class)
     public void testQueryVnfWithException() throws VnfException {
         {
-            new MockUp<MsoHeatUtils>() {
-                @Mock
-                public StackInfo queryStack(String cloudSiteId, String tenantId, String stackName) throws MsoException {
-                    throw new MsoCloudSiteNotFound(cloudSiteId);
-                }
-            };
-
             MsoVnfAdapter vnfAdapter = new MsoVnfAdapterImpl();
             String cloudId = "MT";
             String tenantId = "MSO_Test";
diff --git a/bpmn/MSOCommonBPMN/src/main/groovy/org/openecomp/mso/bpmn/common/scripts/GenericGetService.groovy b/bpmn/MSOCommonBPMN/src/main/groovy/org/openecomp/mso/bpmn/common/scripts/GenericGetService.groovy
index 14f9135826..cfc5171dca 100644
--- a/bpmn/MSOCommonBPMN/src/main/groovy/org/openecomp/mso/bpmn/common/scripts/GenericGetService.groovy
+++ b/bpmn/MSOCommonBPMN/src/main/groovy/org/openecomp/mso/bpmn/common/scripts/GenericGetService.groovy
@@ -20,14 +20,14 @@
 

 package org.openecomp.mso.bpmn.common.scripts

 

-import static org.apache.commons.lang3.StringUtils.*

-

-import org.apache.commons.lang3.*

+import org.apache.commons.lang3.StringEscapeUtils

 import org.camunda.bpm.engine.delegate.BpmnError

 import org.camunda.bpm.engine.runtime.Execution

 import org.openecomp.mso.rest.APIResponse

 import org.springframework.web.util.UriUtils

 

+import static org.apache.commons.lang3.StringUtils.isBlank

+

 

 /**

  * This class supports the GenericGetService Sub Flow.

@@ -301,7 +301,9 @@ class GenericGetService extends AbstractServiceTaskProcessor{
 			if(responseCode == 200){

 				utils.log("DEBUG", "  Query for Service Instance Url Received a Good Response Code", isDebugEnabled)

 				execution.setVariable("GENGS_SuccessIndicator", true)

-				if(utils.nodeExists(aaiResponse, "result-data")){

+				String globalCustomerId = execution.getVariable("GENGS_globalCustomerId")

+				boolean nodeExists = isBlank(globalCustomerId) ? utils.nodeExists(aaiResponse, "result-data") : hasCustomerServiceInstance(aaiResponse, globalCustomerId)

+				if(nodeExists){

 					utils.log("DEBUG", "Query for Service Instance Url Response Does Contain Data" , isDebugEnabled)

 					execution.setVariable("GENGS_FoundIndicator", true)

 					String resourceLink = utils.getNodeText1(aaiResponse, "resource-link")

@@ -439,4 +441,30 @@ class GenericGetService extends AbstractServiceTaskProcessor{
 		utils.log("DEBUG", " *** COMPLETED GenericGetService GetServiceObject Process*** ", isDebugEnabled)

 	}

 

+	/**

+	 * An utility method which check whether a service(by name) is already present within a globalCustomerId or not.

+	 * @param jsonResponse raw response received from AAI by searching ServiceInstance by Name.

+	 * @param globalCustomerId

+	 * @return {@code true} if globalCustomerId is found at 6th position within "resource-link", {@code false} in any other cases.

+	 */

+	public boolean hasCustomerServiceInstance(String aaiResponse, final String globalCustomerId) {

+		if (isBlank(aaiResponse)) {

+			return false

+		}

+		aaiResponse = utils.removeXmlNamespaces(aaiResponse)

+		ArrayList<String> linksArray = utils.getMultNodeObjects(aaiResponse, "resource-link")

+		if (linksArray == null || linksArray.size() == 0) {

+			return false

+		}

+		for (String resourceLink : linksArray) {

+			int custStart = resourceLink.indexOf("customer/")

+			int custEnd = resourceLink.indexOf("/service-subscriptions/")

+			String receivedCustomerId = resourceLink.substring(custStart + 9, custEnd)

+			if (globalCustomerId.equals(receivedCustomerId)) {

+				return true

+			}

+		}

+		return false

+	}

+

 }
\ No newline at end of file
diff --git a/bpmn/MSOCommonBPMN/src/test/java/org/openecomp/mso/bpmn/common/GenericGetServiceTest.java b/bpmn/MSOCommonBPMN/src/test/java/org/openecomp/mso/bpmn/common/GenericGetServiceTest.java
index b1172837cf..82cceb0b70 100644
--- a/bpmn/MSOCommonBPMN/src/test/java/org/openecomp/mso/bpmn/common/GenericGetServiceTest.java
+++ b/bpmn/MSOCommonBPMN/src/test/java/org/openecomp/mso/bpmn/common/GenericGetServiceTest.java
@@ -482,6 +482,61 @@ public class GenericGetServiceTest extends WorkflowTest {
 		assertEquals(expectedWorkflowException, workflowException);

 	}

 

+    @Test

+    @Deployment(resources = {"subprocess/GenericGetService.bpmn"})

+    public void testGenericGetService_success_serviceInstance_byNameServicePresent() throws Exception{

+

+        MockNodeQueryServiceInstanceByName("1604-MVM-26", "GenericFlows/getSIUrlByNameMultiCustomer.xml");

+        MockGetServiceInstance("XyCorporation", "123456789", "MIS%252F1604%252F0026%252FSW_INTERNET", "GenericFlows/getServiceInstance.xml");

+

+        Map<String, String> variables = new HashMap<String, String>();

+        setVariablesInstance(variables, null, "1604-MVM-26", "XyCorporation", null);

+

+        WorkflowResponse workflowResponse = executeWorkFlow(processEngineRule, "GenericGetService", variables);

+        waitForWorkflowToFinish(processEngineRule, workflowResponse.getProcessInstanceID());

+

+        String successIndicator = BPMNUtil.getVariable(processEngineRule, "GenericGetService", "GENGS_SuccessIndicator");

+        String found = BPMNUtil.getVariable(processEngineRule, "GenericGetService", "GENGS_FoundIndicator");

+        String resourceLink = BPMNUtil.getVariable(processEngineRule, "GenericGetService", "GENGS_resourceLink");

+        String response = BPMNUtil.getVariable(processEngineRule, "GenericGetService", "WorkflowResponse");

+        String workflowException = BPMNUtil.getVariable(processEngineRule, "GenericGetService", "WorkflowException");

+        String siUrlResponseCode = BPMNUtil.getVariable(processEngineRule, "GenericGetService", "GENGS_obtainSIUrlResponseCode");

+

+        assertEquals("true", successIndicator);

+        assertEquals("true", found);

+		assertNotNull(resourceLink);

+        assertNotNull(response);

+        assertEquals("200", siUrlResponseCode);

+        assertEquals(null, workflowException);

+    }

+

+	@Test

+	@Deployment(resources = {"subprocess/GenericGetService.bpmn"})

+	public void testGenericGetService_success_serviceInstance_byNameServiceNotPresent() throws Exception{

+

+		MockNodeQueryServiceInstanceByName("1604-MVM-26", "GenericFlows/getSIUrlByNameMultiCustomer.xml");

+		MockGetServiceInstance("CorporationNotPresent", "123456789", "MIS%252F1604%252F0026%252FSW_INTERNET", "GenericFlows/getServiceInstance.xml");

+

+		Map<String, String> variables = new HashMap<String, String>();

+		setVariablesInstance(variables, null, "1604-MVM-26", "CorporationNotPresent", null);

+

+		WorkflowResponse workflowResponse = executeWorkFlow(processEngineRule, "GenericGetService", variables);

+		waitForWorkflowToFinish(processEngineRule, workflowResponse.getProcessInstanceID());

+

+		String successIndicator = BPMNUtil.getVariable(processEngineRule, "GenericGetService", "GENGS_SuccessIndicator");

+		String found = BPMNUtil.getVariable(processEngineRule, "GenericGetService", "GENGS_FoundIndicator");

+		String resourceLink = BPMNUtil.getVariable(processEngineRule, "GenericGetService", "GENGS_resourceLink");

+		String response = BPMNUtil.getVariable(processEngineRule, "GenericGetService", "WorkflowResponse");

+		String workflowException = BPMNUtil.getVariable(processEngineRule, "GenericGetService", "WorkflowException");

+		String siUrlResponseCode = BPMNUtil.getVariable(processEngineRule, "GenericGetService", "GENGS_obtainSIUrlResponseCode");

+

+		assertEquals("true", successIndicator);

+		assertEquals("false", found);

+		assertEquals(null, resourceLink);

+		assertEquals("  ", response);

+		assertEquals("200", siUrlResponseCode);

+		assertEquals(null, workflowException);

+	}

 

 	private void setVariablesInstance(Map<String, String> variables, String siId, String siName, String globalCustId, String serviceType) {

 		variables.put("isDebugLogEnabled", "true");

diff --git a/bpmn/MSOCommonBPMN/src/test/resources/__files/GenericFlows/getSIUrlByNameMultiCustomer.xml b/bpmn/MSOCommonBPMN/src/test/resources/__files/GenericFlows/getSIUrlByNameMultiCustomer.xml
new file mode 100644
index 0000000000..fce47fcd0d
--- /dev/null
+++ b/bpmn/MSOCommonBPMN/src/test/resources/__files/GenericFlows/getSIUrlByNameMultiCustomer.xml
@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<search-results xmlns="http://org.openecomp.aai.inventory/v11">
+    <result-data>
+        <resource-type>service-instance</resource-type>
+        <resource-link>/aai/v11/business/customers/customer/AbcBank/service-subscriptions/service-subscription/ABC-ST/service-instances/service-instance/MIS%252F1604%252F0026%252FSW_INTERNET</resource-link>
+    </result-data>
+    <result-data>
+        <resource-type>service-instance</resource-type>
+        <resource-link>/aai/v11/business/customers/customer/XyCorporation/service-subscriptions/service-subscription/XY-ST/service-instances/service-instance/MIS%252F1604%252F0026%252FSW_INTERNET</resource-link>
+    </result-data>
+</search-results>
\ No newline at end of file
diff --git a/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/RollbackData.java b/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/RollbackData.java
index 66edaaae3c..7ece05ea9e 100644
--- a/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/RollbackData.java
+++ b/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/RollbackData.java
@@ -89,6 +89,7 @@ public class RollbackData implements Serializable {
 	/**
 	 * Returns a string representation of this object.
 	 */
+	 @Override
 	public String toString() {
 		StringBuilder out = new StringBuilder();
 		out.append(getClass().getSimpleName());
diff --git a/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/domain/JsonWrapper.java b/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/domain/JsonWrapper.java
index ce66e06089..4d895f3279 100644
--- a/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/domain/JsonWrapper.java
+++ b/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/domain/JsonWrapper.java
@@ -142,6 +142,7 @@ public abstract class JsonWrapper implements Serializable  {
 	/**

 	 * Returns a string representation of this object.

 	 */

+	 @Override

 	public String toString() {

 		return this.toJsonString();

 	}

diff --git a/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/plugins/LoggingAndURNMappingPlugin.java b/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/plugins/LoggingAndURNMappingPlugin.java
index 71ed0eae5e..c346308e2b 100644
--- a/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/plugins/LoggingAndURNMappingPlugin.java
+++ b/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/plugins/LoggingAndURNMappingPlugin.java
@@ -323,6 +323,7 @@ public class LoggingAndURNMappingPlugin extends AbstractProcessEnginePlugin {
 		private void loadFromDB(DelegateExecution execution, ProcessEngineConfigurationImpl processEngineConfiguration) {
 			Command<List<URNMapping>> command = new Command<List<URNMapping>>() {
 				@SuppressWarnings("unchecked")
+				@Override
 				public List<URNMapping> execute(CommandContext commandContext) {
 					return (List<URNMapping>) commandContext.getDbSqlSession().selectList(
 						"mso.urnMapping.selectAll", null);
diff --git a/bpmn/MSOInfrastructureBPMN/src/test/java/org/openecomp/mso/bpmn/infrastructure/CreateGenericALaCarteServiceInstanceTest.java b/bpmn/MSOInfrastructureBPMN/src/test/java/org/openecomp/mso/bpmn/infrastructure/CreateGenericALaCarteServiceInstanceTest.java
index 21c00918d3..571db76399 100644
--- a/bpmn/MSOInfrastructureBPMN/src/test/java/org/openecomp/mso/bpmn/infrastructure/CreateGenericALaCarteServiceInstanceTest.java
+++ b/bpmn/MSOInfrastructureBPMN/src/test/java/org/openecomp/mso/bpmn/infrastructure/CreateGenericALaCarteServiceInstanceTest.java
@@ -79,8 +79,8 @@ public class CreateGenericALaCarteServiceInstanceTest extends WorkflowTest {
 		MockGetCustomer("MCBH-1610", "CreateServiceInstance/createServiceInstance_queryGlobalCustomerId_AAIResponse_Success.xml");
 		MockPutServiceInstance("MCBH-1610", "viprsvc", "RaaTest-1-id", "");
 		MockGetServiceInstance("MCBH-1610", "viprsvc", "RaaTest-1-id", "GenericFlows/getServiceInstance.xml");
-		MockNodeQueryServiceInstanceByName("RAATest-1", "");
-		MockNodeQueryServiceInstanceById("RaaTest-1-id", "");
+		MockNodeQueryServiceInstanceByName("RAATest-1", null);
+		MockNodeQueryServiceInstanceById("RaaTest-1-id", null);
 		//SDNC
 		mockSDNCAdapter(200);
 		//DB