diff options
3 files changed, 11 insertions, 12 deletions
diff --git a/adapters/mso-vfc-adapter/src/main/java/org/openecomp/mso/adapters/vfc/VfcManager.java b/adapters/mso-vfc-adapter/src/main/java/org/openecomp/mso/adapters/vfc/VfcManager.java index c2d5fe241c..8c503aa43e 100644 --- a/adapters/mso-vfc-adapter/src/main/java/org/openecomp/mso/adapters/vfc/VfcManager.java +++ b/adapters/mso-vfc-adapter/src/main/java/org/openecomp/mso/adapters/vfc/VfcManager.java @@ -64,7 +64,7 @@ public class VfcManager { private static Map<String, String> nfvoUrlMap; static { - nfvoUrlMap = new HashMap<String, String>(); + nfvoUrlMap = new HashMap<>(); nfvoUrlMap.put(Step.CREATE, CommonConstant.NFVO_CREATE_URL); nfvoUrlMap.put(Step.INSTANTIATE, CommonConstant.NFVO_INSTANTIATE_URL); nfvoUrlMap.put(Step.TERMINATE, CommonConstant.NFVO_TERMINATE_URL); @@ -399,7 +399,7 @@ public class VfcManager { */ private String getUrl(String variable, String step) { - String url = CommonConstant.STR_EMPTY; + String url; String originalUrl; originalUrl = (String)nfvoUrlMap.get(step); url = String.format(originalUrl, variable); diff --git a/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/BpelRestClient.java b/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/BpelRestClient.java index 67e263c3a7..a4f1046df9 100644 --- a/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/BpelRestClient.java +++ b/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/BpelRestClient.java @@ -142,9 +142,10 @@ public class BpelRestClient { } public void setRetryCount(int retryCount) { - if (retryCount < 0) - retryCount = DEFAULT_RETRY_COUNT; - this.retryCount = retryCount; + int newRetryCount = retryCount; + if (newRetryCount < 0) + newRetryCount = DEFAULT_RETRY_COUNT; + this.retryCount = newRetryCount; } public int getRetryInterval() { @@ -164,14 +165,14 @@ public class BpelRestClient { } public String getRetryList() { - if (retryList.size() == 0) + if (retryList.isEmpty()) return ""; String t = retryList.toString(); return t.substring(1, t.length()-1); } public void setRetryList(String retryList) { - Set<Integer> s = new TreeSet<Integer>(); + Set<Integer> s = new TreeSet<>(); for (String t : retryList.split("[, ]")) { try { s.add(Integer.parseInt(t)); diff --git a/bpmn/MSOInfrastructureBPMN/src/main/java/org/openecomp/mso/bpmn/infrastructure/workflow/serviceTask/AbstractSdncVlOperationTask.java b/bpmn/MSOInfrastructureBPMN/src/main/java/org/openecomp/mso/bpmn/infrastructure/workflow/serviceTask/AbstractSdncVlOperationTask.java index 8b26d01432..212711e5f3 100644 --- a/bpmn/MSOInfrastructureBPMN/src/main/java/org/openecomp/mso/bpmn/infrastructure/workflow/serviceTask/AbstractSdncVlOperationTask.java +++ b/bpmn/MSOInfrastructureBPMN/src/main/java/org/openecomp/mso/bpmn/infrastructure/workflow/serviceTask/AbstractSdncVlOperationTask.java @@ -89,23 +89,21 @@ public abstract class AbstractSdncVlOperationTask extends BaseTask { } catch (Exception e) { System.out.println(e); logger.error(MessageEnum.GENERAL_EXCEPTION, " getMsbIp catch exception: ", "", this.getTaskName(), MsoLogger.ErrorCode.UnknownError, e.getClass().toString()); - } finally { - return defaultValue; } + return defaultValue; } private Integer getInteger(DelegateExecution execution, String name, Integer defaultValue) { Integer vlaue = (Integer) execution.getVariable(name); try { - if (vlaue != null && vlaue instanceof Integer) { + if (vlaue != null) { return vlaue; } } catch (Exception e) { System.out.println(e); logger.error(MessageEnum.GENERAL_EXCEPTION, " getMsbIp catch exception: ", "", this.getTaskName(), MsoLogger.ErrorCode.UnknownError, e.getClass().toString()); - } finally { - return defaultValue; } + return defaultValue; } public String getProcessKey(DelegateExecution execution) { |