diff options
9 files changed, 35 insertions, 21 deletions
diff --git a/adapters/mso-adapters-rest-interface/src/main/java/org/openecomp/mso/adapters/nwrest/CreateNetworkRequest.java b/adapters/mso-adapters-rest-interface/src/main/java/org/openecomp/mso/adapters/nwrest/CreateNetworkRequest.java index 9def0a4878..061da6fca2 100644 --- a/adapters/mso-adapters-rest-interface/src/main/java/org/openecomp/mso/adapters/nwrest/CreateNetworkRequest.java +++ b/adapters/mso-adapters-rest-interface/src/main/java/org/openecomp/mso/adapters/nwrest/CreateNetworkRequest.java @@ -67,7 +67,7 @@ public class CreateNetworkRequest extends NetworkRequestCommon { private ContrailNetwork contrailNetwork; private Boolean failIfExists = false; private Boolean backout = true; - private Map<String,String> networkParams = new HashMap<String, String>(); + private Map<String,String> networkParams = new HashMap<>(); private MsoRequest msoRequest = new MsoRequest(); public CreateNetworkRequest() { diff --git a/adapters/mso-network-adapter/src/main/java/org/openecomp/mso/adapters/network/MsoNetworkAdapterAsyncImpl.java b/adapters/mso-network-adapter/src/main/java/org/openecomp/mso/adapters/network/MsoNetworkAdapterAsyncImpl.java index 74c39af68a..b3ed711cf5 100644 --- a/adapters/mso-network-adapter/src/main/java/org/openecomp/mso/adapters/network/MsoNetworkAdapterAsyncImpl.java +++ b/adapters/mso-network-adapter/src/main/java/org/openecomp/mso/adapters/network/MsoNetworkAdapterAsyncImpl.java @@ -653,9 +653,11 @@ public class MsoNetworkAdapterAsyncImpl implements MsoNetworkAdapterAsync { sMap = hMap.value; UpdateNetworkNotification.SubnetIdMap.Entry entry = new UpdateNetworkNotification.SubnetIdMap.Entry (); - for (String key : sMap.keySet ()) { + for (Map.Entry<String,String> mapEntry : sMap.entrySet ()) { + String key = mapEntry.getKey(); + String value = mapEntry.getValue(); entry.setKey (key); - entry.setValue (sMap.get (key)); + entry.setValue (value); subnetIdMap.getEntry ().add (entry); } } @@ -671,9 +673,11 @@ public class MsoNetworkAdapterAsyncImpl implements MsoNetworkAdapterAsync { sMap = hMap.value; QueryNetworkNotification.SubnetIdMap.Entry entry = new QueryNetworkNotification.SubnetIdMap.Entry (); - for (String key : sMap.keySet ()) { + for (Map.Entry<String,String> mapEntry : sMap.entrySet ()) { + String key = mapEntry.getKey(); + String value = mapEntry.getValue(); entry.setKey (key); - entry.setValue (sMap.get (key)); + entry.setValue (value); subnetIdMap.getEntry ().add (entry); } } diff --git a/adapters/mso-sdnc-adapter/src/main/java/org/openecomp/mso/adapters/sdnc/sdncrest/SDNCServiceRequestTask.java b/adapters/mso-sdnc-adapter/src/main/java/org/openecomp/mso/adapters/sdnc/sdncrest/SDNCServiceRequestTask.java index 3e908e4296..2c5355f5fb 100644 --- a/adapters/mso-sdnc-adapter/src/main/java/org/openecomp/mso/adapters/sdnc/sdncrest/SDNCServiceRequestTask.java +++ b/adapters/mso-sdnc-adapter/src/main/java/org/openecomp/mso/adapters/sdnc/sdncrest/SDNCServiceRequestTask.java @@ -196,7 +196,7 @@ public class SDNCServiceRequestTask implements Runnable { } catch (Exception e) { LOGGER.error(MessageEnum.RA_ERROR_CONVERT_XML2STR, "", "", MsoLogger.ErrorCode.DataError, "Exception - domToStr", e); - return(null); + return null; } LOGGER.debug("Formatted SDNC service request XML:\n" + xml); diff --git a/adapters/mso-tenant-adapter/src/main/java/org/openecomp/mso/adapters/tenant/MsoTenantAdapterImpl.java b/adapters/mso-tenant-adapter/src/main/java/org/openecomp/mso/adapters/tenant/MsoTenantAdapterImpl.java index a875a862aa..29f5630586 100644 --- a/adapters/mso-tenant-adapter/src/main/java/org/openecomp/mso/adapters/tenant/MsoTenantAdapterImpl.java +++ b/adapters/mso-tenant-adapter/src/main/java/org/openecomp/mso/adapters/tenant/MsoTenantAdapterImpl.java @@ -103,7 +103,7 @@ public class MsoTenantAdapterImpl implements MsoTenantAdapter { MsoTenantUtils tUtils = tFactory.getTenantUtils (cloudSiteId); MsoTenant newTenant = null; - String newTenantId = null; + String newTenantId; long queryTenantStartTime = System.currentTimeMillis (); try { newTenant = tUtils.queryTenantByName (tenantName, cloudSiteId); diff --git a/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/MsoVnfAdapterAsyncImpl.java b/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/MsoVnfAdapterAsyncImpl.java index b3756c4ccb..15a4e0ab94 100644 --- a/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/MsoVnfAdapterAsyncImpl.java +++ b/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/MsoVnfAdapterAsyncImpl.java @@ -555,9 +555,11 @@ public class MsoVnfAdapterAsyncImpl implements MsoVnfAdapterAsync { sMap = hMap.value; UpdateVnfNotification.Outputs.Entry entry = new UpdateVnfNotification.Outputs.Entry (); - for (String key : sMap.keySet ()) { + for (Map.Entry<String,String> mapEntry : sMap.entrySet ()) { + String key = mapEntry.getKey(); + String value = mapEntry.getValue(); entry.setKey (key); - entry.setValue (sMap.get (key)); + entry.setValue (value); outputs.getEntry ().add (entry); } } @@ -574,9 +576,11 @@ public class MsoVnfAdapterAsyncImpl implements MsoVnfAdapterAsync { QueryVnfNotification.Outputs.Entry entry = new QueryVnfNotification.Outputs.Entry (); - for (String key : sMap.keySet ()) { + for (Map.Entry<String,String> mapEntry : sMap.entrySet ()) { + String key = mapEntry.getKey(); + String value = mapEntry.getValue(); entry.setKey (key); - entry.setValue (sMap.get (key)); + entry.setValue (value); outputs.getEntry ().add (entry); } } diff --git a/bpmn/MSOCockpit/pom.xml b/bpmn/MSOCockpit/pom.xml index ed9d08d060..be3f9dafb5 100644 --- a/bpmn/MSOCockpit/pom.xml +++ b/bpmn/MSOCockpit/pom.xml @@ -41,7 +41,7 @@ <dependency>
<groupId>org.camunda.bpm.webapp</groupId>
- <artifactId>camunda-webapp-jboss-standalone</artifactId>
+ <artifactId>${camunda.bpm.webapp.artifact}</artifactId>
<version>${camunda.version}</version>
<type>war</type>
</dependency>
diff --git a/bpmn/MSOCockpit/src/main/assembly/cockpit-build.xml b/bpmn/MSOCockpit/src/main/assembly/cockpit-build.xml index b84a84df8a..3bc0ace298 100644 --- a/bpmn/MSOCockpit/src/main/assembly/cockpit-build.xml +++ b/bpmn/MSOCockpit/src/main/assembly/cockpit-build.xml @@ -34,7 +34,7 @@ <dependencySet>
<outputDirectory>/</outputDirectory>
<includes>
- <include>org.camunda.bpm.webapp:camunda-webapp-jboss-standalone</include>
+ <include>org.camunda.bpm.webapp:${camunda.bpm.webapp.artifact}</include>
</includes>
<unpack>true</unpack>
<unpackOptions>
diff --git a/bpmn/MSOURN-plugin/src/main/java/org/openecomp/camunda/bpmn/plugin/urnmap/resources/ProcessInstanceResource.java b/bpmn/MSOURN-plugin/src/main/java/org/openecomp/camunda/bpmn/plugin/urnmap/resources/ProcessInstanceResource.java index 7d432067ba..5cf6f6ca05 100644 --- a/bpmn/MSOURN-plugin/src/main/java/org/openecomp/camunda/bpmn/plugin/urnmap/resources/ProcessInstanceResource.java +++ b/bpmn/MSOURN-plugin/src/main/java/org/openecomp/camunda/bpmn/plugin/urnmap/resources/ProcessInstanceResource.java @@ -27,6 +27,9 @@ import javax.ws.rs.GET; import javax.ws.rs.POST;
import javax.ws.rs.PUT;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import org.camunda.bpm.cockpit.db.QueryParameters;
import org.camunda.bpm.cockpit.plugin.resource.AbstractPluginResource;
import org.camunda.bpm.cockpit.db.CommandExecutor;
@@ -34,6 +37,8 @@ import org.openecomp.camunda.bpmn.plugin.urnmap.db.*; public class ProcessInstanceResource extends AbstractPluginResource {
+ private static final Logger log = LoggerFactory.getLogger(ProcessInstanceResource.class);
+
public ProcessInstanceResource(String engineName) {
super(engineName);
}
@@ -45,11 +50,11 @@ public class ProcessInstanceResource extends AbstractPluginResource { "cockpit.urnMap.retrieveUrnKeyValuePair",
new QueryParameters<URNData>());
- System.out.println("urnmap-plugin project - Results Retrieved: ");
- System.out.println("URNName: " + " " + "URNValue: " );
+ log.info("urnmap-plugin project - Results Retrieved: ");
+ log.info("URNName: " + " " + "URNValue: " );
for(URNData d: list)
{
- System.out.println( d.getURNName() + " " + d.getURNValue());
+ log.info( d.getURNName() + " " + d.getURNValue());
}
return list;
@@ -59,7 +64,7 @@ public class ProcessInstanceResource extends AbstractPluginResource { //public void insertNewRow(String key_, String value_)
public void insertNewRow(String temp)
{
- System.out.println("AddNewRow: XXXXXXXXXXXXXXXXX ---> " + temp);
+ log.info("AddNewRow: XXXXXXXXXXXXXXXXX ---> " + temp);
StringTokenizer st = new StringTokenizer(temp, "|");
String key_ = "";
String value_ = "";
@@ -70,7 +75,7 @@ public class ProcessInstanceResource extends AbstractPluginResource { System.out.println(key_ + "\t" + value_);
}
- System.out.println("AddNewRow: XXXXXXXXXXXXXXXXX ---> key: " + key_ + " , Value: " + value_);
+ log.info("AddNewRow: XXXXXXXXXXXXXXXXX ---> key: " + key_ + " , Value: " + value_);
URNData nRow = new URNData();
nRow.setVer_("1");
nRow.setURNName(key_);
@@ -78,19 +83,19 @@ public class ProcessInstanceResource extends AbstractPluginResource { getQueryService().executeQuery("cockpit.urnMap.insertNewRow", nRow, URNData.class);
- System.out.println("AddNewRow: XXXXXX END XXXXXXXXXXX");
+ log.info("AddNewRow: XXXXXX END XXXXXXXXXXX");
}
@POST
// public void getPersistData(List<URNData > myList) {
public void getPersistData(URNData d) {
- System.out.println("getPersistData: UrnName: " + d.getURNName() + " , URNValue: " + d.getURNValue() );
+ log.info("getPersistData: UrnName: " + d.getURNName() + " , URNValue: " + d.getURNValue() );
getQueryService().executeQuery("cockpit.urnMap.persistURNData", d, URNData.class);
//getQueryService().executeQuery("cockpit.sample.persistURNData", d, ProcessInstanceCountDto.class);
- System.out.println("XXXXXXXXXX - END - XXXXXXXXXXXXXXX");
+ log.info("XXXXXXXXXX - END - XXXXXXXXXXXXXXX");
}
}
diff --git a/bpmn/pom.xml b/bpmn/pom.xml index 9c9e6e01ef..b878467e72 100644 --- a/bpmn/pom.xml +++ b/bpmn/pom.xml @@ -18,6 +18,7 @@ <properties> <camunda.version>7.7.0</camunda.version> <camunda.bpm.assert.version>1.2</camunda.bpm.assert.version> + <camunda.bpm.webapp.artifact>camunda-webapp-jboss-standalone</camunda.bpm.webapp.artifact> <h2.version>1.3.173</h2.version> <groovy.version>2.4.7</groovy.version> <saxon.version>9.5.1-8</saxon.version> |