Fix some Sonar Blocker issues in apihandler/common

Some sonar code fixes are done in this patch.

https://sonar.onap.org/issues/search#issues=AV3BntKO5bp_wwmIVCLv
https://sonar.onap.org/issues/search#issues=AV5mhwQk32hFUzlqebFJ
https://sonar.onap.org/issues/search#issues=AV3BntKc5bp_wwmIVCMJ
https://sonar.onap.org/issues/search#issues=AV3BntKi5bp_wwmIVCMK
https://sonar.onap.org/issues/search#issues=AV3BntKu5bp_wwmIVCMQ
https://sonar.onap.org/issues/search#issues=AV3BntK35bp_wwmIVCMX
https://sonar.onap.org/issues/search#issues=AV5mhwRN32hFUzlqebFQ
https://sonar.onap.org/issues/search#issues=AV3BntLG5bp_wwmIVCMc
https://sonar.onap.org/issues/search#issues=AV3BntLR5bp_wwmIVCMh

Change-Id: I3ba77adec1951fb7153ed640eb1ea0a4a3ed3e6b
Issue-ID: SO-165
Signed-off-by: Shashank Kumar Shankar <shashank.kumar.shankar@intel.com>

1 files changed, 4 insertions, 17 deletions

diff --git a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/CamundaTaskClient.java b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/CamundaTaskClient.java
index b4e7b7e068..64193cf6c4 100644
--- a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/CamundaTaskClient.java
+++ b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/CamundaTaskClient.java
@@ -20,19 +20,14 @@
 

 package org.openecomp.mso.apihandler.common;

 

-import org.openecomp.mso.logger.MessageEnum;

 import org.openecomp.mso.logger.MsoLogger;

 import org.apache.http.HttpResponse;

 import org.apache.http.client.ClientProtocolException;

 import org.apache.http.client.methods.HttpGet;

 import org.apache.http.client.methods.HttpPost;

 import org.apache.http.entity.StringEntity;

-import org.codehaus.jackson.map.ObjectMapper;

-import org.codehaus.jackson.map.SerializationConfig;

 

 import javax.xml.bind.DatatypeConverter;

-import java.io.BufferedReader;

-import java.io.InputStreamReader;

 import java.io.IOException;

 

 public class CamundaTaskClient extends RequestClient{

@@ -63,9 +58,7 @@ public class CamundaTaskClient extends RequestClient{
 		}

 

 		post.setEntity(input);

-		HttpResponse response = client.execute(post);

-

-		return response;

+		return client.execute(post);

 	}

 	

 	@Override

@@ -88,8 +81,7 @@ public class CamundaTaskClient extends RequestClient{
 	}

 	

 	@Override

-	public HttpResponse get()

-			throws ClientProtocolException, IOException{

+	public HttpResponse get() throws ClientProtocolException, IOException{

 		HttpGet get = new HttpGet(url);

 		msoLogger.debug("Camunda Task url is: "+ url);	

 		String encryptedCredentials;

@@ -103,12 +95,7 @@ public class CamundaTaskClient extends RequestClient{
 			}

 		}

 		

-		HttpResponse getResponse = client.execute(get);	

-

-		return getResponse;

-}

-	

-	

-

+		return client.execute(get);

+	}

 

 }