diff options
author | r.bogacki <r.bogacki@samsung.com> | 2019-07-10 11:29:37 +0200 |
---|---|---|
committer | Robert Bogacki <r.bogacki@samsung.com> | 2019-07-12 06:49:14 +0000 |
commit | 89604fd38922a99d7566526562cebf7406907c18 (patch) | |
tree | d0d5c64806222814fe23a1bdb5ba5cdd6ff538ac /bpmn/so-bpmn-building-blocks/src | |
parent | c7113532f34e920d6cfe773cd84591fc863801ae (diff) |
Fixes in WorkflowAction
Fixes in WorkflowAction according to the Sonar analysis:
-Fixed String comparison.
-Removed unnecessary method parameters.
-Updated junit test.
Issue-ID: SO-2107
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I7522269e237f736521a627bcd1c8f77b0c776a70
Diffstat (limited to 'bpmn/so-bpmn-building-blocks/src')
-rw-r--r-- | bpmn/so-bpmn-building-blocks/src/test/java/org/onap/so/bpmn/infrastructure/bpmn/process/WorkflowActionBBTest.java | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/bpmn/so-bpmn-building-blocks/src/test/java/org/onap/so/bpmn/infrastructure/bpmn/process/WorkflowActionBBTest.java b/bpmn/so-bpmn-building-blocks/src/test/java/org/onap/so/bpmn/infrastructure/bpmn/process/WorkflowActionBBTest.java index 051f373eaf..bd29e5570a 100644 --- a/bpmn/so-bpmn-building-blocks/src/test/java/org/onap/so/bpmn/infrastructure/bpmn/process/WorkflowActionBBTest.java +++ b/bpmn/so-bpmn-building-blocks/src/test/java/org/onap/so/bpmn/infrastructure/bpmn/process/WorkflowActionBBTest.java @@ -4,6 +4,8 @@ * ================================================================================ * Copyright (C) 2017 - 2018 AT&T Intellectual Property. All rights reserved. * ================================================================================ + * Modifications Copyright (c) 2019 Samsung + * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at @@ -93,8 +95,7 @@ public class WorkflowActionBBTest extends BaseBPMNTest { Map<String, String> map = new HashMap<>(); map.put("handlingCode", "Abort"); - doThrow(new BpmnError("7000", "TESTING ERRORS")).when(workflowActionBBFailure) - .abortCallErrorHandling(any(DelegateExecution.class)); + doThrow(new BpmnError("7000", "TESTING ERRORS")).when(workflowActionBBFailure).abortCallErrorHandling(); mockSubprocess("ExecuteBuildingBlock", "Mocked ExecuteBuildingBlock", "GenericStub", map); ProcessInstance pi = runtimeService.startProcessInstanceByKey("WorkflowActionBB", variables); |