diff options
| author |   Zhu Libo <libo.zhu@intel.com> | 2018-01-18 01:43:44 +0800 |
|---|---|---|
| committer | liboNet <libo.zhu@intel.com> | 2018-01-20 01:40:45 +0800 |
| commit | 3c335070cb5f653956f419e7fee29282a45b9f96 (patch) | |
| tree | d30f0d4e0878fa84219c528c16be657b4221da9a /adapters | |
| parent | 4da1270fb9814f230e064e995bb379db6a4d25d4 (diff) | |
Sonar blocker issue - NullPointerExeption
use the try-with-resource statement method to fix issues:
https://sonar.onap.org/issues/search#issues=AV3BnuCb5bp_wwmIVClC
and https://sonar.onap.org/issues/search#issues=AV7t547AlaLbmlVXT_jY
Change-Id: I912be949793066bef6e3036fb474247d4d269e4f
Issue-ID: SO-165
Signed-off-by: Zhu Libo <libo.zhu@intel.com>
Diffstat (limited to 'adapters')
| -rw-r--r-- | adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/BpelRestClient.java | 16 |
1 files changed, 1 insertions, 15 deletions
diff --git a/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/BpelRestClient.java b/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/BpelRestClient.java index a8189925fb..749b9f9fc3 100644 --- a/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/BpelRestClient.java +++ b/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/BpelRestClient.java @@ -256,13 +256,9 @@ public class BpelRestClient { .build(); post.setConfig(requestConfig); - //Client 4.3+ - CloseableHttpClient client = null; - //Client 4.3+ //Execute & GetResponse - try { - client = HttpClients.createDefault(); + try(CloseableHttpClient client = HttpClients.createDefault()) { CloseableHttpResponse response = client.execute(post); if (response != null) { lastResponseCode = response.getStatusLine().getStatusCode(); @@ -277,16 +273,6 @@ public class BpelRestClient { LOGGER.error (MessageEnum.RA_SEND_VNF_NOTIF_ERR, error, "Camunda", "", MsoLogger.ErrorCode.BusinessProcesssError, "Exception - Error sending Bpel notification", e); lastResponseCode = 900; lastResponse = ""; - } finally { - try { - client.close(); - } catch (IOException e) { - // ignore - LOGGER.debug("IOException: ", e); - } catch (NullPointerException e) { - //ignore - LOGGER.debug("NullPointerException: ", e); - } } LOGGER.debug("Response code from BPEL server: "+lastResponseCode); LOGGER.debug("Response body is: "+lastResponse); |