summaryrefslogtreecommitdiffstats
path: root/adapters
diff options
context:
space:
mode:
authorsurya-huawei <a.u.surya@huawei.com>2017-09-26 18:25:40 +0530
committerSURYA A U <a.u.surya@huawei.com>2017-09-27 03:11:18 +0000
commit3065620fde4e78b2c2003ef1d912c36af0b0b61a (patch)
tree573f7ca77de43cb353f52d629c071b2ab0d2b41c /adapters
parente0081f9b154b44265deb85d9d05b05f8e9719000 (diff)
Fix major Sonar issues
*Use negation operator instead of converting boolean operator *Remove unused imports These changes are done to increase code readability Issue-Id: SO-118 Change-Id: I8ec491217520edad95657f8cbb33d20149f64425 Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Diffstat (limited to 'adapters')
-rw-r--r--adapters/mso-network-adapter/src/main/java/org/openecomp/mso/adapters/network/MsoNetworkAdapterImpl.java2
-rw-r--r--adapters/mso-sdnc-adapter/src/main/java/org/openecomp/mso/adapters/sdnc/impl/SDNCRestClient.java2
2 files changed, 1 insertions, 3 deletions
diff --git a/adapters/mso-network-adapter/src/main/java/org/openecomp/mso/adapters/network/MsoNetworkAdapterImpl.java b/adapters/mso-network-adapter/src/main/java/org/openecomp/mso/adapters/network/MsoNetworkAdapterImpl.java
index ccac38a58c..687930673b 100644
--- a/adapters/mso-network-adapter/src/main/java/org/openecomp/mso/adapters/network/MsoNetworkAdapterImpl.java
+++ b/adapters/mso-network-adapter/src/main/java/org/openecomp/mso/adapters/network/MsoNetworkAdapterImpl.java
@@ -444,7 +444,7 @@ public class MsoNetworkAdapterImpl implements MsoNetworkAdapter {
throw new NetworkException (me);
}
- if (heatStack != null && !(heatStack.getStatus () == HeatStatus.NOTFOUND)) {
+ if (heatStack != null && (heatStack.getStatus () != HeatStatus.NOTFOUND)) {
// Stack exists. Return success or error depending on input directive
if (failIfExists != null && failIfExists) {
String error = "CreateNetwork: Stack " + networkName
diff --git a/adapters/mso-sdnc-adapter/src/main/java/org/openecomp/mso/adapters/sdnc/impl/SDNCRestClient.java b/adapters/mso-sdnc-adapter/src/main/java/org/openecomp/mso/adapters/sdnc/impl/SDNCRestClient.java
index 757ea8207d..a4603ab5d4 100644
--- a/adapters/mso-sdnc-adapter/src/main/java/org/openecomp/mso/adapters/sdnc/impl/SDNCRestClient.java
+++ b/adapters/mso-sdnc-adapter/src/main/java/org/openecomp/mso/adapters/sdnc/impl/SDNCRestClient.java
@@ -34,7 +34,6 @@ import java.util.HashMap;
import java.util.List;
import java.util.Map;
-import javax.ejb.EJB;
import javax.xml.XMLConstants;
import javax.xml.bind.DatatypeConverter;
import javax.xml.parsers.DocumentBuilder;
@@ -58,7 +57,6 @@ import org.openecomp.mso.adapters.sdnc.util.SDNCRequestIdUtil;
import org.openecomp.mso.logger.MsoAlarmLogger;
import org.openecomp.mso.logger.MsoLogger;
import org.openecomp.mso.logger.MessageEnum;
-import org.openecomp.mso.properties.MsoJavaProperties;
import org.openecomp.mso.properties.MsoPropertiesFactory;
//SDNCAdapter to SDNC Rest Client