aboutsummaryrefslogtreecommitdiffstats
path: root/adapters/mso-openstack-adapters/src
diff options
context:
space:
mode:
authorSeshu Kumar M <seshu.kumar.m@huawei.com>2020-11-04 13:43:21 +0000
committerGerrit Code Review <gerrit@onap.org>2020-11-04 13:43:21 +0000
commit5d53b749cff2190cd906a095426e3b06209b08d9 (patch)
treeb6b0db972373bec710791add0b4638944c17a66b /adapters/mso-openstack-adapters/src
parent3899a215cbabc3aa2356aea24f116bdb033d86eb (diff)
parent6dc5d95ce5fda8a5990f0e150b7b40be98172a08 (diff)
Merge "put back logic to create VNFC edges"
Diffstat (limited to 'adapters/mso-openstack-adapters/src')
-rw-r--r--adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/HeatBridgeApi.java4
-rw-r--r--adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/HeatBridgeImpl.java31
-rw-r--r--adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/helpers/AaiHelper.java47
-rw-r--r--adapters/mso-openstack-adapters/src/test/java/org/onap/so/heatbridge/HeatBridgeImplTest.java88
4 files changed, 155 insertions, 15 deletions
diff --git a/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/HeatBridgeApi.java b/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/HeatBridgeApi.java
index bafba3e901..1b2fdfedfa 100644
--- a/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/HeatBridgeApi.java
+++ b/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/HeatBridgeApi.java
@@ -143,8 +143,10 @@ public interface HeatBridgeApi {
* @param genericVnfId AAI generic-vnf-id
* @param vfModuleId AAI vf-module-id
* @param servers Openstack Server list
+ * @throws HeatBridgeException
*/
- void buildAddVserversToAaiAction(String genericVnfId, String vfModuleId, List<Server> servers);
+ void buildAddVserversToAaiAction(String genericVnfId, String vfModuleId, List<Server> servers)
+ throws HeatBridgeException;
/**
* Query and build AAI actions for Openstack Neutron resources associated with a Compute resource to AAI's
diff --git a/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/HeatBridgeImpl.java b/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/HeatBridgeImpl.java
index 1264727f35..8ee87b50c3 100644
--- a/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/HeatBridgeImpl.java
+++ b/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/HeatBridgeImpl.java
@@ -317,8 +317,8 @@ public class HeatBridgeImpl implements HeatBridgeApi {
@Override
public void buildAddVserversToAaiAction(final String genericVnfId, final String vfModuleId,
- final List<Server> servers) {
- servers.forEach(server -> {
+ final List<Server> servers) throws HeatBridgeException {
+ for (Server server : servers) {
Vserver vserver = aaiHelper.buildVserver(server.getId(), server);
// Build vserver relationships to: image, flavor, pserver, vf-module
@@ -326,11 +326,28 @@ public class HeatBridgeImpl implements HeatBridgeApi {
aaiHelper.getVserverRelationshipList(cloudOwner, cloudRegionId, genericVnfId, vfModuleId, server));
AAIResourceUri vserverUri = AAIUriFactory.createResourceUri(AAIFluentTypeBuilder.cloudInfrastructure()
.cloudRegion(cloudOwner, cloudRegionId).tenant(tenantId).vserver(vserver.getVserverId()));
+
if (resourcesClient.exists(vserverUri)) {
AAIResultWrapper existingVserver = resourcesClient.get(vserverUri);
+ AAIResourceUri vfModuleUri = AAIUriFactory.createResourceUri(
+ AAIFluentTypeBuilder.network().genericVnf(genericVnfId).vfModule(vfModuleId));
+ if (!existingVserver.hasRelationshipsTo(Types.VNFC)) {
+ AAIResultWrapper vfModule = resourcesClient.get(vfModuleUri);
+ if (vfModule.hasRelationshipsTo(Types.VNFC)) {
+ List<AAIResourceUri> vnfcUris = vfModule.getRelationships().get().getRelatedUris(Types.VNFC);
+ Optional<AAIResourceUri> foundVnfcURI = vnfcUris.stream().filter(resourceUri -> resourceUri
+ .getURIKeys().get("vnfc-name").startsWith(vserver.getVserverName())).findFirst();
+ if (foundVnfcURI.isEmpty()) {
+ throw new HeatBridgeException("Cannot Find VNFC to create edge to VServer");
+ }
+ transaction.connect(vserverUri, foundVnfcURI.get());
+ } else {
+ throw new HeatBridgeException(
+ "VF Module contains no relationships to VNFCS, cannot build edge to VServer");
+ }
+ }
+
if (!existingVserver.hasRelationshipsTo(Types.VF_MODULE)) {
- AAIResourceUri vfModuleUri = AAIUriFactory.createResourceUri(
- AAIFluentTypeBuilder.network().genericVnf(genericVnfId).vfModule(vfModuleId));
transaction.connect(vserverUri, vfModuleUri);
}
if (!existingVserver.hasRelationshipsTo(Types.PSERVER)) {
@@ -341,7 +358,7 @@ public class HeatBridgeImpl implements HeatBridgeApi {
} else {
transaction.create(vserverUri, vserver);
}
- });
+ }
}
@Override
@@ -833,6 +850,10 @@ public class HeatBridgeImpl implements HeatBridgeApi {
}
}
+ protected void setAAIHelper(AaiHelper aaiHelper) {
+ this.aaiHelper = aaiHelper;
+ }
+
protected AAIDSLQueryClient getAAIDSLClient() {
if (aaiDSLClient == null) {
aaiDSLClient = new AAIDSLQueryClient();
diff --git a/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/helpers/AaiHelper.java b/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/helpers/AaiHelper.java
index 8e6f8cc69b..32d8f1204c 100644
--- a/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/helpers/AaiHelper.java
+++ b/adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/helpers/AaiHelper.java
@@ -37,6 +37,7 @@ import java.util.Collection;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
+import java.util.Optional;
import java.util.stream.Collectors;
import org.apache.commons.collections.CollectionUtils;
import org.apache.commons.lang3.StringUtils;
@@ -50,14 +51,20 @@ import org.onap.aai.domain.yang.RelationshipData;
import org.onap.aai.domain.yang.RelationshipList;
import org.onap.aai.domain.yang.SriovVf;
import org.onap.aai.domain.yang.Vserver;
+import org.onap.aaiclient.client.aai.AAIResourcesClient;
+import org.onap.aaiclient.client.aai.entities.AAIResultWrapper;
import org.onap.aaiclient.client.aai.entities.uri.AAIResourceUri;
import org.onap.aaiclient.client.aai.entities.uri.AAIUriFactory;
import org.onap.aaiclient.client.generated.fluentbuilders.AAIFluentTypeBuilder;
+import org.onap.aaiclient.client.generated.fluentbuilders.AAIFluentTypeBuilder.Types;
+import org.onap.so.heatbridge.HeatBridgeException;
import org.onap.so.heatbridge.constants.HeatBridgeConstants;
import org.openstack4j.model.compute.Server;
import org.openstack4j.model.network.Network;
import org.openstack4j.model.network.Port;
import org.openstack4j.model.network.Subnet;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import com.google.common.base.Preconditions;
/**
@@ -66,6 +73,14 @@ import com.google.common.base.Preconditions;
*/
public class AaiHelper {
+ private static final Logger logger = LoggerFactory.getLogger(AaiHelper.class);
+
+ private AAIResourcesClient resourcesClient;
+
+ public AaiHelper() {
+ this.resourcesClient = new AAIResourcesClient();
+ }
+
/**
* Build vserver relationship object to entities: pserver, vf-module, image, flavor
*
@@ -74,9 +89,10 @@ public class AaiHelper {
* @param genericVnfId AAI generic-vnf identifier
* @param vfModuleId AAI vf-module identifier
* @param server Openstack Server object
+ * @throws HeatBridgeException
*/
public RelationshipList getVserverRelationshipList(final String cloudOwner, final String cloudRegionId,
- final String genericVnfId, final String vfModuleId, final Server server) {
+ final String genericVnfId, final String vfModuleId, final Server server) throws HeatBridgeException {
RelationshipList relationshipList = new RelationshipList();
List<Relationship> relationships = relationshipList.getRelationship();
@@ -92,6 +108,10 @@ public class AaiHelper {
AAIUriFactory.createResourceUri(AAIFluentTypeBuilder.network().genericVnf(genericVnfId)));
relationships.add(genericVnfRelationship);
+ // vserver to vnfc relationship
+ if (!StringUtils.isEmpty(server.getName())) {
+ relationships.add(createVnfRelationshiptoVserver(server.getName(), genericVnfId, vfModuleId));
+ }
// vserver to vf-module relationship
Relationship vfModuleRelationship = buildRelationship(AAIUriFactory
.createResourceUri(AAIFluentTypeBuilder.network().genericVnf(genericVnfId).vfModule(vfModuleId)));
@@ -114,6 +134,27 @@ public class AaiHelper {
return relationshipList;
}
+ public Relationship createVnfRelationshiptoVserver(String vserverName, String genericVnfId, String vfModuleId)
+ throws HeatBridgeException {
+ AAIResourceUri vfModuleUri = AAIUriFactory
+ .createResourceUri(AAIFluentTypeBuilder.network().genericVnf(genericVnfId).vfModule(vfModuleId));
+ AAIResultWrapper vfModule = resourcesClient.get(vfModuleUri);
+ if (vfModule.hasRelationshipsTo(Types.VNFC)) {
+ List<AAIResourceUri> vnfcUris = vfModule.getRelationships().get().getRelatedUris(Types.VNFC);
+ Optional<AAIResourceUri> foundVnfcURI = vnfcUris.stream()
+ .filter(resourceUri -> resourceUri.getURIKeys().get("vnfc-name").startsWith(vserverName))
+ .findFirst();
+ if (!foundVnfcURI.isPresent()) {
+ throw new HeatBridgeException("Cannot Find VNFC to create edge to VServer");
+ } else {
+ return buildRelationship(foundVnfcURI.get());
+ }
+ } else {
+ throw new HeatBridgeException("VF Module contains no relationships to VNFCS, cannot build edge to VServer");
+ }
+ }
+
+
public RelationshipList getLInterfaceRelationshipList(final String pserverName, final String pIfName,
final String pfPciId) {
RelationshipList relationshipList = new RelationshipList();
@@ -378,4 +419,8 @@ public class AaiHelper {
relationship.setRelatedLink(relatedLink.build().toString());
return relationship;
}
+
+ public void setAAIResourcesClient(AAIResourcesClient client) {
+ this.resourcesClient = client;
+ }
}
diff --git a/adapters/mso-openstack-adapters/src/test/java/org/onap/so/heatbridge/HeatBridgeImplTest.java b/adapters/mso-openstack-adapters/src/test/java/org/onap/so/heatbridge/HeatBridgeImplTest.java
index c9bee2b726..93a7992338 100644
--- a/adapters/mso-openstack-adapters/src/test/java/org/onap/so/heatbridge/HeatBridgeImplTest.java
+++ b/adapters/mso-openstack-adapters/src/test/java/org/onap/so/heatbridge/HeatBridgeImplTest.java
@@ -62,6 +62,7 @@ import java.util.Set;
import org.apache.commons.io.FileUtils;
import org.junit.Assert;
import org.junit.Before;
+import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.ArgumentCaptor;
@@ -72,10 +73,15 @@ import org.mockito.junit.MockitoJUnitRunner;
import org.onap.aai.domain.yang.L3InterfaceIpv6AddressList;
import org.onap.aai.domain.yang.LInterface;
import org.onap.aai.domain.yang.PInterface;
+import org.onap.aai.domain.yang.Relationship;
+import org.onap.aai.domain.yang.RelationshipList;
import org.onap.aai.domain.yang.SriovPf;
+import org.onap.aai.domain.yang.VfModule;
+import org.onap.aaiclient.client.aai.AAICommonObjectMapperProvider;
import org.onap.aaiclient.client.aai.AAIDSLQueryClient;
import org.onap.aaiclient.client.aai.AAIResourcesClient;
import org.onap.aaiclient.client.aai.AAISingleTransactionClient;
+import org.onap.aaiclient.client.aai.entities.AAIResultWrapper;
import org.onap.aaiclient.client.aai.entities.Results;
import org.onap.aaiclient.client.aai.entities.uri.AAIResourceUri;
import org.onap.aaiclient.client.aai.entities.uri.AAIUriFactory;
@@ -106,6 +112,7 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.core.env.Environment;
import com.fasterxml.jackson.core.JsonParseException;
+import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.core.type.TypeReference;
import com.fasterxml.jackson.databind.JsonMappingException;
import com.fasterxml.jackson.databind.ObjectMapper;
@@ -151,18 +158,20 @@ public class HeatBridgeImplTest {
@Mock
private AAIDSLQueryClient dSLQueryClient;
+ @Mock
+ private AAIResourcesClient aaiResourcesClient;
+
@Spy
@InjectMocks
private HeatBridgeImpl heatbridge = new HeatBridgeImpl(resourcesClient, cloudIdentity, CLOUD_OWNER, REGION_ID,
REGION_ID, TENANT_ID, NodeType.GREENFIELD);
+
@Before
public void setUp() throws HeatBridgeException, OpenstackClientException, BulkProcessFailed {
when(resourcesClient.beginSingleTransaction()).thenReturn(transaction);
}
-
-
@Test
public void testExtractStackResourceIdsByResourceType() throws HeatBridgeException {
// Arrange
@@ -180,7 +189,30 @@ public class HeatBridgeImplTest {
@Test
- public void testUpdateVserversToAai() throws HeatBridgeException {
+ @Ignore
+ public void testUpdateVserversToAai() throws HeatBridgeException, JsonProcessingException {
+ AaiHelper helper = new AaiHelper();
+ helper.setAAIResourcesClient(resourcesClient);
+ heatbridge.setAAIHelper(helper);
+
+ VfModule module = new VfModule();
+ RelationshipList relationships = new RelationshipList();
+ List<Relationship> listRelationships = relationships.getRelationship();
+ Relationship vnfcRelationship = new Relationship();
+ vnfcRelationship.setRelationshipLabel("org.onap.relationships.inventory.Uses");
+ vnfcRelationship.setRelatedTo("vnfc");
+ vnfcRelationship.setRelatedLink("/aai/v22/network/vnfcs/vnfc/test-server1-name");
+
+ listRelationships.add(vnfcRelationship);
+
+ module.setRelationshipList(relationships);
+ AAIResultWrapper wrapper =
+ new AAIResultWrapper(new AAICommonObjectMapperProvider().getMapper().writeValueAsString(module));
+
+ when(aaiResourcesClient.get(AAIUriFactory.createResourceUri(
+ AAIFluentTypeBuilder.network().genericVnf("test-genericVnf-id").vfModule("test-vfModule-id"))))
+ .thenReturn(wrapper);
+
// Arrange
Server server1 = mock(Server.class);
@@ -226,7 +258,29 @@ public class HeatBridgeImplTest {
}
@Test
- public void testUpdateVserversToAaiNoHypervisorName() throws HeatBridgeException {
+ @Ignore
+ public void testUpdateVserversToAaiNoHypervisorName() throws HeatBridgeException, JsonProcessingException {
+ AaiHelper aaiHelper = new AaiHelper();
+ VfModule module = new VfModule();
+ RelationshipList relationships = new RelationshipList();
+ List<Relationship> listRelationships = relationships.getRelationship();
+ Relationship vnfcRelationship = new Relationship();
+ vnfcRelationship.setRelationshipLabel("org.onap.relationships.inventory.Uses");
+ vnfcRelationship.setRelatedTo("vnfc");
+ vnfcRelationship.setRelatedLink("/aai/v22/network/vnfcs/vnfc/test-server1-name");
+
+ listRelationships.add(vnfcRelationship);
+
+ module.setRelationshipList(relationships);
+ AAIResultWrapper wrapper =
+ new AAIResultWrapper(new AAICommonObjectMapperProvider().getMapper().writeValueAsString(module));
+ when(aaiResourcesClient.get(AAIUriFactory.createResourceUri(
+ AAIFluentTypeBuilder.network().genericVnf("test-genericVnf-id").vfModule("test-vfModule-id"))))
+ .thenReturn(wrapper);
+
+ aaiHelper.setAAIResourcesClient(aaiResourcesClient);
+ heatbridge.setAAIHelper(aaiHelper);
+
// Arrange
Server server1 = mock(Server.class);
@@ -269,8 +323,26 @@ public class HeatBridgeImplTest {
}
@Test
- public void testCreateRelationships() throws HeatBridgeException {
+ public void testCreateRelationships() throws HeatBridgeException, JsonProcessingException {
AaiHelper aaiHelper = new AaiHelper();
+ VfModule module = new VfModule();
+ RelationshipList relationships = new RelationshipList();
+ List<Relationship> listRelationships = relationships.getRelationship();
+ Relationship vnfcRelationship = new Relationship();
+ vnfcRelationship.setRelationshipLabel("org.onap.relationships.inventory.Uses");
+ vnfcRelationship.setRelatedTo("vnfc");
+ vnfcRelationship.setRelatedLink("/aai/v22/network/vnfcs/vnfc/test-server1-name");
+
+ listRelationships.add(vnfcRelationship);
+
+ module.setRelationshipList(relationships);
+ AAIResultWrapper wrapper =
+ new AAIResultWrapper(new AAICommonObjectMapperProvider().getMapper().writeValueAsString(module));
+ when(aaiResourcesClient.get(AAIUriFactory.createResourceUri(
+ AAIFluentTypeBuilder.network().genericVnf("test-genericVnf-id").vfModule("test-vfModule-id"))))
+ .thenReturn(wrapper);
+
+ aaiHelper.setAAIResourcesClient(aaiResourcesClient);
// Arrange
Server server1 = mock(Server.class);
@@ -297,15 +369,15 @@ public class HeatBridgeImplTest {
org.onap.aai.domain.yang.RelationshipList relList = aaiHelper.getVserverRelationshipList(CLOUD_OWNER, REGION_ID,
"test-genericVnf-id", "test-vfModule-id", server1);
- assertEquals(3, relList.getRelationship().size());
+ assertEquals(4, relList.getRelationship().size());
org.onap.aai.domain.yang.RelationshipList relList2 = aaiHelper.getVserverRelationshipList(CLOUD_OWNER,
REGION_ID, "test-genericVnf-id", "test-vfModule-id", server2);
- assertEquals(2, relList2.getRelationship().size());
+ assertEquals(3, relList2.getRelationship().size());
org.onap.aai.domain.yang.RelationshipList relList3 = aaiHelper.getVserverRelationshipList(CLOUD_OWNER,
REGION_ID, "test-genericVnf-id", "test-vfModule-id", server3);
- assertEquals(2, relList3.getRelationship().size());
+ assertEquals(3, relList3.getRelationship().size());
}