aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorshashikanth <shashikanth.vh@huawei.com>2017-09-25 15:02:23 +0530
committershashikanth <shashikanth.vh@huawei.com>2017-09-25 15:02:24 +0530
commit18953088cfedfb0889fcef3746a12d37468f1811 (patch)
treeb8397184604706ba4922f0411f3c39e729b6424a
parent6ae289e48a8d286e357544d4a8dd4b377a8e6993 (diff)
Deleted redundant code
Remove this return statement from this finally block https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=BLOCKER Issue-Id:SO-118 Change-Id: I6933ec089e6030d5fd5495b37f4d785b0935341b Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
-rw-r--r--bpmn/MSOInfrastructureBPMN/src/main/java/org/openecomp/mso/bpmn/infrastructure/workflow/serviceTask/AbstractSdncVlOperationTask.java8
1 files changed, 3 insertions, 5 deletions
diff --git a/bpmn/MSOInfrastructureBPMN/src/main/java/org/openecomp/mso/bpmn/infrastructure/workflow/serviceTask/AbstractSdncVlOperationTask.java b/bpmn/MSOInfrastructureBPMN/src/main/java/org/openecomp/mso/bpmn/infrastructure/workflow/serviceTask/AbstractSdncVlOperationTask.java
index 8b26d01432..212711e5f3 100644
--- a/bpmn/MSOInfrastructureBPMN/src/main/java/org/openecomp/mso/bpmn/infrastructure/workflow/serviceTask/AbstractSdncVlOperationTask.java
+++ b/bpmn/MSOInfrastructureBPMN/src/main/java/org/openecomp/mso/bpmn/infrastructure/workflow/serviceTask/AbstractSdncVlOperationTask.java
@@ -89,23 +89,21 @@ public abstract class AbstractSdncVlOperationTask extends BaseTask {
} catch (Exception e) {
System.out.println(e);
logger.error(MessageEnum.GENERAL_EXCEPTION, " getMsbIp catch exception: ", "", this.getTaskName(), MsoLogger.ErrorCode.UnknownError, e.getClass().toString());
- } finally {
- return defaultValue;
}
+ return defaultValue;
}
private Integer getInteger(DelegateExecution execution, String name, Integer defaultValue) {
Integer vlaue = (Integer) execution.getVariable(name);
try {
- if (vlaue != null && vlaue instanceof Integer) {
+ if (vlaue != null) {
return vlaue;
}
} catch (Exception e) {
System.out.println(e);
logger.error(MessageEnum.GENERAL_EXCEPTION, " getMsbIp catch exception: ", "", this.getTaskName(), MsoLogger.ErrorCode.UnknownError, e.getClass().toString());
- } finally {
- return defaultValue;
}
+ return defaultValue;
}
public String getProcessKey(DelegateExecution execution) {