aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorshashikanth <shashikanth.vh@huawei.com>2017-09-19 17:27:19 +0530
committershashikanth <shashikanth.vh@huawei.com>2017-09-19 17:27:20 +0530
commitab9de38d32244138d1258db9ae7528a1ecd5bdd4 (patch)
treea9926dd86355925806fdaf42ca5af91f3c6bc210
parent7562a302a4856f733fc5a12fddf57a7e9f06ee37 (diff)
Fix Blocker/Critical sonar issues
Fix Blocker/Critical sonar issues in so module https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=BLOCKER Fixed condition that always evaluate to "true" Issue-Id:SO-118 Change-Id: Iceec8653cad6c2ca5dc148644c761075fe207a66 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
-rw-r--r--bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/json/JsonUtils.java4
1 files changed, 1 insertions, 3 deletions
diff --git a/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/json/JsonUtils.java b/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/json/JsonUtils.java
index 9dbd4b171d..d5170af22d 100644
--- a/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/json/JsonUtils.java
+++ b/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/json/JsonUtils.java
@@ -519,9 +519,7 @@ public class JsonUtils {
// String isDebugLogEnabled = "true";
try {
JSONObject jsonObj = new JSONObject(jsonStr);
- if (jsonObj != null) {
- return getJsonValueForKey(jsonObj, key);
- }
+ return getJsonValueForKey(jsonObj, key);
} catch (Exception e) {
msoLogger.debug("getJsonValueForKey(): unable to parse json to retrieve value for field=" + key + ". Exception was: " + e.toString(), e);
}