1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
|
package org.onap.sdnc.northbound;
import static org.junit.Assert.assertEquals;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
import static org.onap.sdnc.northbound.GenericResourceApiProvider.APP_NAME;
import static org.onap.sdnc.northbound.GenericResourceApiProvider.INVALID_INPUT_ERROR_MESSAGE;
import static org.onap.sdnc.northbound.GenericResourceApiProvider.NO_SERVICE_LOGIC_ACTIVE;
import static org.onap.sdnc.northbound.GenericResourceApiProvider.NULL_OR_EMPTY_ERROR_PARAM;
import static org.onap.sdnc.northbound.util.MDSALUtil.build;
import static org.onap.sdnc.northbound.util.MDSALUtil.exec;
import static org.onap.sdnc.northbound.util.MDSALUtil.requestInformation;
import static org.onap.sdnc.northbound.util.MDSALUtil.sdncRequestHeader;
import static org.onap.sdnc.northbound.util.MDSALUtil.securityZoneResponseInformation;
import static org.onap.sdnc.northbound.util.MDSALUtil.securityZoneTopologyOperationInput;
import static org.onap.sdnc.northbound.util.MDSALUtil.securityZoneTopologyOperationOutput;
import static org.onap.sdnc.northbound.util.MDSALUtil.service;
import static org.onap.sdnc.northbound.util.MDSALUtil.serviceData;
import static org.onap.sdnc.northbound.util.MDSALUtil.serviceInformationBuilder;
import static org.onap.sdnc.northbound.util.MDSALUtil.serviceLevelOperStatus;
import static org.onap.sdnc.northbound.util.MDSALUtil.serviceResponseInformation;
import static org.onap.sdnc.northbound.util.MDSALUtil.serviceStatus;
import java.time.Instant;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Mockito;
import org.mockito.runners.MockitoJUnitRunner;
import org.onap.sdnc.northbound.util.PropBuilder;
import org.opendaylight.mdsal.binding.api.DataBroker;
import org.opendaylight.mdsal.binding.api.TransactionChainClosedException;
import org.opendaylight.mdsal.binding.api.WriteTransaction;
import org.opendaylight.mdsal.common.api.LogicalDatastoreType;
import org.opendaylight.yang.gen.v1.org.onap.sdnc.northbound.generic.resource.rev170824.OperStatusData.LastAction;
import org.opendaylight.yang.gen.v1.org.onap.sdnc.northbound.generic.resource.rev170824.OperStatusData.LastOrderStatus;
import org.opendaylight.yang.gen.v1.org.onap.sdnc.northbound.generic.resource.rev170824.OperStatusData.LastRpcAction;
import org.opendaylight.yang.gen.v1.org.onap.sdnc.northbound.generic.resource.rev170824.OperStatusData.OrderStatus;
import org.opendaylight.yang.gen.v1.org.onap.sdnc.northbound.generic.resource.rev170824.SecurityZoneTopologyOperationInput;
import org.opendaylight.yang.gen.v1.org.onap.sdnc.northbound.generic.resource.rev170824.SecurityZoneTopologyOperationOutput;
import org.opendaylight.yang.gen.v1.org.onap.sdnc.northbound.generic.resource.rev170824.request.information.RequestInformation;
import org.opendaylight.yang.gen.v1.org.onap.sdnc.northbound.generic.resource.rev170824.sdnc.request.header.SdncRequestHeader.SvcAction;
import org.opendaylight.yang.gen.v1.org.onap.sdnc.northbound.generic.resource.rev170824.service.data.ServiceData;
import org.opendaylight.yang.gen.v1.org.onap.sdnc.northbound.generic.resource.rev170824.service.information.ServiceInformation;
import org.opendaylight.yang.gen.v1.org.onap.sdnc.northbound.generic.resource.rev170824.service.model.infrastructure.Service;
import org.opendaylight.yangtools.yang.common.RpcResult;
@RunWith(MockitoJUnitRunner.class)
public class SecurityZoneTopologyOperationRPCTest extends GenericResourceApiProviderTest {
private static final String SVC_OPERATION = "security-zone-topology-operation";
@Before
public void setUp() throws Exception {
super.setUp();
svcClient.setScvOperation(SVC_OPERATION);
}
@Test
public void should_fail_when_service_instance_id_not_present() throws Exception {
SecurityZoneTopologyOperationInput input = build(securityZoneTopologyOperationInput());
SecurityZoneTopologyOperationOutput output =
exec(genericResourceApiProvider::securityZoneTopologyOperation, input, RpcResult::getResult);
assertEquals("404", output.getResponseCode());
assertEquals(NULL_OR_EMPTY_ERROR_PARAM, output.getResponseMessage());
assertEquals("Y", output.getAckFinalIndicator());
}
@Test
public void should_fail_when_invalid_service_data() throws Exception {
SecurityZoneTopologyOperationInput input = build(securityZoneTopologyOperationInput()
.setSdncRequestHeader(build(sdncRequestHeader()
.setSvcRequestId("test-svc-request-id")
.setSvcAction(SvcAction.Assign)
))
.setServiceInformation(build(serviceInformationBuilder()
.setServiceInstanceId("test-service-instance-id")
))
);
SecurityZoneTopologyOperationOutput output =
exec(genericResourceApiProvider::securityZoneTopologyOperation, input, RpcResult::getResult);
assertEquals("404", output.getResponseCode());
assertEquals(INVALID_INPUT_ERROR_MESSAGE, output.getResponseMessage());
assertEquals("Y", output.getAckFinalIndicator());
}
@Test
public void should_fail_when_client_execution_failed() throws Exception {
svcClient.mockHasGraph(true);
svcClient.mockExecute(new RuntimeException("test exception"));
SecurityZoneTopologyOperationInput input = build(securityZoneTopologyOperationInput()
.setSdncRequestHeader(build(sdncRequestHeader()
.setSvcRequestId("test-svc-request-id")
.setSvcAction(SvcAction.Assign)
))
.setServiceInformation(build(serviceInformationBuilder()
.setServiceInstanceId("test-service-instance-id")
))
);
persistServiceInDataBroker(input);
SecurityZoneTopologyOperationOutput output =
exec(genericResourceApiProvider::securityZoneTopologyOperation, input, RpcResult::getResult);
assertEquals("500", output.getResponseCode());
assertEquals("test exception", output.getResponseMessage());
assertEquals("Y", output.getAckFinalIndicator());
}
@Test
public void should_fail_when_client_has_no_graph() throws Exception {
svcClient.mockHasGraph(false);
SecurityZoneTopologyOperationInput input = build(securityZoneTopologyOperationInput()
.setSdncRequestHeader(build(sdncRequestHeader()
.setSvcRequestId("test-svc-request-id")
.setSvcAction(SvcAction.Assign)
))
.setServiceInformation(build(serviceInformationBuilder()
.setServiceInstanceId("test-service-instance-id")
))
);
persistServiceInDataBroker(input);
SecurityZoneTopologyOperationOutput output =
exec(genericResourceApiProvider::securityZoneTopologyOperation, input, RpcResult::getResult);
assertEquals("503", output.getResponseCode());
assertEquals(NO_SERVICE_LOGIC_ACTIVE + APP_NAME + ": '" + SVC_OPERATION + "'", output.getResponseMessage());
assertEquals("Y", output.getAckFinalIndicator());
}
@Test
public void should_fail_when_failed_to_update_mdsal() throws Exception {
PropBuilder svcResultProp = svcClient.createExecuteOKResult();
svcClient.mockExecute(svcResultProp);
svcClient.mockHasGraph(true);
WriteTransaction mockWriteTransaction = mock(WriteTransaction.class);
when(mockWriteTransaction.commit()).thenThrow(new TransactionChainClosedException("test exception"));
DataBroker spyDataBroker = Mockito.spy(dataBroker);
when(spyDataBroker.newWriteOnlyTransaction()).thenReturn(mockWriteTransaction);
genericResourceApiProvider.setDataBroker(spyDataBroker);
SecurityZoneTopologyOperationInput input = build(securityZoneTopologyOperationInput()
.setSdncRequestHeader(build(sdncRequestHeader()
.setSvcRequestId("test-svc-request-id")
.setSvcAction(SvcAction.Assign)
))
.setServiceInformation(build(serviceInformationBuilder()
.setServiceInstanceId("test-service-instance-id")
))
);
persistServiceInDataBroker(input);
SecurityZoneTopologyOperationOutput output =
exec(genericResourceApiProvider::securityZoneTopologyOperation, input, RpcResult::getResult);
assertEquals("500", output.getResponseCode());
assertEquals("test exception", output.getResponseMessage());
assertEquals("Y", output.getAckFinalIndicator());
}
@Test
public void should_success_when_no_errors_encountered() throws Exception {
svcClient.mockHasGraph(true);
PropBuilder svcResultProp = svcClient.createExecuteOKResult();
svcResultProp.set("security-zone-object-path", "securityZoneObjectPath: XYZ");
svcClient.mockExecute(svcResultProp);
SecurityZoneTopologyOperationInput input = build(securityZoneTopologyOperationInput()
.setSdncRequestHeader(build(sdncRequestHeader()
.setSvcRequestId("test-svc-request-id")
.setSvcAction(SvcAction.Assign)
))
.setRequestInformation(build(requestInformation()
.setRequestId("test-request-id")
.setRequestAction(RequestInformation.RequestAction.CreateServiceInstance)
))
.setServiceInformation(build(serviceInformationBuilder()
.setServiceInstanceId("test-service-instance-id")
))
);
Service service = persistServiceInDataBroker(input);
SecurityZoneTopologyOperationOutput output =
exec(genericResourceApiProvider::securityZoneTopologyOperation, input, RpcResult::getResult);
assertEquals("200", output.getResponseCode());
assertEquals("OK", output.getResponseMessage());
assertEquals("Y", output.getAckFinalIndicator());
SecurityZoneTopologyOperationOutput expectedOutput = createExpectedOutput(svcResultProp, input);
assertEquals(expectedOutput, output);
Service actualService = db
.read(input.getServiceInformation().getServiceInstanceId(), LogicalDatastoreType.CONFIGURATION);
Service expectedService = createExpectedService(input, service.getServiceData());
assertEquals(expectedService, actualService);
}
private Service persistServiceInDataBroker(SecurityZoneTopologyOperationInput input) throws Exception {
Service service = build(service()
.setServiceInstanceId(input.getServiceInformation().getServiceInstanceId())
.setServiceData(build(serviceData()
.setServiceLevelOperStatus(build(serviceLevelOperStatus()
.setOrderStatus(OrderStatus.Created)
.setModifyTimestamp(Instant.now().toString())
.setLastSvcRequestId(input.getSdncRequestHeader().getSvcRequestId())
.setLastRpcAction(LastRpcAction.Activate)
.setLastOrderStatus(LastOrderStatus.PendingAssignment)
.setLastAction(LastAction.ActivateNetworkInstance)
.setCreateTimestamp(Instant.now().toString())
))
))
);
db.write(true, service, LogicalDatastoreType.CONFIGURATION);
return service;
}
private SecurityZoneTopologyOperationOutput createExpectedOutput(PropBuilder propBuilder,
SecurityZoneTopologyOperationInput input) {
return build(securityZoneTopologyOperationOutput()
.setSecurityZoneResponseInformation(build(securityZoneResponseInformation()
.setObjectPath(propBuilder.get("security-zone-object-path"))))
.setSvcRequestId(input.getSdncRequestHeader().getSvcRequestId())
.setResponseCode(propBuilder.get(svcClient.errorCode))
.setAckFinalIndicator(propBuilder.get(svcClient.ackFinal))
.setResponseMessage(propBuilder.get(svcClient.errorMessage))
.setServiceResponseInformation(build(serviceResponseInformation()
.setInstanceId(input.getServiceInformation().getServiceInstanceId())
.setObjectPath(propBuilder.get(svcClient.serviceObjectPath))
))
);
}
private Service createExpectedService(
SecurityZoneTopologyOperationInput expectedInput, ServiceData expectedServiceData) {
ServiceInformation expectedServiceInformation = expectedInput.getServiceInformation();
return build(service()
.setServiceInstanceId(expectedServiceInformation.getServiceInstanceId())
.setServiceData(build(serviceData()))
.setServiceData(expectedServiceData)
.setServiceStatus(build(serviceStatus()))
);
}
}
|
