aboutsummaryrefslogtreecommitdiffstats
path: root/vnfapi/provider/src
AgeCommit message (Collapse)AuthorFilesLines
2019-03-07Add test cases for vnf-apiTimoney, Dan (dt5972)3-28/+471
Added additional jUnit test cases for vnf-api to test all actions of vnf-instance-topology-operations and vf-module-topology-operations. Change-Id: I41a4ec03805c4ede678b78fd72139f2cf1f79be7 Issue-ID: SDNC-687 Signed-off-by: Timoney, Dan (dt5972) <dtimoney@att.com>
2019-02-26Remove unused code in vnfapiTimoney, Dan (dt5972)3-271/+3
vnfapi has code to implement the onDataTreeChanged event, but does not register itself as a listener. This code is not used and is untested, so should be removed. Change-Id: Ide4f2c38c5bb22871cd5f86135f791d5f51ed19b Issue-ID: SDNC-667 Signed-off-by: Timoney, Dan (dt5972) <dtimoney@att.com>
2019-01-18Update sdnc/northbound to support FluorineTimoney, Dan (dt5972)3-94/+126
Update code to support OpenDaylight Fluorine changes. Change-Id: Iec7e5173076419b101d07e3321b1ca93178b6fa7 Issue-ID: SDNC-552 Signed-off-by: Timoney, Dan (dt5972) <dtimoney@att.com>
2018-02-28Nitrogen port : sdnc-northboundTimoney, Dan (dt5972)2-1/+2
Update sdnc/northbound to OpenDaylight Nitrogen release. Change-Id: I6e299418a7ab441899b78b5d3df5f8ee96829222 Issue-ID: SDNC-269 Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
2018-02-27Add tests to VnfApiProvider part 5pawel.kadlubanski1-17/+78
Write test for function vnfInstanceTopologyOperation in vnfapiProvider class. Case when svcLogicClient svcLogicClient execute method returns null and there is nor error during transaction writing. Issue-ID: SDNC-267 Change-Id: I8058a2f38bea66fe1c7b6f5dbf24400fef5ab3b8 Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
2018-02-27Add tests to VnfApiProvider part 4pawel.kadlubanski2-173/+250
Write test for function vnfInstanceTopologyOperation in vnfapiProvider class. Case when svcLogicClient svcLogicClient execute method returns null but exception is thrown during transaction writing. Issue-ID: SDNC-267 Change-Id: I28c833938297032eaa717001cae8810ab007e9b7 Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
2018-02-20Add tests to VnfApiProvider part 3pawel.kadlubanski1-0/+33
Write test for function vnfInstanceTopologyOperation in vnfapiProvider class. Case when svcLogicClient svcLogicClient execute method returns not null. Change-Id: Ia00b6d8ce2370920035424c6095e1d31611aaeb1 Issue-ID: SDNC-267 Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
2018-02-20Add tests to VnfApiProvider part 2pawel.kadlubanski1-30/+90
Write test for function vnfInstanceTopologyOperation in vnfapiProvider class. Case when svcLogicClient hasGraph return false. Case when svcLogicClient execute throw SvcLogicException. Case when svcLogicClient execute throw SvcLogicException. Change-Id: I6f65049e7567ae1d0fd9eccf7f8c1f35deb3c482 Issue-ID: SDNC-267 Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
2018-02-19Refactoring VnfApiProvider part 1pawel.kadlubanski2-27/+41
Move VnfInstanceTopologyOperationInput validation from vnfInstanceTopologyOperation to seperate method. Change-Id: I56e3999a92323c745f6d0aa8b4417b9e7acb277a Issue-ID: SDNC-268 Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
2018-02-19Add tests to VnfApiProvider part 1pawel.kadlubanski1-2/+62
Write test for function vnfInstanceTopologyOperation in vnfapiProvider class. Case when VnfInstanceTopologyOperationInput is null. Case when VnfInstanceTopologyOperationInput is not null but VnfInstanceRequestInformation is null. Case when VnfInstanceId in VnfInstanceRequestInformation is null. Change-Id: Icc778544a9e7a80600e54a2dcd87b77d11a23121 Issue-ID: SDNC-267 Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
2018-02-14Improve code metricspawel.kadlubanski1-90/+69
Resolve nested try block identified by Sonar as in class vnfapiProvider fixes Define a constant instead of duplicating literals identified by Sonar in class vnfapiProvider fixes Change-Id: I584dfb104ee6f506ef063bb83d00beb11b1f971f Issue-ID: SDNC-243 Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
2018-02-06Fixed some sonar minors in VnfApiProviderJakub Dudycz1-161/+157
Change-Id: Ia9ed74f4c5dfab36c083b887191d9acca817eec8 Issue-ID: SDNC-247 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-05Improve code metricspawel.kadlubanski1-140/+141
Change variable name identified by Sonar as issue in class vnfapiProvider fixes Change-Id: I98965aeb8f64e06d7e2f5d5ff7eca7a9f2ddd22f Issue-ID: SDNC-243 Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
2018-02-02Improve code metricspawel.kadlubanski1-57/+14
Improve code issued identified by Sonar in class vnfapiProvider fixes Change-Id: I7a28380920385f5644eb41767f68d7ae1e176473 Issue-ID: SDNC-243 Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
2018-01-30Fixed sonar errors to line 1224Jakub Dudycz1-362/+297
Change-Id: I973460d2a34818294280cae7b44a285448672bdf Issue-ID: SDNC-242 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-01-30Fixed sonar errors to line 463Jakub Dudycz4-119/+150
Change-Id: Ib3c5a2e872fd47585dca1df49237206e968760e0 Issue-ID: SDNC-242 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2017-12-20Resolve duplicate file nameDan Timoney1-1/+1
Renamed vnfapiProviderTest.java to VnfapiProviderTestBase.java to avoid conflict with VnfapiProviderTest.java Change-Id: I500785a038691c17b84faac427232da2f9fdee21 Issue-ID: SDNC-228 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-11-22Deleting missing vnf-list entry cause infiniteLoopJoey Sullivan7-11/+662
Deleting a vnf-list entry that does not exist from the databoker throws a ModifiedNodeDoesNotExistException. This conflicted with the optimistic locking retry mechanism causing a infinite loop. Change-Id: I216a31eabf710ed365c8d928e4df0e866848eeca Issue-ID: SDNC-156 Signed-off-by: Joey Sullivan <joey.sullivan@amdocs.com>
2017-11-14Fix preload-network-topology-operation err msgsMarcus G K Williams2-12/+13
Issue-Id: SDNC-145 Change-Id: Ibf4fe3101b278ad3dee7632863eb10f4b4c88e48 Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2017-10-19Ignore ModifiedNodeDoesNotExistException on deleteDan Timoney1-4/+10
When trying to deleteVnf from operational or config tree, if a ModifiedNodeDoesNotExistException is cause for commit exception it means that the data you are trying to delete does not exist. So you wanted it gone, it's already gone ... log a message at debug level but don't fail the transaction. Change-Id: Iea0f4e78522cc2f437843e2b17080855cd314ea6 Issue-ID: SDNC-137 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-16Add junit test for vnfapiProviderHao Kuang3-843/+2283
(1) added junit test for vnf apiProvider (2) formatted vnfapiProvider via using ONAP java code formatter (3) added license for VnfSdnUtilTest Issue-Id: SDNC-123 Change-Id: Ia0a12003a97331ae790224df14012b48d99af7d5 Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
2017-10-13Sonar coverage vnfapi -VNFSDNSvcLogicServiceClientbeili.zhou2-240/+580
Add Junit test case for VNFSDNSvcLogicServiceClient In VNFSDNSvcLogicServiceClient: - Fix sonarlint issues (remove un-used import and etc) - Changed tab to 4 spaces as per ONAP Java code style Issue-Id: SDNC-123 Change-Id: Id176e915f17ef5fabc6805415f92d60b4c8e95b2 Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
2017-10-13Add junit test for VnfSdnUtilTestHao Kuang3-191/+180
(1) add junit test for vnfSdnUtilTest (2) format VnfSdnUtil.java via using ONAP java code formatter (3) fix some sonar lint issues Issue-Id: SDNC-123 Change-Id: I0e1cd55f67b238d70514a2caf02f4ead7809de31 Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
2017-10-12Fixed vnfapi install issueDan Timoney7-254/+45
Fixed issues with vnfapi install: - Resolved issue installing vnftools by converting to blueprint - Resolved issue not finding RPC implementation of vnfapi by fixing dependency feature vnftools, and by converting vnfapi to blueprint. The root cause in both cases was probably something wrong with the provider configuration, but it was simpler (not to mention more maintainable) to just convert from config to blueprint. Change-Id: I7010a845687673c932457774f3103834d328ab84 Issue-ID: SDNC-119 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-09-25Change "try" to try-with-resourcessurya-huawei1-11/+3
One major issue in sdnc/northbound module *This is done for a guaranteed closing of resource and avoiding the finally block Issue-Id: CCSDK-87 Change-Id: I3ab9119f0b10f47d16864aa3619cc54e069bb9de Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-18Replace deprecated APIs with newer oneGaurav Agrawal5-25/+28
Replace following deprecated API 1) NotificationProviderService replaced with NotificationPublishService 2) InstanceIdentifier<T> toInstance() replace with build() 3) setProperties replaced with setYangMappingProperties Change-Id: I89fba42e88363c5e1e5b23fe272d2754361aee25 Issue-Id: SDNC-89 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-14Set RequestId as MDC in SDNCvaibhav.jain11-0/+15
SDNC dosen't set RequestId as MDC whereas it logs it into the log message as svcRequestId. A change has been made to set RequestId as MDC so that it propagates throughout the flow. Change-Id: I0b66958f3ece2a90e11d2986cfd5bbd0858d27ce Issue-ID: SO-87 Signed-off-by: vaibhav.jain1 <vaibhav.jain1@amdocs.com>
2017-09-08Fix few Blocker/Critical sonar issuesramu.n1-4/+4
Fix few Blocker/Critical sonar issues in sdnc northbound modules https://sonar.onap.org/component_issues?id=org.openecomp.sdnc.northbound%3Asdnc-northbound#resolved=false|severities=BLOCKER%2CCRITICAL Change-Id: I277dd72784a2186acffdd2a7045fecbef528f56b Issue-Id: SDNC-65 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-09-07Fix Blocker/Critical sonar issuesRamu N2-13/+12
Fix Blocker/Critical sonar issues in vnfapi module https://sonar.onap.org/component_issues?id=org.openecomp.sdnc.northbound%3Asdnc-northbound#resolved=false|severities=BLOCKER%2CCRITICAL Issue-Id: SDNC-65 Change-Id: Ie5617b7f40ed1d05eb9657a9686fef4b4c9bec35 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-08-30Update SDNC NB to depend on CCSDKMarcus G K Williams10-3279/+3279
Refactor code to use CCSDK Issue-Id: SDNC-50 Change-Id: If637d1a0609ec5ae9df60939f72eb64888e61e71 Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2017-04-24[SDNC-5] Split listenersDan Timoney9-12/+46
Split dmaap-listener and ueb-listener to separate artifacts Change-Id: I7b1d5b15c8ef850ace75d4da451143ba4062b817 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-03-31[SDNC-5] Rebase sdnc-northboundDan Timoney9-22/+23
Port to OpenDaylight Boron and sync updates since 16.10 Change-Id: I036c5d0bb600b305300e653023caffc83a262604 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-02-15Initial commit for OpenECOMP SDN-C northboundDan Timoney10-0/+3597
Change-Id: Iffe4d4fbcfd21ecbc1000238354094cc064298ce Signed-off-by: Dan Timoney <dtimoney@att.com>