aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-02-19Add tests to VnfApiProvider part 1pawel.kadlubanski1-2/+62
Write test for function vnfInstanceTopologyOperation in vnfapiProvider class. Case when VnfInstanceTopologyOperationInput is null. Case when VnfInstanceTopologyOperationInput is not null but VnfInstanceRequestInformation is null. Case when VnfInstanceId in VnfInstanceRequestInformation is null. Change-Id: Icc778544a9e7a80600e54a2dcd87b77d11a23121 Issue-ID: SDNC-267 Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
2018-02-15Merge "Improve code metrics"Dan Timoney1-90/+69
2018-02-14Improve code metricspawel.kadlubanski1-90/+69
Resolve nested try block identified by Sonar as in class vnfapiProvider fixes Define a constant instead of duplicating literals identified by Sonar in class vnfapiProvider fixes Change-Id: I584dfb104ee6f506ef063bb83d00beb11b1f971f Issue-ID: SDNC-243 Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
2018-02-07GenericResourceApiProvider fixes part 6Jakub Dudycz1-168/+341
Fixed most of cyclomatic complexity related sonar issues by method extraction Change-Id: I539ed3db1a162e4e6c96917aa37faad035ff41fe Issue-ID: SDNC-248 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-07GenericResourceApiProvider fixes part 5Jakub Dudycz1-1837/+1961
Code reformat only Change-Id: Iee35caa38ab893f0f347a8d6d61072c88a585b9e Issue-ID: SDNC-248 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-07GenericResourceApiProvider fixes part 4Jakub Dudycz1-280/+148
Handled code duplicates Change-Id: I34621242eb68d1956b39e62a5b348a90ce3dfad5 Issue-ID: SDNC-248 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-07GenericResourceApiProvider fixes part 3Jakub Dudycz1-217/+162
Handled some of the issues identified by sonar Change-Id: Iaddc1f86c6a0c54aa8d838b7608106bf1c2cbb09 Issue-ID: SDNC-248 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-07GenericResourceApiProvider fixes part 2Jakub Dudycz1-282/+223
Handled some of the issues identified by sonar Change-Id: I29d36d41499f09a75af099d23948ed661e07aba3 Issue-ID: SDNC-248 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-07GenericResourceApiProvider fixes part 1Jakub Dudycz2-307/+356
Handled some of the issues identified by sonar Change-Id: I1afc0cfd24594f96e0782e79f522d5bba1494881 Issue-ID: SDNC-248 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-06Fixed some sonar minors in VnfApiProviderJakub Dudycz1-161/+157
Change-Id: Ia9ed74f4c5dfab36c083b887191d9acca817eec8 Issue-ID: SDNC-247 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-05Improve code metricspawel.kadlubanski1-140/+141
Change variable name identified by Sonar as issue in class vnfapiProvider fixes Change-Id: I98965aeb8f64e06d7e2f5d5ff7eca7a9f2ddd22f Issue-ID: SDNC-243 Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
2018-02-02Improve code metricspawel.kadlubanski1-57/+14
Improve code issued identified by Sonar in class vnfapiProvider fixes Change-Id: I7a28380920385f5644eb41767f68d7ae1e176473 Issue-ID: SDNC-243 Signed-off-by: pawel.kadlubanski <pawel.kadlubanski@nokia.com>
2018-01-30Fixed sonar errors to line 1224Jakub Dudycz1-362/+297
Change-Id: I973460d2a34818294280cae7b44a285448672bdf Issue-ID: SDNC-242 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-01-30Fixed sonar errors to line 463Jakub Dudycz4-119/+150
Change-Id: Ib3c5a2e872fd47585dca1df49237206e968760e0 Issue-ID: SDNC-242 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2017-12-20Resolve duplicate file nameDan Timoney2-1/+2
Renamed vnfapiProviderTest.java to VnfapiProviderTestBase.java to avoid conflict with VnfapiProviderTest.java Change-Id: I500785a038691c17b84faac427232da2f9fdee21 Issue-ID: SDNC-228 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-11-22Deleting missing vnf-list entry cause infiniteLoopJoey Sullivan8-11/+692
Deleting a vnf-list entry that does not exist from the databoker throws a ModifiedNodeDoesNotExistException. This conflicted with the optimistic locking retry mechanism causing a infinite loop. Change-Id: I216a31eabf710ed365c8d928e4df0e866848eeca Issue-ID: SDNC-156 Signed-off-by: Joey Sullivan <joey.sullivan@amdocs.com>
2017-11-21Bump minor versionJessica Wagantall16-20/+20
Bump minor version in preparation for Amsterdam branching. Change-Id: If5ef8fc3ffb6c819d1c3b8eed0922729997243ef Issue-ID: CIMAN-120 Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
2017-11-15Update version.propertiesv1.2.21.0.0-ONAP1.0.0-AmsterdamDan Timoney1-1/+1
Fix version in version.properties to 1.2.2 Change-Id: I8f2f71f3dac9dc462cff969b2c666c961d3e978a Issue-ID: SDNC-79 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-11-15Roll to next versionDan Timoney15-18/+18
Since release 1.2.1 has already been cut, need to bump version to 1.2.2-SNAPSHOT. Change-Id: I97f293f264082d78d15984c231b67759c3e1006b Issue-ID: SDNC-74 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-11-15Fix VoLTE service delete issueramu.n1-1/+2
In VoLTE use case underlay uses network-topology-operation with svc-action create & delete, during underlay create operation need to update MDSAL OPERATIONAL data store similar to network-topology-operation with activate. Change-Id: I312679244656b4bef514595d1ec724969d44d38f Issue-Id: SDNC-193 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-11-15Rm docs in repo consolidated w/ sdnc/oamRich Bennett8-119/+0
Change-Id: I3e6d9b04c3ce814597d1d3992f947b87d1757f61 Issue-ID: DOC-124 Signed-off-by: Rich Bennett <rb2745@att.com>
2017-11-14Fix preload-network-topology-operation err msgsMarcus G K Williams2-12/+13
Issue-Id: SDNC-145 Change-Id: Ibf4fe3101b278ad3dee7632863eb10f4b4c88e48 Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2017-11-09Roll to version 1.2.1-SNAPSHOTv1.2.1Dan Timoney16-19/+19
Roll to next release version Change-Id: Id1d521317ca37583ed28b2bf60b0411120f13e00 Issue-ID: SDNC-74 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-11-08fix doc8 errorMorgan Richomme1-1/+0
JIRA: SDNC-178 Change-Id: If5fe5ef8564eb8f673b95b058159c8259722c59f Signed-off-by: Morgan Richomme <morgan.richomme@orange.com>
2017-11-04Add DG actions to last-action in GenRes.API YangMarcus G K Williams2-1/+13
Issue-Id: SDNC-171 Change-Id: I913a40c604f9cab4d9eb1be56c53b69aefc4a3bf Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2017-11-03Fix GENERIC-RESOURCE-API yang modelDan Timoney4-243/+543
Add missing enum values and container to yang model Also, BRG and tunnelxconn's service instance parent is VNF-API, not GENERIC-RESOURCE-API, so do not try to retrieve service data. Change-Id: I12c977a7e621ce654d0d5d38f8ac8f3ad95487bd Issue-ID: SDNC-166 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-11-03Update swagger doc for GENERIC-RESOURCE-APIDan Timoney1-403/+653
Update swagger v2.0 doc for GENERIC-RESOURCE-API to reflect changes made for new tunnelxconn assignment Change-Id: I3a298ff36a8eefc0a638dc40531f79137443cc56 Issue-ID: SDNC-160 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-11-01New tunnelxconn assignmentDan Timoney1-15/+23
Add new assignment (vg-ip) to tunnelxconn assignments container Change-Id: Ib9439ceb440b508007104b0a8452a9ae64255354 Issue-ID: SDNC-160 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-30Fix typos in GENERIC-RESOURCE-APIDan Timoney2-2/+2
Updated location of Yang-mapping properties file and fixed typo in Yang model for GENERIC-RESOURCE-API. Change-Id: I379274beefd5673cca5096ff3769b552e0475535 Issue-ID: SDNC-151 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-27Add offered apis to sdnc/northbound docDan Timoney1-0/+2
Add links to swagger docs to SDNC Northbound offered APIs Change-Id: I40def203f5748453e5fea6edfb3f2ec0e242f563 Issue-ID: SDNC-72 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-25Use version 0.1.0 of parentDan Timoney1-1/+1
Update to use version 0.1.0 (released version) of parent pom Change-Id: I3d03456167e0b9467ae068a91c22a95c58f0c4ee Issue-ID: SDNC-74 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-23Create a Junit test for NetworkTopologyOperationJoey Sullivan6-92/+361
This test verifies NetworkTopologyOperation RPC executes a DG then produces the expected NetworkTopologyOperationOutput and persisted the expected Service in the DataBroker. In addition util classes were updated to make it easier to write additional MDSAL test in the future. Change-Id: Icf099c0dbf4445fb5d3e5b009a8cb6e8ca7200cb Issue-ID: SDNC-101 Signed-off-by: Joey Sullivan <joey.sullivan@amdocs.com>
2017-10-19Create a Junit test for ServiceTopologyOperationJoey Sullivan9-79/+638
This test verifies ServiceTopologyOperation RPC executes a DG then produces the expected ServiceTopologyOperationOutput and persisted the expected Service in the DataBroker. In addition util classes were written to make it easier to write additional MDSAL test in the future. Change-Id: I2281099df767397b628ec2caff06f3dd49962b8b Issue-ID: SDNC-101 Signed-off-by: Joey Sullivan <joey.sullivan@amdocs.com>
2017-10-19Ignore ModifiedNodeDoesNotExistException on deleteDan Timoney2-5/+11
When trying to deleteVnf from operational or config tree, if a ModifiedNodeDoesNotExistException is cause for commit exception it means that the data you are trying to delete does not exist. So you wanted it gone, it's already gone ... log a message at debug level but don't fail the transaction. Change-Id: Iea0f4e78522cc2f437843e2b17080855cd314ea6 Issue-ID: SDNC-137 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-17Fix vnftools load issuesDan Timoney4-76/+6
Fixed 2 issues that prevented vnftools from loading: 1) Added org.onap.ccsdk.* to Import-Package in provider manifest (needed to resolve path to SvcLogicJavaPlugin) 2) Removed useless Properties arg from VnfTools constructor Change-Id: Iba8213710d012836a7a70fca07c7c232a3b7b539 Issue-ID: SDNC-132 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-16Add junit test for vnfapiProviderHao Kuang3-843/+2283
(1) added junit test for vnf apiProvider (2) formatted vnfapiProvider via using ONAP java code formatter (3) added license for VnfSdnUtilTest Issue-Id: SDNC-123 Change-Id: Ia0a12003a97331ae790224df14012b48d99af7d5 Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
2017-10-13Sonar coverage vnfapi -VNFSDNSvcLogicServiceClientbeili.zhou2-240/+580
Add Junit test case for VNFSDNSvcLogicServiceClient In VNFSDNSvcLogicServiceClient: - Fix sonarlint issues (remove un-used import and etc) - Changed tab to 4 spaces as per ONAP Java code style Issue-Id: SDNC-123 Change-Id: Id176e915f17ef5fabc6805415f92d60b4c8e95b2 Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
2017-10-13Sonar coverage - GenericResourceApi providerbeili.zhou2-122/+318
Add Junit test case for GenericResourceApiSvcLogicServiceClient In GenericResourceApiSvcLogicServiceClient: - Fix sonarlint issues (remove un-used import and etc) - Changed tab to 4 spaces as per ONAP Java code style Issue-Id: SDNC-101 Change-Id: I789d20a749f8daa4d6b626fedef6a9bb904bae2e Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
2017-10-13Merge "Add junit test for VnfSdnUtilTest"Dan Timoney4-191/+195
2017-10-13Add junit test for VnfSdnUtilTestHao Kuang4-191/+195
(1) add junit test for vnfSdnUtilTest (2) format VnfSdnUtil.java via using ONAP java code formatter (3) fix some sonar lint issues Issue-Id: SDNC-123 Change-Id: I0e1cd55f67b238d70514a2caf02f4ead7809de31 Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
2017-10-13Merge "Fix installation issues with generic-resource-api"Marcus Williams14-1742/+1382
2017-10-13Fix installation issues with generic-resource-apiDan Timoney14-1742/+1382
Updated generic-resource-api to use Aries blueprint to install and resolved issues preventing it from installing properly in karaf. Change-Id: Iaef8bdb7a9e6aaf149a8e8a0d847197cf3f704a9 Issue-ID: SDNC-109 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-12Sonar coverage vnftools - VnfToolsbeili.zhou3-180/+367
Add junit test cases for VnfTools class In VnfTools: - Fix sonarlint issues (remove un-used private method and etc) - Changed tab to 4 spaces as per ONAP Java code style Issue-Id: SDNC-122 Change-Id: If216f53c8ffa7b646f6ebf18d4b9568cfdf4683b Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
2017-10-12Fixed vnfapi install issueDan Timoney14-431/+138
Fixed issues with vnfapi install: - Resolved issue installing vnftools by converting to blueprint - Resolved issue not finding RPC implementation of vnfapi by fixing dependency feature vnftools, and by converting vnfapi to blueprint. The root cause in both cases was probably something wrong with the provider configuration, but it was simpler (not to mention more maintainable) to just convert from config to blueprint. Change-Id: I7010a845687673c932457774f3103834d328ab84 Issue-ID: SDNC-119 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-12Add readthedocs for sdnc/northboundDan Timoney8-14/+112
Add readthedocs documentation for sdnc/northbound. Change-Id: Iad6b19f8194564807ac5e2b9772a554ab14c2cad Issue-ID: SDNC-72 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-12Use try-with-resource to close filestreamsurya-huawei1-11/+6
*Using try-with-resource here makes sure that the resource is automatically closed and increases code readability Issue-Id: CCSDK-117 Change-Id: Ie923e4540d5be90324104593a1d5fcb1bd501f5c Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-10-10Add missing info to swagger docDan Timoney1-1/+9
Add missing required sections of info in swagger doc for generic-resource-api Change-Id: Iea25ce95d6bc0ae0d0edb7ad9a4f71be0669f231 Issue-ID: SDNC-72 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-10Convert swagger docs to v 2Dan Timoney5-3/+68739
Generate updated swagger specs and convert from swagger 1.2 to 2.0 format. Change-Id: I2d357b903596b3f2341ed5d024465e967fdaa76c Issue-ID: SDNC-72 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-04Added new request-actions for overlayGaurav Agrawal1-0/+2
Added new request-actions for dci overlay activation & deactivation. This is required to differentiate dci activation/deactivation for VoLTE use case from normal network activation/deactivation. Change-Id: I865963b78ae8b8ba3a8173259179013997318e87 Issue-Id: SDNC-110 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-29Fix url for swagger fileBrian Freeman1-2/+2
Issue-ID: SDNC-72 Change-Id: Ia0c1504393ea8d3af00a082e0d265ccaf4bfef82 Signed-off-by: Brian Freeman <bf1936@att.com>