summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-10-19Create a Junit test for ServiceTopologyOperationJoey Sullivan9-79/+638
This test verifies ServiceTopologyOperation RPC executes a DG then produces the expected ServiceTopologyOperationOutput and persisted the expected Service in the DataBroker. In addition util classes were written to make it easier to write additional MDSAL test in the future. Change-Id: I2281099df767397b628ec2caff06f3dd49962b8b Issue-ID: SDNC-101 Signed-off-by: Joey Sullivan <joey.sullivan@amdocs.com>
2017-10-19Ignore ModifiedNodeDoesNotExistException on deleteDan Timoney2-5/+11
When trying to deleteVnf from operational or config tree, if a ModifiedNodeDoesNotExistException is cause for commit exception it means that the data you are trying to delete does not exist. So you wanted it gone, it's already gone ... log a message at debug level but don't fail the transaction. Change-Id: Iea0f4e78522cc2f437843e2b17080855cd314ea6 Issue-ID: SDNC-137 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-17Fix vnftools load issuesDan Timoney4-76/+6
Fixed 2 issues that prevented vnftools from loading: 1) Added org.onap.ccsdk.* to Import-Package in provider manifest (needed to resolve path to SvcLogicJavaPlugin) 2) Removed useless Properties arg from VnfTools constructor Change-Id: Iba8213710d012836a7a70fca07c7c232a3b7b539 Issue-ID: SDNC-132 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-16Add junit test for vnfapiProviderHao Kuang3-843/+2283
(1) added junit test for vnf apiProvider (2) formatted vnfapiProvider via using ONAP java code formatter (3) added license for VnfSdnUtilTest Issue-Id: SDNC-123 Change-Id: Ia0a12003a97331ae790224df14012b48d99af7d5 Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
2017-10-13Sonar coverage vnfapi -VNFSDNSvcLogicServiceClientbeili.zhou2-240/+580
Add Junit test case for VNFSDNSvcLogicServiceClient In VNFSDNSvcLogicServiceClient: - Fix sonarlint issues (remove un-used import and etc) - Changed tab to 4 spaces as per ONAP Java code style Issue-Id: SDNC-123 Change-Id: Id176e915f17ef5fabc6805415f92d60b4c8e95b2 Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
2017-10-13Sonar coverage - GenericResourceApi providerbeili.zhou2-122/+318
Add Junit test case for GenericResourceApiSvcLogicServiceClient In GenericResourceApiSvcLogicServiceClient: - Fix sonarlint issues (remove un-used import and etc) - Changed tab to 4 spaces as per ONAP Java code style Issue-Id: SDNC-101 Change-Id: I789d20a749f8daa4d6b626fedef6a9bb904bae2e Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
2017-10-13Merge "Add junit test for VnfSdnUtilTest"Dan Timoney4-191/+195
2017-10-13Add junit test for VnfSdnUtilTestHao Kuang4-191/+195
(1) add junit test for vnfSdnUtilTest (2) format VnfSdnUtil.java via using ONAP java code formatter (3) fix some sonar lint issues Issue-Id: SDNC-123 Change-Id: I0e1cd55f67b238d70514a2caf02f4ead7809de31 Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
2017-10-13Merge "Fix installation issues with generic-resource-api"Marcus Williams14-1742/+1382
2017-10-13Fix installation issues with generic-resource-apiDan Timoney14-1742/+1382
Updated generic-resource-api to use Aries blueprint to install and resolved issues preventing it from installing properly in karaf. Change-Id: Iaef8bdb7a9e6aaf149a8e8a0d847197cf3f704a9 Issue-ID: SDNC-109 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-12Sonar coverage vnftools - VnfToolsbeili.zhou3-180/+367
Add junit test cases for VnfTools class In VnfTools: - Fix sonarlint issues (remove un-used private method and etc) - Changed tab to 4 spaces as per ONAP Java code style Issue-Id: SDNC-122 Change-Id: If216f53c8ffa7b646f6ebf18d4b9568cfdf4683b Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
2017-10-12Fixed vnfapi install issueDan Timoney14-431/+138
Fixed issues with vnfapi install: - Resolved issue installing vnftools by converting to blueprint - Resolved issue not finding RPC implementation of vnfapi by fixing dependency feature vnftools, and by converting vnfapi to blueprint. The root cause in both cases was probably something wrong with the provider configuration, but it was simpler (not to mention more maintainable) to just convert from config to blueprint. Change-Id: I7010a845687673c932457774f3103834d328ab84 Issue-ID: SDNC-119 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-12Add readthedocs for sdnc/northboundDan Timoney8-14/+112
Add readthedocs documentation for sdnc/northbound. Change-Id: Iad6b19f8194564807ac5e2b9772a554ab14c2cad Issue-ID: SDNC-72 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-12Use try-with-resource to close filestreamsurya-huawei1-11/+6
*Using try-with-resource here makes sure that the resource is automatically closed and increases code readability Issue-Id: CCSDK-117 Change-Id: Ie923e4540d5be90324104593a1d5fcb1bd501f5c Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-10-10Add missing info to swagger docDan Timoney1-1/+9
Add missing required sections of info in swagger doc for generic-resource-api Change-Id: Iea25ce95d6bc0ae0d0edb7ad9a4f71be0669f231 Issue-ID: SDNC-72 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-10Convert swagger docs to v 2Dan Timoney5-3/+68739
Generate updated swagger specs and convert from swagger 1.2 to 2.0 format. Change-Id: I2d357b903596b3f2341ed5d024465e967fdaa76c Issue-ID: SDNC-72 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-04Added new request-actions for overlayGaurav Agrawal1-0/+2
Added new request-actions for dci overlay activation & deactivation. This is required to differentiate dci activation/deactivation for VoLTE use case from normal network activation/deactivation. Change-Id: I865963b78ae8b8ba3a8173259179013997318e87 Issue-Id: SDNC-110 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-29Fix url for swagger fileBrian Freeman1-2/+2
Issue-ID: SDNC-72 Change-Id: Ia0c1504393ea8d3af00a082e0d265ccaf4bfef82 Signed-off-by: Brian Freeman <bf1936@att.com>
2017-09-28Add VNF-API, GEN-RES SWAGGER docBrian Freeman3-1/+15
Issue-ID: SDNC-72 Change-Id: I1a9fcf3fb99668acba6e89ce8b1db9500adb5670 Signed-off-by: Brian Freeman <bf1936@att.com>
2017-09-28Setup ReadTheDocsBrian Freeman1-0/+8
Issue-ID: SDNC-72 Change-Id: Iad42b847700c37d3f1099d6a8cc521141d66dfae Signed-off-by: Brian Freeman <bf1936@att.com>
2017-09-27Merge "Fix VNF-API yang validation issues"Dan Timoney2-582/+592
2017-09-27Merge "Improve SDNC Sonar coverage"Dan Timoney2-8/+143
2017-09-25Improve SDNC Sonar coverageramu.n2-8/+143
Added initial test cases for GENERIC-RESOURCE-APIs Change-Id: I84a0d44210f97b9378ad75cc55919d5d404be6a2 Issue-Id: SDNC-101 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-09-25Change "try" to try-with-resourcessurya-huawei1-11/+3
One major issue in sdnc/northbound module *This is done for a guaranteed closing of resource and avoiding the finally block Issue-Id: CCSDK-87 Change-Id: I3ab9119f0b10f47d16864aa3619cc54e069bb9de Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-22Merge "Remove sdnc-sli version dependency"Dan Timoney2-2/+2
2017-09-22Merge "Fix GENERIC-RESOURCE-API yang validation issues"Dan Timoney1-2/+2
2017-09-21Merge "Refer JUNIT version of parent pom."Marcus Williams1-7/+6
2017-09-21Merge "Add RPCs for vCPE"Dan Timoney3-15/+517
2017-09-21Fix VNF-API yang validation issuesramu.n2-582/+592
when validate VNF-API.yang with "pyang" has some issues Change-Id: I908a6bee90b24614f66df61afccf617a599b58db Issue-Id: SDNC-99 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-09-21Fix GENERIC-RESOURCE-API yang validation issuesramu.n1-2/+2
when validate GENERIC-RESOURCE-API.yang with "pyang" has some issues Change-Id: Ibdc71e5a369a6815766e42667beacc4a262dc196 Issue-Id: SDNC-99 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-09-21Add RPCs for vCPEDan Timoney3-15/+517
Added new RPCs for tunnelxconn and brg RPCs. Change-Id: I036beaad10a8ac1f4c088dffa9a589b7b6bae227 Issue-ID: SDNC-98 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-09-21Refer JUNIT version of parent pom.Gaurav Agrawal1-7/+6
Remove the hardcoded version and rather take from parent pom. Change-Id: Ia146f738af2b447b6164bcf8a6ed7a5700d767d9 Issue-Id: SDNC-97 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-21Change "try" to try-with-resourcessurya-huawei1-12/+4
One major issue in sdnc/northbound module *This is done for a guaranteed closing of resource and not worrying about finally block to close it Issue-Id: CCSDK-87 Change-Id: Ic6ea871cb9fb61cbce24b61d7c434d3404570ae7 Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-19Remove sdnc-sli version dependencyBrian Freeman2-2/+2
Issue-ID: SDNC-86 Change-Id: Iae6f03e1d69840f0c0d2dab97d502eb61b65b149 Signed-off-by: Brian Freeman <bf1936@att.com>
2017-09-18Merge "Replace deprecated APIs with newer one"Dan Timoney5-25/+28
2017-09-19Some minor refinements to generic-resource-apiGaurav Agrawal1-150/+160
Minor refinements to generic-resource-api including: 1) Replace printStackTrace() with log 2) Use built-in string formatting instead of string concatenation 3) Removed redundant ';' after switch statement 4) Change the private method names to follow guidelines to start with lower case 5) Removed redundant null assignment Change-Id: I48eb08f7305aa549b952715615201a13c3458ca4 Issue-Id: SDNC-45 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-18Replace deprecated APIs with newer oneGaurav Agrawal5-25/+28
Replace following deprecated API 1) NotificationProviderService replaced with NotificationPublishService 2) InstanceIdentifier<T> toInstance() replace with build() 3) setProperties replaced with setYangMappingProperties Change-Id: I89fba42e88363c5e1e5b23fe272d2754361aee25 Issue-Id: SDNC-89 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-15Inherit from oparent-odlparentDan Timoney1-1/+1
Update version of root pom to 0.0.2-SNAPSHOT to inherit from oparent-odlparent Change-Id: I5f06b2f0f7d1d78246579f157a589a2886b76c38 Issue-ID: SDNC-32 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-09-15Merge "Set RequestId as MDC in SDNC"Marcus Williams1-0/+15
2017-09-14Set RequestId as MDC in SDNCvaibhav.jain11-0/+15
SDNC dosen't set RequestId as MDC whereas it logs it into the log message as svcRequestId. A change has been made to set RequestId as MDC so that it propagates throughout the flow. Change-Id: I0b66958f3ece2a90e11d2986cfd5bbd0858d27ce Issue-ID: SO-87 Signed-off-by: vaibhav.jain1 <vaibhav.jain1@amdocs.com>
2017-09-13Change openecomp to onap in pom.xmlMarcus G K Williams1-10/+10
Update components to onap. This change should fix sdnc-northbound-master-release-version-java-daily and allow sonar updates. Issue-Id: SDNC-65 Change-Id: Id6ccb9b3d39cddc64f95eb89efb0de6a10b58485 Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2017-09-08Cleanup project's name in SonarJessica Wagantall1-1/+1
The name parameter in the root pom.xml should match the project name in gerrit to reflect consistency in Sonar. Change-Id: I29c6363a2ee4fc65f85a25709aa219ee16897d07 Issue-id: CIMAN-65 Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
2017-09-08Fix few Blocker/Critical sonar issuesramu.n2-8/+19
Fix few Blocker/Critical sonar issues in sdnc northbound modules https://sonar.onap.org/component_issues?id=org.openecomp.sdnc.northbound%3Asdnc-northbound#resolved=false|severities=BLOCKER%2CCRITICAL Change-Id: I277dd72784a2186acffdd2a7045fecbef528f56b Issue-Id: SDNC-65 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-09-07Merge "Enable surefire unit tests"Dan Timoney1-1/+1
2017-09-07Some minor refinements/fixesGaurav Agrawal3-15/+17
Minor refinements to generic-resource-api like sonar issue fix, removal of redundant typecast etc. Change-Id: Ibb52f280847478e589640afb428088f379fab5b3 Issue-Id: SDNC-45 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-07Replace deprecated APIs with newer oneGaurav Agrawal5-16/+20
Replace following deprecated API 1) NotificationProviderService replaced with NotificationPublishService 2) InstanceIdentifier<T> toInstance() replace with build() 3) setProperties replaced with setYangMappingProperties Change-Id: Id3e9f116cb825187bf65cc5ac9d6f49484ab0846 Issue-Id: SDNC-45 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-07Merge "Fix Blocker/Critical sonar issues"Dan Timoney2-13/+12
2017-09-07Update revision no of generic-resource-api.yangGaurav Agrawal4-8/+8
Update the generic-resource-api-provider.yang revision to fall in-line with generic-resource-api.yang, also depicting actual initial version addition date. Issue-Id: SDNC-45 Change-Id: I3193d997fb7261ca1c61eaa61acf949c806e56a4 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-07Fix Blocker/Critical sonar issuesRamu N2-13/+12
Fix Blocker/Critical sonar issues in vnfapi module https://sonar.onap.org/component_issues?id=org.openecomp.sdnc.northbound%3Asdnc-northbound#resolved=false|severities=BLOCKER%2CCRITICAL Issue-Id: SDNC-65 Change-Id: Ie5617b7f40ed1d05eb9657a9686fef4b4c9bec35 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-09-06Enable surefire unit testsMarcus G K Williams1-1/+1
Issue-Id: SDNC-65 Change-Id: I6bd2a5e1fe8aac68c160c1e481106aa507dc67e1 Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>