diff options
author | Dan Timoney <dtimoney@att.com> | 2022-08-03 11:59:43 -0400 |
---|---|---|
committer | Dan Timoney <dtimoney@att.com> | 2022-08-05 16:10:18 -0400 |
commit | 219b28ed3c3ee23f10d67c9c50583a8bd5a84f3a (patch) | |
tree | e3d5654f7cb1c16d899d652ab25c97992bf635b6 /generic-resource-api/provider/src/test/java/org/onap/sdnc/northbound/PnfTopologyOperationRPCTest.java | |
parent | 2b1dc5b10650ed62f71d4b84ef662b59ed663fc1 (diff) |
Changes to support ODL Sulfur update
Changes to sdnc/northbound to conform to changes in OpenDaylight Sulfur
release. Many of these changes are due to a change in yangtools, which
no longer implements a common ancestor for its builder classes. This broke
a utility method used in jUnit test cases (build()), which meant all
jUnits using that method had to be updated to call each individual
builder's build() method directly.
Issue-ID: CCSDK-1728
Signed-off-by: Dan Timoney <dtimoney@att.com>
Change-Id: Ia82aa3decd82d873120dd643a6a0427928890f99
Diffstat (limited to 'generic-resource-api/provider/src/test/java/org/onap/sdnc/northbound/PnfTopologyOperationRPCTest.java')
-rw-r--r-- | generic-resource-api/provider/src/test/java/org/onap/sdnc/northbound/PnfTopologyOperationRPCTest.java | 90 |
1 files changed, 42 insertions, 48 deletions
diff --git a/generic-resource-api/provider/src/test/java/org/onap/sdnc/northbound/PnfTopologyOperationRPCTest.java b/generic-resource-api/provider/src/test/java/org/onap/sdnc/northbound/PnfTopologyOperationRPCTest.java index 29d48857..57d218ec 100644 --- a/generic-resource-api/provider/src/test/java/org/onap/sdnc/northbound/PnfTopologyOperationRPCTest.java +++ b/generic-resource-api/provider/src/test/java/org/onap/sdnc/northbound/PnfTopologyOperationRPCTest.java @@ -6,7 +6,6 @@ import static org.mockito.Mockito.when; import static org.onap.sdnc.northbound.GenericResourceApiProvider.APP_NAME; import static org.onap.sdnc.northbound.GenericResourceApiProvider.NO_SERVICE_LOGIC_ACTIVE; import static org.onap.sdnc.northbound.GenericResourceApiProvider.NULL_OR_EMPTY_ERROR_PARAM; -import static org.onap.sdnc.northbound.util.MDSALUtil.build; import static org.onap.sdnc.northbound.util.MDSALUtil.exec; import static org.onap.sdnc.northbound.util.MDSALUtil.pnfDetailsBuilder; import static org.onap.sdnc.northbound.util.MDSALUtil.pnfResponseInformation; @@ -46,7 +45,7 @@ public class PnfTopologyOperationRPCTest extends GenericResourceApiProviderTest @Test public void should_fail_when_service_info_not_present() throws Exception { - PnfTopologyOperationInput input = build(pnfTopologyOperationInput()); + PnfTopologyOperationInput input = pnfTopologyOperationInput().build(); PnfTopologyOperationOutput output = exec(genericResourceApiProvider::pnfTopologyOperation, input, RpcResult::getResult); @@ -82,14 +81,13 @@ public class PnfTopologyOperationRPCTest extends GenericResourceApiProviderTest svcClient.mockHasGraph(true); svcClient.mockExecute(new RuntimeException("test exception")); - PnfTopologyOperationInput input = build(pnfTopologyOperationInput() - .setServiceInformation(build(serviceInformationBuilder() - .setServiceInstanceId("test-service-instance-id") - )) - .setPnfDetails(build(pnfDetailsBuilder() - .setPnfId("test-pnf-id") - )) - ); + PnfTopologyOperationInput input = pnfTopologyOperationInput() + .setServiceInformation(serviceInformationBuilder() + .setServiceInstanceId("test-service-instance-id").build() + ) + .setPnfDetails(pnfDetailsBuilder() + .setPnfId("test-pnf-id").build() + ).build(); PnfTopologyOperationOutput output = exec(genericResourceApiProvider::pnfTopologyOperation, input, RpcResult::getResult); @@ -104,14 +102,13 @@ public class PnfTopologyOperationRPCTest extends GenericResourceApiProviderTest svcClient.mockHasGraph(false); - PnfTopologyOperationInput input = build(pnfTopologyOperationInput() - .setServiceInformation(build(serviceInformationBuilder() - .setServiceInstanceId("test-service-instance-id") - )) - .setPnfDetails(build(pnfDetailsBuilder() - .setPnfId("test-pnf-id") - )) - ); + PnfTopologyOperationInput input = pnfTopologyOperationInput() + .setServiceInformation(serviceInformationBuilder() + .setServiceInstanceId("test-service-instance-id").build() + ) + .setPnfDetails(pnfDetailsBuilder() + .setPnfId("test-pnf-id").build() + ).build(); PnfTopologyOperationOutput output = exec(genericResourceApiProvider::pnfTopologyOperation, input, RpcResult::getResult); @@ -134,14 +131,13 @@ public class PnfTopologyOperationRPCTest extends GenericResourceApiProviderTest when(spyDataBroker.newWriteOnlyTransaction()).thenReturn(mockWriteTransaction); genericResourceApiProvider.setDataBroker(spyDataBroker); - PnfTopologyOperationInput input = build(pnfTopologyOperationInput() - .setServiceInformation(build(serviceInformationBuilder() - .setServiceInstanceId("test-service-instance-id") - )) - .setPnfDetails(build(pnfDetailsBuilder() - .setPnfId("test-pnf-id") - )) - ); + PnfTopologyOperationInput input = pnfTopologyOperationInput() + .setServiceInformation(serviceInformationBuilder() + .setServiceInstanceId("test-service-instance-id").build() + ) + .setPnfDetails(pnfDetailsBuilder() + .setPnfId("test-pnf-id").build() + ).build(); PnfTopologyOperationOutput output = exec(genericResourceApiProvider::pnfTopologyOperation, input, RpcResult::getResult); @@ -158,22 +154,21 @@ public class PnfTopologyOperationRPCTest extends GenericResourceApiProviderTest PropBuilder svcResultProp = svcClient.createExecuteOKResult(); svcClient.mockExecute(svcResultProp); - PnfTopologyOperationInput input = build(pnfTopologyOperationInput() - .setSdncRequestHeader(build(sdncRequestHeader() + PnfTopologyOperationInput input = pnfTopologyOperationInput() + .setSdncRequestHeader(sdncRequestHeader() .setSvcRequestId("test-svc-request-id") - .setSvcAction(SvcAction.Assign) - )) - .setRequestInformation(build(requestInformation() + .setSvcAction(SvcAction.Assign).build() + ) + .setRequestInformation(requestInformation() .setRequestId("test-request-id") - .setRequestAction(RequestInformation.RequestAction.CreateServiceInstance) - )) - .setServiceInformation(build(serviceInformationBuilder() - .setServiceInstanceId("test-service-instance-id") - )) - .setPnfDetails(build(pnfDetailsBuilder() - .setPnfId("test-pnf-id") - )) - ); + .setRequestAction(RequestInformation.RequestAction.CreateServiceInstance).build() + ) + .setServiceInformation(serviceInformationBuilder() + .setServiceInstanceId("test-service-instance-id").build() + ) + .setPnfDetails(pnfDetailsBuilder() + .setPnfId("test-pnf-id").build() + ).build(); PnfTopologyOperationOutput output = exec(genericResourceApiProvider::pnfTopologyOperation, input, RpcResult::getResult); @@ -189,20 +184,19 @@ public class PnfTopologyOperationRPCTest extends GenericResourceApiProviderTest private PnfTopologyOperationOutput createExpectedOutput(PropBuilder svcResultProp, PnfTopologyOperationInput pnfTopologyOperationInput) { - return build( + return pnfTopologyOperationOutput() .setSvcRequestId(pnfTopologyOperationInput.getSdncRequestHeader().getSvcRequestId()) .setResponseCode(svcResultProp.get(svcClient.errorCode)) .setAckFinalIndicator(svcResultProp.get(svcClient.ackFinal)) .setResponseMessage(svcResultProp.get(svcClient.errorMessage)) - .setServiceResponseInformation(build(serviceResponseInformation() + .setServiceResponseInformation(serviceResponseInformation() .setInstanceId(pnfTopologyOperationInput.getServiceInformation().getServiceInstanceId()) - .setObjectPath(svcResultProp.get(svcClient.serviceObjectPath)) - )) - .setPnfResponseInformation(build(pnfResponseInformation() + .setObjectPath(svcResultProp.get(svcClient.serviceObjectPath)).build() + ) + .setPnfResponseInformation(pnfResponseInformation() .setInstanceId(pnfTopologyOperationInput.getPnfDetails().getPnfId()) - .setObjectPath(svcResultProp.get(svcClient.pnfObjectPath)) - )) - ); + .setObjectPath(svcResultProp.get(svcClient.pnfObjectPath)).build() + ).build(); } } |