aboutsummaryrefslogtreecommitdiffstats
path: root/openecomp-be/lib/openecomp-sdc-logging-lib/openecomp-sdc-logging-core/src/test/java/org/openecomp/sdc/logging/slf4j/SLF4JLoggerWrapperTest.java
blob: f4a29efe8b279f52cbcf01e82813b9bcc806f9a7 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
/*
 * Copyright © 2016-2018 European Support Limited
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package org.openecomp.sdc.logging.slf4j;

import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertNotNull;
import static org.testng.Assert.assertNull;

import java.lang.reflect.InvocationHandler;
import java.lang.reflect.Method;
import java.lang.reflect.Proxy;
import java.util.Arrays;
import java.util.Map;
import org.openecomp.sdc.logging.api.AuditData;
import org.openecomp.sdc.logging.api.MetricsData;
import org.openecomp.sdc.logging.api.StatusCode;
import org.slf4j.Logger;
import org.slf4j.MDC;
import org.slf4j.Marker;
import org.testng.annotations.Test;

/**
 * Unit-test of SLF4J implementation of Logger.
 *
 * @author evitaliy
 * @since 05 Mar 18
 */
@SuppressWarnings("CheckStyle")
public class SLF4JLoggerWrapperTest {

    @Test
    public void auditDoesNotFailWhenInputNull() {
        new SLF4JLoggerWrapper(this.getClass()).audit(null);
    }

    @Test
    public void metricsDoesNotFailWhenInputNull() {
        new SLF4JLoggerWrapper(this.getClass()).metrics((MetricsData) null);
    }

    @Test
    public void auditBeginTimeAvailableWhenPassed() {
        SpyLogger spy = createSpy();
        long start = System.currentTimeMillis();
        new SLF4JLoggerWrapper(spy).audit(AuditData.builder().startTime(start).build());
        assertNotNull(spy.mdc().get(AuditField.BEGIN_TIMESTAMP.asKey()));
    }

    @Test
    public void metricsBeginTimeAvailableWhenPassed() {
        SpyLogger spy = createSpy();
        long start = System.currentTimeMillis();
        new SLF4JLoggerWrapper(spy).metrics(MetricsData.builder().startTime(start).build());
        assertNotNull(spy.mdc().get(MetricsField.BEGIN_TIMESTAMP.asKey()));
    }

    @Test
    public void auditEndTimeAvailableWhenPassed() {
        SpyLogger spy = createSpy();
        long end = System.currentTimeMillis();
        new SLF4JLoggerWrapper(spy).audit(AuditData.builder().endTime(end).build());
        assertNotNull(spy.mdc().get(AuditField.END_TIMESTAMP.asKey()));
    }

    @Test
    public void metricsEndTimeAvailableWhenPassed() {
        SpyLogger spy = createSpy();
        long end = System.currentTimeMillis();
        new SLF4JLoggerWrapper(spy).metrics(MetricsData.builder().endTime(end).build());
        assertNotNull(spy.mdc().get(MetricsField.END_TIMESTAMP.asKey()));
    }

    @Test
    public void auditElapsedTimeAvailableWhenPassed() {
        SpyLogger spy = createSpy();
        long start = System.currentTimeMillis();
        new SLF4JLoggerWrapper(spy).audit(AuditData.builder()
                                                   .startTime(start).endTime(start + 777).build());
        assertEquals("777", spy.mdc().get(AuditField.ELAPSED_TIME.asKey()));
    }

    @Test
    public void metricsElapsedTimeAvailableWhenPassed() {
        SpyLogger spy = createSpy();
        long start = System.currentTimeMillis();
        new SLF4JLoggerWrapper(spy).metrics(MetricsData.builder()
                                                       .startTime(start).endTime(start + 1024).build());
        assertEquals("1024", spy.mdc().get(MetricsField.ELAPSED_TIME.asKey()));
    }

    @Test
    public void auditStatusCodeAvailableWhenPassed() {
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).audit(AuditData.builder().statusCode(StatusCode.COMPLETE).build());
        assertEquals(spy.mdc().get(AuditField.STATUS_CODE.asKey()), StatusCode.COMPLETE.name());
    }

    @Test
    public void metricsStatusCodeAvailableWhenPassed() {
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).metrics(MetricsData.builder().statusCode(StatusCode.COMPLETE).build());
        assertEquals(spy.mdc().get(MetricsField.STATUS_CODE.asKey()), StatusCode.COMPLETE.name());
    }

    @Test
    public void auditStatusCodeEmptyWhenNotPassed() {
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).audit(AuditData.builder().build());
        assertNull(spy.mdc().get(AuditField.STATUS_CODE.asKey()));
    }

    @Test
    public void metricsStatusCodeEmptyWhenNotPassed() {
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).metrics(MetricsData.builder().build());
        assertNull(spy.mdc().get(MetricsField.STATUS_CODE.asKey()));
    }

    @Test
    public void auditResponseCodeAvailableWhenPassed() {
        final String responseCode = "AuditSpyResponse";
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).audit(AuditData.builder().responseCode(responseCode).build());
        assertEquals(spy.mdc().get(AuditField.RESPONSE_CODE.asKey()), responseCode);
    }

    @Test
    public void metricsResponseCodeAvailableWhenPassed() {
        final String responseCode = "MetricsSpyResponse";
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).metrics(MetricsData.builder().responseCode(responseCode).build());
        assertEquals(spy.mdc().get(MetricsField.RESPONSE_CODE.asKey()), responseCode);
    }

    @Test
    public void auditResponseCodeEmptyWhenNotPassed() {
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).audit(AuditData.builder().build());
        assertNull(spy.mdc().get(AuditField.RESPONSE_CODE.asKey()));
    }

    @Test
    public void metricsResponseCodeEmptyWhenNotPassed() {
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).metrics(MetricsData.builder().build());
        assertNull(spy.mdc().get(MetricsField.RESPONSE_CODE.asKey()));
    }

    @Test
    public void auditResponseDescriptionAvailableWhenPassed() {
        final String responseDescription = "AuditSpyDescription";
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).audit(AuditData.builder().responseDescription(responseDescription).build());
        assertEquals(spy.mdc().get(AuditField.RESPONSE_DESCRIPTION.asKey()), responseDescription);
    }

    @Test
    public void metricsResponseDescriptionAvailableWhenPassed() {
        final String responseDescription = "MetricsSpyDescription";
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).metrics(MetricsData.builder().responseDescription(responseDescription).build());
        assertEquals(spy.mdc().get(MetricsField.RESPONSE_DESCRIPTION.asKey()), responseDescription);
    }

    @Test
    public void auditResponseDescriptionEmptyWhenNotPassed() {
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).audit(AuditData.builder().build());
        assertNull(spy.mdc().get(AuditField.RESPONSE_DESCRIPTION.asKey()));
    }

    @Test
    public void metricsResponseDescriptionEmptyWhenNotPassed() {
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).metrics(MetricsData.builder().build());
        assertNull(spy.mdc().get(MetricsField.RESPONSE_DESCRIPTION.asKey()));
    }

    @Test
    public void auditClientIpAddressAvailableWhenPassed() {
        final String ipAddress = "10.56.20.20";
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).audit(AuditData.builder().clientIpAddress(ipAddress).build());
        assertEquals(spy.mdc().get(AuditField.CLIENT_IP_ADDRESS.asKey()), ipAddress);
    }

    @Test
    public void metricsClientIpAddressAvailableWhenPassed() {
        final String ipAddress = "10.56.20.22";
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).metrics(MetricsData.builder().clientIpAddress(ipAddress).build());
        assertEquals(spy.mdc().get(MetricsField.CLIENT_IP_ADDRESS.asKey()), ipAddress);
    }

    @Test
    public void auditClientIpAddressEmptyWhenNotPassed() {
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).audit(AuditData.builder().build());
        assertNull(spy.mdc().get(AuditField.CLIENT_IP_ADDRESS.asKey()));
    }

    @Test
    public void metricsClientIpAddressEmptyWhenNotPassed() {
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).metrics(MetricsData.builder().build());
        assertNull(spy.mdc().get(MetricsField.CLIENT_IP_ADDRESS.asKey()));
    }

    @Test
    public void metricsTargetEntityAvailableWhenPassed() {
        final String targetEntity = "MetricsTargetEntity";
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).metrics(MetricsData.builder().targetEntity(targetEntity).build());
        assertEquals(spy.mdc().get(MetricsField.TARGET_ENTITY.asKey()), targetEntity);
    }

    @Test
    public void metricsTargetEntityEmptyWhenNotPassed() {
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).metrics(MetricsData.builder().build());
        assertNull(spy.mdc().get(MetricsField.TARGET_ENTITY.asKey()));
    }

    @Test
    public void metricsTargetVirtualEntityAvailableWhenPassed() {
        final String targetEntity = "MetricsTargetVirtualEntity";
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).metrics(MetricsData.builder().targetVirtualEntity(targetEntity).build());
        assertEquals(spy.mdc().get(MetricsField.TARGET_VIRTUAL_ENTITY.asKey()), targetEntity);
    }

    @Test
    public void metricsTargetVirtualEntityEmptyWhenNotPassed() {
        SpyLogger spy = createSpy();
        new SLF4JLoggerWrapper(spy).metrics(MetricsData.builder().build());
        assertNull(spy.mdc().get(MetricsField.TARGET_VIRTUAL_ENTITY.asKey()));
    }

    interface SpyLogger extends Logger {
        Map<String, String> mdc();
    }

    /**
     * Creates a in instance of Logger that can be used to track MDC changes as part of an invocation of
     * Logger.audit().
     *
     * @return object that implements {@link SpyLogger}
     */
    private static SpyLogger createSpy() {

        // build a dynamic proxy to avoid implementing the long list of Logger methods
        // when we actually need just Logger.info() with the audit marker
        ClassLoader classLoader = Thread.currentThread().getContextClassLoader();
        return SpyLogger.class.cast(
                Proxy.newProxyInstance(classLoader, new Class<?>[]{SpyLogger.class}, new SpyingInvocationHandler()));
    }

    private static class SpyingInvocationHandler implements InvocationHandler {

        private Map<String, String> lastMdc;

        @Override
        public Object invoke(Object proxy, Method method, Object[] args) {

            if (isReturnMdcMethod(method)) {
                return lastMdc;
            }

            if (!isAuditMethod(method, args) && !isMetricsMethod(method, args)) {
                throw new UnsupportedOperationException("Method " + method.getName() + " with arguments "
                        + Arrays.toString(args) + " wasn't supposed to be called");
            }

            storeEffectiveMdc();
            return null;
        }

        private boolean isMetricsMethod(Method method, Object[] args) {
            return isSpecialLogMethod(method, args, Markers.METRICS);
        }

        private boolean isAuditMethod(Method method, Object[] args) {
            return isSpecialLogMethod(method, args, Markers.AUDIT);
        }

        private boolean isSpecialLogMethod(Method method, Object[] args, Marker marker) {
            return method.getName().equals("info") && args.length > 0 && args[0].equals(marker);
        }

        private void storeEffectiveMdc() {
            lastMdc = MDC.getCopyOfContextMap();
        }

        private boolean isReturnMdcMethod(Method method) {
            return method.equals(SpyLogger.class.getDeclaredMethods()[0]);
        }
    }
}