1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
|
package org.openecomp.sdc.be.components.property;
import fj.data.Either;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.ArgumentCaptor;
import org.mockito.Captor;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.MockitoJUnitRunner;
import org.openecomp.sdc.be.components.utils.PropertyDataDefinitionBuilder;
import org.openecomp.sdc.be.dao.utils.MapUtil;
import org.openecomp.sdc.be.datatypes.elements.GetInputValueDataDefinition;
import org.openecomp.sdc.be.datatypes.elements.PropertyDataDefinition;
import org.openecomp.sdc.be.model.*;
import org.openecomp.sdc.be.model.jsontitan.operations.ToscaOperationFacade;
import org.openecomp.sdc.be.model.operations.api.StorageOperationStatus;
import org.openecomp.sdc.be.model.operations.impl.UniqueIdBuilder;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.stream.Collectors;
import java.util.stream.Stream;
import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.when;
@RunWith(MockitoJUnitRunner.class)
public class ComponentInstancePropertyDeclaratorTest extends PropertyDeclaratorTestBase {
@InjectMocks
private ComponentInstancePropertyDeclarator testInstance;
@Mock
private ToscaOperationFacade toscaOperationFacade;
@Captor
private ArgumentCaptor<Map<String, List<ComponentInstanceProperty>>> instancePropertiesCaptor;
@Test
public void declarePropertiesAsInputs_componentInstanceNotExist() {
Component cmpt = new Resource();
Either<List<InputDefinition>, StorageOperationStatus> createdInputs = testInstance.declarePropertiesAsInputs(cmpt, "someCmptInstId", Collections.emptyList());
assertThat(createdInputs.right().value()).isEqualTo(StorageOperationStatus.NOT_FOUND);
verifyZeroInteractions(toscaOperationFacade);
}
@Test
public void declarePropertiesAsInputs_singleNonComplexProperty() {
List<PropertyDataDefinition> properties = Collections.singletonList(prop1);
List<ComponentInstancePropInput> propsToDeclare = createInstancePropInputList(properties);
when(toscaOperationFacade.addComponentInstancePropertiesToComponent(eq(resource), instancePropertiesCaptor.capture())).thenReturn(Either.left(Collections.emptyMap()));
Either<List<InputDefinition>, StorageOperationStatus> createdInputs = testInstance.declarePropertiesAsInputs(resource, "inst1", propsToDeclare);
List<InputDefinition> inputs = createdInputs.left().value();
List<ComponentInstanceProperty> capturedInstanceProperties = instancePropertiesCaptor.getValue().get(INSTANCE_ID);
verifyCreatedInputs(properties, capturedInstanceProperties, inputs);
verifyUpdatedProperties(properties, capturedInstanceProperties, inputs);
}
@Test
public void declarePropertiesAsInputs_multipleNonComplexProperty() {
List<PropertyDataDefinition> properties = Arrays.asList(prop1, prop2);
List<ComponentInstancePropInput> propsToDeclare = createInstancePropInputList(properties);
when(toscaOperationFacade.addComponentInstancePropertiesToComponent(eq(resource), instancePropertiesCaptor.capture())).thenReturn(Either.left(Collections.emptyMap()));
Either<List<InputDefinition>, StorageOperationStatus> createdInputs = testInstance.declarePropertiesAsInputs(resource, "inst1", propsToDeclare);
List<InputDefinition> inputs = createdInputs.left().value();
List<ComponentInstanceProperty> capturedInstanceProperties = instancePropertiesCaptor.getValue().get(INSTANCE_ID);
verifyCreatedInputs(properties, capturedInstanceProperties, inputs);
verifyUpdatedProperties(properties, capturedInstanceProperties, inputs);
}
@Test
public void declarePropertiesAsInputs_singleComplexProperty() {
PropertyDefinition innerProp1 = new PropertyDataDefinitionBuilder()
.setName(INNER_PROP1)
.setValue("true")
.setType("boolean")
.setUniqueId(complexProperty.getType() + ".datatype.ecomp_generated_naming")
.build();
PropertyDefinition innerProp2 = new PropertyDataDefinitionBuilder()
.setName(INNER_PROP2)
.setValue("abc")
.setType("string")
.setUniqueId(complexProperty.getType() + ".datatype.ecomp_generated_naming")
.build();
List<ComponentInstancePropInput> propsToDeclare = createComplexPropInputList(innerProp1, innerProp2);
when(toscaOperationFacade.addComponentInstancePropertiesToComponent(eq(resource), instancePropertiesCaptor.capture())).thenReturn(Either.left(Collections.emptyMap()));
Either<List<InputDefinition>, StorageOperationStatus> createdInputs = testInstance.declarePropertiesAsInputs(resource, "inst1", propsToDeclare);
List<InputDefinition> inputs = createdInputs.left().value();
List<ComponentInstanceProperty> capturedInstanceProperties = instancePropertiesCaptor.getValue().get(INSTANCE_ID);
verifyCreatedInputsFromComplexProperty(propsToDeclare, capturedInstanceProperties, inputs);
verifyUpdatedComplexProperty(capturedInstanceProperties, inputs);
}
private void verifyUpdatedProperties(List<PropertyDataDefinition> properties, List<ComponentInstanceProperty> capturedInstanceProperties, List<InputDefinition> inputs) {
assertThat(capturedInstanceProperties).hasSize(properties.size());
Map<String, ComponentInstanceProperty> updatedPropertiesByName = MapUtil.toMap(capturedInstanceProperties, ComponentInstanceProperty::getName);
properties.forEach(prop -> verifyUpdatedInstanceProperty(prop, updatedPropertiesByName.get(prop.getName()), inputs));
}
private void verifyUpdatedComplexProperty(List<ComponentInstanceProperty> capturedInstanceProperties, List<InputDefinition> inputs) {
assertThat(capturedInstanceProperties).hasSize(1);
verifyUpdatedInstanceComplexProperty(capturedInstanceProperties.get(0), inputs);
}
private void verifyCreatedInputs(List<PropertyDataDefinition> originalPropsToDeclare, List<ComponentInstanceProperty> capturedUpdatedProperties, List<InputDefinition> inputs) {
assertThat(inputs).hasSize(originalPropsToDeclare.size());
Map<String, InputDefinition> propertyIdToCreatedInput = MapUtil.toMap(inputs, InputDefinition::getPropertyId);
originalPropsToDeclare.forEach(propToDeclare -> verifyCreatedInput(propToDeclare, propertyIdToCreatedInput.get(propToDeclare.getUniqueId())));
capturedUpdatedProperties.forEach(updatedProperty -> verifyInputPropertiesList(updatedProperty, propertyIdToCreatedInput.get(updatedProperty.getUniqueId())));
}
private void verifyCreatedInputsFromComplexProperty(List<ComponentInstancePropInput> propsToDeclare, List<ComponentInstanceProperty> capturedInstanceProperties, List<InputDefinition> inputs) {
assertThat(inputs).hasSize(propsToDeclare.size());
Map<String, InputDefinition> inputsByName = MapUtil.toMap(inputs, InputDefinition::getName);
propsToDeclare.forEach(propToDeclare -> verifyCreatedInputFromComplexProperty(propToDeclare, inputsByName));
Map<String, List<InputDefinition>> propertyIdToCreatedInput = MapUtil.groupListBy(inputs, InputDefinition::getPropertyId);
capturedInstanceProperties.forEach(updatedProperty -> verifyInputPropertiesListFromComplexProperty(updatedProperty, propertyIdToCreatedInput.get(updatedProperty.getUniqueId())));
}
private void verifyInputPropertiesListFromComplexProperty(ComponentInstanceProperty updatedProperty, List<InputDefinition> inputs) {
inputs.forEach(input -> verifyInputPropertiesList(updatedProperty, input));
}
private void verifyCreatedInputFromComplexProperty(ComponentInstancePropInput parentProperty, Map<String, InputDefinition> inputsByName) {
PropertyDefinition innerProperty = parentProperty.getInput();
String expectedInputName = generateExpectedInputName(parentProperty, innerProperty);
InputDefinition input = inputsByName.get(expectedInputName);
assertThat(input.getType()).isEqualTo(innerProperty.getType());
assertThat(input.getValue()).isEqualTo(innerProperty.getValue());
// assertThat(input.getDefaultValue()).isEqualTo(innerProperty.getValue());//bug
assertThat(input.getUniqueId()).isEqualTo(UniqueIdBuilder.buildPropertyUniqueId(RESOURCE_ID, input.getName()));
assertThat(input.getPropertyId()).isEqualTo(parentProperty.getUniqueId());
assertThat(input.getInstanceUniqueId()).isEqualTo(INSTANCE_ID);
}
private void verifyInputPropertiesList(ComponentInstanceProperty updatedProperty, InputDefinition input) {
assertThat(input.getProperties()).hasSize(1);
assertThat(updatedProperty).isEqualTo(input.getProperties().get(0));
}
private List<ComponentInstancePropInput> createComplexPropInputList(PropertyDefinition ... innerProperties) {
return Stream.of(innerProperties).map(this::createComplexPropInput).collect(Collectors.toList());
}
private ComponentInstancePropInput createComplexPropInput(PropertyDefinition innerProp) {
ComponentInstancePropInput componentInstancePropInput = new ComponentInstancePropInput(new ComponentInstanceProperty(complexProperty));
componentInstancePropInput.setInput(innerProp);
componentInstancePropInput.setPropertiesName(complexProperty.getName() + "#" + innerProp.getName());
return componentInstancePropInput;
}
private void verifyUpdatedInstanceProperty(PropertyDataDefinition originalProperty, ComponentInstanceProperty updatedProperty, List<InputDefinition> inputs) {
assertThat(updatedProperty.getValue()).isEqualTo(generateGetInputValue(generateExpectedInputName(originalProperty)));
assertThat(updatedProperty.isGetInputProperty()).isTrue();
assertThat(updatedProperty.getName()).isEqualTo(originalProperty.getName());
List<GetInputValueDataDefinition> getInputValues = updatedProperty.getGetInputValues();
verifyGetInputValues(getInputValues, inputs);
}
private void verifyUpdatedInstanceComplexProperty(ComponentInstanceProperty updatedComplexProperty, List<InputDefinition> inputs) {
assertThat(updatedComplexProperty.getValue()).isEqualTo(generateComplexGetInputValue(inputs));
assertThat(updatedComplexProperty.isGetInputProperty()).isTrue();
assertThat(updatedComplexProperty.getName()).isEqualTo(complexProperty.getName());
List<GetInputValueDataDefinition> getInputValues = updatedComplexProperty.getGetInputValues();
verifyGetInputValues(getInputValues, inputs);
}
private void verifyGetInputValues(List<GetInputValueDataDefinition> getInputValues, List<InputDefinition> inputs) {
Map<String, InputDefinition> inputsByName = MapUtil.toMap(inputs, InputDefinition::getName);
getInputValues.forEach(getInputVal -> {
InputDefinition input = inputsByName.get(getInputVal.getInputName());
assertThat(input.getUniqueId()).isEqualTo(getInputVal.getInputId());
});
}
private String generateComplexGetInputValue(List<InputDefinition> createdInputs) {
return String.format("{\"%s\":%s,\"%s\":%s}", INNER_PROP1, generateGetInputValue(createdInputs.get(0).getName()), INNER_PROP2, generateGetInputValue(createdInputs.get(1).getName()));
}
private String generateExpectedInputName(PropertyDataDefinition prop) {
return INSTANCE_ID + "_" + prop.getName();
}
private String generateExpectedInputName(PropertyDefinition parentProp, PropertyDefinition innerProperty) {
return INSTANCE_ID + "_" + parentProp.getName()+ "_" + innerProperty.getName();
}
private void verifyCreatedInput(PropertyDataDefinition property, InputDefinition input) {
assertThat(input.getType()).isEqualTo(property.getType());
assertThat(input.getName()).isEqualTo(generateExpectedInputName(property));
assertThat(input.getValue()).isEqualTo(property.getValue());
assertThat(input.getDefaultValue()).isEqualTo(property.getValue());
assertThat(input.getUniqueId()).isEqualTo(UniqueIdBuilder.buildPropertyUniqueId(RESOURCE_ID, input.getName()));
assertThat(input.getPropertyId()).isEqualTo(property.getUniqueId());
assertThat(input.getInstanceUniqueId()).isEqualTo(INSTANCE_ID);
}
}
|
