1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
|
package org.openecomp.sdc.be.components.impl.version;
import fj.data.Either;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.ArgumentCaptor;
import org.mockito.Captor;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.MockitoJUnitRunner;
import org.openecomp.sdc.be.components.utils.ComponentInstanceBuilder;
import org.openecomp.sdc.be.components.utils.GroupDefinitionBuilder;
import org.openecomp.sdc.be.components.utils.ResourceBuilder;
import org.openecomp.sdc.be.dao.api.ActionStatus;
import org.openecomp.sdc.be.datatypes.elements.GroupDataDefinition;
import org.openecomp.sdc.be.datatypes.enums.ComponentTypeEnum;
import org.openecomp.sdc.be.impl.ComponentsUtils;
import org.openecomp.sdc.be.model.ComponentInstance;
import org.openecomp.sdc.be.model.GroupDefinition;
import org.openecomp.sdc.be.model.Resource;
import org.openecomp.sdc.be.model.jsontitan.operations.GroupsOperation;
import org.openecomp.sdc.be.model.operations.api.StorageOperationStatus;
import java.util.ArrayList;
import java.util.List;
import java.util.stream.Stream;
import static java.util.Collections.emptyMap;
import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.when;
@RunWith(MockitoJUnitRunner.class)
public class GroupMembersUpdateOperationTest {
private static final String CONTAINER_ID = "containerId";
private static final String INSTANCE_ID_PRE_CHANGE = "inst2";
private static final String INSTANCE_ID_POST_CHANGE = "newInst2";
@InjectMocks
private GroupMembersUpdateOperation testInstance;
@Mock
private GroupsOperation groupsOperation;
@Mock
private ComponentsUtils componentsUtils;
@Captor
private ArgumentCaptor<List<GroupDataDefinition>> updatedGroupsCaptor;
private GroupDefinition group1, group2, group3;
private Resource container;
private ComponentInstance prevInst2Version, currInst2Version;
private static final ComponentInstance DONT_CARE = new ComponentInstance();
@Before
public void setUp() throws Exception {
group1 = createGroupWithMembers("group1", "inst1", INSTANCE_ID_PRE_CHANGE);
group2 = createGroupWithMembers("group2", "inst1", "inst2", "inst3");
group3 = createGroupWithMembers("group3", "inst1", "inst3");
container = new ResourceBuilder()
.addGroups(group1)
.addGroups(group2)
.setUniqueId(CONTAINER_ID)
.setComponentType(ComponentTypeEnum.RESOURCE)
.build();
prevInst2Version = new ComponentInstanceBuilder()
.setId(INSTANCE_ID_PRE_CHANGE)
.build();
currInst2Version = new ComponentInstanceBuilder()
.setId(INSTANCE_ID_POST_CHANGE)
.build();
}
@Test
public void whenNoGroupsOnContainer_returnOk() {
ActionStatus actionStatus = testInstance.onChangeVersion(new Resource(), DONT_CARE, DONT_CARE);
assertThat(actionStatus).isEqualTo(ActionStatus.OK);
}
@Test
public void whenEmptyListOfGroups_returnOk() {
Resource resource = new Resource();
resource.setGroups(new ArrayList<>());
ActionStatus actionStatus = testInstance.onChangeVersion(resource, DONT_CARE, DONT_CARE);
assertThat(actionStatus).isEqualTo(ActionStatus.OK);
}
@Test
public void whenGroupsHasNoMembers_returnOk() {
GroupDefinition group1 = new GroupDefinition();
group1.setMembers(emptyMap());
GroupDefinition group2 = new GroupDefinition();
group2.setMembers(emptyMap());
Resource container = new ResourceBuilder()
.addGroups(group1)
.addGroups(group2)
.build();
ComponentInstance prevInstance = new ComponentInstanceBuilder().setId("inst1").build();
ActionStatus actionStatus = testInstance.onChangeVersion(container, prevInstance, DONT_CARE);
assertThat(actionStatus).isEqualTo(ActionStatus.OK);
}
@Test
public void whenPrevInstanceIsNotAMemberOfAnyGroup_returnOk() {
ComponentInstance prevInstance = new ComponentInstanceBuilder().setId("nonMemberInst").build();
ActionStatus actionStatus = testInstance.onChangeVersion(container, prevInstance, DONT_CARE);
assertThat(actionStatus).isEqualTo(ActionStatus.OK);
}
@Test
public void whenGroupHasPrevInstanceAsMember_replaceWithNewInstanceId_updateReplacedGroups() {
verifyAllGroupsHasPrevInstancesAsMembers();
when(groupsOperation.updateGroups(eq(container), updatedGroupsCaptor.capture())).thenReturn(Either.left(null));
ActionStatus actionStatus = testInstance.onChangeVersion(container, prevInst2Version, currInst2Version);
assertThat(actionStatus).isEqualTo(ActionStatus.OK);
verifyGroupWithPrevInstanceMemberWereReplaced();
assertThat(updatedGroupsCaptor.getValue())
.containsExactlyInAnyOrder(group1, group2);
}
@Test
public void whenFailingToUpdateGroups_propagateError() {
when(groupsOperation.updateGroups(eq(container), updatedGroupsCaptor.capture())).thenReturn(Either.right(StorageOperationStatus.NOT_FOUND));
when(componentsUtils.convertFromStorageResponse(StorageOperationStatus.NOT_FOUND, ComponentTypeEnum.RESOURCE)).thenCallRealMethod();
ActionStatus actionStatus = testInstance.onChangeVersion(container, prevInst2Version, currInst2Version);
assertThat(actionStatus).isEqualTo(ActionStatus.RESOURCE_NOT_FOUND);
}
private void verifyGroupWithPrevInstanceMemberWereReplaced() {
assertGroupMembersIds(group1, "inst1", INSTANCE_ID_POST_CHANGE);
assertGroupMembersIds(group2, "inst1", INSTANCE_ID_POST_CHANGE, "inst3");
assertGroupMembersIds(group3, "inst1", "inst3");
}
private void verifyAllGroupsHasPrevInstancesAsMembers() {
assertGroupMembersIds(group1, "inst1", INSTANCE_ID_PRE_CHANGE);
assertGroupMembersIds(group2, "inst1", INSTANCE_ID_PRE_CHANGE, "inst3");
assertGroupMembersIds(group3, "inst1", "inst3");
}
private void assertGroupMembersIds(GroupDefinition group, String ... expectedMembersIds) {
assertThat(group.getMembers())
.containsValues(expectedMembersIds);
}
private GroupDefinition createGroupWithMembers(String groupId, String ... membersIds) {
GroupDefinitionBuilder groupDefinitionBuilder = GroupDefinitionBuilder.create();
Stream.of(membersIds).forEach(memberId -> groupDefinitionBuilder.addMember(memberId + "name", memberId));
groupDefinitionBuilder.setUniqueId(groupId);
return groupDefinitionBuilder.build();
}
}
|
