aboutsummaryrefslogtreecommitdiffstats
path: root/workflow-designer-be/src/test/java/org/onap/sdc/workflow/services/impl/WorkflowManagerImplTest.java
blob: 1db24092843e55f3ea842f53ce481d92c7675b7a (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
/*
 * Copyright © 2016-2018 European Support Limited
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package org.onap.sdc.workflow.services.impl;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.onap.sdc.common.versioning.services.types.VersionStatus.Certified;
import static org.onap.sdc.workflow.TestUtil.createItem;
import static org.onap.sdc.workflow.TestUtil.createWorkflow;
import static org.onap.sdc.workflow.services.types.PagingConstants.DEFAULT_LIMIT;
import static org.onap.sdc.workflow.services.types.PagingConstants.DEFAULT_OFFSET;
import static org.onap.sdc.workflow.services.types.PagingConstants.MAX_LIMIT;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
import java.util.function.Function;
import java.util.stream.Collectors;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.onap.sdc.common.versioning.services.ItemManager;
import org.onap.sdc.common.versioning.services.types.Item;
import org.onap.sdc.common.versioning.services.types.ItemStatus;
import org.onap.sdc.workflow.services.UniqueValueService;
import org.onap.sdc.workflow.services.exceptions.EntityNotFoundException;
import org.onap.sdc.workflow.services.impl.mappers.VersionStateMapper;
import org.onap.sdc.workflow.services.impl.mappers.WorkflowMapper;
import org.onap.sdc.workflow.services.types.ArchivingStatus;
import org.onap.sdc.workflow.services.types.Page;
import org.onap.sdc.workflow.services.types.Paging;
import org.onap.sdc.workflow.services.types.PagingRequest;
import org.onap.sdc.workflow.services.types.RequestSpec;
import org.onap.sdc.workflow.services.types.Sort;
import org.onap.sdc.workflow.services.types.SortingRequest;
import org.onap.sdc.workflow.services.types.Workflow;
import org.onap.sdc.workflow.services.types.WorkflowVersionState;
import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;

@RunWith(SpringJUnit4ClassRunner.class)
public class WorkflowManagerImplTest {


    private static final String ITEM1_ID = "1";
    private static final String WORKFLOW_TYPE = "WORKFLOW";
    private static final String WORKFLOW_NAME_UNIQUE_TYPE = "WORKFLOW_NAME";
    private static final List<Item> ITEMS;
    private static final List<Workflow> MAPPED_WORKFLOWS;
    private static final String SORT_FIELD_NAME = "name";

    static {
        List<Item> items = new ArrayList<>();
        List<Workflow> mappedWorkflows = new ArrayList<>();
        for (int i = 0; i < 5; i++) {
            items.add(createItem(i, true, true, ItemStatus.ACTIVE));
            mappedWorkflows.add(createWorkflow(i, true, ArchivingStatus.ACTIVE));
        }
        ITEMS = Collections.unmodifiableList(items);
        MAPPED_WORKFLOWS = Collections.unmodifiableList(mappedWorkflows);
    }

    @Mock
    private ItemManager itemManagerMock;
    @Mock
    private UniqueValueService uniqueValueServiceMock;
    @Mock
    private WorkflowMapper workflowMapperMock;
    @Mock
    private VersionStateMapper versionStateMapperMock;
    @InjectMocks
    private WorkflowManagerImpl workflowManager;

    @Test
    public void shouldReturnWorkflowVersionList() {
        doReturn(ITEMS).when(itemManagerMock).list(any());
        mockItemToWorkflowMaps();
        RequestSpec requestSpec = createRequestSpec(0, 20, true);
        Page<Workflow> workflows = workflowManager.list(null, null, null, requestSpec);

        Map<String, Workflow> workflowById =
                workflows.getItems().stream().collect(Collectors.toMap(Workflow::getId, Function.identity()));
        assertEquals(ITEMS.size(), workflows.getItems().size());
        for (int i = 0; i < ITEMS.size(); i++) {
            assertTrue(workflowById.containsKey(String.valueOf(i)));
        }
        assertPaging(workflows.getPaging(), requestSpec.getPaging().getOffset(), requestSpec.getPaging().getLimit(),
                ITEMS.size());
    }

    @Test
    public void listWithVersionStateFilter() {
        doReturn(Certified).when(versionStateMapperMock)
                           .workflowVersionStateToVersionStatus(WorkflowVersionState.CERTIFIED);
        doReturn(Arrays.asList(ITEMS.get(0), ITEMS.get(2))).when(itemManagerMock).list(any());
        doReturn(MAPPED_WORKFLOWS.get(0)).when(workflowMapperMock).fromItem(ITEMS.get(0));
        doReturn(MAPPED_WORKFLOWS.get(2)).when(workflowMapperMock).fromItem(ITEMS.get(2));

        RequestSpec requestSpec = createRequestSpec(0, 20, true);
        Page<Workflow> workflows =
                workflowManager.list(null, null, Collections.singleton(WorkflowVersionState.CERTIFIED), requestSpec);

        Map<String, Workflow> workflowById =
                workflows.getItems().stream().collect(Collectors.toMap(Workflow::getId, Function.identity()));
        assertEquals(2, workflows.getItems().size());
        assertTrue(workflowById.containsKey("0"));
        assertTrue(workflowById.containsKey("2"));

        assertPaging(workflows.getPaging(), requestSpec.getPaging().getOffset(), requestSpec.getPaging().getLimit(), 2);
    }

    @Test(expected = EntityNotFoundException.class)
    public void shouldThrowExceptionWhenWorkflowDontExist() {
        Workflow nonExistingWorkflow = new Workflow();
        nonExistingWorkflow.setId(ITEM1_ID);
        doReturn(null).when(itemManagerMock).get(ITEM1_ID);
        workflowManager.get(nonExistingWorkflow);
        verify(workflowMapperMock, times(3)).fromItem(any(Item.class));
    }

    @Test
    public void shouldReturnWorkflow() {
        Item retrievedItem = createItem(1, true, true, ItemStatus.ACTIVE);
        doReturn(retrievedItem).when(itemManagerMock).get(ITEM1_ID);
        Workflow workflow = createWorkflow(1, true, ArchivingStatus.ACTIVE);
        workflowManager.get(workflow);
        verify(itemManagerMock).get(ITEM1_ID);
        verify(workflowMapperMock).fromItem(retrievedItem);
    }

    @Test
    public void shouldCreateWorkflowItemFromWorkflow() {
        Workflow workflowToBeCreated = createWorkflow(1, false, ArchivingStatus.ACTIVE);
        workflowManager.create(workflowToBeCreated);
        verify(itemManagerMock).create(any(Item.class));
        verify(uniqueValueServiceMock).validateUniqueValue(WORKFLOW_NAME_UNIQUE_TYPE, workflowToBeCreated.getName());
    }

    @Test
    public void shouldUpdateWorkflow() {
        Item workflowItem = createItem(1, true, true, ItemStatus.ACTIVE);
        doReturn(workflowItem).when(itemManagerMock).get(ITEM1_ID);
        Workflow workflowToBeUpdated = createWorkflow(1, true, ArchivingStatus.ACTIVE);
        workflowManager.update(workflowToBeUpdated);
        verify(itemManagerMock).update(eq(ITEM1_ID),any(Item.class));
        verify(uniqueValueServiceMock)
                .updateUniqueValue(WORKFLOW_NAME_UNIQUE_TYPE, workflowItem.getName(), workflowToBeUpdated.getName());

    }

    @Test(expected = EntityNotFoundException.class)
    public void shouldThrowExceptionWhenWorkflowToUpdateNotFound() {
        doReturn(null).when(itemManagerMock).get(ITEM1_ID);
        workflowManager.update(createWorkflow(1, true, ArchivingStatus.ACTIVE));
    }

    @Test
    public void listWhenRequestSpecIsNull() {
        doReturn(ITEMS).when(itemManagerMock).list(any());
        mockItemToWorkflowMaps();
        Page<Workflow> workflows = workflowManager.list(null, null, null, null);

        assertEquals(ITEMS.size(), workflows.getItems().size());
        assertPaging(workflows.getPaging(), DEFAULT_OFFSET, DEFAULT_LIMIT, ITEMS.size());

        // verify sorted ascending by name
        for (int i = DEFAULT_OFFSET; i < ITEMS.size(); i++) {
            assertEquals("Workflow_" + i, workflows.getItems().get(i).getName());
        }
    }

    @Test
    public void listWhenPagingIsNull() {
        doReturn(ITEMS).when(itemManagerMock).list(any());
        mockItemToWorkflowMaps();
        Page<Workflow> workflows = workflowManager.list(null, null, null,
                new RequestSpec(null, SortingRequest.builder().sort(new Sort(SORT_FIELD_NAME, true)).build()));

        assertEquals(ITEMS.size(), workflows.getItems().size());
        assertPaging(workflows.getPaging(), DEFAULT_OFFSET, DEFAULT_LIMIT, ITEMS.size());
    }

    @Test
    public void listWhenOffsetAndLimitAreNull() {
        doReturn(ITEMS).when(itemManagerMock).list(any());
        mockItemToWorkflowMaps();
        RequestSpec requestSpec = new RequestSpec(new PagingRequest(-2, -8),
                SortingRequest.builder().sort(new Sort(SORT_FIELD_NAME, true)).build());
        Page<Workflow> workflows = workflowManager.list(null, null, null, requestSpec);

        assertEquals(ITEMS.size(), workflows.getItems().size());
        assertPaging(workflows.getPaging(), DEFAULT_OFFSET, DEFAULT_LIMIT, ITEMS.size());
    }

    @Test
    public void listWhenSortingIsNull() {
        doReturn(ITEMS).when(itemManagerMock).list(any());
        mockItemToWorkflowMaps();
        RequestSpec requestSpec = new RequestSpec(new PagingRequest(2, 8), null);
        Page<Workflow> workflows = workflowManager.list(null, null, null, requestSpec);

        assertEquals(3, workflows.getItems().size());
        assertPaging(workflows.getPaging(), requestSpec.getPaging().getOffset(), requestSpec.getPaging().getLimit(),
                ITEMS.size());

        // verify sorted ascending by name
        assertEquals("Workflow_2", workflows.getItems().get(0).getName());
        assertEquals("Workflow_3", workflows.getItems().get(1).getName());
        assertEquals("Workflow_4", workflows.getItems().get(2).getName());
    }

    @Test
    public void listWhenSortingIsEmpty() {
        doReturn(ITEMS).when(itemManagerMock).list(any());
        mockItemToWorkflowMaps();
        RequestSpec requestSpec = new RequestSpec(new PagingRequest(2, 8), SortingRequest.builder().build());
        Page<Workflow> workflows = workflowManager.list(null, null, null, requestSpec);

        assertEquals(3, workflows.getItems().size());
        assertPaging(workflows.getPaging(), requestSpec.getPaging().getOffset(), requestSpec.getPaging().getLimit(),
                ITEMS.size());

        // verify sorted ascending by name
        assertEquals("Workflow_2", workflows.getItems().get(0).getName());
        assertEquals("Workflow_3", workflows.getItems().get(1).getName());
        assertEquals("Workflow_4", workflows.getItems().get(2).getName());
    }

    @Test
    public void listWhenRequestSpecIsValid() {
        RequestSpec requestSpec = createRequestSpec(0, 5, true);
        doReturn(ITEMS).when(itemManagerMock).list(any());
        mockItemToWorkflowMaps();
        Page<Workflow> workflows = workflowManager.list(null, null, null, requestSpec);

        assertEquals(5, workflows.getItems().size());
        assertPaging(workflows.getPaging(), requestSpec.getPaging().getOffset(), requestSpec.getPaging().getLimit(),
                ITEMS.size());
    }

    @Test
    public void listWhenLimitIsLessThanTotal() {
        RequestSpec requestSpec = createRequestSpec(0, 3, true);
        doReturn(ITEMS).when(itemManagerMock).list(any());
        mockItemToWorkflowMaps();
        Page<Workflow> workflows = workflowManager.list(null, null, null, requestSpec);
        assertEquals(3, workflows.getItems().size());
        assertPaging(workflows.getPaging(), requestSpec.getPaging().getOffset(), requestSpec.getPaging().getLimit(),
                ITEMS.size());
    }


    @Test
    public void listWhenOffsetIsNotFirst() {
        RequestSpec requestSpec = createRequestSpec(3, 1, true);
        doReturn(ITEMS).when(itemManagerMock).list(any());
        mockItemToWorkflowMaps();
        Page<Workflow> workflows = workflowManager.list(null, null, null, requestSpec);
        assertEquals(1, workflows.getItems().size());
        assertPaging(workflows.getPaging(), requestSpec.getPaging().getOffset(), requestSpec.getPaging().getLimit(),
                ITEMS.size());
    }

    @Test
    public void listWhenLimitIsMoreThanTotal() {
        RequestSpec requestSpec = createRequestSpec(0, 10, true);
        doReturn(ITEMS).when(itemManagerMock).list(any());
        mockItemToWorkflowMaps();
        Page<Workflow> workflows = workflowManager.list(null, null, null, requestSpec);
        assertEquals(5, workflows.getItems().size());
        assertPaging(workflows.getPaging(), requestSpec.getPaging().getOffset(), requestSpec.getPaging().getLimit(),
                ITEMS.size());
    }

    @Test
    public void listWhenOffsetIsMoreThanTotal() {
        RequestSpec requestSpec = createRequestSpec(6, 3, true);
        doReturn(ITEMS).when(itemManagerMock).list(any());
        mockItemToWorkflowMaps();
        Page<Workflow> workflows = workflowManager.list(null, null, null, requestSpec);
        assertEquals(0, workflows.getItems().size());
        assertPaging(workflows.getPaging(), requestSpec.getPaging().getOffset(), requestSpec.getPaging().getLimit(),
                ITEMS.size());
    }

    @Test
    public void listWhenOffsetIsMoreThanMax() {
        doReturn(ITEMS).when(itemManagerMock).list(any());
        mockItemToWorkflowMaps();
        RequestSpec requestSpec = createRequestSpec(0, 5555, true);
        Page<Workflow> workflows = workflowManager.list(null, null, null, requestSpec);

        assertEquals(ITEMS.size(), workflows.getItems().size());
        assertPaging(workflows.getPaging(), requestSpec.getPaging().getOffset(), MAX_LIMIT, ITEMS.size());
    }

    @Test
    public void listWhenOffsetAndLimitAreMoreThanTotal() {
        RequestSpec requestSpec = createRequestSpec(10, 10, true);
        doReturn(ITEMS).when(itemManagerMock).list(any());
        mockItemToWorkflowMaps();
        Page<Workflow> workflows = workflowManager.list(null, null, null, requestSpec);
        assertEquals(0, workflows.getItems().size());
        assertPaging(workflows.getPaging(), requestSpec.getPaging().getOffset(), requestSpec.getPaging().getLimit(),
                ITEMS.size());
    }

    @Test
    public void listWhenSortedDesc() {
        RequestSpec requestSpec = createRequestSpec(2, 1, false);
        doReturn(ITEMS).when(itemManagerMock).list(any());
        mockItemToWorkflowMaps();
        Page<Workflow> workflows = workflowManager.list(null, null, null, requestSpec);
        assertEquals(1, workflows.getItems().size());
        assertPaging(workflows.getPaging(), requestSpec.getPaging().getOffset(), requestSpec.getPaging().getLimit(),
                ITEMS.size());
        Iterator<Workflow> workflowIterator = workflows.getItems().iterator();
        assertEquals("Workflow_2", workflowIterator.next().getName());
    }

    private void mockItemToWorkflowMaps() {
        for (int i = 0; i < ITEMS.size(); i++) {
            doReturn(MAPPED_WORKFLOWS.get(i)).when(workflowMapperMock).fromItem(ITEMS.get(i));
        }
    }

    private static RequestSpec createRequestSpec(int offset, int limit, boolean isAscending) {
        return new RequestSpec(new PagingRequest(offset, limit),
                SortingRequest.builder().sort(new Sort(SORT_FIELD_NAME, isAscending)).build());
    }

    private static void assertPaging(Paging paging, int expectedOffset, int expectedLimit, int expectedTotal) {
        assertEquals(expectedOffset, paging.getOffset());
        assertEquals(expectedLimit, paging.getLimit());
        assertEquals(expectedTotal, paging.getTotal());
    }
}