diff options
author | michal.banka <michal.banka@nokia.com> | 2019-07-10 16:14:27 +0200 |
---|---|---|
committer | Tomasz Golabek <tomasz.golabek@nokia.com> | 2019-07-25 10:11:05 +0000 |
commit | d0d5690f13b9c794044bfe6bd7ac87557dd3dcea (patch) | |
tree | 651bf59514a2ec3603e753094e0edae54296dc5c /src/main/java/org/onap/sdc/toscaparser/api/Triggers.java | |
parent | cad897335db0c7912782482fa71932cc2b4ce421 (diff) |
Fix checkstyle violations in sdc/jtosca
Number of checkstyle violations has decreased from about 8200 to 450.
Change-Id: I31f763d7f51fa66958aab68d094280189c612417
Issue-ID: SDC-2434
Signed-off-by: michal.banka <michal.banka@nokia.com>
Diffstat (limited to 'src/main/java/org/onap/sdc/toscaparser/api/Triggers.java')
-rw-r--r-- | src/main/java/org/onap/sdc/toscaparser/api/Triggers.java | 232 |
1 files changed, 115 insertions, 117 deletions
diff --git a/src/main/java/org/onap/sdc/toscaparser/api/Triggers.java b/src/main/java/org/onap/sdc/toscaparser/api/Triggers.java index 91545c2..c78978f 100644 --- a/src/main/java/org/onap/sdc/toscaparser/api/Triggers.java +++ b/src/main/java/org/onap/sdc/toscaparser/api/Triggers.java @@ -7,9 +7,9 @@ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at - * + * * http://www.apache.org/licenses/LICENSE-2.0 - * + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. @@ -28,121 +28,119 @@ import java.util.LinkedHashMap; public class Triggers extends EntityTemplate { - private static final String DESCRIPTION = "description"; - private static final String EVENT = "event_type"; - private static final String SCHEDULE = "schedule"; - private static final String TARGET_FILTER = "target_filter"; - private static final String CONDITION = "condition"; - private static final String ACTION = "action"; - - private static final String SECTIONS[] = { - DESCRIPTION, EVENT, SCHEDULE, TARGET_FILTER, CONDITION, ACTION - }; - - private static final String METER_NAME = "meter_name"; - private static final String CONSTRAINT = "constraint"; - private static final String PERIOD = "period"; - private static final String EVALUATIONS = "evaluations"; - private static final String METHOD = "method"; - private static final String THRESHOLD = "threshold"; - private static final String COMPARISON_OPERATOR = "comparison_operator"; - - private static final String CONDITION_KEYNAMES[] = { - METER_NAME, CONSTRAINT, PERIOD, EVALUATIONS, METHOD, THRESHOLD, COMPARISON_OPERATOR - }; - - private String name; - private LinkedHashMap<String,Object> triggerTpl; - - public Triggers(String _name,LinkedHashMap<String,Object> _triggerTpl) { - super(); // dummy. don't want super - name = _name; - triggerTpl = _triggerTpl; - _validateKeys(); - _validateCondition(); - _validateInput(); - } - - public String getDescription() { - return (String)triggerTpl.get("description"); - } - - public String getEvent() { - return (String)triggerTpl.get("event_type"); - } - - public LinkedHashMap<String,Object> getSchedule() { - return (LinkedHashMap<String,Object>)triggerTpl.get("schedule"); - } - - public LinkedHashMap<String,Object> getTargetFilter() { - return (LinkedHashMap<String,Object>)triggerTpl.get("target_filter"); - } - - public LinkedHashMap<String,Object> getCondition() { - return (LinkedHashMap<String,Object>)triggerTpl.get("condition"); - } - - public LinkedHashMap<String,Object> getAction() { - return (LinkedHashMap<String,Object>)triggerTpl.get("action"); - } - - private void _validateKeys() { - for(String key: triggerTpl.keySet()) { - boolean bFound = false; - for(int i=0; i<SECTIONS.length; i++) { - if(key.equals(SECTIONS[i])) { - bFound = true; - break; - } - } - if(!bFound) { - ThreadLocalsHolder.getCollector().appendValidationIssue(new JToscaValidationIssue("JE249", String.format( - "UnknownFieldError: Triggers \"%s\" contains unknown field \"%s\"", - name,key))); - } - } - } - - private void _validateCondition() { - for(String key: getCondition().keySet()) { - boolean bFound = false; - for(int i=0; i<CONDITION_KEYNAMES.length; i++) { - if(key.equals(CONDITION_KEYNAMES[i])) { - bFound = true; - break; - } - } - if(!bFound) { - ThreadLocalsHolder.getCollector().appendValidationIssue(new JToscaValidationIssue("JE250", String.format( - "UnknownFieldError: Triggers \"%s\" contains unknown field \"%s\"", - name,key))); - } - } - } - - private void _validateInput() { - for(String key: getCondition().keySet()) { - Object value = getCondition().get(key); - if(key.equals(PERIOD) || key.equals(EVALUATIONS)) { - ValidateUtils.validateInteger(value); - } - else if(key.equals(THRESHOLD)) { - ValidateUtils.validateNumeric(value); - } - else if(key.equals(METER_NAME) || key.equals(METHOD)) { - ValidateUtils.validateString(value); - } - } - } - - @Override - public String toString() { - return "Triggers{" + - "name='" + name + '\'' + - ", triggerTpl=" + triggerTpl + - '}'; - } + private static final String DESCRIPTION = "description"; + private static final String EVENT = "event_type"; + private static final String SCHEDULE = "schedule"; + private static final String TARGET_FILTER = "target_filter"; + private static final String CONDITION = "condition"; + private static final String ACTION = "action"; + + private static final String[] SECTIONS = { + DESCRIPTION, EVENT, SCHEDULE, TARGET_FILTER, CONDITION, ACTION + }; + + private static final String METER_NAME = "meter_name"; + private static final String CONSTRAINT = "constraint"; + private static final String PERIOD = "period"; + private static final String EVALUATIONS = "evaluations"; + private static final String METHOD = "method"; + private static final String THRESHOLD = "threshold"; + private static final String COMPARISON_OPERATOR = "comparison_operator"; + + private static final String[] CONDITION_KEYNAMES = { + METER_NAME, CONSTRAINT, PERIOD, EVALUATIONS, METHOD, THRESHOLD, COMPARISON_OPERATOR + }; + + private String name; + private LinkedHashMap<String, Object> triggerTpl; + + public Triggers(String name, LinkedHashMap<String, Object> triggerTpl) { + super(); // dummy. don't want super + this.name = name; + this.triggerTpl = triggerTpl; + validateKeys(); + validateCondition(); + validateInput(); + } + + public String getDescription() { + return (String) triggerTpl.get("description"); + } + + public String getEvent() { + return (String) triggerTpl.get("event_type"); + } + + public LinkedHashMap<String, Object> getSchedule() { + return (LinkedHashMap<String, Object>) triggerTpl.get("schedule"); + } + + public LinkedHashMap<String, Object> getTargetFilter() { + return (LinkedHashMap<String, Object>) triggerTpl.get("target_filter"); + } + + public LinkedHashMap<String, Object> getCondition() { + return (LinkedHashMap<String, Object>) triggerTpl.get("condition"); + } + + public LinkedHashMap<String, Object> getAction() { + return (LinkedHashMap<String, Object>) triggerTpl.get("action"); + } + + private void validateKeys() { + for (String key : triggerTpl.keySet()) { + boolean bFound = false; + for (int i = 0; i < SECTIONS.length; i++) { + if (key.equals(SECTIONS[i])) { + bFound = true; + break; + } + } + if (!bFound) { + ThreadLocalsHolder.getCollector().appendValidationIssue(new JToscaValidationIssue("JE249", String.format( + "UnknownFieldError: Triggers \"%s\" contains unknown field \"%s\"", + name, key))); + } + } + } + + private void validateCondition() { + for (String key : getCondition().keySet()) { + boolean bFound = false; + for (int i = 0; i < CONDITION_KEYNAMES.length; i++) { + if (key.equals(CONDITION_KEYNAMES[i])) { + bFound = true; + break; + } + } + if (!bFound) { + ThreadLocalsHolder.getCollector().appendValidationIssue(new JToscaValidationIssue("JE250", String.format( + "UnknownFieldError: Triggers \"%s\" contains unknown field \"%s\"", + name, key))); + } + } + } + + private void validateInput() { + for (String key : getCondition().keySet()) { + Object value = getCondition().get(key); + if (key.equals(PERIOD) || key.equals(EVALUATIONS)) { + ValidateUtils.validateInteger(value); + } else if (key.equals(THRESHOLD)) { + ValidateUtils.validateNumeric(value); + } else if (key.equals(METER_NAME) || key.equals(METHOD)) { + ValidateUtils.validateString(value); + } + } + } + + @Override + public String toString() { + return "Triggers{" + + "name='" + name + '\'' + + ", triggerTpl=" + triggerTpl + + '}'; + } } /*python |