diff options
| author |   Remigiusz Janeczek <remigiusz.janeczek@nokia.com> | 2021-03-18 10:32:23 +0100 |
|---|---|---|
| committer | Remigiusz Janeczek <remigiusz.janeczek@nokia.com> | 2021-03-18 10:32:23 +0100 |
| commit | 09d2ec0b674d07b01b530ecc48c68132358c4915 (patch) | |
| tree | 6388f20ec5ce5cbd3d384dfa8a039598ed11746e /src/main/java | |
| parent | e0437a4237c99a16955d5ec56ff5fe9996c76b57 (diff) | |
Fix sonar code smells
Issue-ID: SDC-3185
Signed-off-by: Remigiusz Janeczek <remigiusz.janeczek@nokia.com>
Change-Id: Icfb466816c76c0444b7132651038768a832c03a2
Diffstat (limited to 'src/main/java')
3 files changed, 3 insertions, 3 deletions
diff --git a/src/main/java/org/onap/sdc/helmvalidator/helm/validation/BashExecutor.java b/src/main/java/org/onap/sdc/helmvalidator/helm/validation/BashExecutor.java index 0bebc0a..066e731 100644 --- a/src/main/java/org/onap/sdc/helmvalidator/helm/validation/BashExecutor.java +++ b/src/main/java/org/onap/sdc/helmvalidator/helm/validation/BashExecutor.java @@ -36,7 +36,7 @@ import org.springframework.stereotype.Service; public class BashExecutor { private static final Logger LOGGER = LoggerFactory.getLogger( - ValidationService.class); + BashExecutor.class); BashOutput execute(String helmCommand) { diff --git a/src/main/java/org/onap/sdc/helmvalidator/helm/validation/ValidationService.java b/src/main/java/org/onap/sdc/helmvalidator/helm/validation/ValidationService.java index 1e6cedb..02f28a3 100644 --- a/src/main/java/org/onap/sdc/helmvalidator/helm/validation/ValidationService.java +++ b/src/main/java/org/onap/sdc/helmvalidator/helm/validation/ValidationService.java @@ -155,7 +155,7 @@ public class ValidationService { LOGGER.debug("Command executions: {} ", helmCommand); BashOutput chartTemplateResult = executor.execute(helmCommand); - LOGGER.debug("Status code: " + chartTemplateResult.getExitValue()); + LOGGER.debug("Status code: {}", chartTemplateResult.getExitValue()); if (chartTemplateResult.getExitValue() != 0) { List<String> renderingErrors = parseTemplateError(chartTemplateResult.getOutputLines()); return new TemplateValidationResult(false, renderingErrors); diff --git a/src/main/java/org/onap/sdc/helmvalidator/helm/versions/ApiVersionsReader.java b/src/main/java/org/onap/sdc/helmvalidator/helm/versions/ApiVersionsReader.java index e5c1a2e..1c48d20 100644 --- a/src/main/java/org/onap/sdc/helmvalidator/helm/versions/ApiVersionsReader.java +++ b/src/main/java/org/onap/sdc/helmvalidator/helm/versions/ApiVersionsReader.java @@ -61,7 +61,7 @@ public class ApiVersionsReader { BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(tarInput)); return bufferedReader.lines() .filter(chartLine -> chartLine.contains(API_VERSION_PREFIX)) - .map(apiVersionLine -> apiVersionLine.replaceAll(API_VERSION_PREFIX, "")) + .map(apiVersionLine -> apiVersionLine.replace(API_VERSION_PREFIX, "")) .map(String::trim) .findFirst(); } |