1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
|
/*-
* ============LICENSE_START=======================================================
* SDC
* ================================================================================
* Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
* ================================================================================
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
* ============LICENSE_END=========================================================
*/
package org.onap.sdc.security.filters;
import org.apache.http.impl.client.CloseableHttpClient;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Mock;
import org.mockito.junit.MockitoJUnitRunner;
import org.onap.sdc.security.*;
import javax.servlet.http.Cookie;
import java.io.IOException;
import java.security.InvalidParameterException;
import java.util.HashSet;
import static org.junit.Assert.*;
import static org.mockito.Mockito.*;
@RunWith(MockitoJUnitRunner.class)
public class RestrictionAccessFilterTest {
private static final String jsonResponseFromPortal = "{\"orgId\":null,\"managerId\":null,\"firstName\":\"NAME\",\"middleInitial\":null,\"lastName\":\"FAMILY\",\"phone\":null,\"email\":\"abc123@test.com\",\"hrid\":null,\"orgUserId\":\"abc123\",\"orgCode\":null,\"orgManagerUserId\":null,\"jobTitle\":null," +
"\"loginId\":\"abc123\",\"active\":true,\"roles\":[%s]}";
private static final String rolesJson = "{\"id\":\"1234\",\"name\":\"designer\",\"roleFunctions\":[\"read\",\"write\"]}";
private static final String userId = "abc123";
@Mock
private CloseableHttpClient httpClient;
@Mock
private ISessionValidationFilterConfiguration configuration;
@Mock
private ISessionValidationCookieConfiguration cookieConfig;
@Mock
private IUsersThreadLocalHolder threadLocalUtils;
@Mock
private AuthenticationCookie authenticationCookie;
@Mock
private PortalClient portalClient;
private RestrictionAccessFilter filter;
@Before
public void setUp() {
mockCreateFilter(configuration, threadLocalUtils, portalClient);
assertNotNull(filter);
}
private void mockCreateFilter(ISessionValidationFilterConfiguration sessionConfig, IUsersThreadLocalHolder threadLocalUtils, PortalClient portalClient) {
filter = new RestrictionAccessFilter(sessionConfig, threadLocalUtils, portalClient);
}
// @Test(expected = InvalidParameterException.class)
// public void filterConfigurationObjectCreationFailedWhenPropertyIsNotSet() {
// when(configuration.getAuthCookie()).thenReturn(cookieConfig);
// when(cookieConfig.getRedirectURL()).thenReturn("does_not_exist");
// filter = new RestrictionAccessFilter(configuration, portalClient, threadLocalUtils);
// }
@Test (expected = RedirectException.class)
public void authorizeUserOnSessionExpirationWhenUsersDifferent() throws RedirectException {
Cookie[] cookies = new Cookie [1] ;
cookies[0] = new Cookie(RestrictionAccessFilter.CSP_USER_ID, "user1");
filter.authorizeUserOnSessionExpiration(authenticationCookie, cookies);
}
@Test (expected = RedirectException.class)
public void authorizeUserOnSessionExpirationWhenUserRolesDifferent() throws RedirectException, IOException {
when(authenticationCookie.getUserID()).thenReturn(userId);
RestrictionAccessFilter spyFilter2 = spy(filter);
HashSet<String> roles = new HashSet<>();
roles.add("b");
Cookie[] cookies = new Cookie [] {new Cookie(RestrictionAccessFilter.CSP_USER_ID, userId)};
when(authenticationCookie.getRoles()).thenReturn(roles);
spyFilter2.authorizeUserOnSessionExpiration(authenticationCookie, cookies);
}
@Test (expected = RedirectException.class)
public void authorizeUserOnSessionExpirationWhenUserRolesDisappearInCookie() throws RedirectException, IOException {
when(authenticationCookie.getUserID()).thenReturn(userId);
RestrictionAccessFilter spyFilter2 = spy(filter);
HashSet<String> roles = new HashSet<>();
Cookie[] cookies = new Cookie [] {new Cookie(RestrictionAccessFilter.CSP_USER_ID, userId)};
when(authenticationCookie.getRoles()).thenReturn(roles);
spyFilter2.authorizeUserOnSessionExpiration(authenticationCookie, cookies);
}
@Test (expected = RedirectException.class)
public void authorizeUserOnSessionExpirationWhenUserRolesRetrievedFromPortalAndMatch() throws RedirectException, IOException {
when(authenticationCookie.getUserID()).thenReturn(userId);
PortalClient spyFilter = spy(portalClient);
RestrictionAccessFilter spyFilter2 = spy(filter);
HashSet<String> roles = new HashSet<>();
roles.add("DESIGNER");
when(authenticationCookie.getRoles()).thenReturn(roles);
Cookie[] cookies = new Cookie [] {new Cookie(RestrictionAccessFilter.CSP_USER_ID, userId)};
spyFilter2.authorizeUserOnSessionExpiration(authenticationCookie, cookies);
}
@Test (expected = RedirectException.class)
public void authorizeUserOnSessionExpirationWhenUserRolesRetrievedFromPortalAndEmpty() throws RedirectException, IOException {
HashSet<String> roles = new HashSet<>();
roles.add("b");
when(authenticationCookie.getUserID()).thenReturn(userId);
when(authenticationCookie.getRoles()).thenReturn(roles);
PortalClient spyFilter = spy(portalClient);
RestrictionAccessFilter spyFilter2 = spy(filter);
Cookie[] cookies = new Cookie [] {new Cookie(RestrictionAccessFilter.CSP_USER_ID, userId)};
spyFilter2.authorizeUserOnSessionExpiration(authenticationCookie, cookies);
}
@Test (expected = RedirectException.class)
public void authorizeUserOnSessionExpirationWhenUserRolesCantBeRetrievedFromPortal() throws RedirectException, IOException {
HashSet<String> roles = new HashSet<>();
roles.add("b");
when(authenticationCookie.getUserID()).thenReturn(userId);
when(authenticationCookie.getRoles()).thenReturn(roles);
RestrictionAccessFilter spyFilter2 = spy(filter);
Cookie[] cookies = new Cookie [] {new Cookie(RestrictionAccessFilter.CSP_USER_ID, userId)};
spyFilter2.authorizeUserOnSessionExpiration(authenticationCookie, cookies);
}
// @Test (expected = RedirectException.class)
// public void authorizeUserOnSessionExpirationWhenHttpRequestFailed() throws RedirectException, IOException, RestrictionAccessFilterException {
// HashSet<String> roles = new HashSet<>();
// roles.add("b");
// when(authenticationCookie.getUserID()).thenReturn(userId);
// when(authenticationCookie.getRoles()).thenReturn(roles);
//// PortalClient spyFilter = spy(portalClient);
// RestrictionAccessFilter spyFilter2 = spy(filter);
//// when(spyFilter.fetchUserRolesFromPortal()*/
// doThrow(IOException.class).when(portalClient).fetchUserRolesFromPortal(eq(userId));
// Cookie[] cookies = new Cookie [] {new Cookie(RestrictionAccessFilter.CSP_USER_ID, userId)};
// spyFilter2.authorizeUserOnSessionExpiration(authenticationCookie, cookies);
// }
@Test (expected = RedirectException.class)
public void authorizeUserOnSessionExpirationWhenCspUserCookieIsNull() throws RedirectException, IOException {
when(authenticationCookie.getUserID()).thenReturn(userId);
Cookie[] cookies = new Cookie [] {new Cookie(RestrictionAccessFilter.CSP_USER_ID, null)};
filter.authorizeUserOnSessionExpiration(authenticationCookie, cookies);
}
@Test (expected = RedirectException.class)
public void authorizeUserOnSessionExpirationWhenCookieNotFound() throws RedirectException, IOException {
assertNotNull(filter);
Cookie[] cookies = new Cookie [] {new Cookie("someCookie", userId)};
filter.authorizeUserOnSessionExpiration(authenticationCookie, cookies);
}
@Test
public void getCspUserIdWhenMoreThanOneUserIdExists() throws RedirectException {
Cookie[] cookies = new Cookie [] {
new Cookie(RestrictionAccessFilter.CSP_USER_ID, userId),
new Cookie(RestrictionAccessFilter.CSP_USER_ID, "other")};
assertEquals(userId, filter.getCookieValue(cookies, RestrictionAccessFilter.CSP_USER_ID));
}
@Test()
public void getCspUserIdWhenUserIdIsNull() throws RedirectException {
Cookie[] cookies = new Cookie [] {new Cookie(RestrictionAccessFilter.CSP_USER_ID, null)} ;
assertNull(filter.getCookieValue(cookies, RestrictionAccessFilter.CSP_USER_ID));
}
@Test(expected=RedirectException.class)
public void getCspUserIdWhenUserIdCookieNotFound() throws RedirectException {
Cookie[] cookies = new Cookie [] {new Cookie("someName", "someValue")} ;
filter.getCookieValue(cookies, RestrictionAccessFilter.CSP_USER_ID);
}
@Test(expected=RedirectException.class)
public void getCspUserIdWhenNoCookiesFound() throws RedirectException {
Cookie[] cookies = new Cookie [] {};
filter.getCookieValue(cookies, RestrictionAccessFilter.CSP_USER_ID);
}
@Test(expected=RedirectException.class)
public void getCspUserIdWhenCookiesNull() throws RedirectException {
filter.getCookieValue(null, RestrictionAccessFilter.CSP_USER_ID);
}
}
|
