summaryrefslogtreecommitdiffstats
path: root/openecomp-be
AgeCommit message (Collapse)AuthorFilesLines
2017-12-31Fix sonar issues -HeatToToscaUtilsiddharth09051-112/+142
Changed as per comments provided Change-Id: I4787b99b2a8629dbf2c1a68995546e185778f5e8 Issue-ID: SDC-343 Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
2017-12-31Fixing sonar Exception Handlingavigaffa2-93/+84
Change-Id: I0afe103b921ea26de8f701e9a2cff7943ab58110 Issue-ID: SDC-810 Signed-off-by: avigaffa <avi.gaffa@amdocs.com>
2017-12-28Fixed broken mapping of ChoiceOrOthervempo3-11/+53
ChoiceOrOther needs default constructor to be recreated by reflection Change-Id: I194ced8b5e6a60f0dbe6f9b73715cd36c70f5163 Issue-ID: SDC-830 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2017-12-28Fixed sonar issues - OrchestrationUploadFactorymojahidi1-4/+22
Fixed all sonar issues except exception handling Change-Id: I694a37df40ef05a6217d2f6db41cd7b15ba1e10e Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-28Refactored - ProcessManagerImplmojahidi1-29/+26
Refactored as per given comment Change-Id: I366fc8ac93ce977143adbc3a4698ed5f11010405 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-28Fixing sonar qube issuesshrikantawachar1-9/+6
Refactor code as per review comment. Change-Id: I49f566c7babebf395a689846734f4932f150a9f8 Issue-ID: SDC-343 Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
2017-12-28Fixing sonar qube issuesshrikantawachar1-9/+6
Refactor code as per review comment. Change-Id: I5419848dd28e1c2276c995308dcdff55c624dd8b Issue-ID: SDC-343 Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
2017-12-28Fixed sonar issues - ImageManagerImplmojahidi1-40/+46
Fixed all sonar issues and refactored as per given comment Change-Id: I86ec2ac3f72eae3fea5291664865a1c3b4c57791 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-27Fixing sonar qube issuesshrikantawachar1-22/+13
Refactoring the code as per review comments. Change-Id: I1edd457f8d0989f815cbf3f28fa0a5124a8c4ac7 Issue-ID: SDC-343 Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
2017-12-27sonar issue fix - remove dead codeshrek20001-3/+19
remove dead code. Issue-ID: SDC-804 Change-Id: I1bae8d3d338730dfad72b155eacebc8e1f5c838f Signed-off-by: shrek2000 <orenkle@amdocs.com>
2017-12-27Fix sonar issues - Common Methodssiddharth09052-36/+50
Junit and Logger removed Change-Id: Ic1a987600a8a5ab8c236be242f0f0cd12faf9624 Issue-ID: SDC-343 Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
2017-12-27Add teststalio17-0/+1784
Add unit tests for ToscaTreeManager Change-Id: I772b63799cd34b687e6c81cb235c1c9a36ad34a2 Issue-ID: SDC-802 Signed-off-by: talio <tali.orenbach@amdocs.com>
2017-12-27Fixed sonar issues - OrchestrationTemplateCandidatmojahidi3-93/+33
Fixed all sonar issues Change-Id: I3490d2299053475e79354526a854be99ebc5b9de Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-27Validate notification framework called in testavigaffa1-16/+48
Call to ItemPermissionsManagerImplTest Change-Id: I8b1f0e42c0f7b4ebf821f18e9fbbb801f95052c9 Issue-ID: SDC-803 Signed-off-by: avigaffa <avi.gaffa@amdocs.com>
2017-12-27Fixed sonar issues - NetworkManagerImplmojahidi1-39/+28
Fixed all sonar issues Change-Id: I0baf7c56a68b60a8635dd88638a287098e685b31 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-27Fixing sonar qube issuesshrikantawachar1-12/+5
Removed commented code from MapValidationFileResponseToValidationFileResponseDto file. Change-Id: I03eca70fe5bc6dfed8ca7762b298e8f83f2ee628 Issue-ID: SDC-343 Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
2017-12-27Fixed sonar issues - MonitoringUploadsManagerImplmojahidi1-18/+17
Fixed all sonar issues except exception handling Change-Id: I799c2d485b509469f6b58b36654b2ee71d97f8c6 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-27Refactored as per given commentmojahidi1-9/+27
Removed exception handling fixes Change-Id: Ie5a89783a63ebcf4b404db4f2b8be2c7b2140e50 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-27Fixed sonar issues - ComputeManagerImplmojahidi1-32/+51
Fixed all sonar issues Change-Id: I04a06aadcf5b142334f571949b22778fa393fcc8 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-27Fixed sonar issues - ComponentManagerImplmojahidi1-44/+30
Fixed all sonar issues Change-Id: I2cc957cea740c2410c6b5d98e3335a3b1c1684e1 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-27Fixed sonar issues - NotSupportedHeatOnboardMethodmojahidi1-6/+26
Fixed all sonar issues Change-Id: I877e1bdccf63a20a618dabfa9176d94cf023d2b8 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-27Fix sonar issuessiddharth09051-14/+7
Removed default constructor and changed few access modifier Change-Id: Ibc669a1e8973fd6d7f90e474554b4701d1db4c57 Issue-ID: SDC-343 Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
2017-12-27Fix sonar issues - TranslationContextsiddharth09051-50/+38
Code refactor and variable name change Change-Id: I528be906feb5255d1b34ed30c7a287ae0d6bb29c Issue-ID: SDC-343 Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
2017-12-27Sonar issue Dix - Session is closeableshrek20002-28/+27
Cassandra session is closeable and should be protected by try block Issue-ID: SDC-801 Change-Id: Ib2cc178e029dce1915e2931fe58e4a5d6527dd5f Signed-off-by: shrek2000 <orenkle@amdocs.com>
2017-12-27Fixed sonar issues ToscaFileOutputServiceCsarImplsheetalm1-11/+7
Remove unwanted parenthesis. Corrected Copyright Change-Id: If7cb2a722aa486156d6dc2c1fb90877d0442b3a6 Issue-ID: SDC-343 Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
2017-12-27Fixed sonar issues - DeploymentFlavorManagerImplmojahidi2-85/+111
Fixed all sonar issues Change-Id: Ied0cf9f1d5aac4fb97f7fc09bf3233cb5304c4c3 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-27Fixed sonar issues - OrchestrationProcessFactorymojahidi1-20/+26
Fixed all sonar issues except exception handling Change-Id: Id1ecf35c157be3c1c9c3f5614bd97b5f8c856e5b Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-27Fixed sonar issues - OrchestrationTemplateProcessmojahidi1-11/+28
Fixed all sonar issues Change-Id: I9f706783dfc8ce794b018c3f65a78754e43e9dc0 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-27Fixed sonar issues - OrchestrationTemplateProcessmojahidi1-0/+17
Fixed all sonar issues Change-Id: Ib6664ac0837ffe83dbdf9afa7d0f6f0dc53e853f Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-27Fixed sonar issues - CSARConstantsmojahidi1-0/+20
Fixed all sonar issues Change-Id: Ia0db69f41abe5557faf1e845590ba98f667bea1e Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-27Fixed sonar issues - OnboardingMethodErrorBuildermojahidi1-0/+20
Fixed all sonar issues Change-Id: Iec00a6d2b8028861fdab6e34e17d421fe3de1334 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-27Fixed sonar issues - ImageErrorBuildermojahidi1-1/+19
Fixed all sonar issues Change-Id: I1a4f289524425999f019817cbc8df060d83e252b Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-27Fix sonar issues - ResourceWalkersiddharth09051-6/+31
Code refactor and Javadoc Change-Id: Ic14f3fe0cc8e1903ec3ec73b9a6b63a694e0db81 Issue-ID: SDC-343 Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
2017-12-27Fixing sonar qube issuesshrikantawachar1-11/+7
Added Override annotation to method and removed runtime exception from method specification. Change-Id: I12640d880c262fc301cafe8ede228e2a4772af88 Issue-ID: SDC-343 Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
2017-12-27Fixing sonar qube issuesshrikantawachar1-16/+15
Fixed critical , major , minor issues in DefaultOutput class. Updated license header. Change-Id: Ie79498108433c5cc16a3adb04c6f6072724d381d Issue-ID: SDC-343 Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
2017-12-27Avoid Null Pointershrek20001-3/+0
Change-Id: Ie6f78934a1c6407a05bd988fb234bf5662fb26e8 Issue-ID: SDC-799 Signed-off-by: shrek2000 <orenkle@amdocs.com>
2017-12-27Fixed sonar issues -NicInternalNetworkErrorBuildermojahidi1-3/+23
Fixed all sonar issues Change-Id: I206a6529b85c501f06747178ff0571b7547428ad Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-27Avoid Null Pointershrek20001-0/+4
Change-Id: I91eb26e842495271017d0c918bdae81d03c192f2 Issue-ID: SDC-797 Signed-off-by: shrek2000 <orenkle@amdocs.com>
2017-12-27Fixed sonar issues - OrchestrationTemplateFileHandmojahidi1-0/+17
Fixed all sonar issues Change-Id: Ieece2d0e081a918e841e8ecbaf2b6af1a5d0f3b8 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-27Fix sonar issuessiddharth09051-13/+11
Modified access modifier and few refactor Change-Id: I9386cce2dd90c411a262b3dbc0b95525dd1362c5 Issue-ID: SDC-343 Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
2017-12-27Fixed sonar issues - OnboardingManifestmojahidi1-29/+59
Fixed all sonar issues Change-Id: I7f07c7dba6713e76b24ad5bb4bf994a867769edc Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-27Fixed sonar issues - DeploymentFlavorErrorBuildermojahidi1-17/+39
Fixed all sonar issues Change-Id: I528de8e970f40b03af183f499bd9ff61792c174a Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-27fix TOSCA structure treetalio1-35/+23
when uploading a csar with two different directories that share the same name, the files structure that appears on the validation screen shows all of the files written under the same directory. this issue got fixed Change-Id: I6da7399271fa1cde384f6feb51d60724584aa8f9 Issue-ID: SDC-535 Signed-off-by: talio <tali.orenbach@amdocs.com>
2017-12-27Simplified the return conditionojasdubey17-87/+367
Note: Sonar violations will be handled as a separate task Change-Id: I862247f5c693f4d64dff4ce18f2f71e42c85355a Issue-ID: SDC-749 Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
2017-12-27Fixed sonar issues - NicManagerImplmojahidi2-72/+78
Fixed all sonar issues Change-Id: Ic56ea70826845f94a3a8d83193fc75f1179bb62b Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-26Fixed sonar issues - ComputeErrorBuildermojahidi1-0/+20
Fixed all sonar issues Change-Id: If38e9ec81c72da6a96e9d0c12312416b239c2d02 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-26Fixed sonar issues - ComponentDependencyModelmojahidi1-0/+18
Fixed all sonar issues Change-Id: I4469b63b6a2291a7780e591edda36827c7bf51a1 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-26Fixed sonar issues - DeleteNicErrorBuildermojahidi1-1/+21
Fixed all sonar issues Change-Id: I5a71e83bce19bff06f6d9d7609c3b959abcda066 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-26Fix sonar issuessiddharth09051-2/+17
Argument name change and no-op comment Change-Id: I3087310fe8dfedadbeac8408051fded0225838f2 Issue-ID: SDC-343 Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
2017-12-26Fixed sonar issues - VendorLicenseManagerImplmojahidi1-108/+133
Refactored as per given comment Change-Id: I92ec3c5a0152a625c1cad33ef2a92292b10977b2 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>