summaryrefslogtreecommitdiffstats
path: root/openecomp-be
AgeCommit message (Collapse)AuthorFilesLines
2017-12-27Simplified the return conditionojasdubey17-87/+367
Note: Sonar violations will be handled as a separate task Change-Id: I862247f5c693f4d64dff4ce18f2f71e42c85355a Issue-ID: SDC-749 Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
2017-12-27Fixed sonar issues - NicManagerImplmojahidi2-72/+78
Fixed all sonar issues Change-Id: Ic56ea70826845f94a3a8d83193fc75f1179bb62b Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-26Fixed sonar issues - ComputeErrorBuildermojahidi1-0/+20
Fixed all sonar issues Change-Id: If38e9ec81c72da6a96e9d0c12312416b239c2d02 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-26Fixed sonar issues - ComponentDependencyModelmojahidi1-0/+18
Fixed all sonar issues Change-Id: I4469b63b6a2291a7780e591edda36827c7bf51a1 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-26Fixed sonar issues - DeleteNicErrorBuildermojahidi1-1/+21
Fixed all sonar issues Change-Id: I5a71e83bce19bff06f6d9d7609c3b959abcda066 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-26Fix sonar issuessiddharth09051-2/+17
Argument name change and no-op comment Change-Id: I3087310fe8dfedadbeac8408051fded0225838f2 Issue-ID: SDC-343 Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
2017-12-26Fixed sonar issues - VendorLicenseManagerImplmojahidi1-108/+133
Refactored as per given comment Change-Id: I92ec3c5a0152a625c1cad33ef2a92292b10977b2 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-26Fix sonar issuessiddharth09051-6/+21
Code correction as per suggestion Change-Id: Ia7772c1f257b90fc38ff4b12ee71b37354f7606b Issue-ID: SDC-343 Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
2017-12-26Fixed sonar issues - NovaServerGuideLineValidatormojahidi1-91/+94
Fixed all sonar issues Change-Id: I5152c860c925ce0532d1b5053a3738d82e1bfafe Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-26Fix sonar issuessiddharth09051-5/+4
Removed commented code, and refactor Change-Id: I3cb107ab3931e323dd11c32c8285f871e5082531 Issue-ID: SDC-343 Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
2017-12-26Fixed sonar issues - HeatResourceValidatormojahidi2-152/+60
Done refactoring as per given comment Change-Id: Id1cd659af6ddd9e24d281a1bb0d1ae9431bcaf98 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-26Fixed sonar issues - ToscaNodeTypesheetalm1-14/+13
Adding private constructor. Making constant final. Corrected copyright Change-Id: I025aaddbae4133a2bd0b4bba450726a166ebeb1a Issue-ID: SDC-343 Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
2017-12-26Fixed sonar issues - LimitErrorBuildermojahidi1-1/+21
Fixed all sonar issues Change-Id: I6243f40a4bf400f834166f813154455cae9b7ab1 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-26Add Item Manager and Dao impl unit teststalig3-3/+250
Change-Id: I30df90a7ca543195d286f322e8bfa52ffabca849 Issue-ID: SDC-779 Signed-off-by: talig <talig@amdocs.com>
2017-12-26Fix sonar issuessiddharth09051-65/+67
Added static inner class for initializing system prop Change-Id: I63c23640058a68c7f8d228a2a509d1b440fd20e6 Issue-ID: SDC-343 Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
2017-12-26 Fixed sonar issues - ContrailServiceTemplatemojahidi1-16/+30
Fixed all sonar issues Change-Id: I2ecf439dac9e180fd1640c53abb0e15991434704 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-26 Fixed sonar issues - NeutronPortNamingConventionmojahidi1-48/+70
Fixed all sonar issues Change-Id: Ibc328c6e7d7d6e71837107d34dc24731735db9d6 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-26Fixed sonar issues - ContrailServiceInstancemojahidi1-16/+29
Fixed all sonar issues Change-Id: Ia1f1f73dd5c0d7f6151b9cab91a3bcb11bd787ed Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-26Fixed sonar issues - FileDataStructureHealersheetalm1-17/+5
Remove no arg constructor and unwanted logger. Corrected Copyright Change-Id: I3417663d57eefe21051ac033415f3364e90351a3 Issue-ID: SDC-343 Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
2017-12-26Fixed sonar issues - Healersheetalm1-12/+6
Add functional interface annotation. Corrected Copyright Change-Id: Ia271a0c335756c8d4369d6921d43c9b9282bd412 Issue-ID: SDC-343 Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
2017-12-26fix VM groupingTal Gitelman93-527/+629
ignoring fixed_ips value when consolidating VMs Issue-ID: SDC-774 Change-Id: Icdd88af94ff0609f6efabf69b00ed09836270fff Signed-off-by: talio <tali.orenbach@amdocs.com>
2017-12-25Refactor list revisions apitalig8-143/+287
Remove zusammen-api dependency in versioning-api, enhance version zusammen dao impl UT. Issue-ID: SDC-779 Change-Id: Ic792462eac52f1f5129f92ce80d3deb641c90916 Signed-off-by: talig <talig@amdocs.com>
2017-12-25Import Export Tool add executorsshrek20002-11/+22
Issue-ID: SDC-773 Change-Id: Id203b671e9af0b3478b75032111b73a509a9a5df Signed-off-by: shrek2000 <orenkle@amdocs.com>
2017-12-24Fix sonar issuessiddharth09051-8/+19
Rearranged the code Change-Id: Ic08659d8c56aec1a001a2e3e1de2f8e200a10a4e Issue-ID: SDC-343 Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
2017-12-24Fixed sonar issues - NovaServerGroupResourceValidmojahidi1-6/+20
Fixed all sonar issues Change-Id: I4eb6f2923e9b2605e048d4b8ad720bf8bd05c6c9 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-24Fixed sonar issues - NovaServerResourceValidatormojahidi1-16/+35
Fixed all sonar issues Change-Id: I4ee3a6fdc33a3874ce36d32296ab508ee7089468 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-24Fixed sonar issues - NeutronPortResourceValidatormojahidi1-13/+26
Fixed all sonar issues Change-Id: I15953126b263c5746551f024f5ff34ae5848eba8 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-24Fixed sonar issues - SharedResourceGuideLineValmojahidi1-23/+35
Removed unused method parameters Used isEmpty() to check whether the collection is empty or not Change-Id: Id812b2fd4d9b16b399eb9edc0f41e5e0c5d54211 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-24 Fixed sonar issues - YamlValidatormojahidi1-17/+10
Removed unused logger Removed useless parentheses Change-Id: Ia804c7c461690172f67d610df0bfa46c17525ae8 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-24Fixed sonar issues - HeatValidatormojahidi1-219/+233
Refactored code to not nest more than 3 if/for/while/switch/try statements and fixed other sonar violations Change-Id: I0bcef3c45a894c9e1da9a16ad82b6f5140c789ce Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-24Fixed sonar issues - YamlValidatorUtilmojahidi1-13/+10
Added private constructor to hide the implicit public one Change-Id: Iaedd9c5fe8f55025af6b26a41837da2c6e75a5fc Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-24Fixed sonar issues - ForbiddenResourceGuideLineValmojahidi1-14/+28
Added license, removed Removed unnecessary cast to Logger Change-Id: Icf1cac7841e26224573820addd85f3497ee5ae3d Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-24Fixed sonar issues - ContrailValidatormojahidi1-36/+28
Removed unnecessary cast to Logger Removed unused method parameters Change-Id: I766e6333f8309b83d0725c1c6d25109fb81d47f7 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-24Fixed sonar issues - ServiceTemplateEntitysheetalm1-12/+9
Add override annotations to methods. Remove no arg default constructor Corrected Copyright. Not fixing duplicate code violation since same code block exists but for different entities Change-Id: Ib776e280fb7e67100ac75f3312ad0c19dc709d46 Issue-ID: SDC-343 Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
2017-12-21Fixed sonar issues - ManifestValidatormojahidi1-76/+72
Removed unnecessary cast to Logger Moved private methods into ManifestScanner Change-Id: I40e581ec03a5400b8728057d766317615299b3e8 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-21Add collaboration featuretalig858-18574/+30240
Issue-ID: SDC-767 Change-Id: I14fb4c1f54086ed03a56a7ff7fab9ecd40381795 Signed-off-by: talig <talig@amdocs.com>
2017-12-13Rearranging togglez to avoid dependency issuessheetalm2-12/+5
Added new profile "dev-integ" which will allow togglez-console dependency to be added. When built with default profile togglez-console will be excluded Change-Id: I8a918fe1ad56620d4215acb70dc126b0bc986802 Issue-ID: SDC-343 Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
2017-12-13Adding Error code in HEAT Validatorsmojahidi16-387/+1221
added error code in NestedResourceValidator and ResourceGroupResourceValidator fixed sonar issues Change-Id: I1705b7103a3b3c42338f97cb4a7a255a6c85e88f Issue-ID: SDC-572 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com> Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2017-12-13Fixed sonar issues - LoggerFactorymojahidi1-3/+33
Refactored as per previous patch comment Change-Id: Ia971105a56df62575cd3871e3488b6d2c6903d3c Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-12Fixed sonar issues - ServiceArtifactEntitysheetalm1-12/+9
Add override annotations to methods. Remove no arg default constructor Corrected Copyright. Not fixing duplicate code violation since same code block exists but for different entities Change-Id: I64a25f2fe9805774f704700cd5a345db461f152a Issue-ID: SDC-343 Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
2017-12-12Fixed sonar issues - EnrichedServiceTemplateEntitysheetalm1-13/+9
Add override annotations to methods. Remove no arg default constructor Corrected Copyright. Not fixing duplicate code violation since same code block exists but for different entities Change-Id: Ie718ed87dac2be84257e9cedfa20fb98857f907e Issue-ID: SDC-343 Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
2017-12-12Fixed sonar issues - LoggerTragetServiceNamemojahidi1-0/+3
Added private constructor to hide public one Change-Id: I5f4f7d67513c6d4f792ad68ad986867a255356f0 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-12Fixed sonar issues - EnrichedServiceArtifactEntitysheetalm1-12/+9
Add override annotations to methods. Remove no arg default constructor Corrected Copyright. Not fixing duplicate code violation since same code block exists but for different entities Change-Id: Idb1d58396b40205cc534cec56f26a2914f58b9c3 Issue-ID: SDC-343 Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
2017-12-12Fixed sonar issues - AbstractComponentFactorysheetalm1-29/+5
Declaring functional interface. Removing unused code. Correct copyright Change-Id: I749929be60eb0e87b6c4b12b30c211bf778af331 Issue-ID: SDC-343 Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
2017-12-11Fixed sonar issues - DebugMessagesmojahidi1-0/+3
Added private constructor to hide public one Change-Id: I0689d9a4c920a910324b0db298e325c3e87d37f6 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-11Fixed sonar issues - DebugConstantsmojahidi1-3/+3
Added private constructor to hide public one Change-Id: I535017906f12d69333360b1994d87e506f5bf142 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-11Fixed sonar issues - AuditMessagesmojahidi1-3/+18
Added private constructor to hide public one Change-Id: Icddef8c59eb1f4cc77ed6646cfb7b362d4921da1 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-11Fixed sonar issues - LoggerConstantsmojahidi1-0/+3
Added private constructor to hide public one Change-Id: I8958d8906d7339d8bc0c7d0188de5d397aa04c79 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-11Fixed sonar issues - ContextPropagationServicemojahidi1-0/+2
Added FunctionalInterface annotation Change-Id: Ia8c68be7a2154d68d0d472cd0bb757c01ad59e27 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2017-12-11Fixed sonar issues - LoggerErrorDescriptionmojahidi1-0/+3
Added private constructor to hide public one Change-Id: I06eca13ddcd6ca4e2eae427c2fb8a12e7c603e64 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>