summaryrefslogtreecommitdiffstats
path: root/openecomp-be/backend
AgeCommit message (Collapse)AuthorFilesLines
2020-06-10Fix security issue in SecurityUtilNeil Derraugh6-30/+42
- Specified mode and padding to address risky algorithm - Corrected unit test for different exception message - Moved tests to package Issue-ID: SDC-3105 Signed-off-by: Neil Derraugh <neil.derraugh@yoppworks.com> Change-Id: I5773ab555a5468362c775cf99795df4eb8c52136
2020-05-19remove powermock dependency from pom xmlsRodrigo Lima7-97/+18
- Remove powermock from pom xml files - Remove powermock from ActivityLogManagerFactoryImplTest Issue-ID: SDC-3071 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I4c4b8b0751f4ce8895617a951429111fc08d8e2e
2020-05-12Remove powermock from SecurityManagerTestRodrigo Lima2-15/+10
- Add new package level constructor to SecurityManager - Remove powermock from SecurityManagerTest Issue-ID: SDC-3054 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I04c53601f31d2aad84de8f8801f6889f8b9d4260
2020-05-11Fix security issues in SecurityUtilNeil Derraugh2-203/+0
- Removed hard coded key - Specified mode and padding to address risky algorithm Issue-ID: SDC-3017 Signed-off-by: Neil Derraugh <neil.derraugh@yoppworks.com> Change-Id: I6c21174003fcb5669de49158d8dd6bf9907f50c6
2020-05-06Prepare for Junit5vasraz8-627/+570
Remove unused/duplicated dependencies Change-Id: Iee0d9510ffbe3e2e14574e22ba965d6829fd568b Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2844 Issue-ID: SDC-2983
2020-04-20Fix Tosca properties declarationaribeiro1-1/+1
Remove duplicated entries Default value for Boolean type should not be a String According to the description for the keyname 'attachments:' it should be of type List rather than String Issue-ID: SDC-2870 Signed-off-by: aribeiro <anderson.ribeiro@est.tech> Change-Id: Iac2b4f89dac16a6aef9dcabea74def5cacff99a6
2020-04-16Upgrade Junit to version 5.6Baumel, Dvir (db384r)2-2/+16
Issue-ID: SDC-2844 Change-Id: I4716bf7920f9bb79c450ebfd48e9d4fba54fdfdd Signed-off-by: Baumel, Dvir (db384r) <dvir.baumel@intl.att.com>
2020-04-05Fix data type properties declarationaribeiro2-2/+2
According to TOSCA Network properties definition the keyname 'ip_version:' should have Integer as valid_values rather than String Where the keyname 'count:' is declared as a String type the default value should be String rather than Integer Fix misspelled ONAP types 'onap.datatypes.monitoring.measurementType' and 'onap.datatypes.monitoring.managedObjectDNsBasic' Fix the keynames 'upstream:' and 'downstream:' as both are declared as a String type the valid_values should be String rather than Integer Issue-ID: SDC-2864 Signed-off-by: aribeiro <anderson.ribeiro@est.tech> Change-Id: I56afdf2818b5f2463fb6088cd8b468fd38ef5086
2020-03-23Entitlement Pool - Support Type FieldBen David, Elad (eb7504)1-23/+25
Change-Id: Ibd9996cce04849332bd23dd62e6143386cdd9a70 Issue-ID: SDC-2820 Signed-off-by: Ben David, Elad (eb7504) <eb7504@intl.att.com>
2020-03-15Allow other entries for SOL004 Tosca.metaandre.schmid5-101/+101
Besides the mandatory entries, any other entry will be accepted in the TOSCA.meta file, as far as it has a valid format <name>: <value>. Change-Id: I941a62dbb43167e7e0424deae11a2664e61c8a6c Issue-ID: SDC-2781 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-03-12Disable SecurityFilterOfir Sonsino11-11/+11
Bumping version to 1.7.0 Change-Id: I041bb5ce967b687e10be97dbbaa3ba1d119d13ff Issue-ID: SDC-2825 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2020-02-02Move to version 1.6.1shrek200011-11/+11
Move SDC to version 1.6.1 Issue-ID: SDC-2755 Signed-off-by: shrek2000 <oren.kleks@amdocs.com> Change-Id: If5c55fdebb5bc2591190ee4389487f6dbb0e1831 Signed-off-by: shrek2000 <oren.kleks@amdocs.com>
2019-12-20Unique identifier for test executionatulpurohit3-812/+779
Issue-ID: SDC-2584 Co-authored-by: nikhil.soni@vodafone.com Signed-off-by: atulpurohit <atul.purohit1@vodafone.com> Change-Id: I3e7f1a84935cbcd26f8a42a6e2d2dbcb7533cb19 Signed-off-by: atulpurohit <atul.purohit1@vodafone.com>
2019-12-01Fix Security Hotspots issuesvasraz1-2/+5
Change-Id: Icc45769cff71c8153c0afba6e2363b0399144175 Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2671
2019-11-20Validate non-mano software information artifactandre.schmid11-177/+390
Change-Id: Ie9fabd6af821b830e211ff1068fb287357fd38ee Issue-ID: SDC-2619 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-11-20Onboard PNF software versionandre.schmid4-52/+9
Change-Id: Id9e32e01f6c2f4c39c8ff10816d982cbb3063bf7 Issue-ID: SDC-2589 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-11-07Align Sdc warnings with VNF RequirementsBen David, Elad (eb7504)1-1/+2
Change-Id: Ic133faed7f8b612279de0eb836e88e9ea6b694d7 Issue-ID: SDC-2647 Signed-off-by: Ben David, Elad (eb7504) <eb7504@intl.att.com>
2019-11-05Align logging to Onap-ELS 2019.11Ben David, Elad (eb7504)3-53/+110
Change-Id: I1750493d5c9f2eab8c1395f0fbc9ae66cf74b0a6 Issue-ID: SDC-2639 Signed-off-by: Ben David, Elad (eb7504) <eb7504@intl.att.com>
2019-11-03Validate artifacts signature in SOL004 packageandre.schmid12-287/+468
Change-Id: Ib048f4501fd8a81cdf11fab19f149350011f772e Issue-ID: SDC-2632 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-11-03Create new non-mano Artifact Type entry for pnf software informationaribeiro2-1/+5
Issue-ID: SDC-2615 Change-Id: I4dd879d50b1dec58aceeaf0c265901c62d038071 Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2019-11-03Centralize onboarding package validationandre.schmid33-196/+830
Change-Id: I3cc58cf15f62008e83cfc7ddb095d07ab216b82a Issue-ID: SDC-2583 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-30Fix zip slip security flawandre.schmid3-60/+25
Apply zip slip checking in zip operations throughout the system. Centralizes most of the zip logic in one class. Create tests to zip functionalities and zip slip problem. Change-Id: I721f3d44b34fe6d242c9537f5a515ce1bb534c9a Issue-ID: SDC-1401 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-29Fix for status properties value.aribeiro8-322/+322
These changes were made to align the normative types to the TOSCA property definition requirements. Issue-ID: SDC-322 Change-Id: I32e815dd26990dd6c82c859ad051b271db3c8029 Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2019-10-29Bump SDC version 1.6.0Ofir Sonsino11-11/+11
Change-Id: Ibacb46d19d49023a62caa8f5217086cea6c91ac4 Issue-ID: SDC-2560 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2019-10-25Avoid duplicated verification if package is signedvasraz1-67/+71
Fix potential thread leak by using try-with-resource. Change-Id: I20eda524cd028b9dfdfa83207a059f4e1dfeff5e Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2580
2019-10-24Fix and refactor manifest parsingandre.schmid6-101/+119
Fix a CMS signature reading expected token. Fix the necessity of a empty line in the end of the manifest. Implement CMS signature, Source checksum algorithm and digest reading. Indicate the line number and content when a manifest error occurs. Remove unnecessary recursive reading. Centralize manifest tokens. Improve tests by checking the expected error. Document the code. Change-Id: I7d12020d8922fc5d4c8d9f238557dfbcc0b65757 Issue-ID: SDC-2563 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-21Fix factory instance creation instabilityandre.schmid12-24/+12
Refactor the factory registry and instance creation. Remove unnecessary static code in Factory creation. Centralize the responsibility to read the factory registry configuration and cache the factory instances in a Singleton called FactoryRegistryManager. Clean the base abstract factory that was sharing non factory code, it had all the factory registry code statically, never used by the concrete factory classes. Change-Id: Ie2e9c29013acd36ddaf15383dd6b06432fbdbb66 Issue-ID: SDC-1905 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-09-10Bump SDC version 1.5.2Ofir Sonsino11-11/+11
Change-Id: Ib672dc8d60a0b6f4b37fd94afe84bc27dfba4c44 Issue-ID: SDC-2560 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2019-09-03Implement PNFD Model driven conversionandre.schmid1-2/+2
Change-Id: I7427e82353cac17817457294d78953f867d2d6e8 Issue-ID: SDC-2509 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-09-03Onboard Package Handlingaribeiro12-179/+296
Retain the original onboarded package when it comes in zip/csar format. Issue-ID: SDC-2510 Change-Id: Ie293db25eca8872be26ffc8475b25ccace1aab6f Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2019-09-03unit tests - openecomp-sdcTomasz Golabek1-124/+0
Additional junit tests for action, type etc. Change-Id: I93b088035fca13db4fdcf9da0d58e7f01ee4f976 Issue-ID: SDC-2326 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-09-03General Sonar fixesArindam Mondal1-9/+61
+)Organize imports ++) log formatter Issue-ID: SDC-2542 Change-Id: Ibb4b568b19ee40a68f783bfa820bd7c73aae5c1f Signed-off-by: arindamm <arind.mondal@samsung.com>
2019-09-01Fix artifacts references in main TOSCA descriptorandre.schmid5-383/+276
During package conversion, artifacts can have their path changed. References for those artifacts inside the main TOSCA descriptor must be updated accordingly. Change-Id: Idcffb0724c20875ff1decebfec7c47605bfe20dc Issue-ID: SDC-2540 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-08-28remove duplicated dependenciesvasraz3-18/+0
Change-Id: I60962892f035d81943567a0b3d7819ef3cab52f7 Issue-ID: SDC-2388 Signed-off-by: vasraz <vasyl.razinkov@est.tech>
2019-08-26Add unit test for DuplicateComputeInComponentErrorBuilder and refactor ↵m.kowalski34-7/+42
ComponentDependencyModelErrorBuilder Issue-ID: SDC-2327 Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com> Change-Id: Icb6cf51f7777a8a9d3b237ecd98579edc11f9ebb
2019-08-22unit tests - sdc-healthcheck-managerTomasz Golabek13-118/+210
Additional junit tests Change-Id: I6562e5085f7bfd692db129bf1706f3f569ebd793 Issue-ID: SDC-2326 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-08-22Unit tests - openecomp-sdc-validation-managerTomasz Golabek15-2/+426
Tests for org.openecomp.sdc.validation Change-Id: If0acdb2f453b5cd60d0ec49870f1467cdd212492 Issue-ID: SDC-2326 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-08-21Unit tests - openecomp-sdc-vsp-managerTomasz Golabek9-0/+347
Tests for org.openecomp.sdc.vendorsoftwareproduct Change-Id: I737b8ca71219c3e241f902a34419c685435e467c Issue-ID: SDC-2326 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-08-13Add unit tests for NicInternalNetworkErrorBuilderm.kowalski31-2/+28
Issue-ID: SDC-2327 Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com> Change-Id: I8a6127218edf895b8b43d973348cc47794e212c1
2019-08-06Validate PM Dictionary and VES Events YAML Filesandre.schmid10-126/+777
Validate, during the package onboarding, YAML files declared in the manifest as type onap_ves_events or onap_pm_dictionary under non_mano_artifact_sets. Check if the file is not empty, if has a yaml extension and if it has a valid yaml content. Change-Id: I260d0f5355e9e77b6499f553f8aa9f7e6d0693da Issue-ID: SDC-2475 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-07-28Update SDC version 1.5.1Ofir Sonsino11-11/+11
Change-Id: Id2182099210982248584c1fcf4569a1360d82f1d Issue-ID: SDC-2478 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2019-07-21Add unit test for TranslationFileCreationErrorBuilderm.kowalski31-0/+49
Issue-ID: SDC-2327 Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com> Change-Id: Iedb570e14fdf1169da45321d97807aedad2c16d0
2019-07-21Allow relative path for SOL004 descriptors importandre.schmid3-81/+125
Allow the use of relative path on SOL004 descriptors imports. Resolves imports with "/", "../" or "./" entries during validation and package processing. Validate if the reference is inside the package. Fix problem where imported descriptor files, described as a non string scalar yaml entry, were not being checked by the validator. Change-Id: Ie5a32736b6090b4adf178e8714f7460bcd068def Issue-ID: SDC-2422 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-07-19SDC alignment SOL004 2.6.1bilal.iqbal4-7/+7
Updating TOSCA.meta metadata Created-by key to Created-By Issue-ID: SDC-2402 Change-Id: Ice17dac288d745292bdd8d296bd1ae3eedbff223 Signed-off-by: bilal.iqbal <bilal.iqbal@est.tech>
2019-07-17Add unit test for PackageNotFoundErrorBuilderm.kowalski31-0/+52
Issue-ID: SDC-2327 Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com> Change-Id: I7b553f8eb03b7a1bd8d059ea12dcbdff79100f03
2019-07-15Add unit tests for UploadInvalidErrorBuilderm.kowalski31-0/+56
Issue-ID: SDC-2327 Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com> Change-Id: Icf5f64c77f373d27df438bc6bc89a9e1e67eaf0c
2019-07-15Add unit tests for NicInternalNetworkErrorBuilder and ↵m.kowalski32-0/+83
OnboardingMethodErrorBuilder Issue-ID: SDC-2327 Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com> Change-Id: I46e64b3a7a533a20c4e0e5a98aa99c488fa71a6b
2019-07-11Added oparent to sdc mainTomasz Golabek80-61/+1400
Removed errors regarding to a missing license and others. Started locally and executed basic api tests Change-Id: Iea37613defc97f7b40613d60c10990841cb2a209 Issue-ID: SDC-2419 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-07-09Add unit test for PackageInvalidErrorBuilderm.kowalski31-0/+48
Issue-ID: SDC-2327 Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com> Change-Id: I3ca7aa5ac07acd472e9ddd359e74064bf29186c0
2019-07-08Add validation of non referenced file in packageandre.schmid7-177/+823
Add the validation specified in SOL004, that all files in the package should be listed in the Manifest file. Fix Validator related Test class, adapting to the new validation. Create a manifest builder to help the tests. Fix minor typos. Update .gitignore to remove ajcore files. Change-Id: Ib9a99bf3d7905349e0ec8fef8fd960028bb83f8d Issue-ID: SDC-2412 Signed-off-by: andre.schmid <andre.schmid@est.tech>