aboutsummaryrefslogtreecommitdiffstats
path: root/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src
AgeCommit message (Collapse)AuthorFilesLines
2021-02-23Upgrade Vulnerable Direct Dependencies [snakeyaml]JulienBe1-39/+27
Change-Id: I84417ab3d4f18634be519b837a34d1f1e774ceff Signed-off-by: amohamad <a.mohamad@queensu.ca> Issue-ID: SDC-3051 Updated MVN dependencies in the respective pom.xml files Updated the signature of some methods to match new version 1.26 Modified test cases to match the new wording of exceptions Still working on troublshooting other failing test cases Change-Id: Ifc796574e6d8d4e4fc707db04944d83427b5dbe6 Signed-off-by: amohamad <a.mohamad@queensu.ca> Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
2021-02-22Add new SOL004 ETSI Validatoraribeiro11-45/+369
Support for onboarding ETSI v3.3.1 SOL004 VNF CSAR Packages with minimum CNF enhancements from 4.1.1 Issue-ID: SDC-3337 Signed-off-by: aribeiro <anderson.ribeiro@est.tech> Change-Id: I0fefb43b8462133ae82d10418c79f9e2b126defb
2021-02-21ETSI SOL007 3.3.1 package security option 2andre.schmid5-26/+98
Change-Id: I4e021c517449e6ddf11571c02d0b4bdbc93e7c1e Issue-ID: SDC-2614 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2021-02-21Update node and data types for SOL001 3.3.1 + CNF enhancementsMichaelMorris1-0/+1
Types in 2.7.1 folder are types valid for v3.3.1 that have not changed from v2.7.1 Types in 4.1.1 folder are the CNF enhancements which it is assumed will be in v4.1.1 Includes some changes in functionality to support: 1. Deployment of both existing (2.5.1) versions of types and new versions of types through sdc-BE-init 2. Selection of the correct node type definition version at onboarding of an ETSI SOL004 VNF/CNF csar, based on the declared version supported in the csar (i.e. when a 3.3.1 csar is imported, the node type definitions valid for 3.3.1 are used (rather than current logic which always selects the latest version) Signed-off-by: MichaelMorris <michael.morris@est.tech> Issue-ID: SDC-3470 Change-Id: Iff835d230b173b9d44349caa6b0b11d783e8f8d3
2021-02-20Fix BLOCKER BUGs reported by Sonarvasraz1-41/+44
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Change-Id: I00c466ac3fcbe8fab4629aed3a36bb2d8af3a970 Issue-ID: SDC-3472
2021-02-20Add new SOL004 validatordavsad5-89/+292
New validator for onboarding SOL 004 version 3.3.1 Issue-ID: SDC-2611 Signed-off-by: davsad <david.sadlier@est.tech> Change-Id: I4f41d2fbd913011f42a8319a6594c973c735d2a0
2021-02-20Add validation of manifest for helm packages.Jan Malkiewicz9-85/+754
For ONAP native zip packages added validation of manifest file. HELM package is only valid if: * isBase flag is set to 'true' for exactly one helm entry * isBase flag is present for all helm entries Zip package is considered to be a helm package if it contains HELM entries but does not contain any HEAT entries (however it may contains entries of other types). Refactored method OnboardingPackageProcessor.processPackage(): * simplified logic * enhanced exception handling Issue-ID: SDC-3185 Signed-off-by: Jan Malkiewicz <jan.malkiewicz@nokia.com> Change-Id: Ica3b1f1504ce4fc3a671c4b8fa8de2bf0236bd77
2021-02-15Fix buildChrisC8-136/+130
Fix catalog-be tests and Integration docker test this fix is not final as it just avoids concurrency issues on statics Fix Expired certificates on Vendorsoftwareproduct Issue-ID: SDC-3467 Signed-off-by: ChrisC <christophe.closset@intl.att.com> Change-Id: I311470b305a29bebffbd74b6f2ad7b13193132e1
2021-01-21Fix critical bug in sonar in SecurityManagerTest.javaTomasz Pietruszkiewicz1-4/+5
Change-Id: I2ea2a7c859ea01f86e66440816427f1d5355fa72 Issue-ID: SDC-3444 Signed-off-by: Tomasz Pietruszkiewicz <tomasz.pietruszkiewicz@nokia.com>
2021-01-21PNF CSAR onboarding still works if root CA is removed from SDC directoryTomasz Pietruszkiewicz1-2/+6
Change-Id: I687c4b9e7e25ca254caefb1746ee6f0984a539a8 Issue-ID: SDC-3442 Signed-off-by: Tomasz Pietruszkiewicz <tomasz.pietruszkiewicz@nokia.com>
2021-01-19Fix signature validation in SDC (PNF package onboarding)Tomasz Pietruszkiewicz13-196/+650
Change-Id: Ief8bf62e48a23a091e9084333c2523d8490fdcd2 Issue-ID: SDC-3386 Signed-off-by: Tomasz Pietruszkiewicz <tomasz.pietruszkiewicz@nokia.com>
2021-01-18Map VSP PM_DICTIONARY Type to VF PM_DICTIONARY TypeAdam Wudzinski1-1/+18
File defined in ZIP VSP package as PM_DICTIONARY will be now mapped to PM_DICTIONARY type in VF. Also PmDictionaryValidator is run on files with PM_DICTIONARY type in ZIP Manifest file, instead of file naming convention. Issue-ID: SDC-3390 Signed-off-by: Adam Wudzinski <adam.wudzinski@nokia.com> Change-Id: I2e21353b9e80b6bb68c4c6d408ad1ffa33314e7b
2021-01-12Improve test coverageJulien Bertozzi1-95/+70
Issue-ID: SDC-3428 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com> Change-Id: I48b6991fbbea31279246d92692760fc6375c7eb5 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
2021-01-11Fix NPEJan Malkiewicz1-1/+2
Fix NPE during the onboarding of a helm package. NPE was thrown in HeatTreeManager.handleOrphans(): * tree.getHeat()::contains Issue-ID: SDC-3185 Signed-off-by: Jan Malkiewicz <jan.malkiewicz@nokia.com> Change-Id: I9e0461cfe18705b6fb53ae318e473bd4e2651305
2020-12-17Integration tests for validating PM_Dictionary.Maciej Malewski2-3/+10
Checking compliance content of the PM_Dictionary file against it's schema. Issue-ID: SDC-3390 Change-Id: I8e20f977c7d6838005bc84fc6c7c8ab197152a53 Signed-off-by: Maciej Malewski <maciej.malewski@nokia.com>
2020-12-02Validate PMDictionary contentsMaciej Malewski11-185/+751
Validate contents against schema for .csar packs compliant with NFV-SOL 004. Issue-ID: SDC-3390 Signed-off-by: Maciej Malewski <maciej.malewski@nokia.com> Change-Id: Ib768821ad8215105ca4a33953fa9974a63ed76f7
2020-10-19Read files from resources to create HELM VFMMD IRSHAD SHEIKH3-3/+3
Issue-ID: SDC-3316 Signed-off-by: MD IRSHAD SHEIKH <md.irshad.sheikh@huawei.com> Change-Id: Ieb3a4aa46c657ffaa328aef00394a13361bdbe5a
2020-09-22SDC changes for adding dummy base heat-new patchSithara Nambiar6-1/+188
Issue-ID: REQ-341 Signed-off-by: Sithara Nambiar <sitharav.aredath@huawei.com> Change-Id: I1fff1ea7615ed21c769df651e3f1951be802ff65
2020-09-07Rename ONBOARDED_PACKAGE folder to ETSI_PACKAGEKrupaNagabhushan1-1/+2
Issue-ID: SDC-3259 Signed-off-by: KrupaNagabhushan <krupa.nagabhushan@est.tech> Change-Id: I8bcaeb11536aa1c7ad8d15f00bdf5663e6a059b5
2020-06-21Fix Assert usageChrisC1-244/+243
Sonar Fix, fix assert usage in this file Issue-ID: SDC-3116 Signed-off-by: ChrisC <christophe.closset@intl.att.com> Change-Id: I292649e84e589a35eb69139de53b3ee95223be26
2020-06-16Manifest is optional in ETSI SOL004 manifestMichaelMorris2-1/+60
SOL004MetaDirectoryValidtor enforces all files contained in an ETSI SOL004 CSAR are included in the manifest file, however the manifest itself is not mandatory to include in the manifest Signed-off-by: MichaelMorris <michael.morris@est.tech> Issue-ID: SDC-3057 Change-Id: I460071ecbd21578edb0603f600da0ac1ea877539
2020-05-12Remove powermock from SecurityManagerTestRodrigo Lima2-15/+10
- Add new package level constructor to SecurityManager - Remove powermock from SecurityManagerTest Issue-ID: SDC-3054 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I04c53601f31d2aad84de8f8801f6889f8b9d4260
2020-04-20Fix Tosca properties declarationaribeiro1-1/+1
Remove duplicated entries Default value for Boolean type should not be a String According to the description for the keyname 'attachments:' it should be of type List rather than String Issue-ID: SDC-2870 Signed-off-by: aribeiro <anderson.ribeiro@est.tech> Change-Id: Iac2b4f89dac16a6aef9dcabea74def5cacff99a6
2020-04-16Upgrade Junit to version 5.6Baumel, Dvir (db384r)1-2/+2
Issue-ID: SDC-2844 Change-Id: I4716bf7920f9bb79c450ebfd48e9d4fba54fdfdd Signed-off-by: Baumel, Dvir (db384r) <dvir.baumel@intl.att.com>
2020-04-05Fix data type properties declarationaribeiro2-2/+2
According to TOSCA Network properties definition the keyname 'ip_version:' should have Integer as valid_values rather than String Where the keyname 'count:' is declared as a String type the default value should be String rather than Integer Fix misspelled ONAP types 'onap.datatypes.monitoring.measurementType' and 'onap.datatypes.monitoring.managedObjectDNsBasic' Fix the keynames 'upstream:' and 'downstream:' as both are declared as a String type the valid_values should be String rather than Integer Issue-ID: SDC-2864 Signed-off-by: aribeiro <anderson.ribeiro@est.tech> Change-Id: I56afdf2818b5f2463fb6088cd8b468fd38ef5086
2020-03-15Allow other entries for SOL004 Tosca.metaandre.schmid5-101/+101
Besides the mandatory entries, any other entry will be accepted in the TOSCA.meta file, as far as it has a valid format <name>: <value>. Change-Id: I941a62dbb43167e7e0424deae11a2664e61c8a6c Issue-ID: SDC-2781 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-12-20Unique identifier for test executionatulpurohit3-812/+779
Issue-ID: SDC-2584 Co-authored-by: nikhil.soni@vodafone.com Signed-off-by: atulpurohit <atul.purohit1@vodafone.com> Change-Id: I3e7f1a84935cbcd26f8a42a6e2d2dbcb7533cb19 Signed-off-by: atulpurohit <atul.purohit1@vodafone.com>
2019-11-20Validate non-mano software information artifactandre.schmid10-177/+383
Change-Id: Ie9fabd6af821b830e211ff1068fb287357fd38ee Issue-ID: SDC-2619 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-11-20Onboard PNF software versionandre.schmid4-52/+9
Change-Id: Id9e32e01f6c2f4c39c8ff10816d982cbb3063bf7 Issue-ID: SDC-2589 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-11-03Validate artifacts signature in SOL004 packageandre.schmid12-287/+468
Change-Id: Ib048f4501fd8a81cdf11fab19f149350011f772e Issue-ID: SDC-2632 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-11-03Create new non-mano Artifact Type entry for pnf software informationaribeiro2-1/+5
Issue-ID: SDC-2615 Change-Id: I4dd879d50b1dec58aceeaf0c265901c62d038071 Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2019-11-03Centralize onboarding package validationandre.schmid32-194/+828
Change-Id: I3cc58cf15f62008e83cfc7ddb095d07ab216b82a Issue-ID: SDC-2583 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-30Fix zip slip security flawandre.schmid2-2/+5
Apply zip slip checking in zip operations throughout the system. Centralizes most of the zip logic in one class. Create tests to zip functionalities and zip slip problem. Change-Id: I721f3d44b34fe6d242c9537f5a515ce1bb534c9a Issue-ID: SDC-1401 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-29Fix for status properties value.aribeiro8-322/+322
These changes were made to align the normative types to the TOSCA property definition requirements. Issue-ID: SDC-322 Change-Id: I32e815dd26990dd6c82c859ad051b271db3c8029 Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2019-10-25Avoid duplicated verification if package is signedvasraz1-67/+71
Fix potential thread leak by using try-with-resource. Change-Id: I20eda524cd028b9dfdfa83207a059f4e1dfeff5e Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2580
2019-10-24Fix and refactor manifest parsingandre.schmid6-101/+119
Fix a CMS signature reading expected token. Fix the necessity of a empty line in the end of the manifest. Implement CMS signature, Source checksum algorithm and digest reading. Indicate the line number and content when a manifest error occurs. Remove unnecessary recursive reading. Centralize manifest tokens. Improve tests by checking the expected error. Document the code. Change-Id: I7d12020d8922fc5d4c8d9f238557dfbcc0b65757 Issue-ID: SDC-2563 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-21Fix factory instance creation instabilityandre.schmid12-24/+12
Refactor the factory registry and instance creation. Remove unnecessary static code in Factory creation. Centralize the responsibility to read the factory registry configuration and cache the factory instances in a Singleton called FactoryRegistryManager. Clean the base abstract factory that was sharing non factory code, it had all the factory registry code statically, never used by the concrete factory classes. Change-Id: Ie2e9c29013acd36ddaf15383dd6b06432fbdbb66 Issue-ID: SDC-1905 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-09-03Implement PNFD Model driven conversionandre.schmid1-2/+2
Change-Id: I7427e82353cac17817457294d78953f867d2d6e8 Issue-ID: SDC-2509 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-09-03Onboard Package Handlingaribeiro12-179/+296
Retain the original onboarded package when it comes in zip/csar format. Issue-ID: SDC-2510 Change-Id: Ie293db25eca8872be26ffc8475b25ccace1aab6f Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2019-09-01Fix artifacts references in main TOSCA descriptorandre.schmid5-383/+276
During package conversion, artifacts can have their path changed. References for those artifacts inside the main TOSCA descriptor must be updated accordingly. Change-Id: Idcffb0724c20875ff1decebfec7c47605bfe20dc Issue-ID: SDC-2540 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-08-26Add unit test for DuplicateComputeInComponentErrorBuilder and refactor ↵m.kowalski34-7/+42
ComponentDependencyModelErrorBuilder Issue-ID: SDC-2327 Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com> Change-Id: Icb6cf51f7777a8a9d3b237ecd98579edc11f9ebb
2019-08-21Unit tests - openecomp-sdc-vsp-managerTomasz Golabek8-0/+341
Tests for org.openecomp.sdc.vendorsoftwareproduct Change-Id: I737b8ca71219c3e241f902a34419c685435e467c Issue-ID: SDC-2326 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-08-13Add unit tests for NicInternalNetworkErrorBuilderm.kowalski31-2/+28
Issue-ID: SDC-2327 Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com> Change-Id: I8a6127218edf895b8b43d973348cc47794e212c1
2019-08-06Validate PM Dictionary and VES Events YAML Filesandre.schmid9-123/+768
Validate, during the package onboarding, YAML files declared in the manifest as type onap_ves_events or onap_pm_dictionary under non_mano_artifact_sets. Check if the file is not empty, if has a yaml extension and if it has a valid yaml content. Change-Id: I260d0f5355e9e77b6499f553f8aa9f7e6d0693da Issue-ID: SDC-2475 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-07-21Add unit test for TranslationFileCreationErrorBuilderm.kowalski31-0/+49
Issue-ID: SDC-2327 Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com> Change-Id: Iedb570e14fdf1169da45321d97807aedad2c16d0
2019-07-21Allow relative path for SOL004 descriptors importandre.schmid3-81/+125
Allow the use of relative path on SOL004 descriptors imports. Resolves imports with "/", "../" or "./" entries during validation and package processing. Validate if the reference is inside the package. Fix problem where imported descriptor files, described as a non string scalar yaml entry, were not being checked by the validator. Change-Id: Ie5a32736b6090b4adf178e8714f7460bcd068def Issue-ID: SDC-2422 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-07-19SDC alignment SOL004 2.6.1bilal.iqbal4-7/+7
Updating TOSCA.meta metadata Created-by key to Created-By Issue-ID: SDC-2402 Change-Id: Ice17dac288d745292bdd8d296bd1ae3eedbff223 Signed-off-by: bilal.iqbal <bilal.iqbal@est.tech>
2019-07-17Add unit test for PackageNotFoundErrorBuilderm.kowalski31-0/+52
Issue-ID: SDC-2327 Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com> Change-Id: I7b553f8eb03b7a1bd8d059ea12dcbdff79100f03
2019-07-15Add unit tests for UploadInvalidErrorBuilderm.kowalski31-0/+56
Issue-ID: SDC-2327 Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com> Change-Id: Icf5f64c77f373d27df438bc6bc89a9e1e67eaf0c
2019-07-15Add unit tests for NicInternalNetworkErrorBuilder and ↵m.kowalski32-0/+83
OnboardingMethodErrorBuilder Issue-ID: SDC-2327 Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com> Change-Id: I46e64b3a7a533a20c4e0e5a98aa99c488fa71a6b