summaryrefslogtreecommitdiffstats
path: root/common
AgeCommit message (Collapse)AuthorFilesLines
2019-12-01Fixing sonar issueDmitry Puzikov3-11/+137
Getting rid of nested ifs-fors Change-Id: I71ef686683b7070614c27aabbf6cd058b5d35ffd Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-25Fixing sonar issuesDmitry Puzikov2-43/+96
Simplified method ConfigurationUtils::getProperty. Added unit tests for method. Change-Id: I521661b464e7f60101ee51ccbc9d915bf5030f31 Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-21Fixing sonar issuesDmitry Puzikov1-56/+89
Reduce cyclomatic complexity. Splitted complex method to a set of more simple methods. Change-Id: Ic0be3cccefa520f38af83872ddc3e981205edc36 Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-21Fixing sonar issuesDmitry Puzikov1-1/+5
Logging exception instead of printing trace. Change-Id: I6c24c258fc1b96c74e55aa2f90c82d09f28ef247 Issue-ID: SDC-2660 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-21Fixing sonar issuesDmitry Puzikov1-11/+17
Replaced URL with URI to avoid trigger DNS. Change-Id: If85f1f2780c46e0966f3707af51571f4a7aa2f15 Issue-ID: SDC-2660 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-19Fix for scalar-unit type value.aribeiro3-20/+101
Issue-ID: SDC-323 Change-Id: I7f19a7356e1cd34deca0a168b3cb707ef657b9cb Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2019-11-17Fixing sonar issueDmitry Puzikov1-15/+45
Constant is used instead of repeated literal. Change-Id: I540c09f8ba596398257b34ff3189b1a3ce5ab416 Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-17Fixing sonar issuesDmitry Puzikov1-5/+5
Added logging instead of skipping or printing stacktraces. Change-Id: I258a2a76c295f12b30e200c4519bc1bb0741f642 Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-10-30Fix zip slip security flawandre.schmid1-2/+2
Apply zip slip checking in zip operations throughout the system. Centralizes most of the zip logic in one class. Create tests to zip functionalities and zip slip problem. Change-Id: I721f3d44b34fe6d242c9537f5a515ce1bb534c9a Issue-ID: SDC-1401 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-29Fix for status properties value.aribeiro15-401/+391
These changes were made to align the normative types to the TOSCA property definition requirements. Issue-ID: SDC-322 Change-Id: I32e815dd26990dd6c82c859ad051b271db3c8029 Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2019-10-29Bump SDC version 1.6.0Ofir Sonsino8-8/+8
Change-Id: Ibacb46d19d49023a62caa8f5217086cea6c91ac4 Issue-ID: SDC-2560 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2019-09-10Bump SDC version 1.5.2Ofir Sonsino8-8/+8
Change-Id: Ib672dc8d60a0b6f4b37fd94afe84bc27dfba4c44 Issue-ID: SDC-2560 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2019-09-04common code coverage increasePiotr Darosz46-4/+1657
Add tests for classes in sdc.tosca.datatypes.model package Change-Id: Ifc277512d833b2501f0e594b9062d39c26565055 Issue-ID: SDC-2326 Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
2019-09-03Implement PNFD Model driven conversionandre.schmid2-0/+41
Change-Id: I7427e82353cac17817457294d78953f867d2d6e8 Issue-ID: SDC-2509 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-08-26Fixed sonar issues in ConfigurationRepositoryPiotr Borelowski2-10/+20
Fixing sonar issues in onap-configuration-management-core project Issue-ID: SDC-2390 Signed-off-by: Piotr Borelowski <p.borelowski@partner.samsung.com> Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I2814b189eb53f53ab94295ff6bba76d118616800
2019-07-28Update SDC version 1.5.1Ofir Sonsino8-8/+8
Change-Id: Id2182099210982248584c1fcf4569a1360d82f1d Issue-ID: SDC-2478 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2019-07-24Refactor ConfigurationRepositoryTest to remove the powermock.k.kedron2-18/+8
Refactor the ConfigurationRepositoryTest to doesn't affect to other tests. Removed powermock. Issue-ID: SDC-2473 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: Iad67cdce365fef89da8b56499d86139d6927da07
2019-07-17Fix checkstyle violations in sdc-main/commonmichal.banka29-126/+112
Change-Id: I3e132cf4bffd77f9910bf6eff2026c3267873b11 Issue-ID: SDC-2454 Signed-off-by: michal.banka <michal.banka@nokia.com>
2019-07-16Add Lombok support to Repositorynoahs1-27/+6
add @Data annotation Change-Id: I0a56a2f1978035a00eb4edafd5ecc7db6a7301a4 Issue-ID: SDC-2401 Signed-off-by: noahs <noah.shogan@amdocs.com>
2019-07-11Added oparent to sdc mainTomasz Golabek23-10/+290
Removed errors regarding to a missing license and others. Started locally and executed basic api tests Change-Id: Iea37613defc97f7b40613d60c10990841cb2a209 Issue-ID: SDC-2419 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-07-08Move import handling to service templateojasdubey9-3/+304
Moving the handling of all import formats parsing to ServiceTemplate class to make it generic and reusable Change-Id: I80595c3654a625275549a3bb3afe8ba7c9455aff Issue-ID: SDC-2421 Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
2019-07-07Improved the ConfigurationRepositoryTest.k.kedron3-35/+44
Checkstyle for CliConfigurationImpTest. Improved the ConfigurationRepositoryTest to not has an influence on other tests. Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I74b95617ad1b17c26a8d6237c7e7469ef2213596
2019-07-03Added unit tests for ConfigurationRepositoryPiotr Borelowski1-0/+81
Improved the unit test coverage in onap-configuration-management-core project Issue-ID: SDC-2327 Signed-off-by: Piotr Borelowski <p.borelowski@partner.samsung.com> Change-Id: Ib448d3f318a89d65d4b6ae912e3ca38a31b86146
2019-06-23Add Lombok support to RelationshipTypenoahs1-75/+15
add @Data annotation Change-Id: I185a32166a6efe9d221c260a0f25d958dec2690e Issue-ID: SDC-2380 Signed-off-by: noahs <noah.shogan@amdocs.com>
2019-06-17Add lombok support to simple classesOren Kleks1-39/+4
Change-Id: I98ced4b0f30c3b676e02de08ccab0c06bc7b8965 Issue-ID: SDC-2354 Signed-off-by: shrek2000 <orenkle@amdocs.com>
2019-06-17BeanUtils upgrade to 1.9.xOren Kleks1-0/+10
Transitive dependency to beanutils 1.8.3 removed. Refactor of existing usage of beanutils proposed. Change-Id: Ice5a996dc6f782d787309bd9c604335710627b2c Issue-ID: SDC-2269 Signed-off-by: shrek2000 <orenkle@amdocs.com>
2019-06-16BeanUtils upgrade to 1.9.xTomasz Golabek5-12/+103
Transitive dependency to beanutils 1.8.3 removed. Refactor of existing usage of beanutils proposed. Change-Id: I6614a5794979225376338c778b25f71911ae9c50 Issue-ID: SDC-2269 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-06-11Improve unit test in the NonConfigResourceTest and various sonar fixes.k.kedron3-14/+31
Improve the NonConfigResourceTest. Remove the throws the Exception in CliConfigurationImp constructor. ConfigurationImpl class: - Replace the string to chart in indexOf method. - Extract the assigment out from expression Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: If72a75e6a2d81a9ea74e3ae1af94b16a8489a29a
2019-06-06Add lombok support to simple classesshrek20001-26/+6
Change-Id: I1d39f6bc0513189ce0f3581ddc51e9f557d2dadc Issue-ID: SDC-2354 Signed-off-by: shrek2000 <orenkle@amdocs.com>
2019-06-06Add lombok support to simple classesOren Kleks1-56/+4
Change-Id: Ie4c25fd87b3e302f7dd19f4d0156524398e1af55 Issue-ID: SDC-2354 Signed-off-by: shrek2000 <orenkle@amdocs.com>
2019-06-06Add lombok support to simple classesshrek20001-39/+4
Change-Id: I76b00170ba5304bf82df3903cc381d46d7f0f513 Issue-ID: SDC-2354 Signed-off-by: shrek2000 <orenkle@amdocs.com>
2019-06-05Add lombok support to simple classesshrek20001-123/+6
Change-Id: Id4db17168cce9a6a02138c2c6bd74971159994dc Issue-ID: SDC-2354 Signed-off-by: shrek2000 <orenkle@amdocs.com>
2019-06-05Add lombok support to simple classesshrek20001-38/+2
Change-Id: Ic48b301b2e45815bfb9e71d26626ad89cb61d753 Issue-ID: SDC-2354 Signed-off-by: shrek2000 <orenkle@amdocs.com>
2019-06-05Add lombok support to simple classesshrek20001-31/+5
Change-Id: I7060b515880159261fd228bdcfe5e75f84e2d99b Issue-ID: SDC-2354 Signed-off-by: shrek2000 <orenkle@amdocs.com>
2019-06-05Add lombok support to simple classesshrek20001-15/+4
Change-Id: Ic3956c9c6f4fddf412a2216de3d79a2cb2d779b0 Issue-ID: SDC-2354 Signed-off-by: shrek2000 <orenkle@amdocs.com>
2019-06-02Add new unit test for ConfigurationImpl.k.kedron4-16/+185
Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I96269b0bcdf3c1254052d057b8c4ad2d7a48c89d
2019-05-30Improve unit test for ConfigurationUtils and sonar fixesk.kedron2-16/+97
Add more test for ConfigurationUtils. Fix error in getCompatibleCollectionForAbstractDef method bad return value for TransferQueue.class. Sonar fixes: - use not deprecated method IOUtils.toString. - remove code duplication. - return empty collection instead of null. Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I5abb10bca0a1c409ec20daf6c22066836a0b76a3
2019-05-30Add Lombok support to RelationshipTemplatenoahs1-72/+2
add @Data annotation Change-Id: I030c5dc506b3fabcb6f447016dc1e74aeb2df30f Issue-ID: SDC-2343 Signed-off-by: noahs <noah.shogan@amdocs.com>
2019-05-28Add Lombok support to PreconditionDefinitionnoahs1-23/+2
add @Data annotation Change-Id: Ia1482cfb0b1775d4d729df7d0bfc182f59dd15b5 Issue-ID: SDC-2331 Signed-off-by: noahs <noah.shogan@amdocs.com>
2019-05-27Add unit tests for DataModelNormalizeUtilm.kowalski31-0/+90
Issue-ID: SDC-2327 Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com> Change-Id: I31dbd12b2d897da83327c17af2f2d83bd4459f1d
2019-05-07Update SDC version 1.5.0Sonsino, Ofir (os0695)8-8/+8
Change-Id: I22d2273103230bd9ee7c3655b5f33e4308bb9f92 Issue-ID: SDC-1913 Signed-off-by: Sonsino, Ofir (os0695) <os0695@intl.att.com>
2019-04-26Fix for incorrect count of coverageTomasz Golabek1-8/+7
Increased version of junit-jupiter.version and junit-vintage.version Removed junit-platform-surefire-provider (not needed since surefire2.22) Enabled jacoco for some tests from onboarding package Change-Id: I05093b263de1ce93af88a3f99587a4050568caa3 Issue-ID: SDC-2250 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-04-20Fix for jupiter tests execution.Tomasz Golabek1-22/+8
Currently mvn-surefire-plugin doesnt execute junit5 tests. Purpose of this merge request is to resolve the problem. Change-Id: Idb63483c87b1137b21beabed9d24bbff6f01cf53 Issue-ID: SDC-2094 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-04-10READMETomasz Golabek1-0/+72
README for the yaml parser. Change-Id: Id94ec7bf4ba27ccffb31765b279e1ba3b8b50cd1 Issue-ID: SDC-2094 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-04-01Introduced yaml parser as common libTomasz Golabek19-0/+1938
Introduced parser with capability of search for given json paths. Introduced cucumber tests for gab service Change-Id: I154d71085ee82c1ead7c4e002a488524f60c5d8d Issue-ID: SDC-2094 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-03-17Load TOSCA package into Tosca model objectshiria1-1/+5
Change-Id: I24360bcd988df48359eb6092f6a80e989e35f026 Issue-ID: SDC-2192 Signed-off-by: shiria <shiri.amichai@amdocs.com>
2018-11-28Add updated normative typesYuli Shlosberg1-1/+22
Change-Id: I89977232727fd5516111279639a9ca19e7ce5018 Issue-ID: SDC-1962 Signed-off-by: Yuli Shlosberg <ys9693@att.com>
2018-11-15update sdc version in masterMichael Lando5-5/+5
update sdc version to 1.4.0 for master Change-Id: Ia3b16b397b6e01dc185549dd20be399ee67a791a Issue-ID: SDC-1913 Signed-off-by: Michael Lando <michael.lando@intl.att.com>
2018-11-11Deleted artifact generator modulesvempo142-52188/+0
Change-Id: Ibad18285edc1181d7247d395efa8f2322e255147 Issue-ID: SDC-1906 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-11-08Removed dead and duplicate code in onboardingvempo1-106/+101
Change-Id: I2ca0f1a4b00938838213ba2d615ab72c80d6dda3 Issue-ID: SDC-1903 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>