Age | Commit message (Collapse) | Author | Files | Lines |
|
Process NPE safe way.
Add no NPE failures tests.
Add caught exceptions logging.
Issue-ID: SDC-2694
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
Change-Id: Ic1d6e7f9b4f210ac0ca289dc6f44d7c6e15ef126
|
|
Added exxception logging,
added tests.
Change-Id: Ia878030d13570b1445e9b077fce77ca387e69f9a
Issue-ID: SDC-2711
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
|
|
Added tests to increase coverage.
Fixed test faiulures.
Issue-ID: SDC-2710
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
Change-Id: I3fb49f2fc794411347780a904837d8d0c61aa7bf
|
|
Fix sonar issue related to logging
caught exceptions.
Change-Id: I61b2106165a81f3b2f0f9cc0da5911787504f50e
Issue-ID: SDC-2698
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
|
|
Added tests for uncovered default methods.
Change-Id: I3bd88ba5d53a8e5614bd72d2781801fcd5f3fe14
Issue-ID: SDC-2669
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
|
|
Added tests to cover the case.
Fixed provider load failure:
If more than one provider is configured and if the first if failng
try to load next one.
Change-Id: Idd7edb90e2b9b1cf21ec20e299140d3362bd1138
Issue-ID: SDC-2693
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
|
|
Getting rid of nested ifs-fors
Change-Id: I71ef686683b7070614c27aabbf6cd058b5d35ffd
Issue-ID: SDC-2654
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
|
|
Simplified method ConfigurationUtils::getProperty.
Added unit tests for method.
Change-Id: I521661b464e7f60101ee51ccbc9d915bf5030f31
Issue-ID: SDC-2654
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
|
|
Reduce cyclomatic complexity.
Splitted complex method to a set of more simple methods.
Change-Id: Ic0be3cccefa520f38af83872ddc3e981205edc36
Issue-ID: SDC-2654
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
|
|
Logging exception instead of printing trace.
Change-Id: I6c24c258fc1b96c74e55aa2f90c82d09f28ef247
Issue-ID: SDC-2660
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
|
|
Replaced URL with URI to avoid
trigger DNS.
Change-Id: If85f1f2780c46e0966f3707af51571f4a7aa2f15
Issue-ID: SDC-2660
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
|
|
Constant is used instead of repeated literal.
Change-Id: I540c09f8ba596398257b34ff3189b1a3ce5ab416
Issue-ID: SDC-2654
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
|
|
Added logging instead of skipping or printing stacktraces.
Change-Id: I258a2a76c295f12b30e200c4519bc1bb0741f642
Issue-ID: SDC-2654
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
|
|
Change-Id: Ibacb46d19d49023a62caa8f5217086cea6c91ac4
Issue-ID: SDC-2560
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
|
|
Change-Id: Ib672dc8d60a0b6f4b37fd94afe84bc27dfba4c44
Issue-ID: SDC-2560
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
|
|
Fixing sonar issues in onap-configuration-management-core project
Issue-ID: SDC-2390
Signed-off-by: Piotr Borelowski <p.borelowski@partner.samsung.com>
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I2814b189eb53f53ab94295ff6bba76d118616800
|
|
Change-Id: Id2182099210982248584c1fcf4569a1360d82f1d
Issue-ID: SDC-2478
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
|
|
Refactor the ConfigurationRepositoryTest to doesn't affect to other tests.
Removed powermock.
Issue-ID: SDC-2473
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: Iad67cdce365fef89da8b56499d86139d6927da07
|
|
Change-Id: I3e132cf4bffd77f9910bf6eff2026c3267873b11
Issue-ID: SDC-2454
Signed-off-by: michal.banka <michal.banka@nokia.com>
|
|
Removed errors regarding to a missing license and others.
Started locally and executed basic api tests
Change-Id: Iea37613defc97f7b40613d60c10990841cb2a209
Issue-ID: SDC-2419
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
|
|
Checkstyle for CliConfigurationImpTest.
Improved the ConfigurationRepositoryTest
to not has an influence on other tests.
Issue-ID: SDC-2327
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I74b95617ad1b17c26a8d6237c7e7469ef2213596
|
|
Improved the unit test coverage
in onap-configuration-management-core project
Issue-ID: SDC-2327
Signed-off-by: Piotr Borelowski <p.borelowski@partner.samsung.com>
Change-Id: Ib448d3f318a89d65d4b6ae912e3ca38a31b86146
|
|
Transitive dependency to beanutils 1.8.3 removed.
Refactor of existing usage of beanutils proposed.
Change-Id: I6614a5794979225376338c778b25f71911ae9c50
Issue-ID: SDC-2269
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
|
|
Improve the NonConfigResourceTest.
Remove the throws the Exception in CliConfigurationImp constructor.
ConfigurationImpl class:
- Replace the string to chart in indexOf method.
- Extract the assigment out from expression
Issue-ID: SDC-2327
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: If72a75e6a2d81a9ea74e3ae1af94b16a8489a29a
|
|
Issue-ID: SDC-2327
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I96269b0bcdf3c1254052d057b8c4ad2d7a48c89d
|
|
Add more test for ConfigurationUtils.
Fix error in getCompatibleCollectionForAbstractDef method bad return value
for TransferQueue.class.
Sonar fixes:
- use not deprecated method IOUtils.toString.
- remove code duplication.
- return empty collection instead of null.
Issue-ID: SDC-2327
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I5abb10bca0a1c409ec20daf6c22066836a0b76a3
|
|
Change-Id: I22d2273103230bd9ee7c3655b5f33e4308bb9f92
Issue-ID: SDC-1913
Signed-off-by: Sonsino, Ofir (os0695) <os0695@intl.att.com>
|
|
update sdc version to 1.4.0 for master
Change-Id: Ia3b16b397b6e01dc185549dd20be399ee67a791a
Issue-ID: SDC-1913
Signed-off-by: Michael Lando <michael.lando@intl.att.com>
|
|
Removed unused dependencies, inherited versions
from dependencyManagement of the parent.
Change-Id: I324e89e22fa431add147f8d499e01857deb7770a
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
|
|
Change-Id: I703591a9985f9792649622b16f2a05aa89d1d8ea
Issue-ID: SDC-1865
Signed-off-by: Michael Lando <michael.lando@intl.att.com>
|
|
Change-Id: Ibd1a6a23f061c23e8bb0bb603f6ac315581564f6
Issue-ID: SDC-1865
Signed-off-by: Michael Lando <michael.lando@intl.att.com>
|
|
Simplified code, added unit tests.
Change-Id: I0a35daf8a2d4cfd0979e30363c9fad30e7c0570b
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
|
|
Removed code duplicates, stabilized test execution via
Maven, re-aranged code, fixed spelling.
Change-Id: I41fc303ea0a8c7d78d89a12bb20850de51cb8c52
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
|
|
Replaced not thread-safe fields with synchornized versions,
removed duplicate code, deleted class that was accessing DB,
made surefire plugin to pick up all available unit tests
(instead of hand-picked).
Change-Id: Idff3ac333dc87ebfd3ecf50438ba0179556eb9c9
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
|
|
Configuration framework will not poll configuration
for changes, and will not notify client code of them.
Also minor cleanup, added unit tests.
Change-Id: I428b23f7acb13c6610390f46aae6e011d6b0ee80
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
|
|
Added slf4j binding for tests.
Updated patch version of commons-configuration.
Change-Id: Ifef09eb3591f01be4f90f16758448018361dcdb7
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
|
|
Fixed code formatting, removed meaningless Javadoc comments,
added copyright headers, minor (and safe) static analysis fixes.
Change-Id: I3eda1f242905da5b80e024cf30a69ff59381fc43
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
|
|
On Linux, environment variables are case sensitive,
while on Windows they are not.
Change-Id: I49dfd68ab3596ff7ee4a7a53aeba906b606df81b
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
|
|
Conditionally enabled unit tests, fixed a few
static analysis violations, added copyright headers.
Change-Id: I46ccafc5f4397f82b86d5c51bf0452f2060f6a70
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
|
|
Change-Id: I195d96ddf5bd6257ade7eb56c65f9e4bc2d602b6
Issue-ID: SDC-1865
Signed-off-by: Michael Lando <michael.lando@intl.att.com>
|
|
The tests with Thread.sleep() caused a long build time (>7 min).
Aslo fixed formatting, copyright headers, static analysis violations.
Change-Id: I8279478c1e6812facc51730679d2ee4e73e22ec7
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
|
|
Change-Id: I03aea493ef87f4a5234505296b9627886d99c7e6
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
|
|
Change-Id: I7b99fdeeeb66f5de9bcd9283d815976c3d7520b0
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
|
|
Change-Id: Ia35aaca4fc07cf98eed8edff4ce9b73a633b3798
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
|
|
Fortify SDC issue
Change-Id: I7acf3420080ed4c7045aeda1cb1ff0d31d9b5228
Issue-ID: SDC-1644
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
|
|
Change-Id: I48ac8bbc9ed8a7c15401a3af44696be93c5a4d7c
Issue-ID: SDC-1065
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
|
|
Fixes of sonar violations sdc and refactor
This reverts commit baf7f0a965d0ffebd5308d44758bfa9ba96c0c76.
except the catalog files.
the onbording files will be resubmited.
Change-Id: I84c00cec41665211e0bd16ff9cc0c87073d6b897
Issue-ID: SDC-1484
Signed-off-by: Michael Lando <ml636r@att.com>
|
|
Issue-ID: SDC-1484
Change-Id: I3cf17454c533d3419c97af63cc6b5412976726fb
Signed-off-by: Sandra Koblosz <sandra.koblosz@nokia.com>
|
|
Moved dependencies from "dependencies" to "dependencyManagement"
so that they aren't inherited unconditionally to child modules.
Organized and cleaned up dependencies, aligned versions.
Change-Id: I27c7792135ec5b7b2b5b49527bc0ac0d09b024b1
Issue-ID: SDC-1065
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
|
|
Change-Id: I12a5ca14a6d8a87e9316b9ff362eb131105f98a5
Issue-ID: SDC-1566
Signed-off-by: Michael Lando <ml636r@att.com>
|