summaryrefslogtreecommitdiffstats
path: root/common/onap-common-configuration-management
AgeCommit message (Collapse)AuthorFilesLines
2020-06-17Reduce nest statement levelsxuegao1-32/+34
Reduce the if/for/switch/try nest statement levels to less than 3. Issue-ID: SDC-3119 Signed-off-by: xuegao <xg353y@intl.att.com> Change-Id: I60f0c0203db4495c6e10127114acdb8586867b14 Signed-off-by: xuegao <xg353y@intl.att.com>
2020-06-17Reduce nest statement levelsxuegao1-10/+11
Reduce the if/for/switch/try nest statement levels to less than 3. Issue-ID: SDC-3118 Signed-off-by: xuegao <xg353y@intl.att.com> Change-Id: I490e66a807a0a8508b7e3c1da332546f2ced3005
2020-06-15Fix Critical security vulnerabilityvasraz1-0/+6
com.fasterxml.jackson.core : jackson-databind : 2.9.9 Change-Id: I81af7879cb1fbcd158177a3dc220b704ff2f3388 Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-3111
2020-05-07Reduce scope from 'compile' to 'test' for 'junit-vintage-engine'vasraz2-0/+2
Change-Id: I39b0be6ba6650c9a7215acf359f3d74e0a24e553 Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2844 Issue-ID: SDC-2983
2020-05-06Prepare for Junit5vasraz2-130/+148
Remove unused/duplicated dependencies Change-Id: Iee0d9510ffbe3e2e14574e22ba965d6829fd568b Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2844 Issue-ID: SDC-2983
2020-03-12Disable SecurityFilterOfir Sonsino3-3/+3
Bumping version to 1.7.0 Change-Id: I041bb5ce967b687e10be97dbbaa3ba1d119d13ff Issue-ID: SDC-2825 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2020-02-02Move to version 1.6.1shrek20003-3/+3
Move SDC to version 1.6.1 Issue-ID: SDC-2755 Signed-off-by: shrek2000 <oren.kleks@amdocs.com> Change-Id: If5c55fdebb5bc2591190ee4389487f6dbb0e1831 Signed-off-by: shrek2000 <oren.kleks@amdocs.com>
2020-01-29Fixed sonar issuesDmitry Puzikov3-357/+574
Refactored overcomplicated methods by splitting into the more simple. Remove redundant conditional checks. Move common checks into the utils class. Fixed raw types usage where it is possible. Add some tests. Fixed typos in test names. Fixed lost switch branch. Issue-ID: SDC-2698 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com> Change-Id: Ifb5887401be4b397267b2f922cc9ad3f01c757f6
2019-12-15Fix unprocessed NPEDmitry Puzikov3-53/+84
Process NPE safe way. Add no NPE failures tests. Add caught exceptions logging. Issue-ID: SDC-2694 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com> Change-Id: Ic1d6e7f9b4f210ac0ca289dc6f44d7c6e15ef126
2019-12-15Fix different sonar issuesDmitry Puzikov2-1/+59
Added exxception logging, added tests. Change-Id: Ia878030d13570b1445e9b077fce77ca387e69f9a Issue-ID: SDC-2711 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-12-15Fix the lack of test coverage reported by sonarDmitry Puzikov1-0/+48
Added tests to increase coverage. Fixed test faiulures. Issue-ID: SDC-2710 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com> Change-Id: I3fb49f2fc794411347780a904837d8d0c61aa7bf
2019-12-05Logged all caught exceptionsDmitry Puzikov1-5/+30
Fix sonar issue related to logging caught exceptions. Change-Id: I61b2106165a81f3b2f0f9cc0da5911787504f50e Issue-ID: SDC-2698 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-12-01Increase test coverageDmitry Puzikov2-0/+117
Added tests for uncovered default methods. Change-Id: I3bd88ba5d53a8e5614bd72d2781801fcd5f3fe14 Issue-ID: SDC-2669 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-12-01Fix sonar issue with test coverageDmitry Puzikov4-2/+121
Added tests to cover the case. Fixed provider load failure: If more than one provider is configured and if the first if failng try to load next one. Change-Id: Idd7edb90e2b9b1cf21ec20e299140d3362bd1138 Issue-ID: SDC-2693 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-12-01Fixing sonar issueDmitry Puzikov3-11/+137
Getting rid of nested ifs-fors Change-Id: I71ef686683b7070614c27aabbf6cd058b5d35ffd Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-25Fixing sonar issuesDmitry Puzikov2-43/+96
Simplified method ConfigurationUtils::getProperty. Added unit tests for method. Change-Id: I521661b464e7f60101ee51ccbc9d915bf5030f31 Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-21Fixing sonar issuesDmitry Puzikov1-56/+89
Reduce cyclomatic complexity. Splitted complex method to a set of more simple methods. Change-Id: Ic0be3cccefa520f38af83872ddc3e981205edc36 Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-21Fixing sonar issuesDmitry Puzikov1-1/+5
Logging exception instead of printing trace. Change-Id: I6c24c258fc1b96c74e55aa2f90c82d09f28ef247 Issue-ID: SDC-2660 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-21Fixing sonar issuesDmitry Puzikov1-11/+17
Replaced URL with URI to avoid trigger DNS. Change-Id: If85f1f2780c46e0966f3707af51571f4a7aa2f15 Issue-ID: SDC-2660 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-17Fixing sonar issueDmitry Puzikov1-15/+45
Constant is used instead of repeated literal. Change-Id: I540c09f8ba596398257b34ff3189b1a3ce5ab416 Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-17Fixing sonar issuesDmitry Puzikov1-5/+5
Added logging instead of skipping or printing stacktraces. Change-Id: I258a2a76c295f12b30e200c4519bc1bb0741f642 Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-10-29Bump SDC version 1.6.0Ofir Sonsino3-3/+3
Change-Id: Ibacb46d19d49023a62caa8f5217086cea6c91ac4 Issue-ID: SDC-2560 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2019-09-10Bump SDC version 1.5.2Ofir Sonsino3-3/+3
Change-Id: Ib672dc8d60a0b6f4b37fd94afe84bc27dfba4c44 Issue-ID: SDC-2560 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2019-08-26Fixed sonar issues in ConfigurationRepositoryPiotr Borelowski2-10/+20
Fixing sonar issues in onap-configuration-management-core project Issue-ID: SDC-2390 Signed-off-by: Piotr Borelowski <p.borelowski@partner.samsung.com> Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I2814b189eb53f53ab94295ff6bba76d118616800
2019-07-28Update SDC version 1.5.1Ofir Sonsino3-3/+3
Change-Id: Id2182099210982248584c1fcf4569a1360d82f1d Issue-ID: SDC-2478 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2019-07-24Refactor ConfigurationRepositoryTest to remove the powermock.k.kedron2-18/+8
Refactor the ConfigurationRepositoryTest to doesn't affect to other tests. Removed powermock. Issue-ID: SDC-2473 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: Iad67cdce365fef89da8b56499d86139d6927da07
2019-07-17Fix checkstyle violations in sdc-main/commonmichal.banka4-23/+31
Change-Id: I3e132cf4bffd77f9910bf6eff2026c3267873b11 Issue-ID: SDC-2454 Signed-off-by: michal.banka <michal.banka@nokia.com>
2019-07-11Added oparent to sdc mainTomasz Golabek3-3/+3
Removed errors regarding to a missing license and others. Started locally and executed basic api tests Change-Id: Iea37613defc97f7b40613d60c10990841cb2a209 Issue-ID: SDC-2419 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-07-07Improved the ConfigurationRepositoryTest.k.kedron3-35/+44
Checkstyle for CliConfigurationImpTest. Improved the ConfigurationRepositoryTest to not has an influence on other tests. Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I74b95617ad1b17c26a8d6237c7e7469ef2213596
2019-07-03Added unit tests for ConfigurationRepositoryPiotr Borelowski1-0/+81
Improved the unit test coverage in onap-configuration-management-core project Issue-ID: SDC-2327 Signed-off-by: Piotr Borelowski <p.borelowski@partner.samsung.com> Change-Id: Ib448d3f318a89d65d4b6ae912e3ca38a31b86146
2019-06-16BeanUtils upgrade to 1.9.xTomasz Golabek1-5/+6
Transitive dependency to beanutils 1.8.3 removed. Refactor of existing usage of beanutils proposed. Change-Id: I6614a5794979225376338c778b25f71911ae9c50 Issue-ID: SDC-2269 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-06-11Improve unit test in the NonConfigResourceTest and various sonar fixes.k.kedron3-14/+31
Improve the NonConfigResourceTest. Remove the throws the Exception in CliConfigurationImp constructor. ConfigurationImpl class: - Replace the string to chart in indexOf method. - Extract the assigment out from expression Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: If72a75e6a2d81a9ea74e3ae1af94b16a8489a29a
2019-06-02Add new unit test for ConfigurationImpl.k.kedron4-16/+185
Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I96269b0bcdf3c1254052d057b8c4ad2d7a48c89d
2019-05-30Improve unit test for ConfigurationUtils and sonar fixesk.kedron2-16/+97
Add more test for ConfigurationUtils. Fix error in getCompatibleCollectionForAbstractDef method bad return value for TransferQueue.class. Sonar fixes: - use not deprecated method IOUtils.toString. - remove code duplication. - return empty collection instead of null. Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I5abb10bca0a1c409ec20daf6c22066836a0b76a3
2019-05-07Update SDC version 1.5.0Sonsino, Ofir (os0695)3-3/+3
Change-Id: I22d2273103230bd9ee7c3655b5f33e4308bb9f92 Issue-ID: SDC-1913 Signed-off-by: Sonsino, Ofir (os0695) <os0695@intl.att.com>
2018-11-15update sdc version in masterMichael Lando3-3/+3
update sdc version to 1.4.0 for master Change-Id: Ia3b16b397b6e01dc185549dd20be399ee67a791a Issue-ID: SDC-1913 Signed-off-by: Michael Lando <michael.lando@intl.att.com>
2018-11-06Cleaned up POM of configuration frameworkvempo1-11/+0
Removed unused dependencies, inherited versions from dependencyManagement of the parent. Change-Id: I324e89e22fa431add147f8d499e01857deb7770a Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-11-05bump sdc version to 1.3.3Michael Lando3-3/+3
Change-Id: I703591a9985f9792649622b16f2a05aa89d1d8ea Issue-ID: SDC-1865 Signed-off-by: Michael Lando <michael.lando@intl.att.com>
2018-11-01update sdc to version 1.3.2Michael Lando3-14/+14
Change-Id: Ibd1a6a23f061c23e8bb0bb603f6ac315581564f6 Issue-ID: SDC-1865 Signed-off-by: Michael Lando <michael.lando@intl.att.com>
2018-11-01Fixed Sonar violations in configurationvempo3-64/+209
Simplified code, added unit tests. Change-Id: I0a35daf8a2d4cfd0979e30363c9fad30e7c0570b Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-10-31Removed JMX, other unused code from configurationvempo11-321/+275
Removed code duplicates, stabilized test execution via Maven, re-aranged code, fixed spelling. Change-Id: I41fc303ea0a8c7d78d89a12bb20850de51cb8c52 Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-10-28Handled not thread-safe fields in configurationvempo8-158/+62
Replaced not thread-safe fields with synchornized versions, removed duplicate code, deleted class that was accessing DB, made surefire plugin to pick up all available unit tests (instead of hand-picked). Change-Id: Idff3ac333dc87ebfd3ecf50438ba0179556eb9c9 Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-10-28Removed support of dynamic configurationvempo30-961/+107
Configuration framework will not poll configuration for changes, and will not notify client code of them. Also minor cleanup, added unit tests. Change-Id: I428b23f7acb13c6610390f46aae6e011d6b0ee80 Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-10-28Enabled unit tests of configuration frameworkvempo2-6/+35
Added slf4j binding for tests. Updated patch version of commons-configuration. Change-Id: Ifef09eb3591f01be4f90f16758448018361dcdb7 Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-10-28Code formatting of configuration frameworkvempo52-3820/+2895
Fixed code formatting, removed meaningless Javadoc comments, added copyright headers, minor (and safe) static analysis fixes. Change-Id: I3eda1f242905da5b80e024cf30a69ff59381fc43 Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-10-25Fixed configuration tests to run on Linuxvempo23-22/+32
On Linux, environment variables are case sensitive, while on Windows they are not. Change-Id: I49dfd68ab3596ff7ee4a7a53aeba906b606df81b Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-10-25Removed code that stored configuration in DBvempo8-495/+231
Conditionally enabled unit tests, fixed a few static analysis violations, added copyright headers. Change-Id: I46ccafc5f4397f82b86d5c51bf0452f2060f6a70 Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-10-24update sdc version to 1.3.1Michael Lando3-3/+3
Change-Id: I195d96ddf5bd6257ade7eb56c65f9e4bc2d602b6 Issue-ID: SDC-1865 Signed-off-by: Michael Lando <michael.lando@intl.att.com>
2018-10-24Removed config test with Thread.sleepvempo26-852/+189
The tests with Thread.sleep() caused a long build time (>7 min). Aslo fixed formatting, copyright headers, static analysis violations. Change-Id: I8279478c1e6812facc51730679d2ee4e73e22ec7 Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-10-24Deleted empty configuration tests modulevempo2-49/+0
Change-Id: I03aea493ef87f4a5234505296b9627886d99c7e6 Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>