summaryrefslogtreecommitdiffstats
path: root/common/onap-common-configuration-management/onap-configuration-management-core/src
AgeCommit message (Collapse)AuthorFilesLines
2020-01-29Fixed sonar issuesDmitry Puzikov3-357/+574
Refactored overcomplicated methods by splitting into the more simple. Remove redundant conditional checks. Move common checks into the utils class. Fixed raw types usage where it is possible. Add some tests. Fixed typos in test names. Fixed lost switch branch. Issue-ID: SDC-2698 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com> Change-Id: Ifb5887401be4b397267b2f922cc9ad3f01c757f6
2019-12-15Fix unprocessed NPEDmitry Puzikov3-53/+84
Process NPE safe way. Add no NPE failures tests. Add caught exceptions logging. Issue-ID: SDC-2694 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com> Change-Id: Ic1d6e7f9b4f210ac0ca289dc6f44d7c6e15ef126
2019-12-15Fix different sonar issuesDmitry Puzikov2-1/+59
Added exxception logging, added tests. Change-Id: Ia878030d13570b1445e9b077fce77ca387e69f9a Issue-ID: SDC-2711 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-12-15Fix the lack of test coverage reported by sonarDmitry Puzikov1-0/+48
Added tests to increase coverage. Fixed test faiulures. Issue-ID: SDC-2710 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com> Change-Id: I3fb49f2fc794411347780a904837d8d0c61aa7bf
2019-12-05Logged all caught exceptionsDmitry Puzikov1-5/+30
Fix sonar issue related to logging caught exceptions. Change-Id: I61b2106165a81f3b2f0f9cc0da5911787504f50e Issue-ID: SDC-2698 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-12-01Fixing sonar issueDmitry Puzikov3-11/+137
Getting rid of nested ifs-fors Change-Id: I71ef686683b7070614c27aabbf6cd058b5d35ffd Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-25Fixing sonar issuesDmitry Puzikov2-43/+96
Simplified method ConfigurationUtils::getProperty. Added unit tests for method. Change-Id: I521661b464e7f60101ee51ccbc9d915bf5030f31 Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-21Fixing sonar issuesDmitry Puzikov1-56/+89
Reduce cyclomatic complexity. Splitted complex method to a set of more simple methods. Change-Id: Ic0be3cccefa520f38af83872ddc3e981205edc36 Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-21Fixing sonar issuesDmitry Puzikov1-1/+5
Logging exception instead of printing trace. Change-Id: I6c24c258fc1b96c74e55aa2f90c82d09f28ef247 Issue-ID: SDC-2660 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-21Fixing sonar issuesDmitry Puzikov1-11/+17
Replaced URL with URI to avoid trigger DNS. Change-Id: If85f1f2780c46e0966f3707af51571f4a7aa2f15 Issue-ID: SDC-2660 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-17Fixing sonar issueDmitry Puzikov1-15/+45
Constant is used instead of repeated literal. Change-Id: I540c09f8ba596398257b34ff3189b1a3ce5ab416 Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-17Fixing sonar issuesDmitry Puzikov1-5/+5
Added logging instead of skipping or printing stacktraces. Change-Id: I258a2a76c295f12b30e200c4519bc1bb0741f642 Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-08-26Fixed sonar issues in ConfigurationRepositoryPiotr Borelowski1-10/+13
Fixing sonar issues in onap-configuration-management-core project Issue-ID: SDC-2390 Signed-off-by: Piotr Borelowski <p.borelowski@partner.samsung.com> Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I2814b189eb53f53ab94295ff6bba76d118616800
2019-07-24Refactor ConfigurationRepositoryTest to remove the powermock.k.kedron1-11/+8
Refactor the ConfigurationRepositoryTest to doesn't affect to other tests. Removed powermock. Issue-ID: SDC-2473 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: Iad67cdce365fef89da8b56499d86139d6927da07
2019-07-17Fix checkstyle violations in sdc-main/commonmichal.banka3-23/+28
Change-Id: I3e132cf4bffd77f9910bf6eff2026c3267873b11 Issue-ID: SDC-2454 Signed-off-by: michal.banka <michal.banka@nokia.com>
2019-07-11Added oparent to sdc mainTomasz Golabek2-2/+2
Removed errors regarding to a missing license and others. Started locally and executed basic api tests Change-Id: Iea37613defc97f7b40613d60c10990841cb2a209 Issue-ID: SDC-2419 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-07-07Improved the ConfigurationRepositoryTest.k.kedron2-35/+38
Checkstyle for CliConfigurationImpTest. Improved the ConfigurationRepositoryTest to not has an influence on other tests. Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I74b95617ad1b17c26a8d6237c7e7469ef2213596
2019-07-03Added unit tests for ConfigurationRepositoryPiotr Borelowski1-0/+81
Improved the unit test coverage in onap-configuration-management-core project Issue-ID: SDC-2327 Signed-off-by: Piotr Borelowski <p.borelowski@partner.samsung.com> Change-Id: Ib448d3f318a89d65d4b6ae912e3ca38a31b86146
2019-06-11Improve unit test in the NonConfigResourceTest and various sonar fixes.k.kedron3-14/+31
Improve the NonConfigResourceTest. Remove the throws the Exception in CliConfigurationImp constructor. ConfigurationImpl class: - Replace the string to chart in indexOf method. - Extract the assigment out from expression Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: If72a75e6a2d81a9ea74e3ae1af94b16a8489a29a
2019-06-02Add new unit test for ConfigurationImpl.k.kedron4-16/+185
Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I96269b0bcdf3c1254052d057b8c4ad2d7a48c89d
2019-05-30Improve unit test for ConfigurationUtils and sonar fixesk.kedron2-16/+97
Add more test for ConfigurationUtils. Fix error in getCompatibleCollectionForAbstractDef method bad return value for TransferQueue.class. Sonar fixes: - use not deprecated method IOUtils.toString. - remove code duplication. - return empty collection instead of null. Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I5abb10bca0a1c409ec20daf6c22066836a0b76a3
2018-11-01Fixed Sonar violations in configurationvempo3-64/+209
Simplified code, added unit tests. Change-Id: I0a35daf8a2d4cfd0979e30363c9fad30e7c0570b Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-10-31Removed JMX, other unused code from configurationvempo8-311/+233
Removed code duplicates, stabilized test execution via Maven, re-aranged code, fixed spelling. Change-Id: I41fc303ea0a8c7d78d89a12bb20850de51cb8c52 Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-10-28Handled not thread-safe fields in configurationvempo7-154/+62
Replaced not thread-safe fields with synchornized versions, removed duplicate code, deleted class that was accessing DB, made surefire plugin to pick up all available unit tests (instead of hand-picked). Change-Id: Idff3ac333dc87ebfd3ecf50438ba0179556eb9c9 Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-10-28Removed support of dynamic configurationvempo24-773/+27
Configuration framework will not poll configuration for changes, and will not notify client code of them. Also minor cleanup, added unit tests. Change-Id: I428b23f7acb13c6610390f46aae6e011d6b0ee80 Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-10-28Enabled unit tests of configuration frameworkvempo1-0/+29
Added slf4j binding for tests. Updated patch version of commons-configuration. Change-Id: Ifef09eb3591f01be4f90f16758448018361dcdb7 Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-10-28Code formatting of configuration frameworkvempo43-2745/+2362
Fixed code formatting, removed meaningless Javadoc comments, added copyright headers, minor (and safe) static analysis fixes. Change-Id: I3eda1f242905da5b80e024cf30a69ff59381fc43 Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-10-25Fixed configuration tests to run on Linuxvempo23-22/+32
On Linux, environment variables are case sensitive, while on Windows they are not. Change-Id: I49dfd68ab3596ff7ee4a7a53aeba906b606df81b Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-10-25Removed code that stored configuration in DBvempo7-478/+206
Conditionally enabled unit tests, fixed a few static analysis violations, added copyright headers. Change-Id: I46ccafc5f4397f82b86d5c51bf0452f2060f6a70 Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-10-24Removed config test with Thread.sleepvempo26-852/+189
The tests with Thread.sleep() caused a long build time (>7 min). Aslo fixed formatting, copyright headers, static analysis violations. Change-Id: I8279478c1e6812facc51730679d2ee4e73e22ec7 Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-10-24Moved config tests into config modulevempo107-0/+2496
Change-Id: I7b99fdeeeb66f5de9bcd9283d815976c3d7520b0 Issue-ID: SDC-1867 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-08-07Revert commitMichael Lando4-172/+79
Fixes of sonar violations sdc and refactor This reverts commit baf7f0a965d0ffebd5308d44758bfa9ba96c0c76. except the catalog files. the onbording files will be resubmited. Change-Id: I84c00cec41665211e0bd16ff9cc0c87073d6b897 Issue-ID: SDC-1484 Signed-off-by: Michael Lando <ml636r@att.com>
2018-08-06Fixes of sonar violations sdc and refactorkoblosz4-79/+172
Issue-ID: SDC-1484 Change-Id: I3cf17454c533d3419c97af63cc6b5412976726fb Signed-off-by: Sandra Koblosz <sandra.koblosz@nokia.com>
2018-07-29re base codeMichael Lando10-54/+37
Change-Id: I12a5ca14a6d8a87e9316b9ff362eb131105f98a5 Issue-ID: SDC-1566 Signed-off-by: Michael Lando <ml636r@att.com>
2018-07-24Fix sonar violationsWojciech Sliwka2-54/+57
Fix major sonar violations in ConfigurationUtils,ConfigurationImpl, PropertyType Issue-ID: SDC-1353 Change-Id: Ic3959ba174f0a9fcd3976c9d12c6425dc4353e72 Signed-off-by: Wojciech Sliwka <wojciech.sliwka@nokia.com>
2018-05-14Fixes several sonarqube reported issuesdekstroza3-296/+296
Fixes couple of major sonar reported issues, code is reformatted using ONAP java code style Issue-ID: SDC-1270 Change-Id: I8ae52deac5cf73eaedb0f104d72e5f4446239c6a Signed-off-by: dekstroza <dejan.kitic@ericsson.com>
2018-05-06This patch removes first chunk of duplicated codeDejan Kitic1-36/+19
Removing some of the duplicated code, and few minor code simplifications. Keeping the original file formatting to make review easier, will update the patch and reformat the file to comply with ONAP java code requirements Issue-ID: SDC-1270 Change-Id: I3f6393a19197754bcb860957b0db87100a8ac893 Signed-off-by: dekstroza <dejan.kitic@ericsson.com>
2018-04-30Rename packages from openecomp to onap.amitjai21-0/+3769
This task is all about package name space change also make changes to pom for common module Change-Id: Ie9bda0f958a9a05826c0374830cc9cb7d6d196b6 Issue-ID: SDC-1272 Signed-off-by: amitjai <amitjai@amdocs.com>