aboutsummaryrefslogtreecommitdiffstats
path: root/catalog-be/src/test/java
AgeCommit message (Collapse)AuthorFilesLines
2020-05-27Refactor CsarUtils::WriteArtifactDefinitionFrancis Toth1-18/+2
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I167a05d8fbc2085a3e25eeb5bfd6b30f0e80462e Issue-ID: SDC-2812
2020-05-18Refactor CsarUtil::extractVfcArtifactFrancis Toth1-3/+9
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: Ica8d17d4f3c763920f406ccb89fb3e464d05eab4 Issue-ID: SDC-2812
2020-05-10Refactor to remove false positives from SonarChris André1-0/+25
- change `updateResourceInstancesNames` to account for case where `preparedResource` is null - change `findInputByName` to return an Either<InputDefinition, RuntimeException> in order to make exceptions explicit - create `rollbackWithEither` (+ tests) to make exceptions more explicit Issue-ID: SDC-2992 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I487994a3f9e88b0a2b14d2679c3587d85d8aa12d
2020-05-10Refactor ArtifactsBusinessLogic::handleDelete and ↵Francis Toth2-14/+6
ArtifactsBusinessLogic::deleteArtifactByInterface Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I89f12c70f388375ed13554edf62bf6a442c9036a Issue-ID: SDC-2812
2020-05-10Moved ArtifactsBusinessLogic::buildJsonStringForCsarVfcArtifact to JsonUtilsFrancis Toth2-12/+72
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: Ia3bb9fe9f97e1759e4e5b70eb5e5396ed87d716d Issue-ID: SDC-2961
2020-05-07Support functions in TOSCA Simple Profile in YAMLvasraz1-2/+1
This commit aim to generalize usage of ToscaFunctions enum Change-Id: Iab3529e101f75db5f856778334a852afb532cdb6 Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2982
2020-05-06Prepare for Junit5vasraz8-55/+103
Remove unused/duplicated dependencies Change-Id: Iee0d9510ffbe3e2e14574e22ba965d6829fd568b Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2844 Issue-ID: SDC-2983
2020-05-06fix bug - Unable to link CSAR artifactYuli Shlosberg1-1/+3
Change-Id: I586637f988b84b3b858e2c8d567c6844be38322b Issue-ID: SDC-2972 Signed-off-by: Yuli Shlosberg <ys9693@att.com>
2020-05-03Extract ArtifactOperationInfo from ArtifactsBusinessLogicFrancis Toth5-31/+26
This commit only intends to extract the inner static class ArtifactOperationInfo from the ArtifactsBusinessLogic class. In addition, getters have been added to get the artifactOperationEnum field's state (this allowed to reduce some boilerplate). Change-Id: Ib79a75893ef11ba0d25e0578d7e95f60284589d0 Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Issue-ID: SDC-2961
2020-04-28Handle null case in `GroupVersionUpdater`Chris André1-0/+305
- change in the final condition of `isGenerateGroupUUID` - Added tests related to modified code Issue-ID: SDC-2913 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I22738f9f4922467209a16a4d6b3b78d7bfac11c9
2020-04-22Fix unit tests not runningBaumel, Dvir (db384r)1-7/+0
Change-Id: I06462b6180a1f1a310aae994f4e703a498f80247 Issue-ID: SDC-2933 Signed-off-by: Baumel, Dvir (db384r) <dvir.baumel@intl.att.com>
2020-04-22Used `configurationManager` instead of `getConfigurationManager`Chris André1-10/+9
Issue-ID: SDC-2890 Change-Id: I1559ebc60076bd0884ae1136c9c904f7ab46e72e Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
2020-04-19Configure a new Artifact Typeandre.schmid10-185/+411
Centralizes artifact configuration in one yaml entry. Allow the configuration of a new artifact type without the need of code changes. The configuration file now is used as a source of artifacts types instead the artifact type enum. The enum will be used as a source of base artifact types and also in hard coded business rules. Change-Id: Id0383d9fca9bce0519a4d52a4ecb3a68c8713f0f Issue-ID: SDC-2754 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-16Upgrade Junit to version 5.6Baumel, Dvir (db384r)3-30/+45
Issue-ID: SDC-2844 Change-Id: I4716bf7920f9bb79c450ebfd48e9d4fba54fdfdd Signed-off-by: Baumel, Dvir (db384r) <dvir.baumel@intl.att.com>
2020-04-16Add some unit testsReo Inoue1-0/+71
This change adds unit tests for ComponentLogi to increase test coverage. Issue-ID: SDC-2885 Change-Id: I53e5da1a1022ef2a6e29119cc531b61dcc3020b1 Signed-off-by: Reo Inoue <inoue.reo@jp.fujitsu.com>
2020-04-07Added more tests.k.kedron1-160/+294
Added more unit tests for cover CapabilityRequirementConverter. Issue-ID: SDC-2869 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: If4f252f63cf126aab0961199c296581c0d089b21
2020-04-01Tests added to increase coverageDmitry Puzikov4-0/+238
Change-Id: I16a729385647cb691fb7c94bd8f26a3c19b1b99d Issue-ID: SDC-2861 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2020-03-31Fix catalog-be unit test failureSatoshi Fujii1-1/+1
Fixed catalog-be test failure due to missing imports Change-Id: I91f281302a33b5b8f640100a3f1b77908ae44e7c Issue-ID: SDC-2659 Signed-off-by: Satoshi Fujii <fujii-satoshi@jp.fujitsu.com>
2020-03-31Add 'required in runtime' for service inputsSatoshi Fujii1-3/+47
User may want to set required to true for some inputs so that make sure those input values are given at service instantiation time. By this change 'required in runtime' column is introduced into service inputs table in Properties Assignment screen and user can select required true/false for each input. Change-Id: I0d676d2d20e02c975d51c7f4d2bb63c699743d66 Issue-ID: SDC-2659 Signed-off-by: Satoshi Fujii <fujii-satoshi@jp.fujitsu.com>
2020-03-30Fix unit testsDmitry Puzikov16-170/+59
Added asserts where required, add tests. Replaced getters-setters with Lombok annotations. Fixed incorect SUT in the tests. Removed default constructors used only for tests. Change-Id: I9be29d9c0d891039952178a3c3e1c3a2062d1382 Issue-ID: SDC-2856 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2020-03-26Increase test coveragevasraz2-6/+5
Change-Id: I90606d768c55ad13aa9df62bc4d3f533206db1bc Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2833
2020-03-25Fix unit testsDmitry Puzikov3-203/+413
Add asserts where required, fix tiny issues. Replace getters-setters with Lombok annotations. Change-Id: Icb1a20f400fd8732a3d0ae23b8fe88bc693df1f5 Issue-ID: SDC-2853 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2020-03-24Import of VFC will maintain interface implementationsMichaelMorris3-0/+122
Issue-ID: SDC-2772 Signed-off-by: MichaelMorris <michael.morris@est.tech> Change-Id: Id387ebd67ff0b136d532df70fe8b2b8760edc433
2020-03-24Fix unit testsDmitry Puzikov9-910/+52
Add asserts where required, fix tiny issues. Replace DTO getters-setters with Lombok anntations. Change-Id: I77c7ff2b1b536e357910ab1820ff27e03a16967a Issue-ID: SDC-2849 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2020-03-23Fix unit testsDmitry Puzikov4-10/+51
Add asserts where required, fix tiny issues. Change-Id: I764fb6ab989e6271248a68f488929356ac2069c0 Issue-ID: SDC-2848 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2020-03-22Include derived_from types in generated csararibeiro1-38/+59
Issue-ID: SDC-2775 Change-Id: I7b90ff78c389e5680cacafda2065669f6baf1735 Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2020-03-20Fix unit testsDmitry Puzikov5-110/+58
Add asserts where required, fix tiny issues. Replaced getters-setters with Lombok annotations. Change-Id: I9d75c871870fffe82876e14dd2eb9d3585ecb916 Issue-ID: SDC-2708 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2020-03-20Fix unit testsDmitry Puzikov2-27/+47
Add asserts where required, fix tiny issues. Reverted ApiResourceEnumTest as it will be fixed later. Change-Id: I794e27b0136cf625b9393afe417cd27675f6f891 Issue-ID: SDC-2839 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2020-03-19Fix unit testsDmitry Puzikov3-6/+11
Add asserts where required, fix tiny issues. Change-Id: Ie88a39642fd574745d9fa1f0eeee301ff8e19e23 Issue-ID: SDC-2838 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2020-03-19Fix unit testsDmitry Puzikov2-8/+25
Added asserts where missing into the src/test/java/org/openecomp/sdc/be/components/lifecycle/* Change-Id: Ib888f15c0649e18afe67799fbf540f7a6bb2324a Issue-ID: SDC-2834 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2020-03-18Fix unit tests - add assertsDmitry Puzikov7-134/+253
Add asserts where required, fix tiny issues. Change-Id: I6a3fe8741a5659c9152b48d8d0bd19304ac9d94c Issue-ID: SDC-2823 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2020-03-16Fix broken unit tests in catalog-bevasraz31-132/+102
Change-Id: I9a90a219a6eaec832660e01a359f034060e803c3 Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2783
2020-02-25Policies import when import VSPDmitry Puzikov5-77/+188
Polices import implemented. Error type added for invalid policies. Import tests added. Fix test failures. Got rid of Either in the new code. Change-Id: I3e91cc6d24433c2b3862f407348e71e1e67c3b4e Issue-ID: SDC-2728 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2020-02-25Support import of custom node type namearibeiro2-28/+48
Issue-ID: SDC-2760 Signed-off-by: aribeiro <anderson.ribeiro@est.tech> Change-Id: I3645c737ba367a3576d58afb581c8118eb0f6011
2020-02-13Fix PropertyConvertor initialization (use spring)talig10-283/+278
refactor static InterfacesOperationsToscaUtil to be non-static InterfacesOperationsConverter (as it uses PropertyConvertor), move logic from static ToscaExportUtils to ToscaExportHandler (as it uses PropertyConvertor) Change-Id: I917351ca59ee1e792c7b0850d6a8b246b71b4b03 Issue-ID: SDC-2765 Signed-off-by: talig <talig@amdocs.com>
2020-02-13Update to Portal SDK v2.6Ofir Sonsino1-12/+1
Change-Id: I602891d783ce4c80fca6e9da3c765218d19da993 Issue-ID: SDC-2684 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2020-01-26Increase junit TCsvasraz2-1543/+1634
1. Re-enable disabled TCs (enable = true) 2. Enable @Ignored TCs 3. Add some Assert when missing 4. Remove old unused TCs (covered in UI) Change-Id: I900e52f4860b1fdc5bd1e529a1fe7f5c3491465b Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2672
2020-01-22Catalog alignmentys9693300-12680/+11267
Issue-ID: SDC-2724 Signed-off-by: ys9693 <ys9693@att.com> Change-Id: I52b4aacb58cbd432ca0e1ff7ff1f7dd52099c6fe
2019-12-18Increased code coverage using junitsAnnick Boghossian5-54/+323
Issue-ID: SDC-2699 Change-Id: Ifb0b9616a0218028b06755d6ef7150d54a82ecbb Signed-off-by: Atif Husain <atif.husain@team.telstra.com>
2019-12-11Added datatypes for 3rd Party PartnersAtif Husain1-0/+137
Issue-ID: SDC-2385 Change-Id: Iedc5d5b9b30e7cccd3654a1b6e84514643b6d62f Signed-off-by: Atif Husain <atif.husain@team.telstra.com>
2019-12-11Add service creation API as an External APIDivyang Patel5-33/+238
Issue-ID: SDC-2383 Change-Id: I8490163310e892a7ebb6d7e7275edfdeba24045e Signed-off-by: Atif Husain <atif.husain@team.telstra.com>
2019-11-20Validate non-mano software information artifactandre.schmid3-86/+11
Change-Id: Ie9fabd6af821b830e211ff1068fb287357fd38ee Issue-ID: SDC-2619 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-11-20Onboard PNF software versionandre.schmid9-253/+462
Change-Id: Id9e32e01f6c2f4c39c8ff10816d982cbb3063bf7 Issue-ID: SDC-2589 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-30Fix for missing import merge issueandre.schmid1-26/+21
Some imports from SDC-1952 were lost during the merge of SDC-1401, they were re-added. Change-Id: Ie3af8290f98afe4fd9278c218a47376abcdd1a3c Issue-ID: SDC-1952, SDC-1401 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-30Fix zip slip security flawandre.schmid4-169/+31
Apply zip slip checking in zip operations throughout the system. Centralizes most of the zip logic in one class. Create tests to zip functionalities and zip slip problem. Change-Id: I721f3d44b34fe6d242c9537f5a515ce1bb534c9a Issue-ID: SDC-1401 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-30add artifacts support in TOSCA exported yml fileLiang Ding2-0/+97
Change-Id: I56f8a6a1ce758876e83a7ee8318b79644ae7d5cb Issue-ID: SDC-1952 Signed-off-by: Liang Ding <liang.ding@intel.com>
2019-10-03Fix for error message.aribeiro1-6/+6
Fixing error message for invalid values across SDC backend API. Issue-ID: SDC-2324 Change-Id: If01307138baf7692e398abf20eb75bbe9a8aa394 Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2019-09-04catalog-be code coverage increasePiotr Darosz2-0/+494
Add tests for DistributionCatalogServlet class Change-Id: I3da0460f09c803a0ec5a26bd2c7f70f36c6998a1 Issue-ID: SDC-2326 Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
2019-09-03catalog-be code coverage increasePiotr Darosz1-27/+777
Increase code coverage in ResourcesServlet class Change-Id: I633da1a41d7266dd1b218814bf5d52de73c8d264 Issue-ID: SDC-2326 Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
2019-09-03catalog-be code coverage increasePiotr Darosz1-183/+955
Increase test code coverage in ElementServletTest Change-Id: I65d08d901f30c218e60b5630132d9eb8b4a90a9a Issue-ID: SDC-2326 Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>