Age | Commit message (Collapse) | Author | Files | Lines |
|
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I6d62c1f916aa820f84328d25d2afbc7470397b0d
Issue-ID: SDC-2961
|
|
This commit aims to decouple the component caching logic from CsarUtils to its own class.
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: Ia7e9284639ec8cd87ca5107e12f295e2eb599768
Issue-ID: SDC-2812
|
|
Signed-off-by: MichaelMorris <michael.morris@est.tech>
Issue-ID: SDC-2957
Change-Id: I8a385b02568b3bf3d83a250cbe36a7e7f61e710c
|
|
This change also updates the directives values according to Tosca 1.3 spec
Issue-ID: SDC-3074
Change-Id: Ia6a68c9a23a71a2c17ba2c006990342811aa7b4e
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
|
|
Issue-ID: SDC-2978
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I60942ab1767bf65c806ce796ca62365396b20d93
|
|
- Set ACCESS_EXTERNAL_DTD and ACCESS_EXTERNAL_SCHEMA properties on XML
parsers to prevent XXE attacks
Issue-ID: SDC-3106
Signed-off-by: Neil Derraugh <neil.derraugh@yoppworks.com>
Change-Id: If4e835858dd3d718d37b3ee41fb2fd0c94574c24
|
|
Fix all sonar bugs reported in SwitchoverDetector class + fix all checkstyle issues
Issue-ID: SDC-2931
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: Ic86a3526fc7030e10a61b150058c04a391c40c7b
|
|
Issue-ID: SDC-3079
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
Change-Id: Ie711c61244a4e2d68a96e2814ba2db52e067c6e4
|
|
- Reformatted `downloadResourceInstanceArtifactByUUIDs`
- Fixed Sonar-related warning regarding a NPE in `validateInput`
Issue-ID: SDC-2979
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I5a62daabcc436f28fba1f09317c5723281df15bf
|
|
Add constraints structure to ToscaProperty and implements
the valid_values property.
Change-Id: Id69581582839a8937f0c76c24d6a6bfcc7f0a957
Issue-ID: SDC-3084
Signed-off-by: andre.schmid <andre.schmid@est.tech>
|
|
This commit aims to decouple the zip file writing logic from the CsarUtils::writeComponentInterface function. This should provide a higher level of testability and maintenance thanks to inversion of control. An extra helper has also been added to help the migration from the FJ library to VAVR.
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I4f2df4749cae3082906a80acc39045ac8887ec39
Issue-ID: SDC-2812
|
|
Change-Id: I0101bbe35656b4c7d7405429d95939b892e85402
Issue-ID: SDC-2876
Signed-off-by: MichaelMorris <michael.morris@est.tech>
|
|
Enables interface inputs specified in a node_type to be imported and included in the generated csar
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Change-Id: Ia3acaad50b4091831d0c0471b07ba2b2e9bd380d
Issue-ID: SDC-3077
|
|
Creates an entry point to customize properties of a Service
Component before its creation.
Change-Id: I102a70b37eec498dd9c6df009c38da57d0e5b17f
Issue-ID: SDC-3062
Signed-off-by: andre.schmid <andre.schmid@est.tech>
|
|
Interface types creation logic was not interpreting some allowed TOSCA
entries, that, when declared, were breaking the interface type
creation. Every entry under the interface type was being considered
as an interface operation, but it is possible to have "derived_from",
"version", "metadata" and "description". Also it is not considering
the Interface Type entries "inputs", "operations" and "notifications".
Another thing is that TOSCA 1.3 changes the way operations should be
declared, deprecating the previous way. Now there should be an entry
"operations" with the operations entries under it, instead of having
the operations entries direct under the interface type. The change
allows both types, following the TOSCA rule: if operations entry is
not present, then the deprecated way is considered.
Change-Id: I13218bda60b29d19b9c5565cbfd63ae3250a78bf
Issue-ID: SDC-3075
Signed-off-by: andre.schmid <andre.schmid@est.tech>
|
|
Open the access for two methods in ToscaExportHandler so they
can be called in a CsarEntryGenerator plugin.
Change-Id: I0ee1daab348c0fc85db56428369a5ec190cb0101
Issue-ID: SDC-3083
Signed-off-by: andre.schmid <andre.schmid@est.tech>
|
|
This commit extracts checkArtifactInComponent and checkArtifactInResourceInstance from ArtifactsBusinessLogic. Tests have been added along with a some utility functions designed to generate randomized test data. The former tests were deleted as they were not doing any assertions.
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I1b27c55d064cf4e9a40cd7b152e7ea6032a09276
Issue-ID: SDC-2961
|
|
This change allows to configure which global type file will be added to the generated CSAR
Issue-ID: SDC-3021
Change-Id: I83c0c3f317c4a4e5e8dbf22cb3dbd47e63562d3a
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
|
|
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I167a05d8fbc2085a3e25eeb5bfd6b30f0e80462e
Issue-ID: SDC-2812
|
|
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: Ibb8621a91551a2e4ffcac1145f85ed7983063d02
Issue-ID: SDC-2812
|
|
- extract code to static methods
- throw an explicit exception now if element not found
Issue-ID: SDC-2987
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I693bb53059b056235b567ac1f9f752a33512505a
|
|
After add, update or remove node_filter the component was left locked on SDC
Issue-ID: SDC-3072
Change-Id: I27058760704bd6261619946becda3612a6386432
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
|
|
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I7f32d729a96f696c217631cd019105c17cb36a8c
Issue-ID: SDC-2812
|
|
Change-Id: I9227387c26b6ee4c68c635b78c4980a9c07b3d35
Issue-ID: SDC-3052
Signed-off-by: Ben David, Elad (eb7504) <eb7504@intl.att.com>
|
|
This commit aims to refactor the ArtifactsBusinessLogic::getRelatedComponentInstance, and getRelatedComponentComponentInstance. It improves how Either is used, fixes a potential NullPointerException, reduces some duplication along with cyclomatic complexity.
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I2503f5e2a697f793e4dcf32d7793f83c4a25ff46
Issue-ID: SDC-2812
|
|
This commit aims to remove a redundant cast while preparing the field for some Either refactoring in ArtifactsBusinessLogic. The reasons for removing the wildcard pattern are explained in SDC-3040 (a sub-task of SDC-2812).
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I573c01eca56f096ccb54e564d0144291121bde22
Issue-ID: SDC-2812
|
|
This commit is a first step towards the ArtifactsBusinessLogic::handleDeleteInternal function refactoring. It aims to improve how Either is used, and to reduce its cyclomatic complexity along with some duplications.
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I1b476ccc0e0341975b80c10dc79c5dc1592267f4
Issue-ID: SDC-2812
|
|
- Added test in `changeInstanceVersion` for null value
Issue-ID: SDC-2908
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I42a428c4b245a55b7229e2ec9b781e9af4403662
|
|
This commit aims to make some minor refactoring related to the either used in ArtifactsBusinessLogic::generateAndSaveToscaArtifact.
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I4923e014146a17f1cd035db3513359a2ab8f38f2
Issue-ID: SDC-2812
|
|
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: Ica8d17d4f3c763920f406ccb89fb3e464d05eab4
Issue-ID: SDC-2812
|
|
This commit aims to simplify CsarUtils::populateZip by extracting how a tosca representation is fetched to another function. this enables to reduce the overall cyclomatic complexity of the function. Some additional work still needs to be done especially regarding the ToscaRepresentation and MainYamlWithDependencies classes (These happen to be really similar). This will be done in another change in the near future.
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I93600d0752565de523cf2285b1fa2ba43a96334f
Issue-ID: SDC-2812
|
|
This commit deletes the ArtifactsBusinessLogic::updateArtifactsFlowForInterfaceOperations function as it is no longer used anywhere.
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I1dd950930485fc83bb02c889dafc5461192accbc
Issue-ID: SDC-2812
|
|
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I6a40119540c18469db44e218984b4d4b92d3f4af
Issue-ID: SDC-2812
|
|
This commit aims to refactor how Either is used in ArtifactsBusinessLogic::generateToscaArtifact. In order to keep the refactoring relatively small, we evalute its result at the call site.
Change-Id: I669b30b44e9c69d1b3968fd719c5340b2dff83f5
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Issue-ID: SDC-2812
|
|
- change `updateResourceInstancesNames` to account for case where `preparedResource` is null
- change `findInputByName` to return an Either<InputDefinition, RuntimeException> in order to make exceptions explicit
- create `rollbackWithEither` (+ tests) to make exceptions more explicit
Issue-ID: SDC-2992
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I487994a3f9e88b0a2b14d2679c3587d85d8aa12d
|
|
ArtifactsBusinessLogic::deleteArtifactByInterface
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I89f12c70f388375ed13554edf62bf6a442c9036a
Issue-ID: SDC-2812
|
|
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: Ia3bb9fe9f97e1759e4e5b70eb5e5396ed87d716d
Issue-ID: SDC-2961
|
|
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: Ib78be78780a97c873e710d805dd26273159d5354
Issue-ID: SDC-2812
|
|
This commit aim to generalize usage of ToscaFunctions enum
Change-Id: Iab3529e101f75db5f856778334a852afb532cdb6
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2982
|
|
Change-Id: I7def95b3688877acbc9332cf4174c9d92226f2e2
Issue-ID: SDC-2953
Signed-off-by: Yuli Shlosberg <ys9693@att.com>
|
|
Change-Id: I586637f988b84b3b858e2c8d567c6844be38322b
Issue-ID: SDC-2972
Signed-off-by: Yuli Shlosberg <ys9693@att.com>
|
|
- Change code to handle a null value for `groupDefinitions` as if it was an empty List
Issue-ID: SDC-2910
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I5fca0ab76886e5f6a73a8f05ec35d38848f96dd8
|
|
Issue-ID: SDC-3012
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I56cbf7fb5bd04ad2fbc496231d6abe72066124fe
|
|
- Made multiple variables Optional
Issue-ID: SDC-2991
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: If3dbfd37e933d10698ad1a93b6762c84e30f69b8
|
|
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I3f96d76a07fd32bdbd8b59beb5409eab0b0f3aa8
Issue-ID: SDC-2812
|
|
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I510d1d7fb4f4a7d7152fd5ea6d4d5ff61deea23a
Issue-ID: SDC-2812
|
|
This commit is a minor refactoring required to refactor CsarUtils::collectComponentInstanceArtifacts. In order to keep this commit small, we only focused CsarUtils::collectComponentTypeArtifacts, and removed any output that is not reflected by the function's result type. Modifying an argument is a actually a bad practice as explained in Clean Code by Robert Martin (cf. "Output arguments should be avoided"). This commit aims to enforce this aspect.
Change-Id: Ice4d6c9a78e7706c639dd60bc272253e298bc7be
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Issue-ID: SDC-2812
|
|
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I41994c98515844030eed1d6f2756c9779e864cff
Issue-ID: SDC-2812
|
|
This commit only intends to extract the inner static class ArtifactOperationInfo from the ArtifactsBusinessLogic class. In addition, getters have been added to get the artifactOperationEnum field's state (this allowed to reduce some boilerplate).
Change-Id: Ib79a75893ef11ba0d25e0578d7e95f60284589d0
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Issue-ID: SDC-2961
|
|
This commit aims to refactor the CsarUtils::validateNonMetaArtifact function and make it up to standards regarding how fj.Either should be used.
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: Icadfce7229839e53bd09926b6865f2872c39d1a5
Issue-ID: SDC-2812
|