summaryrefslogtreecommitdiffstats
path: root/asdctool/src/test
AgeCommit message (Collapse)AuthorFilesLines
2021-03-24Improve test coveragexuegao1-21/+22
Add unit tests to improve test coverage. Issue-ID: SDC-3428 Change-Id: I9e00af2824366ae45d47d2dcecf322fd3e9a6fea Signed-off-by: xuegao <xue.gao@intl.att.com>
2021-03-14Remove unused codevasraz4-1189/+0
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Change-Id: Iaf6ddfe041a16ac7c853ae8446ce62c14aa89784 Issue-ID: SDC-3428
2021-03-13Remove unused codeChrisC6-413/+0
Remove unused and untested or poorly tested code for migrating old DB Issue-ID: SDC-3428 Signed-off-by: ChrisC <christophe.closset@intl.att.com> Change-Id: I39b086111b5be8d1caf4d6d45bf92105d03709eb
2021-02-26Improve test coveragevasraz1-158/+0
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-3490 Change-Id: Idb71d433834a8612a5434c84c7f0fdef5573cea2
2021-02-25Fix bugs introduced by new codevasraz1-6/+6
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Change-Id: Ide809e2e83b3f620dd1f173266edbe94967454f5 Issue-ID: SDC-3475
2021-02-22Remove testNG dependenciesvasraz7-48/+52
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Change-Id: Ib7632106f9fc0703a90ec3c41cebd5d22471adfd Issue-ID: SDC-3108
2021-02-20Fix BLOCKER BUGs reported by Sonarvasraz5-227/+222
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Change-Id: I00c466ac3fcbe8fab4629aed3a36bb2d8af3a970 Issue-ID: SDC-3472
2021-01-12Improve test coverageJulien Bertozzi1-15/+14
Issue-ID: SDC-3428 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com> Change-Id: I48b6991fbbea31279246d92692760fc6375c7eb5 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
2020-07-29Improve Utils coverage and improve Sonar scoreJulienBe1-84/+66
Issue-ID: SDC-3131 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com> Change-Id: I784a0ad563141dfb546ec1d227b3eb03e08faef3
2020-07-09Clean ValidatorExecutor hierarchyFrancis Toth8-254/+57
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I9d919b1d57eac1d25c8b3874366c2cb9e906923a Issue-ID: SDC-2499
2020-07-07Add test contracts for ValidatorExecutor and TopologyTemplateValidatorExecutorFrancis Toth4-87/+69
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I10f0de565588e0bc7cd0f47ba7f714eab3f1f7f7 Issue-ID: SDC-2499
2020-07-05Fix sonar issuessebdet1-2/+8
Fix sonar/checkstyle issues in sdc code Issue-ID: SDC-3158 Change-Id: Ic29f9233838e25c195d2b349bfac8e6d56888609 Signed-off-by: sebdet <sebastien.determe@intl.att.com>
2020-07-05Clean CsarUtils::MainYamlWithDependenciesFrancis Toth1-5/+1
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I593dd7bb6a20445899a14da793e8c550e1e14e09 Issue-ID: SDC-2812
2020-06-30Fix typo in package name and classesFrancis Toth11-30/+30
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I55a6efeb4a0c2b4734dc3a091afbc6295599c74b Issue-ID: SDC-2499
2020-06-25Cleaned up ArtifactValidatorExecuter and IArtifactValidatorExecutorFrancis Toth9-195/+133
This commit intends to clean the tests related to ArtifactValidatorExecuter and IArtifactValidatorExecutor by introducing the concept of test contract. Some renaming have to be done to fix the typo in Executer (it should be named Executor), hence the number of changes. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I5cd4512c425ae01f4f1118c9d61e6fce3df94f1d Issue-ID: SDC-2499
2020-06-23Decouple TXT Report file writing and formatting logic (6/6)Francis Toth7-85/+62
This commit moves the writeReportLineToFile from ReportManager to ReportFile, deletes ReportManager (as it's not longer used), and finalizes the decoupling between the writing and the formatting logic of the TXT Report file. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: Ia5cce71535ea808e6e24807ed62ae9b262eab6ad Issue-ID: SDC-2499
2020-06-23Decouple TXT Report file writing and formatting logic (5/6)Francis Toth3-23/+44
This commit aims to move the reportEndOfToolRun function from ReportManager (deprecated) to ReportFile. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I17731864c34ed9a70b1b1e91b89bad835dc72449 Issue-ID: SDC-2499
2020-06-22Decouple TXT Report file writing and formatting logic (4/6)Francis Toth1-12/+9
This commit aims to move the reportValidatorTypeSummary function from ReportManager (deprecated) to ReportFile. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I30898d69bbcdb129a2dac917c4dee3c276556e91 Issue-ID: SDC-2499
2020-06-21Decouple TXT Report file writing and formatting logic (3/6)Francis Toth1-8/+8
This commit aims to move the printValidationTaskStatus function's logic from ReportManager (deprecated) to ReportFile. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: Ic33a519f4c70276d404a83bf7de8a27f0007b285 Issue-ID: SDC-2499
2020-06-21Toggletalio1-1/+1
Add toggling mechanism to catalog side. The first toggleable feature is healing - this was added to healing flow, in healJanusGraphDao Issue-ID: SDC-2874 Signed-off-by: talio <talio@amdocs.com> Change-Id: If386651cab8304ebaf13497ded3a7a50bd60e477 Signed-off-by: talio <talio@amdocs.com>
2020-06-21Fix sonar issuessebdet2-2/+2
Fix sonar/checkstyle issues in sdc code Issue-ID: SDC-3116 Change-Id: I87802cc9edb378bdbe456c3ca4f10d8c6ebe9425 Signed-off-by: sebdet <sebastien.determe@intl.att.com>
2020-06-21Decouple TXT Report file writing and formatting logic (2/6)Francis Toth1-6/+7
This commit aims to move the reportStartValidatorRun function's logic from ReportManager (deprecated) to ReportFile. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I93c2e8f98cdef598094647d734d0deec0f1941db Issue-ID: SDC-2499
2020-06-19Decouple TXT Report file writing and formatting logic (1/6)Francis Toth6-16/+73
This commit is the first of a series aiming to decouple the writing and formatting logic of text report files in the asdc tool. Unfortunately because of a significant amount of technical debt, a small hack had to be done so that the header of the file is not written twice. This will be removed in a future change. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I8d2a7c1353d59562d8026088824c26ae0daa36e9 Issue-ID: SDC-2499
2020-06-18Decouple CSV Report file writing and formatting logicFrancis Toth5-32/+133
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I6168b71bb54192a806ff6aa437788bedad933c76 Issue-ID: SDC-2499
2020-05-28Encapsulate ReportManager's failedVerticesPerTask and resultsPerVertex in ReportFrancis Toth8-18/+38
This commit aims to encapsulate the static fields failedVerticesPerTask and resultsPerVertex in their own class (called Report). In the short terms, any state needing to be passed around will be stored there. Unfortunately, this commit required many minor changes in functions signature (to pass the Report instance). Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I3756d9a939cbd0f2856be72aa2bd24a3980dde49 Issue-ID: SDC-2499
2020-05-17Remove powermock from ValidationConfigManagerTestRodrigo Lima1-8/+2
- Remove powermock reference from ValidationConfigManagerTest Issue-ID: SDC-3064 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: Ib330b0fcaf132e5d67f65b482a80b5b75f8c336b
2020-05-17Remove powermock from ArtifactValidationUtilsTestRodrigo Lima1-24/+17
- Remove powermock reference from ArtifactValidationUtilsTest - Use junit 5 imports instead of junit 4 Issue-ID: SDC-3067 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I6388e133024ed1e7604e90fc24ba3e84a33da4f7
2020-05-17Remove powermock from ReportManagerTestRodrigo Lima1-19/+9
- Remove powermock reference from ReportManagerTest - Use Junit 5 imports instead of junit 4 Issue-ID: SDC-3066 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: Iece6e5741d5f2f5bc5db2ec7c85c63948776d601
2020-05-12Remove outputFullFilePath from ValidationConfigManagerFrancis Toth15-345/+306
This commit aims to extract the outputFullFilePath field from ValidationConfigManager in order to improve testability. This commit contains multiple minor modifications resulting from bubbling up the outputFullFilePath static field to where it is actually set. Most of the modifications result from changing the signature of the functions which formerly relied on ValidationConfigManager.getOutputFullFilePath. Change-Id: I0a28e527cabe606de8af62b8dcbc4b4e70db98ed Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Issue-ID: SDC-2499
2020-04-28Remove csvReportFilePath from ValidationConfigManagerFrancis Toth4-50/+54
This commit aims to extract the csvReportFilePath field from ValidationConfigManager in order to improve testability. This commit contains multiple minor modifications resulting from bubbling up the csvReportFilePath static field to where it is actually set. Put differently, most of the modifications result from changing the signature of the functions which formerly relied on ValidationConfigManager.getCSVReportFilePath. Change-Id: I82c3b0fca8a0f407319e40ecfff45e89ec1d4323 Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Issue-ID: SDC-2499
2020-04-20Remove props from ValidationConfigManagerFrancis Toth1-17/+0
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I1c3a845c44722010e8933876e59752cef00937f0 Issue-ID: SDC-2499
2020-04-19Configure a new Artifact Typeandre.schmid1-1/+1
Centralizes artifact configuration in one yaml entry. Allow the configuration of a new artifact type without the need of code changes. The configuration file now is used as a source of artifacts types instead the artifact type enum. The enum will be used as a source of base artifact types and also in hard coded business rules. Change-Id: Id0383d9fca9bce0519a4d52a4ecb3a68c8713f0f Issue-ID: SDC-2754 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-16Upgrade Junit to version 5.6Baumel, Dvir (db384r)2-8/+10
Issue-ID: SDC-2844 Change-Id: I4716bf7920f9bb79c450ebfd48e9d4fba54fdfdd Signed-off-by: Baumel, Dvir (db384r) <dvir.baumel@intl.att.com>
2020-04-01Increase test coveragevasraz1-99/+0
Change-Id: I290371a025ba3376a013ba464e4dfb601d74aa8b Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2833
2020-03-19Added new unit testsk.kedron3-149/+124
Added new unit tests to GraphMLConverter class. Fixed the Sonar issue. Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I985a860012c0c2b0b6524c0a2346415cb113d83c
2020-03-10Added new unit testsk.kedron2-14/+1616
Added new unit tests to GraphMLDataAnalyzer class. Fixed the Sonar issue. Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I9a61dff2e9b0be1733de00b06c255abb8a3d5a8f
2020-01-26Increase junit TCsvasraz1-118/+126
1. Re-enable disabled TCs (enable = true) 2. Enable @Ignored TCs 3. Add some Assert when missing 4. Remove old unused TCs (covered in UI) Change-Id: I900e52f4860b1fdc5bd1e529a1fe7f5c3491465b Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2672
2020-01-22Catalog alignmentys969351-1279/+636
Issue-ID: SDC-2724 Signed-off-by: ys9693 <ys9693@att.com> Change-Id: I52b4aacb58cbd432ca0e1ff7ff1f7dd52099c6fe
2019-08-22unit tests - asdctoolTomasz Golabek3-0/+147
Additional junit tests Change-Id: I889772efaccbc6f1555d50cd47a02d868348d310 Issue-ID: SDC-2326 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-07-24Autowired annotation for catalog-beTomasz Golabek2-49/+0
Injection of the properties moved to the constructors/setters replacing field annotations. Change-Id: I766ff67e466bec5a91db1035f29e7f919d32e0ea Issue-ID: SDC-2400 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-07-22Improved test for ReportManger, ArtifactValidationUtils and Sonar fixes.k.kedron3-74/+267
Add new ReportManagerHelper to read files with reports. Fixed log.info to print the types of exception in the messages. Removed redundant new lines in the report files. Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: If0135f01a05b0936dad681d16e846a6c6560cc80
2019-07-22Improved the CsarGenerator unit tests.k.kedron2-42/+297
Improved the CsarGeneratoryTest. Checkstyle for CsarGenerator and fixed typos. Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I8159dd47540ee3f5ed8b46f99c494c0cb24ed1d6
2019-07-22Improved unit tests for ArtifactValidationUtils and Sonar fixes.k.kedron3-128/+268
Added new tests for ArtifactValidationUtils. Checkstyle in the ValidationConfigManager and ArtifactValidationUtils. Added private constructor to ValidationConfigManager. Added logger for ArtifactValidationUtils and simplified code. Updated the ValidationConfigManagerTest and ReportManagerTests to not influence on each other. Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I9c7c725792737b6cfa6bba20eeeb3b1d4ef1e471
2019-07-16Fixing buildWojciech Sliwka1-1/+3
Change-Id: Ia75cdf511e44347294bb646add89b6c1f60f239c Issue-ID: SDC-2403 Signed-off-by: Wojciech Sliwka <wojciech.sliwka@nokia.com>
2019-07-16Constructor injection in asdctoolPiotr Darosz16-77/+152
Use constructor injection where possible Change-Id: Ibc80850166406a6e3230f555818988109e6ca776 Issue-ID: SDC-2403 Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
2019-07-14ComponentCache & ComponentCassandraDao removalTomasz Golabek1-6/+0
Also removed all classes uses these two. Change-Id: I6793c3c935ae61c5c65f70d3541c542edf188ab4 Issue-ID: SDC-2389 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-07-11Added oparent to sdc mainTomasz Golabek70-48/+1448
Removed errors regarding to a missing license and others. Started locally and executed basic api tests Change-Id: Iea37613defc97f7b40613d60c10990841cb2a209 Issue-ID: SDC-2419 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-07-07Remove field injection in catalog-daoWojciech Sliwka6-14/+28
Change-Id: I24c3a898fa34491e80074944614722fbb3085515 Issue-ID: SDC-2398 Signed-off-by: Wojciech Sliwka <wojciech.sliwka@nokia.com>
2019-06-23ExportImportMenu testsTomasz Golabek1-0/+272
Main class tested and refactored Change-Id: I379a18c289b613cdc7ecbb1617618af96ffa275b Issue-ID: SDC-2326 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-06-13Added unit tests for SpringCLIToolPiotr Borelowski1-0/+61
Improved the unit test coverage in the package org.openecomp.sdc.asdctool.cli Issue-ID: SDC-2327 Signed-off-by: Piotr Borelowski <p.borelowski@partner.samsung.com> Change-Id: Ie5b262587ae704952eb75f8f4008f4d321a4acbd