summaryrefslogtreecommitdiffstats
path: root/asdctool/src/main/java
AgeCommit message (Collapse)AuthorFilesLines
2020-05-12Remove outputFullFilePath from ValidationConfigManagerFrancis Toth20-328/+323
This commit aims to extract the outputFullFilePath field from ValidationConfigManager in order to improve testability. This commit contains multiple minor modifications resulting from bubbling up the outputFullFilePath static field to where it is actually set. Most of the modifications result from changing the signature of the functions which formerly relied on ValidationConfigManager.getOutputFullFilePath. Change-Id: I0a28e527cabe606de8af62b8dcbc4b4e70db98ed Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Issue-ID: SDC-2499
2020-04-28Remove csvReportFilePath from ValidationConfigManagerFrancis Toth5-56/+55
This commit aims to extract the csvReportFilePath field from ValidationConfigManager in order to improve testability. This commit contains multiple minor modifications resulting from bubbling up the csvReportFilePath static field to where it is actually set. Put differently, most of the modifications result from changing the signature of the functions which formerly relied on ValidationConfigManager.getCSVReportFilePath. Change-Id: I82c3b0fca8a0f407319e40ecfff45e89ec1d4323 Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Issue-ID: SDC-2499
2020-04-23Added early check for null value for `containerV`Chris André1-33/+48
- Formatting code following project's code style - Added early check for null value for `containerV` Issue-ID: SDC-2905 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I648e9a4a04be3f2e7cd3e30a70c04de2257a99d3
2020-04-20Remove props from ValidationConfigManagerFrancis Toth1-30/+1
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I1c3a845c44722010e8933876e59752cef00937f0 Issue-ID: SDC-2499
2020-04-20Fix cs-init SchemaFileImport error file creationandre.schmid1-1/+1
Fix issue in SdcSchemaFileImport "STDERR: Error in file creation : data, /tmp/sdctool/tosca/data-types/data.yml (No such file or directory)", during the cassandra init. Introduced by SDC-2898. Change-Id: Ifd2018fac456f15d03fc39ea766a6ae0c3eda081 Issue-ID: SDC-2939 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-20Added a try-with-resource to properly close a FileInputStreamChris André1-221/+234
Issue-ID: SDC-2898 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I0a0163937ee2e760f3074d858dfc68a7b262ecd9
2020-04-20Added early check for null value for `containerV`Chris André1-33/+48
- Formatting code following project's code style - Added early check for null value for `containerV` Issue-ID: SDC-2904 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: Ib8d7c1bf36608855c73d8a0df637e86aefce9377
2020-04-19Configure a new Artifact Typeandre.schmid1-6/+6
Centralizes artifact configuration in one yaml entry. Allow the configuration of a new artifact type without the need of code changes. The configuration file now is used as a source of artifacts types instead the artifact type enum. The enum will be used as a source of base artifact types and also in hard coded business rules. Change-Id: Id0383d9fca9bce0519a4d52a4ecb3a68c8713f0f Issue-ID: SDC-2754 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-19Removed explicit references to exceptions in log messagesChris André1-2/+1
Issue-ID: SDC-2884 Change-Id: I6f3e9503922cc3a4f4049fced8d23cede7b0455a Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
2020-04-01Increase test coveragevasraz4-116/+28
Change-Id: I290371a025ba3376a013ba464e4dfb601d74aa8b Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2833
2020-03-24Improve log textsLasse Kaihlavirta1-1/+1
Issue-ID: SDC-2852 Signed-off-by: Lasse Kaihlavirta <l.kaihlavirt@partner.samsung.com> Change-Id: I7a1ebfc625e297f943794046f37b15cc48d8cacb
2020-03-22Add support for simple yaml profile 1.2vasraz1-3/+3
Change-Id: I735d25c6b6c3344c4b742f09b3aeaf4d03c2d17c Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2738
2020-03-19Added new unit testsk.kedron2-66/+28
Added new unit tests to GraphMLConverter class. Fixed the Sonar issue. Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I985a860012c0c2b0b6524c0a2346415cb113d83c
2020-03-10Added new unit testsk.kedron1-6/+11
Added new unit tests to GraphMLDataAnalyzer class. Fixed the Sonar issue. Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I9a61dff2e9b0be1733de00b06c255abb8a3d5a8f
2020-01-22Catalog alignmentys969371-1572/+1994
Issue-ID: SDC-2724 Signed-off-by: ys9693 <ys9693@att.com> Change-Id: I52b4aacb58cbd432ca0e1ff7ff1f7dd52099c6fe
2019-11-25Fix Sonar issuevasraz1-1/+1
Major SmellCode: Replace StringBuffer with StringBuilder Change-Id: I0283e5160e5c1f23423c66110015f18c8163411e Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2670
2019-09-03General Sonar fixesArindam Mondal3-7/+5
+)Organize imports ++) log formatter Issue-ID: SDC-2542 Change-Id: Ibb4b568b19ee40a68f783bfa820bd7c73aae5c1f Signed-off-by: arindamm <arind.mondal@samsung.com>
2019-08-27General Sonar fixesArindam Mondal2-647/+491
+) Replace System.out with logger ++) Use try-with-resources to close the resource +++) Format to delete tab charachter ++++) flip equals to avoid potential NPE Issue-ID: SDC-2542 Change-Id: If57f36072ec67e9622d4fe51bce8336094dc10c8 Signed-off-by: arindamm <arind.mondal@samsung.com>
2019-08-22unit tests - asdctoolTomasz Golabek3-123/+163
Additional junit tests Change-Id: I889772efaccbc6f1555d50cd47a02d868348d310 Issue-ID: SDC-2326 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-07-24Autowired annotation for catalog-beTomasz Golabek5-61/+25
Injection of the properties moved to the constructors/setters replacing field annotations. Change-Id: I766ff67e466bec5a91db1035f29e7f919d32e0ea Issue-ID: SDC-2400 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-07-22Improved test for ReportManger, ArtifactValidationUtils and Sonar fixes.k.kedron1-26/+23
Add new ReportManagerHelper to read files with reports. Fixed log.info to print the types of exception in the messages. Removed redundant new lines in the report files. Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: If0135f01a05b0936dad681d16e846a6c6560cc80
2019-07-22Improved the CsarGenerator unit tests.k.kedron1-8/+8
Improved the CsarGeneratoryTest. Checkstyle for CsarGenerator and fixed typos. Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I8159dd47540ee3f5ed8b46f99c494c0cb24ed1d6
2019-07-22Improved unit tests for ArtifactValidationUtils and Sonar fixes.k.kedron2-30/+40
Added new tests for ArtifactValidationUtils. Checkstyle in the ValidationConfigManager and ArtifactValidationUtils. Added private constructor to ValidationConfigManager. Added logger for ArtifactValidationUtils and simplified code. Updated the ValidationConfigManagerTest and ReportManagerTests to not influence on each other. Issue-ID: SDC-2327 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: I9c7c725792737b6cfa6bba20eeeb3b1d4ef1e471
2019-07-16Fixing buildWojciech Sliwka1-2/+8
Change-Id: Ia75cdf511e44347294bb646add89b6c1f60f239c Issue-ID: SDC-2403 Signed-off-by: Wojciech Sliwka <wojciech.sliwka@nokia.com>
2019-07-16Constructor injection in asdctoolPiotr Darosz23-99/+253
Use constructor injection where possible Change-Id: Ibc80850166406a6e3230f555818988109e6ca776 Issue-ID: SDC-2403 Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
2019-07-11Added oparent to sdc mainTomasz Golabek87-60/+1710
Removed errors regarding to a missing license and others. Started locally and executed basic api tests Change-Id: Iea37613defc97f7b40613d60c10990841cb2a209 Issue-ID: SDC-2419 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-07-07Remove field injection in catalog-daoWojciech Sliwka5-12/+22
Change-Id: I24c3a898fa34491e80074944614722fbb3085515 Issue-ID: SDC-2398 Signed-off-by: Wojciech Sliwka <wojciech.sliwka@nokia.com>
2019-06-23ExportImportMenu testsTomasz Golabek1-146/+149
Main class tested and refactored Change-Id: I379a18c289b613cdc7ecbb1617618af96ffa275b Issue-ID: SDC-2326 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-06-12Upgrade SDC from Titan to Janus Graphshrikantawachar30-438/+529
Upgrade SDC from Titan to Janus Graph Change-Id: I67fb8b8e60cc6751697bc5ff2f06754c92803786 Issue-ID: SDC-2296 Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
2019-06-10Inheritance in ComponentExceptionTomasz Golabek1-1/+2
ComponentException was split into ByActionStatus and ByResponseFormat exceptions. Test added for ComponentLockAspectTest in passing Change-Id: I89c9ee966b8b4445e791af897bd60cdb845b845b Issue-ID: SDC-2321 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2019-06-03fix sonar: close resourcesk.kazak2-36/+46
Use try-with-resources to close file data stream Fix tests for GraphJsonValidator Change-Id: I20931b4ef815abfb8da8ebd6242b765d0b02ef23 Issue-ID: SDC-2340 Signed-off-by: k.kazak@samsung.com
2019-03-25fix a typoLiang Ding1-1/+1
retrive -- > retrieve Change-Id: Ic6bce5b991c042cc2d19f1f72dd827644111b105 Issue-ID: SDC-2207 Signed-off-by: Liang Ding <liang.ding@intel.com>
2019-03-18Service Consumption BEojasdubey1-0/+167
1. Service consumption feature backend implementation 2. Operation output bug fix for delete operation not allowed for mapped operation output Change-Id: Ib2554eed4f940b003955263a0c8bf795a23cac9a Issue-ID: SDC-1990 Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
2019-02-26Fix Blocker & Critical Sonar issues in asdctoolParshad Patel3-11/+13
Fix NullPointerException issues Update test case Issue-ID: SDC-1895 Change-Id: I183b0bee127efa4331e79a1b76df558dbc9ca33a Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-11-29Fix critical sonar issuesParshad Patel2-1/+2
Fix rethrow the "InterruptedException" and Use "isAssignableFrom" sonar issues Issue-ID: SDC-1895 Change-Id: I2cadc08b9e7acdc84cf25a3ce9d22199711afa5d Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-11-22asdctool code quality improvementsSonsino, Ofir (os0695)8-48/+64
Change-Id: I443c9bb288d123d10bcc2f1f58f540206fb947fc Issue-ID: SDC-1950 Signed-off-by: Sonsino, Ofir (os0695) <os0695@intl.att.com>
2018-11-19Refactor Code asdctool classesSindhuri.A2-39/+32
Code refactor : asdctool classes Issue-ID: SDC-1880 Change-Id: I9a3bfb20441f7c5df25c6a61b77abcb8268a0d62 Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
2018-11-11Deleted artifact generator modulesvempo1-12/+16
Change-Id: Ibad18285edc1181d7247d395efa8f2322e255147 Issue-ID: SDC-1906 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-09-25Add copyright info for asdctool classesSindhuri.A3-0/+87
Addition of copyright info for asdctool classes Issue-ID: SDC-1754 Change-Id: I3c899fa3d4b9aec7b09c4ee1c81f1a36d64b34e1 Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
2018-09-18Fix use try-with-resources issues in asdctoolParshad Patel2-35/+18
Fix sonar issues in ArtifactValidatorExecuter.java,ExportImportTitanServlet.java Issue-ID: SDC-1672 Change-Id: I39a6376ea61de135bfb824e121adff37b631fdf2 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-08-29Add tests for SdcSchema classesPiotr Darosz1-3/+9
Introduce Cassandra Unit tool and tests for schema-related classes Change-Id: I14da602c42056730e7992dd92b4da8b87dd9fb0d Issue-ID: SDC-1358 Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
2018-08-06ASDC dead code removalPiotr Krysiak7-199/+33
Issue-ID: SDC-1493 Change-Id: I74c1748eb2b1f478a0e44b07c174f95964fed667 Signed-off-by: Piotr Krysiak <piotr.krysiak@nokia.com>
2018-08-05Fix sonar issuesParshad Patel2-35/+27
Fix try-with-resources and NPE issue Issue-ID: SDC-1529 Change-Id: Ia1071608528493e0a1a2985c458998d1197a8c0b Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-08-01sonar issue fix blocker, criticalArindam Mondal2-12/+9
Issue-ID: SDC-1534 Change-Id: I58ae2497568fbdff58a1928bdc1e7187be9f0632 Signed-off-by: Arindam Mondal <arind.mondal@samsung.com>
2018-07-29re base codeMichael Lando76-1738/+3605
Change-Id: I12a5ca14a6d8a87e9316b9ff362eb131105f98a5 Issue-ID: SDC-1566 Signed-off-by: Michael Lando <ml636r@att.com>
2018-07-24Fix use try-with-resources sonar issueParshad Patel1-47/+8
Fix in ArtifactUuidFix.java Issue-ID: SDC-1529 Change-Id: Ic6438acbeebcbd5cdaa078a63700560563c518c6 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-07-10update dockers base version to 1.4.0Yuli Shlosberg2-3/+1
Change-Id: I6c2490ade7ff3071487be5c0e783060390e2a2f1 Issue-ID: SDC-1344 Signed-off-by: Yuli Shlosberg <ys9693@att.com>
2018-07-02first attempt to fix vulnerabilitiesYuli Shlosberg11-85/+98
Change-Id: Iaf5f7db54511f730e09a8af8921d52ebf7f6c078 Issue-ID: SDC-1457 Signed-off-by: Yuli Shlosberg <ys9693@att.com>
2018-06-12update sdc logic for new typesMichael Lando1-19/+35
update sdc conformance level and add logic to package onap normatives. Change-Id: I321eeb0cccf662346eb36cb42420fd8fca72ae32 Issue-ID: SDC-1380 Signed-off-by: Michael Lando <ml636r@att.com>
2018-05-06Raise JUnit coverage asdctoolTal Gitelman21-77/+49
Change-Id: I26742875e8e3dddb98b525c4833588bc23d81fdc Issue-ID: SDC-1296 Signed-off-by: Tal Gitelman <tg851x@intl.att.com>