aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-12-01Fix Security Hotspots issuesvasraz2-4/+11
Change-Id: Icc45769cff71c8153c0afba6e2363b0399144175 Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2671
2019-12-01Fixing sonar issueDmitry Puzikov3-11/+137
Getting rid of nested ifs-fors Change-Id: I71ef686683b7070614c27aabbf6cd058b5d35ffd Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-12-01Add alter_tables.cql to gitignoreandre.schmid1-0/+1
The alter_tables.cql is being copied during build and should be ignored. Change-Id: I0a0a420e17761247a6575ad8715ccbd20fd5c1e1 Issue-ID: SDC-2640 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-12-01Sonar fixes for API to retrieve UI configurationilanap1-6/+8
Added configuration file with the menu configuration from catalog-ui. Added to the configuration manager. to chef and to the ui rest APIs. Issue-ID: SDC-2663 Signed-off-by: ilanap <ilanap@amdocs.com> Change-Id: I032a7666f470e7d4797a555470bf9eb4a43cfcc4
2019-12-01Upgrade Node & npm versionvasraz4-955/+958
Change-Id: Ib41da68543824be671e162eb6c0ba78ded1949cb Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2685
2019-11-27Add API to retrieve UI configurationilanap11-0/+870
Added configuration file with the menu configuration from catalog-ui. Added to the configuration manager. to chef and to the ui rest APIs. Issue-ID: SDC-2663 Signed-off-by: ilanap <ilanap@amdocs.com> Change-Id: Ia5e014a273238981241821c0d81b0455bd662b28 Signed-off-by: ilanap <ilanap@amdocs.com>
2019-11-25Fixing sonar issuesDmitry Puzikov2-43/+96
Simplified method ConfigurationUtils::getProperty. Added unit tests for method. Change-Id: I521661b464e7f60101ee51ccbc9d915bf5030f31 Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-25Fix Sonar issuevasraz13-28/+28
Major SmellCode: Replace StringBuffer with StringBuilder Change-Id: I0283e5160e5c1f23423c66110015f18c8163411e Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2670
2019-11-24update info.yamlshrek20001-0/+8
Change-Id: I9fb6ce18430ad0789a030a9c80dd231f44f6f6de Issue-ID: SDC-2448 Signed-off-by: shrek2000 <oren.kleks@amdocs.com>
2019-11-21Fixing sonar issuesDmitry Puzikov1-56/+89
Reduce cyclomatic complexity. Splitted complex method to a set of more simple methods. Change-Id: Ic0be3cccefa520f38af83872ddc3e981205edc36 Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-21Fixing sonar issuesDmitry Puzikov1-1/+5
Logging exception instead of printing trace. Change-Id: I6c24c258fc1b96c74e55aa2f90c82d09f28ef247 Issue-ID: SDC-2660 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-21Fixing sonar issuesDmitry Puzikov1-11/+17
Replaced URL with URI to avoid trigger DNS. Change-Id: If85f1f2780c46e0966f3707af51571f4a7aa2f15 Issue-ID: SDC-2660 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-21Fix to stabilize sanity ui test suiteandre.schmid69-1645/+1515
Fix the selection of the Resource Composition screen. Fix the search for a Resource in the home screen. Refactor some related classes, mainly removing exceptions not thrown, correcting typos, removing unused/commented code, fixing SonarQube issues. Improve the logs and report logs. Change-Id: I89b5a0d89652367520cededa6744831492bbbaba Issue-ID: SDC-2648 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-11-20Add non-mano software information to sanity test PNF packagesandre.schmid6-28/+27
Adds a sample non-mano artifact onap_pnf_software_information to existing api sanity test PNF packages. Resigns the 2 signed packages with the new root certificate. 2/3 packages are signed, so a new root certificate had to be generated, as the private key of the previous one is missing. In the docker_run script, creates a new folder to the test certificate, different from the production folder, and bind it with the sdc-api-tests docker. Minor changes in docker_run script. Change-Id: I78b28303215912df129a0e0d70afad5f3d0c2d09 Issue-ID: SDC-2641 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-11-20Validate non-mano software information artifactandre.schmid31-545/+841
Change-Id: Ie9fabd6af821b830e211ff1068fb287357fd38ee Issue-ID: SDC-2619 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-11-20Onboard PNF software versionandre.schmid43-472/+1429
Change-Id: Id9e32e01f6c2f4c39c8ff10816d982cbb3063bf7 Issue-ID: SDC-2589 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-11-19update info.yamlOren Kleks1-120/+118
Change-Id: Ic32f39f3424d69e25079b91eec78f79e4ce5e020 Issue-ID: SDC-2448 Signed-off-by: shrek2000 <oren.kleks@amdocs.com>
2019-11-19Fix for scalar-unit type value.aribeiro85-310/+798
Issue-ID: SDC-323 Change-Id: I7f19a7356e1cd34deca0a168b3cb707ef657b9cb Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2019-11-17Fixing sonar issueDmitry Puzikov1-15/+45
Constant is used instead of repeated literal. Change-Id: I540c09f8ba596398257b34ff3189b1a3ce5ab416 Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-17Fixing sonar issuesDmitry Puzikov1-5/+5
Added logging instead of skipping or printing stacktraces. Change-Id: I258a2a76c295f12b30e200c4519bc1bb0741f642 Issue-ID: SDC-2654 Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
2019-11-17Configuration.yaml updatedb384r2-20/+11
Issue-ID: SDC-2658 Signed-off-by: db384r <dvir.baumel@intl.att.com> Change-Id: Icec6ad0fb74f023df58ca1a8c9e5a432bff6285f
2019-11-12add SDC Meta Data for CDS IntegrationAhmed Abbas4-1/+43
Issue-ID: SDC-2631 Signed-off-by: Ahmed Abbas <ahmad.helmy@orange.com> Change-Id: Ie691e323f771b786d154c0614d0cd724635a5ec2
2019-11-10Fix incorrect rendering of search box on VF Properties Assignment tabvasraz2-1/+11
Change-Id: I7abb04fa17c525aaba414f1ba1714211ff08b46c Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2328
2019-11-10Fix sonarQube issue.aribeiro6-3/+60
Issue-ID: SDC-2646 Change-Id: Ic426e1cccf50e3db40381896ee50b74e647129ee Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2019-11-07Align Sdc warnings with VNF RequirementsBen David, Elad (eb7504)3-5/+5
Change-Id: Ic133faed7f8b612279de0eb836e88e9ea6b694d7 Issue-ID: SDC-2647 Signed-off-by: Ben David, Elad (eb7504) <eb7504@intl.att.com>
2019-11-06Fix sonarqube issues introduced by ZipSlip changeandre.schmid4-42/+44
Fix major and critical sonarqube issues introduced by ZipSlip change id I721f3d44b34fe6d242c9537f5a515ce1bb534c9a Change-Id: I3aa2cd4116936d715baba99a38d43aa40fd62a29 Issue-ID: SDC-1401 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-11-05Align logging to Onap-ELS 2019.11Ben David, Elad (eb7504)52-741/+581
Change-Id: I1750493d5c9f2eab8c1395f0fbc9ae66cf74b0a6 Issue-ID: SDC-2639 Signed-off-by: Ben David, Elad (eb7504) <eb7504@intl.att.com>
2019-11-04Add a new package with Custom Types to Sanity test.aribeiro1-0/+0
Issue-ID: SDC-2616 Change-Id: Id290626724488e58b4840408429c1962a19064a0 Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2019-11-04Transform custom types for PNFD.aribeiro36-183/+1524
Transformation of customized Node Types for PNFD. Issue-ID: SDC-2561 Change-Id: Id3e07edff0e5a8cb134aa12c07878e14c33d1512 Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2019-11-04a fix to handle onboard ALTER tablesBen David, Elad (eb7504)1-0/+1
Change-Id: I7e721f267e6e5935231d6e38ac490d9335f68f4b Issue-ID: SDC-2640 Signed-off-by: Ben David, Elad (eb7504) <eb7504@intl.att.com>
2019-11-03Validate artifacts signature in SOL004 packageandre.schmid24-379/+639
Change-Id: Ib048f4501fd8a81cdf11fab19f149350011f772e Issue-ID: SDC-2632 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-11-03Create new non-mano Artifact Type entry for pnf software informationaribeiro16-60/+89
Issue-ID: SDC-2615 Change-Id: I4dd879d50b1dec58aceeaf0c265901c62d038071 Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2019-11-03Centralize onboarding package validationandre.schmid67-755/+1127
Change-Id: I3cc58cf15f62008e83cfc7ddb095d07ab216b82a Issue-ID: SDC-2583 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-11-03Handle onboard ALTER tables to support upgradeBen David, Elad (eb7504)6-117/+130
Change-Id: I6c96aecccf00a3b02bf07cf172ff752b69d3cc94 Issue-ID: SDC-2640 Signed-off-by: Ben David, Elad (eb7504) <eb7504@intl.att.com>
2019-10-30Fix for missing import merge issueandre.schmid1-26/+21
Some imports from SDC-1952 were lost during the merge of SDC-1401, they were re-added. Change-Id: Ie3af8290f98afe4fd9278c218a47376abcdd1a3c Issue-ID: SDC-1952, SDC-1401 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-30DmaapPublisher files updateOfir Sonsino4-15/+15
Change-Id: I72b501587ed0b4ea8f7ba54614361d546b255cf6 Issue-ID: SDC-2560 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2019-10-30Fix zip slip security flawandre.schmid44-2173/+1918
Apply zip slip checking in zip operations throughout the system. Centralizes most of the zip logic in one class. Create tests to zip functionalities and zip slip problem. Change-Id: I721f3d44b34fe6d242c9537f5a515ce1bb534c9a Issue-ID: SDC-1401 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-30Validate SOL004 manifest signature orderandre.schmid7-59/+51
SOL004 Manifest signature must be the last entry of the manifest. Change-Id: Ie3835f7140ccdf92ef5518ca2d7571930de81971 Issue-ID: SDC-2587 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-30add artifacts support in TOSCA exported yml fileLiang Ding15-461/+659
Change-Id: I56f8a6a1ce758876e83a7ee8318b79644ae7d5cb Issue-ID: SDC-1952 Signed-off-by: Liang Ding <liang.ding@intel.com>
2019-10-29Fix for status properties value.aribeiro348-16768/+16758
These changes were made to align the normative types to the TOSCA property definition requirements. Issue-ID: SDC-322 Change-Id: I32e815dd26990dd6c82c859ad051b271db3c8029 Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2019-10-29Bump SDC version 1.6.0Ofir Sonsino164-166/+166
Change-Id: Ibacb46d19d49023a62caa8f5217086cea6c91ac4 Issue-ID: SDC-2560 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2019-10-25Avoid duplicated verification if package is signedvasraz2-93/+100
Fix potential thread leak by using try-with-resource. Change-Id: I20eda524cd028b9dfdfa83207a059f4e1dfeff5e Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2580
2019-10-24Fix and refactor manifest parsingandre.schmid44-460/+1536
Fix a CMS signature reading expected token. Fix the necessity of a empty line in the end of the manifest. Implement CMS signature, Source checksum algorithm and digest reading. Indicate the line number and content when a manifest error occurs. Remove unnecessary recursive reading. Centralize manifest tokens. Improve tests by checking the expected error. Document the code. Change-Id: I7d12020d8922fc5d4c8d9f238557dfbcc0b65757 Issue-ID: SDC-2563 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-21Fix factory instance creation instabilityandre.schmid20-272/+216
Refactor the factory registry and instance creation. Remove unnecessary static code in Factory creation. Centralize the responsibility to read the factory registry configuration and cache the factory instances in a Singleton called FactoryRegistryManager. Clean the base abstract factory that was sharing non factory code, it had all the factory registry code statically, never used by the concrete factory classes. Change-Id: Ie2e9c29013acd36ddaf15383dd6b06432fbdbb66 Issue-ID: SDC-1905 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2019-10-16Changes for new service categoryatif husain6-6/+42
Introduced new service category, Partner Domain Service Added logic to disable composition for Partner Domain Service category Issue-ID: SDC-2382 Change-Id: I6ed135733c6f05914e102c037ebe9057ad731e75 Signed-off-by: Atif Husain <atif.husain@team.telstra.com>
2019-10-13El Alto known issuesOfir Sonsino1-1/+1
Change-Id: I293935d6a159691390bd90dd3fc2998821c97773 Issue-ID: SDC-2569 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2019-10-08Fix failing unit testvasraz1-132/+138
Issue-ID: SDC-2609 Change-Id: Ibf411a8d10af858ee2f42f9b4b565b81fee33ebe Signed-off-by: vasraz <vasyl.razinkov@est.tech>
2019-10-06Document fixed OJSI tickets in release notesKrzysztof Opasiak1-0/+7
Issue-ID: OJSI-31 Issue-ID: OJSI-76 Issue-ID: OJSI-77 Issue-ID: OJSI-78 Issue-ID: OJSI-79 Issue-ID: OJSI-80 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Change-Id: Ie57bdbfae0b40ff7633ff674d22ac5ad3c5cf866
2019-10-04Revert "Sonar fix NullPointerException"Ofir Sonsino3-4/+6
This reverts commit b0f96a46e2720c75eb035bbe94015e5a1c6b0b32. Issue-ID: SDC-2542 Change-Id: I63b5349670c8e5fa814d686cfa93173d0ea6297e Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2019-10-03Fix for error message.aribeiro7-28/+28
Fixing error message for invalid values across SDC backend API. Issue-ID: SDC-2324 Change-Id: If01307138baf7692e398abf20eb75bbe9a8aa394 Signed-off-by: aribeiro <anderson.ribeiro@est.tech>