aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-04-27Enabling JS in SonarCloudandre.schmid5-16/+33
Configures jest test coverage and missing sonar properties for javascript file scan and report. Change-Id: I9170a176cc4e580ac14f669c334ee949942503f6 Issue-ID: SDC-2741 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-27Fix null pointer warningRodrigo Lima1-3/+5
- Check name and value in method setToscaPresentationValue Issue-ID: SDC-2926 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I0d66b29c84139afff92065769bf1b79082959333
2020-04-27Add null test to ComponentBusinessLogicChris André1-13/+14
- Added test in `getFilteredComponentInstanceProperties` for null value - Removed nested `if` statements in `isMatchingComplexPropertyByRecursively` Issue-ID: SDC-2907 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I13a47b0dfe7aa6dec845a856c58bba8be5c1eead
2020-04-26Update WORKFLOW Artifact Type configurationandre.schmid1-0/+2
To add an operation with an existing Workflow in a RESOURCE, the Artifact Type WORKFLOW needs to support the extension "bpmn" and the component type "RESOURCE". Change-Id: Ic7eb9afe3ced0348f7aadcc43edf121a0bdcf015 Issue-ID: SDC-2954 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-26Fix potential NPE in ArtifactsBusinessLogicandre.schmid1-8/+15
Fixes potential NPE in ArtifactsBusinessLogic introduced by SDC-2754. Change-Id: If53915ffc41ddd0dbcf00ea318cdae6f1b5471ad Issue-ID: SDC-2959 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-23Added early check for null value for `containerV`Chris André1-33/+48
- Formatting code following project's code style - Added early check for null value for `containerV` Issue-ID: SDC-2905 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I648e9a4a04be3f2e7cd3e30a70c04de2257a99d3
2020-04-23Minor cleanups for BasicAuthenticationFilterChris André1-17/+17
- Changed String representing encoding to Java's StandardCharsets.UTF_8 - Added explicit else condition in order to not rely on `abortWith`'s side effects Issue-ID: SDC-2917 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I81cb94c399ff1d810e85c7b63fde195928ab1b08
2020-04-23Add null testsChris André1-15/+16
- Change `isPropertiesListSizesNotEquals` to `isPropertiesListSizesEquals` - Added assertions to silence SonarCloud Issue-ID: SDC-2914 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I88003de54aea6c28575fecf0f41b4c5ef36ef154
2020-04-23Fix null pointer exception warningsRodrigo Lima1-33/+48
Issue-ID: SDC-2911 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: Ic7f0ef631ed98e8baf2ea32b6bfc56a7142738f8
2020-04-22Handle null condition in TopologyTemplateOperationRodrigo Lima1-0/+1
- check if instanceId null in method isNotEmptyMapOfProperties Issue-ID: SDC-2920 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I70667142ed51834de638903ccae4ffcb896cccab
2020-04-22Fix unit tests not runningBaumel, Dvir (db384r)5-56/+12
Change-Id: I06462b6180a1f1a310aae994f4e703a498f80247 Issue-ID: SDC-2933 Signed-off-by: Baumel, Dvir (db384r) <dvir.baumel@intl.att.com>
2020-04-22Used `configurationManager` instead of `getConfigurationManager`Chris André1-10/+9
Issue-ID: SDC-2890 Change-Id: I1559ebc60076bd0884ae1136c9c904f7ab46e72e Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
2020-04-22Fix bug for class SwitchoverDetectorReo Inoue1-1/+1
Signed-off-by: Reo Inoue <inoue.reo@jp.fujitsu.com> Issue-ID: SDC-2931 Change-Id: I6b40f538ff9ce7eed22ce71c542b188a8c866f26
2020-04-22Add null test to DistributionMonitoringBusinessLogicChris André1-3/+12
- Added test in `handleAuditingDaoResponse` for null value related to `resAuditingGenericEvent` Issue-ID: SDC-2909 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I422629cdbd4f05e10609cd78b7328c4e9f45538b
2020-04-22Handle null condition in ResourceImportManagerRodrigo Lima1-6/+7
- check if parentResource null in methods setRequirements and setCapabilities Issue-ID: SDC-2912 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I1ea5a8cf26e3883b5d26fb970bc0abc4cbf1ee9a
2020-04-22Add null test in ArtifactsOperationsChris André1-15/+23
- Added if statement in `updateArtifactOnGraph` to account for the case where variable `artifactInst` has not been properly initialized Issue-ID: SDC-2919 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I73fe3b3bcef59e5797a0f7cfe7b6894816d0d3fb
2020-04-22Minor cleanups for JanusGraphDaoChris André1-6/+8
- Fixed typo in a call to `logger.debug` - Modified if statement following recommendation from SonarCloud Issue-ID: SDC-2918 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I75d50d74703bf7c706b84723bb5d43760b8b7baf
2020-04-22Add null test to test in `UpgradeBusinessLogic`Chris André1-2/+2
Issue-ID: SDC-2915 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I4e6f27b707b1bdbbecf9a97606c9a655d834fe56
2020-04-22Add null tests in `createComponentExternal`Chris André1-3/+3
Issue-ID: SDC-2916 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: Ieb0a79c8d3a891a08cd758e1a4ebab7679166476
2020-04-22INFO.yaml updateOfir Sonsino1-15/+9
Change-Id: Ie410001eae688aa9d0c579f35eb57eeebfe9ae08 Issue-ID: SDC-2934 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2020-04-21Fix catalog-ui dev proxy calls to uicacheandre.schmid1-0/+8
Fixes webpack dev server proxy to uicache removed in SDC-2843, Change Id: I9a6c89e45ea425eb9abf827906562e14a39cf1ff. Change-Id: I83aa842df4c7bf3d140216c93b48eb1cfec48656 Issue-ID: SDC-2944 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-21Fix 404 in sdc-FE calls to workflowandre.schmid2-34/+20
Fixes webpack workflow proxy configuration. Fixes FE proxy while rewriting URLs to workflow plugin. Fixes compilation problems to run locally the catalog-ui. Change-Id: I89f3f46bd8ce0159713b1d0d957a2e75f8a3d062 Issue-ID: SDC-2943 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-21Fix catalog-fe plugin online checkingandre.schmid1-0/+452
ESAPI encoder cannot be loaded due to a missing ESAPI.properties file in path, which causes an exception and breaks the online checking call. The plugin is always shown as offline. Change-Id: I05088d200e9a1bea1de2e00c07d5bbf6e3a67d41 Issue-ID: SDC-2945 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-20Remove props from ValidationConfigManagerFrancis Toth2-47/+1
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I1c3a845c44722010e8933876e59752cef00937f0 Issue-ID: SDC-2499
2020-04-20Fix cs-init SchemaFileImport error file creationandre.schmid1-1/+1
Fix issue in SdcSchemaFileImport "STDERR: Error in file creation : data, /tmp/sdctool/tosca/data-types/data.yml (No such file or directory)", during the cassandra init. Introduced by SDC-2898. Change-Id: Ifd2018fac456f15d03fc39ea766a6ae0c3eda081 Issue-ID: SDC-2939 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-20Fix GAB problem in ui-ci testsandre.schmid1-1/+1
Generic Artifact Browser is failing in tests due to an assertion problem. Change-Id: Ib398d04f0a876ae7d531af14e129f0dc6838dd52 Issue-ID: SDC-2903 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-20Added a try-with-resource to properly close a FileInputStreamChris André1-221/+234
Issue-ID: SDC-2898 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I0a0163937ee2e760f3074d858dfc68a7b262ecd9
2020-04-20Added early check for null value for `containerV`Chris André1-33/+48
- Formatting code following project's code style - Added early check for null value for `containerV` Issue-ID: SDC-2904 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: Ib8d7c1bf36608855c73d8a0df637e86aefce9377
2020-04-20Fix Tosca properties declarationaribeiro6-9/+7
Remove duplicated entries Default value for Boolean type should not be a String According to the description for the keyname 'attachments:' it should be of type List rather than String Issue-ID: SDC-2870 Signed-off-by: aribeiro <anderson.ribeiro@est.tech> Change-Id: Iac2b4f89dac16a6aef9dcabea74def5cacff99a6
2020-04-19Validates artifact configurationandre.schmid7-12/+389
Validates if all the SDC base artifacts are configured. The base artifacts are provided by the ArtifactTypeEnum. Change-Id: Iffa38d6ba276014940afad71f7472bc8d730fcf8 Issue-ID: SDC-2929 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-19Configure a new Artifact Typeandre.schmid65-4149/+2594
Centralizes artifact configuration in one yaml entry. Allow the configuration of a new artifact type without the need of code changes. The configuration file now is used as a source of artifacts types instead the artifact type enum. The enum will be used as a source of base artifact types and also in hard coded business rules. Change-Id: Id0383d9fca9bce0519a4d52a4ecb3a68c8713f0f Issue-ID: SDC-2754 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-19Max boundary check for instances relationshipsandre.schmid2-17/+52
Considering the max boundary of a requirement during a component composition, allowing the correct number of the requirement relationships between instances. Change-Id: I82a1a6daeda8fadcf1c232b117d5b099db7b35d7 Issue-ID: SDC-2872 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-19Fix non appearance VFCs on the Home tabvasraz2-3/+2
Change-Id: I1543da25b76adbe426726444bd855393267fabe5 Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2868
2020-04-19Added ui-ci test case for checking if hiddenDivyang Patel4-1/+28
categories are not visible (USECASE: 3rd Party Operational Domain Manager) Issue-ID: SDC-2879 Signed-off-by: Divyang Patel <divyang.patel@team.telstra.com> Change-Id: Ic64b7de0f6ee70aef279ce13c3d2e18c194c6789
2020-04-19Simplified thread-safety for the `getGson` methodChris André1-5/+1
Issue-ID: SDC-2900 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I8c687bb408a5e0b1e95316bdae6d53126bc82696
2020-04-19Unable to update VSP (heat template) version in VFSebastien Premont-Tendland2-10/+0
This seems to fix the issue, we can still onboard CBA at VF level and the CBA get included in the distributed CSAR under the directory Artifacts/*/Deployment/CONTROLLER_BLUEPRINT_ARCHIVE/ as expected Issue-ID: SDC-2892 Signed-off-by: Sebastien Premont-Tendland <sebastien.premont@bell.ca> Change-Id: Ie9f9cd7b8d2cf5eb3ff3c41a4b04eedd788265a6
2020-04-19ZipSlip test fails on Mac OSNeil Derraugh1-2/+2
Mac OS has a symlink in the tmp dir that gets created in the test for ZipSlip. Using real paths prevents the test test from failing by using actual paths instead of a potentially different symlinked path to the canonical path. Issue-ID: SDC-2887 Signed-off-by: neil.derraugh <neil.derraugh@yoppworks.com> Change-Id: Iafb0a84f6ab68276c5782c1ef716c59435aa72f5
2020-04-19Removed explicit references to exceptions in log messagesChris André4-12/+11
Issue-ID: SDC-2884 Change-Id: I6f3e9503922cc3a4f4049fced8d23cede7b0455a Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
2020-04-19Fix GAB problem in ui-ci testsandre.schmid1-0/+2
Generic Artifact Browser is failing in tests due mainly to a removal of the default constructor in GAB class. Change-Id: Id10b8d8d81c224e2658002b9c928e8aef7ca8e32 Issue-ID: SDC-2903 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-16Improved UX in the distribution componentk.kedron1-0/+11
Added new logic to expand currently open tab, after clicking the refresh button. Issue-ID: SDC-2886 Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com> Change-Id: Ib9d1c7cbf2ca2dd9df22f7f74ffda64144c06047
2020-04-16Add IntelliJ IDE files to .gitignore, remove duplicationsvasraz1-39/+4
Change-Id: I1f4934dfb8df0c485a5ecbb6e19efd0563f61520 Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2895
2020-04-16Add java 11 dependency in openecomp-beArindam Mondal3-1/+23
Issue-ID: SDC-2889 Change-Id: I1be0ffebb3b954f9020939438782dce4f62d4fad Signed-off-by: arindam <arind.mondal@samsung.com>
2020-04-16Upgrade Junit to version 5.6Baumel, Dvir (db384r)25-78/+258
Issue-ID: SDC-2844 Change-Id: I4716bf7920f9bb79c450ebfd48e9d4fba54fdfdd Signed-off-by: Baumel, Dvir (db384r) <dvir.baumel@intl.att.com>
2020-04-16Add some unit testsReo Inoue1-0/+71
This change adds unit tests for ComponentLogi to increase test coverage. Issue-ID: SDC-2885 Change-Id: I53e5da1a1022ef2a6e29119cc531b61dcc3020b1 Signed-off-by: Reo Inoue <inoue.reo@jp.fujitsu.com>
2020-04-09Automation adds workflow.rstAric Gardner1-0/+1
Issue-ID: CIMAN-376 Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org> Change-Id: If806410c1e2bbe480a1a77c4e04ad38e5084aa5e
2020-04-09Automation adds dcaedesigner.rstAric Gardner1-0/+1
Issue-ID: CIMAN-376 Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org> Change-Id: Ie948abc12c8f0233f39e935dfa9494b726586621
2020-04-08Automation adds sdc-architecture.rstLF Jenkins CI1-0/+1
Issue-ID: CIMAN-376 Change-Id: Ia5a1e44150c71d4fc4fbda18099df1f9bca83dd9 Signed-off-by: lf-jobbuilder <releng+lf-jobbuilder@linuxfoundation.org>
2020-04-08Automation adds sdc-offeredapis.rstLF Jenkins CI1-0/+1
Issue-ID: CIMAN-376 Change-Id: I79720045f2583c91f24ec109a17e76050bafabbb Signed-off-by: lf-jobbuilder <releng+lf-jobbuilder@linuxfoundation.org>
2020-04-08Automation adds release-notes.rstLF Jenkins CI1-15/+16
Add _release_notes hook to allow automation. Fix non valid release notes characters in content. Issue-ID: CIMAN-376 Change-Id: I331047b44e54cb210d8bbc8b5cc84841b13b36d5 Signed-off-by: lf-jobbuilder <releng+lf-jobbuilder@linuxfoundation.org>
2020-04-08Automation adds index.rstLF Jenkins CI1-0/+1
Issue-ID: CIMAN-376 Change-Id: I6b9df89424fcb6ad0cbdbe6631b4514f20edf57a Signed-off-by: lf-jobbuilder <releng+lf-jobbuilder@linuxfoundation.org>