summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-06-23Improve test coveragexuegao1-33/+4
Adding more tests to improve test coverage. Issue-ID: SDC-3129 Signed-off-by: xuegao <xg353y@intl.att.com> Change-Id: I23a717bfb6a0004e58ff3ca37d6dd877a956931e Signed-off-by: xuegao <xg353y@intl.att.com>
2020-06-23Refactor ToscaTypeTestxuegao2-29/+114
Adding more tests and adding assert for old tests. Issue-ID: SDC-3143 Signed-off-by: xuegao <xg353y@intl.att.com> Change-Id: Id7cf5ec763b0d43dece9493613e336a4b3df9b72 Signed-off-by: xuegao <xg353y@intl.att.com>
2020-06-22Decouple TXT Report file writing and formatting logic (4/6)Francis Toth4-23/+26
This commit aims to move the reportValidatorTypeSummary function from ReportManager (deprecated) to ReportFile. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I30898d69bbcdb129a2dac917c4dee3c276556e91 Issue-ID: SDC-2499
2020-06-21Decouple TXT Report file writing and formatting logic (3/6)Francis Toth4-20/+23
This commit aims to move the printValidationTaskStatus function's logic from ReportManager (deprecated) to ReportFile. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: Ic33a519f4c70276d404a83bf7de8a27f0007b285 Issue-ID: SDC-2499
2020-06-21Improve ActionUtil coverage and improve Sonar scoreJulienBe2-238/+317
Issue-ID: SDC-3133 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com> Change-Id: I5e6f927599520efa5bfa5856863ca173ecdfb553 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
2020-06-21Toggletalio33-475/+706
Add toggling mechanism to catalog side. The first toggleable feature is healing - this was added to healing flow, in healJanusGraphDao Issue-ID: SDC-2874 Signed-off-by: talio <talio@amdocs.com> Change-Id: If386651cab8304ebaf13497ded3a7a50bd60e477 Signed-off-by: talio <talio@amdocs.com>
2020-06-21Add Node Filter Servlets Unit Testsaribeiro4-25/+515
Issue-ID: SDC-3117 Signed-off-by: aribeiro <anderson.ribeiro@est.tech> Change-Id: I84e728f21290a59c7674f97d5977b945b93ef546
2020-06-21Add Support for node_filtersaribeiro17-958/+1061
Allows for node_filter to be specified for a node template to provide processing instructions to the orchestrator Issue-ID: SDC-3095 Change-Id: I4e496e300552049d9bfd00df878b86d9fb97312b Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2020-06-21Fix sonar issuessebdet4-33/+24
Fix sonar/checkstyle issues in sdc code Issue-ID: SDC-3116 Change-Id: I87802cc9edb378bdbe456c3ca4f10d8c6ebe9425 Signed-off-by: sebdet <sebastien.determe@intl.att.com>
2020-06-21Fix sonar issuessebdet1-380/+363
Fix sonar/checkstyle issues in sdc code Issue-ID: SDC-3116 Signed-off-by: sebdet <sebastien.determe@intl.att.com> Change-Id: I87802bb9edb378bdbe456c3ca4f10d8c6dae9437
2020-06-21Decouple TXT Report file writing and formatting logic (2/6)Francis Toth4-14/+15
This commit aims to move the reportStartValidatorRun function's logic from ReportManager (deprecated) to ReportFile. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I93c2e8f98cdef598094647d734d0deec0f1941db Issue-ID: SDC-2499
2020-06-21Fix Assert usageChrisC1-244/+243
Sonar Fix, fix assert usage in this file Issue-ID: SDC-3116 Signed-off-by: ChrisC <christophe.closset@intl.att.com> Change-Id: I292649e84e589a35eb69139de53b3ee95223be26
2020-06-21fix sonar issues related to MessageContainer.javaJulienBe2-45/+108
Issue-ID: SDC-3127 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com> Change-Id: I02357fa3cbf7afd7845737ba01c72dc202401882 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
2020-06-19Remove duplicate codexuegao1-17/+1
Removing duplicate code. Issue-ID: SDC-3132 Signed-off-by: xuegao <xg353y@intl.att.com> Change-Id: I595a791ebd7cb160d7149ea92a6434d52cfc9f48
2020-06-19Remove unused methodxuegao3-113/+54
Removing unused method in Constraint and use lombok annotations instead. Issue-ID: SDC-3130 Signed-off-by: xuegao <xg353y@intl.att.com> Change-Id: Ia718d184c55d40503f42830966bb11675b7c3f85 Signed-off-by: xuegao <xg353y@intl.att.com>
2020-06-19Fix Vulnerabilitiesxuegao4-38/+13
Fix the vulnerabilities reported by Sonar. Issue-ID: SDC-3114 Signed-off-by: xuegao <xg353y@intl.att.com> Change-Id: Icf97e427ef0c192b2f279380d7ee9eb570949d1f Signed-off-by: xuegao <xg353y@intl.att.com>
2020-06-19Fix Sonar issuesChrisC1-49/+46
Assert params updated to be in correct order Issue-ID: SDC-3116 Signed-off-by: ChrisC <christophe.closset@intl.att.com> Change-Id: I8be2dec4a1d5ec9ab59ea8fddab540958fe25511
2020-06-19Fix Sonar issuesChrisC1-20/+21
Assert params updated to be in correct order Issue-ID: SDC-3116 Signed-off-by: ChrisC <christophe.closset@intl.att.com> Change-Id: I10168defa289e45102f7f8aa436db8ca7176fe6a
2020-06-19Fix Sonar issuesChrisC1-3/+4
Fix assertThat usage and tests Issue-ID: SDC-3116 Signed-off-by: ChrisC <christophe.closset@intl.att.com> Change-Id: Ife533a479096047c4ccb7ae46dfaaa6e2ece974d
2020-06-19improve test coverageJulienBe1-0/+56
Issue-ID: SDC-3120 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com> Change-Id: I8e02fcb3f495d70c14e6e9cf0304085d77918805
2020-06-19Decouple TXT Report file writing and formatting logic (1/6)Francis Toth15-49/+138
This commit is the first of a series aiming to decouple the writing and formatting logic of text report files in the asdc tool. Unfortunately because of a significant amount of technical debt, a small hack had to be done so that the header of the file is not written twice. This will be removed in a future change. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I8d2a7c1353d59562d8026088824c26ae0daa36e9 Issue-ID: SDC-2499
2020-06-19Fix more doc warningsChrisC6-17/+17
Fix couple of doc warnings Issue-ID: SDC-1357 Signed-off-by: ChrisC <christophe.closset@intl.att.com> Change-Id: I3c195ab8d9caacce7dde5d8e9631a0fb7c2ea25a
2020-06-19datatypes.Constants:JulienBe7-88/+64
- adhere to naming conventions - remove unused Issue-ID: SDC-3126 Change-Id: I4ea23a8c69aaaf8fcc404868d3c59c47d09ba442 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
2020-06-18Importing VSP with node_type in separate fileMichaelMorris4-5/+88
Import fails when a node_type referenced in the main template is defined in a separate yaml file in the csar even when that separate file is correctly imported in the main template Change-Id: I6abe074585c2ce592fe9bed7abe76f0856bcfe93 Issue-ID: SDC-2850 Signed-off-by: MichaelMorris <michael.morris@est.tech>
2020-06-18create tests for ScalarUnitValidator.javaJulienBe2-2/+64
Issue-ID: SDC-3123 Change-Id: Iaa60ce2df46ee7a4d9138a56cf4d4c115a059240 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
2020-06-18create tests for PropertyTypeExt.java and remove unsused methodJulienBe2-44/+74
Issue-ID: SDC-3124 Change-Id: I5d3baeeff23c0003952eabc39a5f9dd296dd7c39 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
2020-06-18Decouple CSV Report file writing and formatting logicFrancis Toth11-62/+303
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I6168b71bb54192a806ff6aa437788bedad933c76 Issue-ID: SDC-2499
2020-06-17Fix Java Code Conventions non-compliance issuesxuegao2-8/+4
Update locations of the constructor and private variable to comply with the Java Code Conventions. Issue-ID: SDC-3121 Signed-off-by: xuegao <xg353y@intl.att.com> Change-Id: I0114c880e389f0ed167262c9cd513583be35ba56 Signed-off-by: xuegao <xg353y@intl.att.com>
2020-06-17Reduce nest statement levelsxuegao1-32/+34
Reduce the if/for/switch/try nest statement levels to less than 3. Issue-ID: SDC-3119 Signed-off-by: xuegao <xg353y@intl.att.com> Change-Id: I60f0c0203db4495c6e10127114acdb8586867b14 Signed-off-by: xuegao <xg353y@intl.att.com>
2020-06-17Refactor ArtifactsBusinessLogic::getUpdatedGroupInstancesFrancis Toth1-23/+20
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I6d62c1f916aa820f84328d25d2afbc7470397b0d Issue-ID: SDC-2961
2020-06-17Reduce nest statement levelsxuegao1-10/+11
Reduce the if/for/switch/try nest statement levels to less than 3. Issue-ID: SDC-3118 Signed-off-by: xuegao <xg353y@intl.att.com> Change-Id: I490e66a807a0a8508b7e3c1da332546f2ced3005
2020-06-17Extract ComponentCache from CsarUtilsFrancis Toth4-89/+306
This commit aims to decouple the component caching logic from CsarUtils to its own class. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: Ia7e9284639ec8cd87ca5107e12f295e2eb599768 Issue-ID: SDC-2812
2020-06-17Support the substitution_mappings in the VNFDMichaelMorris3-10/+44
Signed-off-by: MichaelMorris <michael.morris@est.tech> Issue-ID: SDC-2957 Change-Id: I8a385b02568b3bf3d83a250cbe36a7e7f61e710c
2020-06-16Fix Sonar issuesChrisC2-24/+28
Hide implicit public constructor in utility class Issue-ID: SDC-3116 Signed-off-by: ChrisC <christophe.closset@intl.att.com> Change-Id: I4edd2ac37aab2fd587b5d46391dd669181385748
2020-06-16add information on the containers based on what is available in the wikiJulienBe1-2/+80
Issue-ID: SDC-2449 Change-Id: I740a14623161e051399f03d1788ae8a2605c1076 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
2020-06-16Manifest is optional in ETSI SOL004 manifestMichaelMorris2-1/+60
SOL004MetaDirectoryValidtor enforces all files contained in an ETSI SOL004 CSAR are included in the manifest file, however the manifest itself is not mandatory to include in the manifest Signed-off-by: MichaelMorris <michael.morris@est.tech> Issue-ID: SDC-3057 Change-Id: I460071ecbd21578edb0603f600da0ac1ea877539
2020-06-15Add some unit testsSatoshi Fujii1-151/+403
This change added some unit tests for ComponentInstanceBusinessLogic to increase test coverage and removed unused variables for better readability. Also the test class was rewritten to use JUnit 5. Change-Id: I519976d00d8eccc194f8f1168d45f95392808652 Signed-off-by: Satoshi Fujii <fujii-satoshi@jp.fujitsu.com> Issue-ID: SDC-2885
2020-06-15Onboard TOSCA data_types defined in packageandre.schmid13-162/+329
Onboard TOSCA data_types defined in a CSAR package that does not exists in the SDC default data_types library. Those data_types were being lost. All data_types declared in the package will be included in the "GlobalSubstitutionServiceTemplate". This includes the data_types declared in the main topology template and in its imported definition files. Defines a maven profile to compile the catalog-be in the main SDC pom. Change-Id: I39445b0f42e924dc1015945b7e605e804c1d505b Issue-ID: SDC-2763 Signed-off-by: André Schmid <andre.schmid@est.tech> Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
2020-06-15Fix 'not running Junit5 tests'-issuevasraz3-0/+19
Change-Id: Iee67a4af7262e554a86252b411264f55ff1baa88 Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-3109
2020-06-15Fix Critical security vulnerabilityvasraz16-31/+252
com.fasterxml.jackson.core : jackson-databind : 2.9.9 Change-Id: I81af7879cb1fbcd158177a3dc220b704ff2f3388 Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-3111
2020-06-15Fix bug in UpdateIsVnfMenuxuegao1-2/+2
Fix the unboxing bug reported by Sonar. Issue-ID: SDC-3112 Signed-off-by: xuegao <xg353y@intl.att.com> Change-Id: I4ed3f9a48ad21af2f9f67872791df2796c4e4ad1
2020-06-14Use dummy info for distribution-engineOfir Sonsino1-11/+10
Change-Id: I7679e0ed8ce4c4217cf6c5f4a646fe06cf32372d Issue-ID: SDC-3115 Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
2020-06-14Fix Doc warningsChrisC2-16/+16
Fix some RST warnings and rendering issues Issue-ID: SDC-1357 Signed-off-by: ChrisC <christophe.closset@intl.att.com> Change-Id: I142085dcdbbaf8f1a3de27680548e2c37d0a099e
2020-06-14Add support for directives on VFCaribeiro23-116/+249
This change also updates the directives values according to Tosca 1.3 spec Issue-ID: SDC-3074 Change-Id: Ia6a68c9a23a71a2c17ba2c006990342811aa7b4e Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
2020-06-11Rewrite of `updateArtifactOnInterfaceOperationByResourceUUID` to remove NPEChris André1-24/+25
Issue-ID: SDC-2978 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I60942ab1767bf65c806ce796ca62365396b20d93
2020-06-10Set properties on XML parsers to prevent XXE attackNeil Derraugh3-2/+14
- Set ACCESS_EXTERNAL_DTD and ACCESS_EXTERNAL_SCHEMA properties on XML parsers to prevent XXE attacks Issue-ID: SDC-3106 Signed-off-by: Neil Derraugh <neil.derraugh@yoppworks.com> Change-Id: If4e835858dd3d718d37b3ee41fb2fd0c94574c24
2020-06-10Fix security issue in SecurityUtilNeil Derraugh6-30/+42
- Specified mode and padding to address risky algorithm - Corrected unit test for different exception message - Moved tests to package Issue-ID: SDC-3105 Signed-off-by: Neil Derraugh <neil.derraugh@yoppworks.com> Change-Id: I5773ab555a5468362c775cf99795df4eb8c52136
2020-06-10Java 11 migration - 'test-apis-ci'Rodrigo Lima1-14/+4
- Removed references to protected packages (sun.net.*) Issue-ID: SDC-3037 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: Ibbf25af390e624e15fb2bc8ea17777056fe5f3b5
2020-06-10Fix sonar bugssebdet2-71/+67
Fix all sonar bugs reported in SwitchoverDetector class + fix all checkstyle issues Issue-ID: SDC-2931 Signed-off-by: sebdet <sebastien.determe@intl.att.com> Change-Id: Ic86a3526fc7030e10a61b150058c04a391c40c7b
2020-06-10class passed to MdcLogger() is compared by nameJulienBe2-1/+63
Issue-ID: SDC-3098 Signed-off-by: JulienBe <julien.bertozzi@intl.att.com> Change-Id: I8b61218d1164a0ebff7f290ac82f1cdd67a5152a