summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-05-07Support configuring of tosca type for categoriesMichaelMorris8-353/+442
Signed-off-by: MichaelMorris <michael.morris@est.tech> Issue-ID: SDC-2877 Change-Id: I3160c5089979757628f31a44b01836236563b770
2020-05-06Prepare for Junit5vasraz94-8241/+8148
Remove unused/duplicated dependencies Change-Id: Iee0d9510ffbe3e2e14574e22ba965d6829fd568b Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2844 Issue-ID: SDC-2983
2020-05-06Make `collectNewCapabilities` return an empty MapChris André1-4/+6
- Made `collectNewCapabilities` return an empty HashMap instead of a null value Issue-ID: SDC-2924 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I58c35135be5a2614c3daeafbd766d53f401f917b
2020-05-06Increase test coverage - openecomp-sdc-vendor-software-product-libvasraz75-2815/+695
Change-Id: Id51ce6f488efd6db02aad479ff419b58436be27c Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-3001
2020-05-06Increase test coverage - openecomp-sdc-tosca-generator-apivasraz12-774/+102
Change-Id: I1537d71b11ee440cb01bdee49350336f074ea36d Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-3001
2020-05-06Remove unused ES code and unneeded ES health checkNeil Derraugh1-12/+0
Remove the ES health check since ES was removed. Issue-ID: SDC-3022 Signed-off-by: neil.derraugh@yoppworks.com Change-Id: I918212de39d7b53959ac400975b3c47f889252c1
2020-05-06fix bug - Error 500 while adding an OperationYuli Shlosberg1-5/+0
Change-Id: I7def95b3688877acbc9332cf4174c9d92226f2e2 Issue-ID: SDC-2953 Signed-off-by: Yuli Shlosberg <ys9693@att.com>
2020-05-06fix bug - Unable to link CSAR artifactYuli Shlosberg2-5/+13
Change-Id: I586637f988b84b3b858e2c8d567c6844be38322b Issue-ID: SDC-2972 Signed-off-by: Yuli Shlosberg <ys9693@att.com>
2020-05-06Remove powermockito from OrchestrationTemplateCandidateImplTestRodrigo Lima2-45/+29
- Remove powermockito from OrchestrationTemplateCandidateImplTest. Add new constructor to OrchestrationTemplateCandidateImpl Issue-ID: SDC-3007 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I5f0a2061796e8410a5b225c43baa70d7e0269684
2020-05-06Handle null case in `addCalculatedCapabilitiesWithPropertiesToComponent`Chris André1-6/+15
- Change code to handle a null value for `groupDefinitions` as if it was an empty List Issue-ID: SDC-2910 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I5fca0ab76886e5f6a73a8f05ec35d38848f96dd8
2020-05-06Work around potential NullPointerExceptions in `ToscaOperationFacade`Chris André1-41/+64
- Add tests in `getToscaElementByOperation` and `updateToscaElement` for null values - rewrite `getLatestCertifiedByToscaResourceName` in a more functional way - Rewrite some other usages of Either in a more functional way Issue-ID: SDC-2922 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I52b294ec91faf9e1054af572dcca4060e62fe571
2020-05-05Setting default store types when not defined in configuration for init of ↵ilanap1-3/+4
https client Issue-ID: SDC-2962 Signed-off-by: ilanap <ilanap@amdocs.com> Change-Id: I9d88031c7d20951a4a77138340b1ddc26f47c0b6 Signed-off-by: ilanap <ilanap@amdocs.com>
2020-05-05Add tests for the presence of Optional valuesChris André1-14/+24
Issue-ID: SDC-3012 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I56cbf7fb5bd04ad2fbc496231d6abe72066124fe
2020-05-05UnifiedCompositionService - Refactor code to handle Optional valueChris André1-5/+2
Issue-ID: SDC-3015 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I1d15d20e9c603ff894c7c4be46b26d60745cb7e5
2020-05-05Replace hashCode and equals methods to cleanup NPE warningNeil Derraugh1-93/+13
Replace hashCode() and equals() with Lombok @EqualsAndHashCode(callSuper = true) Issue-ID: SDC-2925 Signed-off-by: neil.derraugh <neil.derraugh@yoppworks.com> Change-Id: I51056103dc7df953508b2e465a535b46c63e2667
2020-05-05Remove call to `get` on Optional variablesChris André1-12/+21
- Made multiple variables Optional Issue-ID: SDC-2991 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: If3dbfd37e933d10698ad1a93b6762c84e30f69b8
2020-05-05Refactor CsarUtil::getLatestSchemaFilesFromCassandraFrancis Toth1-16/+31
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I3f96d76a07fd32bdbd8b59beb5409eab0b0f3aa8 Issue-ID: SDC-2812
2020-05-05Refactor CsarUtil::getFromCassandraFrancis Toth1-11/+6
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I510d1d7fb4f4a7d7152fd5ea6d4d5ff61deea23a Issue-ID: SDC-2812
2020-05-05Refactor CsarUtils::collectComponentTypeArtifactsFrancis Toth1-14/+22
This commit is a minor refactoring required to refactor CsarUtils::collectComponentInstanceArtifacts. In order to keep this commit small, we only focused CsarUtils::collectComponentTypeArtifacts, and removed any output that is not reflected by the function's result type. Modifying an argument is a actually a bad practice as explained in Clean Code by Robert Martin (cf. "Output arguments should be avoided"). This commit aims to enforce this aspect. Change-Id: Ice4d6c9a78e7706c639dd60bc272253e298bc7be Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Issue-ID: SDC-2812
2020-05-05Remove all thrift's dependenciesvasraz8-50/+15
Remove unused/duplicated dependencies Change-Id: Ic2239acc5ddde1d0874b5139c228934ec1e61cd0 Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2985
2020-05-03Add Autowired annotation to the constructor instead of param in ↵Rodrigo Lima1-1/+2
ExternalTestingImpl Issue-ID: SDC-3003 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I720c6cf271a1444a584f42cdca2a7e4f2c59a85d
2020-05-03Refactor CsarUtils::createCsarFrancis Toth1-7/+6
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I41994c98515844030eed1d6f2756c9779e864cff Issue-ID: SDC-2812
2020-05-03Extract ArtifactOperationInfo from ArtifactsBusinessLogicFrancis Toth13-99/+150
This commit only intends to extract the inner static class ArtifactOperationInfo from the ArtifactsBusinessLogic class. In addition, getters have been added to get the artifactOperationEnum field's state (this allowed to reduce some boilerplate). Change-Id: Ib79a75893ef11ba0d25e0578d7e95f60284589d0 Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Issue-ID: SDC-2961
2020-05-03Remove powermockito from NetworksImplTestFrancis Toth2-130/+108
This commit aims to remove the Powermockito dependency from NetworksImplTest. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I7eecb877f86a64514609e11fd9501f3fb972a866 Issue-ID: SDC-2984
2020-05-03Remove powermockito from ApiTestRodrigo Lima2-25/+21
- Remove powermockit from ApiTest. Add new constructor to ExternalTestingImpl in order to pass vendorSoftwareProductManager param. Issue-ID: SDC-3003 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: Ibdaa12a986557dbf1d4cdf6d4c1952ba642582cf
2020-05-03Increase test coverage - openecomp-sdc-model-libvasraz4-107/+35
Change-Id: I86e4935fd418bb01971f21ae32351be6044a2566 Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-3001
2020-05-03Increase test coverage - openecomp-sdc-vendor-software-product-apivasraz8-562/+155
Change-Id: Ifaaf73998ee0f7df66082fdc4963b4c05678e5c1 Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-3001
2020-05-03Refactor CsarUtils::validateNonMetaArtifactFrancis Toth1-20/+22
This commit aims to refactor the CsarUtils::validateNonMetaArtifact function and make it up to standards regarding how fj.Either should be used. Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: Icadfce7229839e53bd09926b6865f2872c39d1a5 Issue-ID: SDC-2812
2020-05-01Fix sdc-FE /onboarding war listingandre.schmid2-3/+8
It creates a index.html page that will end up in the onboarding-FE .war file. When the /onboarding context is accessed, a blank page will show up instead of the contents of the .war. Change-Id: I0fb4be28e193e6e6bbd58c1af9a49d5750981b7e Issue-ID: SDC-3000 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-30HEAT to TOSCA VM ConsolidationBen David, Elad (eb7504)3-54/+29
Change-Id: I00c9cf90d7486af33955acae7dfe653e14ceebdc Issue-ID: SDC-2997 Signed-off-by: Ben David, Elad (eb7504) <eb7504@intl.att.com>
2020-04-30Replace call to `get` with a call to `ifPresent`Chris André1-3/+6
Issue-ID: SDC-2989 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I7fe273d869035f8852dbc398de60cc49dec2ce6e
2020-04-30Remove mockito from TypeUtilsTestRodrigo Lima1-11/+15
- Remove the use of mockito verify from TypeUtilsTest Issue-ID: SDC-2993 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I42c9c972cead10afaa3ec299624cf3d26e4d04db
2020-04-30Fix GAB ui test row and column countandre.schmid1-13/+16
Change-Id: Ib9e4eb054cd23db9359b6d4db4ce079007c1e4e7 Issue-ID: SDC-2963 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-29Fix VFs and Service not visible in SDC Dashboardvasraz2-22/+8
Change-Id: Ia42775388c3ad9539b7d0020476f0f7a91ce8bb9 Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Issue-ID: SDC-2938
2020-04-28Handle null case in `GroupVersionUpdater`Chris André2-13/+330
- change in the final condition of `isGenerateGroupUUID` - Added tests related to modified code Issue-ID: SDC-2913 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I22738f9f4922467209a16a4d6b3b78d7bfac11c9
2020-04-28Refactor CsarUtils::getEntryDataFrancis Toth1-20/+18
Change-Id: I1732ae05cfbe93c1bef8c249e16088a0cad34106 Issue-ID: SDC-2812 Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
2020-04-28Refactor CsarUtils::populateZipFrancis Toth1-30/+55
Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Change-Id: I136ebda0ff92d6c42368f102ccf2b10f37524808 Issue-ID: SDC-2812
2020-04-28Remove csvReportFilePath from ValidationConfigManagerFrancis Toth9-106/+109
This commit aims to extract the csvReportFilePath field from ValidationConfigManager in order to improve testability. This commit contains multiple minor modifications resulting from bubbling up the csvReportFilePath static field to where it is actually set. Put differently, most of the modifications result from changing the signature of the functions which formerly relied on ValidationConfigManager.getCSVReportFilePath. Change-Id: I82c3b0fca8a0f407319e40ecfff45e89ec1d4323 Signed-off-by: Francis Toth <francis.toth@yoppworks.com> Issue-ID: SDC-2499
2020-04-27Work around potential NullPointerExceptions in HeatTreeManagerUtilChris André1-4/+5
- Replace null return values with empty Map objects Issue-ID: SDC-2928 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I3357a8789a00201a7ffda1dbf0be5f08cbb9c33b
2020-04-27Enabling JS in SonarCloudandre.schmid5-16/+33
Configures jest test coverage and missing sonar properties for javascript file scan and report. Change-Id: I9170a176cc4e580ac14f669c334ee949942503f6 Issue-ID: SDC-2741 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-27Fix null pointer warningRodrigo Lima1-3/+5
- Check name and value in method setToscaPresentationValue Issue-ID: SDC-2926 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I0d66b29c84139afff92065769bf1b79082959333
2020-04-27Add null test to ComponentBusinessLogicChris André1-13/+14
- Added test in `getFilteredComponentInstanceProperties` for null value - Removed nested `if` statements in `isMatchingComplexPropertyByRecursively` Issue-ID: SDC-2907 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I13a47b0dfe7aa6dec845a856c58bba8be5c1eead
2020-04-26Update WORKFLOW Artifact Type configurationandre.schmid1-0/+2
To add an operation with an existing Workflow in a RESOURCE, the Artifact Type WORKFLOW needs to support the extension "bpmn" and the component type "RESOURCE". Change-Id: Ic7eb9afe3ced0348f7aadcc43edf121a0bdcf015 Issue-ID: SDC-2954 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-26Fix potential NPE in ArtifactsBusinessLogicandre.schmid1-8/+15
Fixes potential NPE in ArtifactsBusinessLogic introduced by SDC-2754. Change-Id: If53915ffc41ddd0dbcf00ea318cdae6f1b5471ad Issue-ID: SDC-2959 Signed-off-by: andre.schmid <andre.schmid@est.tech>
2020-04-23Added early check for null value for `containerV`Chris André1-33/+48
- Formatting code following project's code style - Added early check for null value for `containerV` Issue-ID: SDC-2905 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I648e9a4a04be3f2e7cd3e30a70c04de2257a99d3
2020-04-23Minor cleanups for BasicAuthenticationFilterChris André1-17/+17
- Changed String representing encoding to Java's StandardCharsets.UTF_8 - Added explicit else condition in order to not rely on `abortWith`'s side effects Issue-ID: SDC-2917 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I81cb94c399ff1d810e85c7b63fde195928ab1b08
2020-04-23Add null testsChris André1-15/+16
- Change `isPropertiesListSizesNotEquals` to `isPropertiesListSizesEquals` - Added assertions to silence SonarCloud Issue-ID: SDC-2914 Signed-off-by: Chris Andre <chris.andre@yoppworks.com> Change-Id: I88003de54aea6c28575fecf0f41b4c5ef36ef154
2020-04-23Fix null pointer exception warningsRodrigo Lima1-33/+48
Issue-ID: SDC-2911 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: Ic7f0ef631ed98e8baf2ea32b6bfc56a7142738f8
2020-04-22Handle null condition in TopologyTemplateOperationRodrigo Lima1-0/+1
- check if instanceId null in method isNotEmptyMapOfProperties Issue-ID: SDC-2920 Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com> Change-Id: I70667142ed51834de638903ccae4ffcb896cccab
2020-04-22Fix unit tests not runningBaumel, Dvir (db384r)5-56/+12
Change-Id: I06462b6180a1f1a310aae994f4e703a498f80247 Issue-ID: SDC-2933 Signed-off-by: Baumel, Dvir (db384r) <dvir.baumel@intl.att.com>